Commit graph

1231 commits

Author SHA1 Message Date
jenkins-bot f8fd06dbaf Merge "Remove 5 more very old unused messages" 2022-08-01 09:46:45 +00:00
Translation updater bot 799c0b86ea Localisation updates from https://translatewiki.net.
Change-Id: I5851d2c86d2ae51dbc44f791387d40456e93667b
2022-08-01 08:23:49 +02:00
Translation updater bot fb8a9396ed Localisation updates from https://translatewiki.net.
Change-Id: I5b58f46c1baf929867084da6a7e3450d5d12fce9
2022-07-29 08:54:32 +02:00
jenkins-bot 15c56b442c Merge "Remove unused template dialog title message" 2022-07-28 10:25:12 +00:00
Translation updater bot 461a6bea84 Localisation updates from https://translatewiki.net.
Change-Id: I1a944644e38391c26d61cb691aa86a4edf6aff2f
2022-07-28 08:58:20 +02:00
Thiemo Kreuz b8b5ed3eaa Remove 5 more very old unused messages
* "visualeditor-dialog-transclusion-options" was added in 2013 via
  I3bcf924. It was used as the label for multiple FieldsetLayouts in
  ve.ui.MWTransclusionDialog.js. In 2013 a larger rewrite was done via
  I51e74b3. The FieldsetLayouts with this message don't exist any more
  since then.
* "visualeditor-dialogbutton-meta-tooltip" was added in 2013 via
  Ibf63329. It was used as the button label in
  ve.ui.MWMetaButtonTool.js. This file was deleted in 2013 via
  I3bb61d5. That patch added a new message "visualeditor-meta-tool"
  that says the same as the old message". The old message is unused
  since then.
* "visualeditor-savedialog-label-create" is a new key for a message
  that existed before. The old key was "visualeditor-create-page". It
  was used in ve.init.mw.ViewPageTarget.js as a button label. This
  usage was removed in 2012 via I5f59482. The renamed message was
  never used.
* "visualeditor-savedialog-label-report" was added in 2012 via
  I5f59482. It was used as a button label in
  ve.init.mw.ViewPageTarget.js. The feature was removed in 2013 with
  no replacement, see I8a5e0ab. Some of the messages that became
  unused got removed in the same patch, but not all of them.
* "visualeditor-savedialog-warning-dirty" was added in 2013 via
  I3daf631. It was used for a confirmation popup in
  ve.init.mw.ViewPageTarget.js. I8c0db01 moved the code to
  ve.ui.MWSaveDialog.js. In 2015 the confirmation popup was removed
  with no replacement, see I9091534.

Change-Id: Iae7961612d5b5be9cdd294a67a9ce40ee8cb9b4d
2022-07-27 09:01:21 +02:00
Thiemo Kreuz 91b5cea852 Remove unused template dialog title message
The message "visualeditor-dialog-template-insert" was added in 2021
via I5da4003. It was used as a dialog title in
ve.ui.MWTemplateDialog.js. In 2021 we introduced three new messages
via Ib9b76ca. One of them still says the same as the old message, but
got a new key assigned. It appears like we forgot to remove the old
message.

Change-Id: Ie3854114197e3f36b48bb7efd8dd96a1f9651198
2022-07-27 08:54:31 +02:00
Translation updater bot d70e425fc9 Localisation updates from https://translatewiki.net.
Change-Id: I9edc9a6a56dc59abb0a8a0b8519024238edaec46
2022-07-27 08:27:02 +02:00
jenkins-bot 7e55a99917 Merge "Add a checkbox to use the image caption as the alt text for galleries" 2022-07-26 20:00:48 +00:00
Translation updater bot bf829f4681 Localisation updates from https://translatewiki.net.
Change-Id: If8f03962e2280a53b18bc6057eea8ce8aefcd6ee
2022-07-26 08:26:05 +02:00
Translation updater bot 576f27e3d5 Localisation updates from https://translatewiki.net.
Change-Id: Id8ba7dd358d976435816667f17ab2a06aab7da65
2022-07-25 09:51:04 +02:00
Translation updater bot f4497c9ddd Localisation updates from https://translatewiki.net.
Change-Id: I480a16f3d6d2a3ca838deb4fd4bc0879d940f686
2022-07-25 08:39:48 +02:00
Arlo Breault 94c4d619a7 Add a checkbox to use the image caption as the alt text for galleries
The need for something like this was anticipated in
I2bf43c7e83283f43e047229eb53c244918fcbb0c.

As of version 2.5.0 of Parsoid's output, if alternate text is missing
for an image but a caption is present and image isn't displaying the
caption (ie. it isn't a thumb or frame), then the text content of the
caption will be set as the alt attribute.  Parsoid will then drop the
alt attribute when serializing if it matches the caption text, since
it's unnecessary.

However, if the caption is modified and the alt text isn't, the alt will
be serialized.  This is likely to be unexpected to editor.  They may
have missed that the both the caption and alt are populated in VE and
only edited one place.

Since all of the above is happening only for images where the caption
isn't visible, it doesn't appear to be a much used feature since, at
least for inline images, the experience of caption editing was already
less than optimal.

However, because of a quirk in how galleries are rendered in Parsoid,
this affects gallery caption editing, which is visible and presumably
used more often.  See T268250 for a discussion on an improved gallery
structure.  But for now, gallery images are effectively inline and set
the alternate text, thus subject to the above.

Here we add a checkbox so that the default is to ignore the alt if it's
the same as the caption.  And only make use of it if it differed
originally or was explicitly unchecked to modify.

Bug: T311677
Change-Id: Idf297d8a98995971c5835b0cea56c3317a3626e2
2022-07-22 15:46:55 -04:00
Translation updater bot 3a0b3e07d5 Localisation updates from https://translatewiki.net.
Change-Id: I588ff3e1e5b5a5b783c0b8941cf38b64a3b06877
2022-07-21 09:04:57 +02:00
Translation updater bot da2c04abb7 Localisation updates from https://translatewiki.net.
Change-Id: Iad665489aa8418e345f8f4cf1a69cc85c1abd64a
2022-07-20 08:28:37 +02:00
Translation updater bot 29cace0be3 Localisation updates from https://translatewiki.net.
Change-Id: I8c4dc5ef4fb727d1397fc355a2e6f4173b89d391
2022-07-19 08:17:46 +02:00
Translation updater bot fc85f06dd1 Localisation updates from https://translatewiki.net.
Change-Id: Id75506d4b41ba26ad25fa5de5c3861808a0ad975
2022-07-18 08:16:01 +02:00
Translation updater bot 3081c2f09d Localisation updates from https://translatewiki.net.
Change-Id: I00b6762101fb8aea78c0f8872367a51e98f6a387
2022-07-15 08:48:25 +02:00
Translation updater bot 6440b62341 Localisation updates from https://translatewiki.net.
Change-Id: I1c2233043ecfa7a2ad9374f2d1009d4c03b9cdcb
2022-07-14 08:49:10 +02:00
Thiemo Kreuz 139e6547d1 Remove unused media/meta-related messages
visualeditor-dialog-media-thumbdimensions
Added in 2014 via I7b4d019, but never used, as far as I can tell.

visualeditor-dialog-media-searchselect
Unused since I65aed34 from 2015.

visualeditor-dialog-meta-settings-displaytitle-enable
The feature was removed in 2017 via I46db6b1.

This patch also marks some other messages as being used via comments.

Change-Id: Ia10b6a5c0ea83dd670e2cfdbaa768c41fc0cf392
2022-07-13 13:56:41 +02:00
Translation updater bot 83fbbba390 Localisation updates from https://translatewiki.net.
Change-Id: I244decbe1796492a7ec251b6b3aab1db8afa05f9
2022-07-13 08:18:24 +02:00
Translation updater bot b3306567e9 Localisation updates from https://translatewiki.net.
Change-Id: I210d73dbdf5f20030b152175873c1d68f603497c
2022-07-12 08:15:57 +02:00
Translation updater bot 1e580da334 Localisation updates from https://translatewiki.net.
Change-Id: I3aff596dc6bb3cc20576f18d815d9a5d018cbc5c
2022-07-11 09:50:54 +02:00
Translation updater bot 106c550c83 Localisation updates from https://translatewiki.net.
Change-Id: I734076267445eeed4ba011faa6ac3d9d5e6bfb35
2022-07-08 08:53:20 +02:00
Translation updater bot b0937f243d Localisation updates from https://translatewiki.net.
Change-Id: I60354d290905322952297de3a7c0fb7654b14a86
2022-07-07 08:51:17 +02:00
Andrew Kostka d5b8107902 Use "Add template" label in the sidebar and as the header
Bug: T311107
Change-Id: Ib85c08c5d72e621a7687dc393b2f8d9443f13b06
2022-07-06 10:55:43 +00:00
Translation updater bot 3117f9a535 Localisation updates from https://translatewiki.net.
Change-Id: I35f351704c7683843fd5893b805667ae75044cff
2022-07-06 10:18:52 +02:00
Adam Wight 0c87f16057 Shorten text for add buttons
This makes layout easier on small screens.

Bug: T311107
Change-Id: I506ac8ae721cf7b77f20c39b8049455d40d319de
2022-07-05 13:50:47 +02:00
Translation updater bot d7d953aefe Localisation updates from https://translatewiki.net.
Change-Id: I8754be18daa834dddf51905392db7bee5d9fd9ff
2022-07-05 08:39:14 +02:00
Translation updater bot bfea60d921 Localisation updates from https://translatewiki.net.
Change-Id: I4c66ef05e3b5629afa6b7d5ac010335354f18e7d
2022-07-04 08:23:09 +02:00
Translation updater bot 11f48d1e1a Localisation updates from https://translatewiki.net.
Change-Id: I4fe9881134214b767ebe364a2a20d0ba969df1fd
2022-07-01 08:54:02 +02:00
Translation updater bot 3d77052c94 Localisation updates from https://translatewiki.net.
Change-Id: I1638ef8b83fedc1f79bd0731d0ef8c561cf03697
2022-06-29 08:35:52 +02:00
Translation updater bot c716ab294c Localisation updates from https://translatewiki.net.
Change-Id: I137073ca319be860062bfcde57b41dd186e8f5fe
2022-06-28 08:40:29 +02:00
jenkins-bot 1e094a8868 Merge "Fix broken error message 'visualeditor-saveerror'" 2022-06-27 19:07:18 +00:00
Translation updater bot bf6eecb1e4 Localisation updates from https://translatewiki.net.
Change-Id: I18e3adacec441e1678e5214e9ba9fd42aecbeddd
2022-06-27 08:18:54 +02:00
Translation updater bot 28f3e9ac0b Localisation updates from https://translatewiki.net.
Change-Id: Ib564d607b009515524f6b8ae8c8d01c0dae535fb
2022-06-24 09:31:40 +02:00
Translation updater bot 72748f59d5 Localisation updates from https://translatewiki.net.
Change-Id: If0afe0972a3f03b6b07018e4f521082d0bfc38f0
2022-06-23 09:04:29 +02:00
jenkins-bot c19a44e246 Merge "Remove unused media info messages" 2022-06-22 19:36:00 +00:00
Adam Wight 15ef2dc3c6 Remove inaccessible ARIA annotation from old sidebar
This was added via I3b792ff. It's about the old sidebar which isn't
accessible any more.

Bug: T311069
Change-Id: I29919285255a84bd58aa06ee1b2816d25a8112a6
2022-06-22 13:44:23 +02:00
Thiemo Kreuz f0bce1c845 Remove unused media info messages
The "visualeditor-dialog-media-info-…" messages are part of a larger
info panel that appears after searching for an image. This was
introduced via I7b4d019, a patch with 52 patchsets, developed between
September 2014 and January 2015.

The "credit" message appeared first in patchset 2, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/2/modules/ve-mw/i18n/en.json

The "dateformat" message appeared first in patchset 12, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/11..12/modules/ve-mw/i18n/en.json
This message appears to be special in so far that it was never used
to begin with.

The other two messages appeared first in patchset 21, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/20..21/modules/ve-mw/i18n/en.json

3 of the 4 messages are used at this point. The message keys are
constructed in code via `"visualeditor-dialog-media-info-" + key`.
This piece of code was also introduced in patchset 21, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/20..21/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js#629

This was entirely rewritten in patchset 41, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/40..41/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js#b670
Since then the messages are unused. The info panel still exists and
still shows all information, but the 3 fields "ImageDescription",
"LicenseShortName", and "Credit" just show an icon and the field's
value, but no label (any more).

Change-Id: Ief35a85d8c5cbf49b662adbfd068dbecd8e4f154
2022-06-22 09:09:07 +00:00
jenkins-bot 1ba1bc76f4 Merge "Remove dead code in MWTemplatePage" 2022-06-22 06:29:47 +00:00
Translation updater bot 04e6954fd9 Localisation updates from https://translatewiki.net.
Change-Id: Icea5faddda50244e4c81eaf0d4f2cf3647429392
2022-06-22 08:14:21 +02:00
jenkins-bot 4eceae3962 Merge "Remove two unused placeholder messages from gallery dialog" 2022-06-22 00:38:19 +00:00
WMDE-Fisch 11f5f6cb59 Remove dead code in MWTemplatePage
Bug: T310859
Change-Id: Ie55d82fb6f3be0b90b8f42aecdd761624b94afca
2022-06-22 00:20:00 +00:00
jenkins-bot 3b9e0bf0dc Merge "Remove unused media position messages" 2022-06-21 17:37:06 +00:00
jenkins-bot b2bd7516f1 Merge "Remove dead code in MWTransclusionDialog" 2022-06-21 14:49:18 +00:00
WMDE-Fisch 8535fa72ab Remove dead code in MWTransclusionDialog
Removing CSS will go into a follow up.

Bug: T310859
Change-Id: I05a0c12ab98ca428aca64181469d8c9cf6311f03
2022-06-21 14:22:47 +02:00
Thiemo Kreuz ec2a961d00 Remove two unused placeholder messages from gallery dialog
Both messages are unused since I1e93c3a. As I understand the patch
what it did was replacing two plain text input fields with WYSIWYG
editors. These don't use placeholders.

Change-Id: Ia4ac7d7c9ae86dedd02040a81300a9722e94d1b7
2022-06-21 14:20:33 +02:00
Thiemo Kreuz a01163d097 Remove unused media position messages
All 4 messages are introduced via I15fbd1e in January 2014.

The "none" message is unused since Iddd78c9 from February 2014. It
was replaced with a checkbox with a different label.

The other 3 messages are unused since I7057997 from February 2015.
A more generic widget is used since then. It uses messages that are
named "visualeditor-align-widget-center" and so on.

Change-Id: I7ad4772cb4fdec7e478cee23dccd5ae600834caf
2022-06-21 14:11:53 +02:00
Translation updater bot 0cdf8f23e0 Localisation updates from https://translatewiki.net.
Change-Id: I89185325aa63903b99158e48b8bb2b3c081e2daa
2022-06-21 08:32:20 +02:00