wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-24 02:38:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused media info messages

Browse source 
The "visualeditor-dialog-media-info-…" messages are part of a larger
info panel that appears after searching for an image. This was
introduced via I7b4d019, a patch with 52 patchsets, developed between
September 2014 and January 2015.

The "credit" message appeared first in patchset 2, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/2/modules/ve-mw/i18n/en.json

The "dateformat" message appeared first in patchset 12, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/11..12/modules/ve-mw/i18n/en.json
This message appears to be special in so far that it was never used
to begin with.

The other two messages appeared first in patchset 21, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/20..21/modules/ve-mw/i18n/en.json

3 of the 4 messages are used at this point. The message keys are
constructed in code via `"visualeditor-dialog-media-info-" + key`.
This piece of code was also introduced in patchset 21, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/20..21/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js#629

This was entirely rewritten in patchset 41, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/40..41/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js#b670
Since then the messages are unused. The info panel still exists and
still shows all information, but the 3 fields "ImageDescription",
"LicenseShortName", and "Credit" just show an icon and the field's
value, but no label (any more).

Change-Id: Ief35a85d8c5cbf49b662adbfd068dbecd8e4f154
This commit is contained in:
Thiemo Kreuz 2022-06-21 13:52:27 +02:00 committed by Thiemo Kreuz (WMDE)
parent 0cdf8f23e0
commit f0bce1c845
3 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
extension.json
View file

@ -1888,11 +1888,7 @@
"visualeditor-dialog-media-info-artist",
"visualeditor-dialog-media-info-audiofile",
"visualeditor-dialog-media-info-created",
"visualeditor-dialog-media-info-credit",
"visualeditor-dialog-media-info-dateformat",
"visualeditor-dialog-media-info-ellipsis",
"visualeditor-dialog-media-info-imagedescription",
"visualeditor-dialog-media-info-licenseshortname",
"visualeditor-dialog-media-info-meta-artist",
"visualeditor-dialog-media-info-moreinfo",
"visualeditor-dialog-media-info-readmore",

4
i18n/ve-mw/en.json
View file

@ -65,11 +65,7 @@
"visualeditor-dialog-media-info-artist": "Uploaded by $1",
"visualeditor-dialog-media-info-audiofile": "Audio file",
"visualeditor-dialog-media-info-created": "Created: $1",
"visualeditor-dialog-media-info-credit": "Credit",
"visualeditor-dialog-media-info-dateformat": "$1 $2, $3",
"visualeditor-dialog-media-info-ellipsis": "…",
"visualeditor-dialog-media-info-imagedescription": "Full description",
"visualeditor-dialog-media-info-licenseshortname": "License",
"visualeditor-dialog-media-info-meta-artist": "Author: $1",
"visualeditor-dialog-media-info-moreinfo": "More information",
"visualeditor-dialog-media-info-readmore": "Read more",

4
i18n/ve-mw/qqq.json
View file

@ -85,11 +85,7 @@
"visualeditor-dialog-media-info-artist": "Label for the uploader information for the image in the media dialog. $1 - Uploader name.",
"visualeditor-dialog-media-info-audiofile": "Label for denoting an audio file for the media info in the media dialog.",
"visualeditor-dialog-media-info-created": "Label for the image creation date in the media dialog. $1 - Date of creation.\n{{Identical|Created}}",
"visualeditor-dialog-media-info-credit": "Label for the credit information for the image in the media dialog.\n{{Identical|Credit}}",
"visualeditor-dialog-media-info-dateformat": "Label laying out the date format for image details in the media dialog. $1 - Month, $2 - Day, $3 - Year\n{{Optional}}",
"visualeditor-dialog-media-info-ellipsis": "An ellipses symbol denoting a truncated string.\n{{Optional}}",
"visualeditor-dialog-media-info-imagedescription": "Label for the description for the image in the media dialog.",
"visualeditor-dialog-media-info-licenseshortname": "Label for the license information for the image in the media dialog.\n{{Identical|License}}",
"visualeditor-dialog-media-info-meta-artist": "Label for the author information for the image in the media dialog. $1 - Author name.",
"visualeditor-dialog-media-info-moreinfo": "Label for the link to more information in the image data panel.\n{{Identical|More information}}",
"visualeditor-dialog-media-info-readmore": "Label for the link to expand the text in the image data panel.\n{{Identical|Read more}}",