Commit graph

20628 commits

Author SHA1 Message Date
Thiemo Kreuz aa989c00dd Extract MWExpandableContentElement.onButtonClick method
This is done in preparation for Iac6205f to make it easier to review.
This patch here is meant to be a no-op that doesn't change anything,
just moves existing code around.

Bug: T307986
Change-Id: Ie6ccd9528e5799ba340fed344e1f47a443c2c51f
2022-05-16 12:43:10 +02:00
Translation updater bot 7094857fab Localisation updates from https://translatewiki.net.
Change-Id: I921f0bf0cc5cfeb380459482ebda9de1c6631ebd
2022-05-16 08:25:38 +02:00
jenkins-bot fb7beaaa3a Merge "ApiParsoidTrait: Log trace as 'exception.trace' instead of 'trace'" 2022-05-15 22:28:59 +00:00
jenkins-bot 291d4d1374 Merge "Upstream teardown of saveDialog from DesktopArticleTarget to ArticleTarget" 2022-05-15 20:41:46 +00:00
jenkins-bot ace451bede Merge "Upstream isViewPage from DesktopArticleTarget to ArticleTarget" 2022-05-15 20:39:35 +00:00
Timo Tijhof 54d44ccb6c ApiParsoidTrait: Log trace as 'exception.trace' instead of 'trace'
This ensures proper redacting, and consistent discovery and formatting
for Logstash queries.

Bug: T233342
Change-Id: I9a2a96793a5b7669648d222a0d472c15c09b84d3
2022-05-15 20:21:34 +00:00
Bartosz Dziewoński aaef4584cc Update VE core submodule to master (f07b7e2cf)
New changes:
46eedcade Localisation updates from https://translatewiki.net.
86add3cf8 WindowManager: Simplify teardown
7f4bc9340 Ensure mobile context appears above toolbar on mobile

Bug: T308201
Bug: T308295
Change-Id: Ib3af733873f836db54c8eece864ae3bd04e8e657
2022-05-14 00:03:19 +02:00
Ed Sanders c877dc47fc Implement replacePageContent in MobileArticleTarget
Change-Id: I5b31bb9406bea15c5473363ba8fcda4c14f90994
Depends-On: Ifeb7c71e053501bc2c9448459c68895cb11368bd
Bug: T219420
2022-05-13 22:53:02 +01:00
Ed Sanders 37b81b5ba4 ArticleTarget: Always reload the page after save on non-view page
This is currently only handled in DesktopArticleTarget in teardown,
which happens after we've wasted time trying to update the page.

Also ensure we always reload on non-view pages on MobileArticleTarget
for other types of teardown (e.g. quitting the editor).

Change-Id: I7fb352fcacc8727bb113115e98af38a3940a8f9c
2022-05-13 22:53:02 +01:00
Ed Sanders ae58439c41 Upstream teardown of saveDialog from DesktopArticleTarget to ArticleTarget
Change-Id: I2e28f604d7e34fed15d9b74b6723347e3a17ce9e
2022-05-13 22:52:40 +01:00
Ed Sanders be2fc6c814 Upstream isViewPage from DesktopArticleTarget to ArticleTarget
Change-Id: Ic3839d9d70d6d4127fe2cd9bc01da799027fed3c
2022-05-13 22:47:06 +01:00
jenkins-bot e449d24344 Merge "Rephrase messages about changes that will be lost" 2022-05-13 16:16:11 +00:00
Translation updater bot 176634ba60 Localisation updates from https://translatewiki.net.
Change-Id: I68ffd16dd2380373dde7642cc363c178e416bd89
2022-05-13 08:27:06 +02:00
jenkins-bot c38ff0bcfc Merge "Hide the floating help button on small screens" 2022-05-12 10:26:07 +00:00
Translation updater bot 6b6b065e07 Localisation updates from https://translatewiki.net.
Change-Id: I19bf42f80434a71504b0401bfdda644efefc6fe5
2022-05-12 08:14:03 +02:00
Andrew Kostka dda7d8e9c1 Hide the floating help button on small screens
Bug: T307981
Change-Id: I7c1776f95f22e9c81b559f25ad97616d2f1a8dc2
2022-05-12 06:32:16 +02:00
jenkins-bot 5f311d3c83 Merge "Follow-up I420bfcac8: Fix typo in loop" 2022-05-11 23:38:50 +00:00
jenkins-bot 26f79fba9c Merge "Update VE core submodule to master (af608e441)" 2022-05-11 23:26:51 +00:00
Ed Sanders 6e647b4858 Follow-up I420bfcac8: Fix typo in loop
Bug: T298147
Change-Id: Ia725709e221994737f393791de914994dbf415dd
2022-05-12 00:20:54 +01:00
jenkins-bot 1ed40a266e Merge "Filter <script> tags during parse, instead of save" 2022-05-11 21:52:47 +00:00
Bartosz Dziewoński 4c90b310ea Update VE core submodule to master (af608e441)
New changes:
30aceee47 Use equivalent colours at 50% opacity for block level backgrounds

Bug: T307466
Change-Id: I262cfc1cb914f3e36b5d5723ce53f83f2b884b87
2022-05-11 23:28:16 +02:00
jenkins-bot 2861442874 Merge "[doc only] Update comment in ApiParsoidTrait which mentions renamed file" 2022-05-11 13:22:47 +00:00
jenkins-bot 2068c1b0fe Merge "Restore global context fiddling to fix FlaggedRevs edit notices and checkboxes" 2022-05-11 09:20:54 +00:00
Translation updater bot f8f72a5035 Localisation updates from https://translatewiki.net.
Change-Id: Ibfed79ef0d511a0edeecaf0885b5cd80805d16d3
2022-05-11 08:12:22 +02:00
C. Scott Ananian 26df6d45c2 [doc only] Update comment in ApiParsoidTrait which mentions renamed file
This file was moved in 3f0f302577
(July 2019).

Change-Id: I310f8ad171cb927b93f61d4a7677741c3cb8faf1
2022-05-10 20:31:24 -04:00
Bartosz Dziewoński 4ebf2ae8bf Restore global context fiddling to fix FlaggedRevs edit notices and checkboxes
Partially reverts aed5bcf7d0.

Bug: T307852
Change-Id: I6aee2266c6b4dce560196c87b518ac25a493623a
2022-05-11 00:08:41 +02:00
Ed Sanders 4dd590432e Filter <script> tags during parse, instead of save
This is a test to identify the soruce of stray <script> tags.

Bug: T298147
Change-Id: I420bfcac89528f3a11742214dd51fadd6281fd91
2022-05-10 17:31:22 +01:00
Amir E. Aharoni 66cfaa8ba4 Rephrase messages about changes that will be lost
Make the two related messages the same, and more
grammatically logical and clear.

Change-Id: I30752a28626945e6ca974a726cb10a1022a8c820
2022-05-10 15:56:40 +03:00
Thiemo Kreuz 53b169ab43 Update CSS to force word wrap in unused parameters button
Follow-up for what was done in I37505af. I don't fully understand why
these two extras are sometimes needed and sometimes not. But this exact
combination of 3 properties is used in multiple places already, so
let's just do the same here.

Bug: T300008
Change-Id: I1eba5fc378475d365111add58a141c3114dc0118
2022-05-10 10:20:44 +02:00
Translation updater bot 85979e72e0 Localisation updates from https://translatewiki.net.
Change-Id: If6d91c0c8666d577d4e17babcd497a7d3da50092
2022-05-10 08:10:13 +02:00
jenkins-bot d411579917 Merge "ArticleTarget: Ensure dataPromise rejects when switching fails" 2022-05-09 23:31:42 +00:00
Bartosz Dziewoński 550c60dff8 Update VE core submodule to master (e54ef8d1c)
New changes:
bb90a1afd ve.dm.Node#hasMatchingAncestor: Use #traverseUpstream
61ebfd367 ve.dm.Surface: Emit context change when selection in node changes collapsed-ness
138360b1f ve.ui.ListAction#allWrapped: Use ve.dm.SurfaceFragment#hasMatchingAncestor
38d4e6c79 ve.dm.Node: Create findMatchingAncestor and factor out compareAttributes
e54ef8d1c ve.dm.SurfaceFragment: Add matchFirstAncestorOfType option

Bug: T217618
Bug: T306752
Bug: T306801
Change-Id: I51dfa902d14929bb28060492cd9e1dea28ed6cb4
2022-05-10 01:01:44 +02:00
jenkins-bot 0f31bb170e Merge "Update VE core submodule to master (5c075c883)" 2022-05-09 18:03:33 +00:00
Bartosz Dziewoński ad95513817 Update VE core submodule to master (5c075c883)
New changes:
0f594f38a Localisation updates from https://translatewiki.net.
58e060bdb AlienNode diff: Ensure types match before doing a complex comparison
c0c7d43b7 ve.ce.Surface#showModelSelection: Handle out-of-bounds nativeSelection
464f1204d ProgressDialog: Make non-escapable

Bug: T306218
Bug: T307875
Change-Id: I145f2d1454240ff01f1a9926b1a6f746be6d11df
2022-05-09 19:45:56 +02:00
jenkins-bot 6336e996b8 Merge "selenium: Check if content editable is editable" 2022-05-09 15:05:18 +00:00
Translation updater bot 3e98262831 Localisation updates from https://translatewiki.net.
Change-Id: I043057a2983ff9f9132d3b9126b01415c9c1a3d7
2022-05-09 08:12:36 +02:00
Bartosz Dziewoński a6c398a73c Update VE core submodule to master (da708802f)
New changes:
713c2d892 Localisation updates from https://translatewiki.net.
c66d07c9e Update language lists
f262afdbc Localisation updates from https://translatewiki.net.
6bedb34d0 build: Update to QUnit 2.18.2
6b89a565b Localisation updates from https://translatewiki.net.
b234264d3 Change focusable minimum size from >8x8 to >=10x4
4e70201e1 Localisation updates from https://translatewiki.net.
3f031fe82 Gruntfile: Fix 'seperate' typo
05fbd550d Remove unused CSS vendor prefixes
b880d9b74 build: Update stylelint-config-wikimedia to 0.13.0

Bug: T201491
Bug: T307527
Change-Id: I708a0675b37c3761e41c191b90ef6cfef36fd22a
2022-05-09 00:07:40 +02:00
Translation updater bot 51a7aa2e90 Localisation updates from https://translatewiki.net.
Change-Id: I64f439515ef4094c2abd9c5129c38fbc4d677bfb
2022-05-06 08:19:55 +02:00
jenkins-bot e0da7b6c8c Merge "ApiVisualEditor: Inject WikiPageFactory, UserFactory & HookContainer" 2022-05-05 21:11:42 +00:00
jenkins-bot 45ad6780eb Merge "build: Update stylelint-config-wikimedia to 0.13.0" 2022-05-05 16:03:38 +00:00
jenkins-bot 1217740612 Merge "Remove unused CSS vendor prefixes" 2022-05-05 16:01:59 +00:00
Translation updater bot 9e9ff2fb97 Localisation updates from https://translatewiki.net.
Change-Id: I3185131de5fdd4084bf3ff53501d8ed33ce48af0
2022-05-05 08:07:11 +02:00
Ed Sanders ab3b068671 build: Update stylelint-config-wikimedia to 0.13.0
Change-Id: I94a18ebc57ea04fe6246b63f6c9b5d5d8718dd4d
2022-05-04 22:54:48 +01:00
Ed Sanders bc57422841 Remove unused CSS vendor prefixes
Change-Id: Id544adce0d88123157f3f52540f7f767027ff6ab
2022-05-04 16:55:43 +01:00
Thiemo Kreuz 9297428eca Improve test coverage of template dialog outline
This focuses on some scenarios that are
a) complex enough to be worth a test,
b) but simple enough so I don't need to spend hours on comming up
   with a test setup. ;-)

This patch also simplifies the ARIA related code in
MWTransclusionOutlinePartWidget a bit.
* Check 1 of the 3 ARIA configs only. Only having one is already
  helpful and should not be skipped.
* No need for the large conditional. setAriaDescribedBy() works fine
  with undefined.

Bug: T291157
Change-Id: I142782ec9b96147de64497f4f6a373eae05b9c8e
2022-05-04 12:01:58 +02:00
Thiemo Kreuz 2cd08e42d7 Add prefixsearch fallback test for MWTemplateTitleInputWidget
The idea of the code under test is that it combines the results from
2 different API requests in a specific way. This is a first basic test
where both search results are small.

Bug: T291158
Change-Id: Ic4de57fb6b85afb952ea604769fddd06d44814c0
2022-05-04 07:11:15 +00:00
Translation updater bot ba8cde4197 Localisation updates from https://translatewiki.net.
Change-Id: Ia52c284389d86c951aa4f69cbb96a43c4829134d
2022-05-04 08:19:07 +02:00
Translation updater bot f247aea770 Localisation updates from https://translatewiki.net.
Change-Id: Id615b67c976e19ace5b3aa4928b68bafd3568942
2022-05-03 08:45:55 +02:00
jenkins-bot 4b6eb1d55b Merge "Hooks::onRecentChangeSave: Don't pass null to explode(), avoiding PHP 8.1 deprecation" 2022-05-02 12:29:05 +00:00
Esther Akinloose 1e030bcde5 selenium: Check if content editable is editable
Bug: T296187
Change-Id: I7a7808bf5cabdccc3f0a01ccecfdadeb7fdc9b91
2022-05-02 13:11:57 +01:00