Commit graph

15617 commits

Author SHA1 Message Date
Ed Sanders 7739b1c79b Fix switching without changes
* Remove 'discardChanges' from switchToWikitext. This was
  intended to discard changes even when the document was
  modified, but it is no longer used as we always keep
  changes if we can.
* Remove 'leaveVE' param, it was only used once and has
  been replaced with a direct call to switchToFallbackWikitextEditor.
* Don't reset 'section' if there are no changes.

Bug: T221981
Change-Id: Ia39345da44d203ba67ae331917c8d5ece7d42ef7
2019-04-30 14:52:58 +01:00
Ed Sanders 4fb17205b6 Allow switching from mobile visual to mobile source mode with data
Bug: T128422
Depends-On: I11b7195e9d63f9b279213201036c6338d71669f0
Change-Id: Ieaa2df17c1f73d681d935cd6103ef41c061e1a28
2019-04-25 22:37:53 +02:00
Ed Sanders 709530993b DesktopArticleTarget: Remove changing document opacity when switching to WTE
When this was introduced in 7b2cacbe57
(2013), the confimation dialog was a generic confirm() popup. Now that
it is a OOUI dialog, the dialog overlay serves the same function.

Change-Id: I9812ab55c7a8179524865d93a6d269e388d4c4ab
2019-04-25 21:08:42 +02:00
jenkins-bot d39c28ca69 Merge "ve.ui.MWSaveDialog: Work around save panel disappearing on iOS Safari as well" 2019-04-24 22:25:59 +00:00
Translation updater bot c444f0e40a Localisation updates from https://translatewiki.net.
Change-Id: Ic11c1dff4e6161ffdb4c366a11a1e2d71fabb6ee
2019-04-24 22:21:43 +02:00
James D. Forrester b89221be3b Update VE core submodule to master (b049d6049)
New changes:
c544dfc40 ve.ui.DebugBar: Fix Filibuster button
2009d0427 Remove list-specific logic from LinearEnterKeyDownHandler
1ee05602a Don't reactivate after opening tools/windows on mobile
3538c3870 (De)activate table selection on context menu toggle
39be19b54 Re-use existing table selection when re-activating
59cf5cdbd Add more granular code coverage targets
d0ff41a71 Update OOUI to v0.31.5
b049d6049 ve.ce.TableArrowKeyDownHandler: Movement from merged cells must collapse selection

Bug: T220633
Bug: T221286
Change-Id: I443e665e8831defd098eb410264c404942f3e2ec
2019-04-24 14:34:39 -05:00
Ed Sanders e3846ed09b EditSummaryWidget: Don't highlight first automatically
Bug: T50274
Change-Id: If9d46116caac381bfc7264652429377e60bb2a0b
2019-04-24 17:58:46 +01:00
jenkins-bot fa50329f62 Merge "Use PageEditStash services instead of static methods" 2019-04-24 15:11:19 +00:00
Bartosz Dziewoński 11673b21ad ve.ui.MWSaveDialog: Work around save panel disappearing on iOS Safari as well
Same thing as Ifb49ede450cabdcd8303b298b62f2ac632809b53, for
a slightly different case that we missed.

Bug: T221289
Change-Id: I0ca287af87e1058620fbed75a50d40f01513a567
2019-04-24 15:56:58 +02:00
jenkins-bot 52f62b7fe7 Merge "Update VE core submodule to master (ac38ec869)" 2019-04-24 10:55:01 +00:00
jenkins-bot 25b0475434 Merge "Remove block notice tracking" 2019-04-24 02:47:26 +00:00
jenkins-bot dc5e49aad1 Merge "ve.ui.MWSaveDialog: Fix preview of redirects" 2019-04-24 02:45:28 +00:00
James D. Forrester 3320d8ec58 Update VE core submodule to master (ac38ec869)
New changes:
64bad457a Localisation updates from https://translatewiki.net.
a4586f717 toggleMobileGlobalOverlay: check whether the target exists before using it
4d2f18871 Update RangeFix 0.2.6 -> 0.2.7
3433770e0 Restore re-activation hack

Bug: T221291
Bug: T221600
Bug: T221669
Change-Id: I783924aa8ba03a9f5969a9c3fc0c1c381a3f5741
2019-04-23 17:32:22 -05:00
Bartosz Dziewoński 5b0bb28323 ve.ui.MWSaveDialog: Fix preview of redirects
Incorrect order of operations caused all metadata to be removed before
we looked for the 'mw:PageProp/redirect' metadata item.

Bug: T221686
Change-Id: Ifcf210ad772babe1019fd0cfbaa7bd60d0e7e5fe
2019-04-23 23:02:24 +02:00
Aaron Schulz e2fa08f0f8 Use PageEditStash services instead of static methods
Change-Id: I1bcda750a22dcacfffa0f7400411a7653806a82e
2019-04-23 12:45:21 -07:00
Ed Sanders e91df06c32 Restore external paste sanitization of DOM elements
Was accidentally removed in I366a091ff4.

Bug: T221668
Change-Id: I6631f47b0afcbfb81ee72234f0b1cdabb24c1a85
2019-04-23 19:48:49 +01:00
Dayllan Maza 96de1353d3 Remove block notice tracking
This is a clean up after collecting the necessary data related to
blocks and how often users see the block notices

See: https://phabricator.wikimedia.org/T189724

Bug: T214214
Change-Id: I532a0cd95009109ba25caa8dd31badd5c1900da7
2019-04-23 11:31:37 -04:00
jenkins-bot 1e950bb222 Merge "Update VE core submodule to master (7cd15cfe9)" 2019-04-23 15:31:33 +00:00
Ed Sanders a7149cc3ee Update VE core submodule to master (7cd15cfe9)
New changes:
9b162a5da Localisation updates from https://translatewiki.net.
10dbdabf4 Remove valid-jsdoc exceptions for @chainable
a424f804d Make blockquote a non-content branch node

Local changes:
* Update stuff for making blockquote a non-content branch node

Bug: T76426
Change-Id: I95ae25f20d3d102da69bf5ffdff55335f6c07635
2019-04-22 12:39:14 +01:00
Translation updater bot 950fee47bf Localisation updates from https://translatewiki.net.
Change-Id: I02b8587b25e8bcb2575fe6771fa60349e109332c
2019-04-22 09:24:20 +02:00
Translation updater bot 19ba1bfee2 Localisation updates from https://translatewiki.net.
Change-Id: I52fab1c643b61d056223819758c74a6f645f20ff
2019-04-19 09:54:26 +02:00
jenkins-bot 8401da1073 Merge "Move autosave logic up to mw.Target" 2019-04-18 22:36:47 +00:00
Ed Sanders 1123c1eadc Move autosave logic up to mw.Target
This would allow non-article targets to implement
autosave more easily.

Change-Id: Icc945575d0982cf82647c9078caf9a39bb715c2e
2019-04-18 15:21:33 -07:00
James D. Forrester 24cb70bae0 Update VE core submodule to master (6afc66096)
New changes:
c2ae612e0 Update OOUI to v0.31.4
4e32f62c3 Re-use previousSelection when re-activating
e1f01b47c Auto-save: Allow an optional document prefix
63192a7f4 ve.ui.ToolbarDialog: Remove unused styles

Bug: T220633
Change-Id: I99a905db6aa5ba91655901a6ea2c821b8603aadf
2019-04-17 14:25:50 -07:00
jenkins-bot ebe04bb856 Merge "Apply styles for WikimediaUI theme by default rather than only Vector and Minerva" 2019-04-17 19:13:41 +00:00
jenkins-bot 6d7de40f0d Merge "ve.ui.MWSaveDialog: Fix border radius styles after changes in OOUI" 2019-04-17 19:13:38 +00:00
jenkins-bot 9a8a0592de Merge "VisualEditorHooks: Remove redundant $resourceModules check" 2019-04-17 19:03:12 +00:00
jenkins-bot bca942974b Merge "DataModule: Use module->getConfig instead of rl->getConfig" 2019-04-17 18:56:50 +00:00
jenkins-bot 32985886e3 Merge "eslint: Enable valid-jsdoc" 2019-04-17 18:39:41 +00:00
Timo Tijhof ff5f688405 DataModule: Use module->getConfig instead of rl->getConfig
The latter is being deprecated as of I74a9535918e because it was
almost never used intentionally. When module objects are created,
the appropriate context object is injected via setConfig. That is
the one the modules should use.

The context object has a reference to the ResourceLoader object
(although unsure why actually), but shouldn't be used for this
purpose as there could be a 1 to many relationships further down
towards modules.

Change-Id: Icab0f12141a46476618f984d4548a82fdae33275
2019-04-17 17:33:53 +00:00
Ed Sanders 0db4ae6e00 eslint: Enable valid-jsdoc
Change-Id: Ia0d1e57246a1c567d73022ceca9b8c02850f9bc8
2019-04-17 17:13:39 +01:00
Timo Tijhof afdd1b5fca VisualEditorHooks: Remove redundant $resourceModules check
For a while now, the 'ResourceLoaderRegisterModules' hook is
the last oppertunity to register modules. Therefore, the
isModuleRegistered() check covers everything it needs to.

In addition, at this point modifications to ResourceModules would
be ignored even if it did contain additional entries.

Change-Id: I77714fca0f561f5817a45dd3be5fd8d3ba42f969
2019-04-17 15:20:13 +01:00
Timo Tijhof ef36f4b0a1 Move usePageImages/usePageDescriptions from page conf to site conf
These do not vary by user or page, and can thus be loaded asynchronously
via the startup module, rather than blocking rendering and fetching
of modules on all pages.

In a future change, it might be better to go a step further and bundle
these with a module so that they only load as-needed instead of still
on all page views, but this should be an improvement nonetheless.

Change-Id: Icae3712ac5546a90bc7ffd787b0f3285dff6a26f
2019-04-17 00:10:27 +01:00
Bartosz Dziewoński 80bfbfc54b ve.init.mw.DesktopArticleTarget: Validate 'veaction' parameter against available modes
If a page can't be edited in the requested mode (e.g. veaction=edit on
talk pages), the parameter will now do nothing (the editor won't
load), instead of trying to load the editor in another available mode.

Bug: T219457
Change-Id: I2cd78ea13ba13ff622f5e4b7db033f82dfa7875e
2019-04-16 20:19:37 +02:00
jenkins-bot 68830e2879 Merge "ve.ui.MWMagicLinkNodeInspector: Select annotation after converting" 2019-04-16 16:17:48 +00:00
jenkins-bot 218a9250c6 Merge "Update VE core submodule to master (3796a1f91)" 2019-04-16 15:58:03 +00:00
jenkins-bot b17acda9b6 Merge "Remove unnecessary duplications of 'default' theme files" 2019-04-16 15:47:56 +00:00
Bartosz Dziewoński b1d3fdbb0c Apply styles for WikimediaUI theme by default rather than only Vector and Minerva
They will now apply for other skins not mentioned here, e.g. Timeless.
The most noticeable change is proper styling for target widgets.

Change-Id: Ibf4c080aaaeedd65144ac5e95ed2f48a1cd17635
2019-04-16 17:35:56 +02:00
Bartosz Dziewoński bba27be62e ve.ui.MWSaveDialog: Fix border radius styles after changes in OOUI
The OOUI selector has changed and we need to update ours, as we're losing the specificity fight.

Change-Id: I294c1c5480a335431542e10bcff234499001090d
2019-04-16 17:35:56 +02:00
James D. Forrester 965b1291e5 Update VE core submodule to master (3796a1f91)
New changes:
b1857b4d2 Distinguish between $scrollContainer and $scrollListener
9639db634 Surface read-only tweaks
0e2dc8646 DimensionsWidget: Make setters chainable
3d8f3538b DimensionsWidget: Add read-only support
f1a8a2693 LinkAnnotationWidget: Make setters chainable
3796a1f91 LanguageInputWidget: Fix disabled support, add read-only support

Change-Id: Iaf85be0a29283f26f4cdf9a06b565c419568170f
2019-04-16 08:26:58 -07:00
Bartosz Dziewoński 0e0bc12177 ve.ui.MWMagicLinkNodeInspector: Select annotation after converting
Currently, the selection is not updated, so we end up keeping the
first two characters selected. Same code as ve.ui.MWLinkNodeInspector,
see cb72eea2041bb35e02eb756be3f2c7e8e6c3b43c.

Change-Id: I2204643c41025ad69fa9e232edfc5a896f1b8bdf
2019-04-16 17:10:42 +02:00
Ed Sanders d14d443aff Use new CE Surface selectAnnotation method
Change-Id: Ic26c46d3cdabc7b9949527d04eada5203cf6f7d3
Depends-On: I23f3586e340899801c99b3015e51dd0965a8ef0b
2019-04-16 17:09:01 +02:00
jenkins-bot 7197fd49c3 Merge "Update VE core submodule to master (6590e0ac5)" 2019-04-16 14:58:46 +00:00
jenkins-bot cf294a0c6d Merge "init: Bundle wgVisualEditorUnsupportedEditParams with DesktopArticleTarget.init" 2019-04-16 14:58:43 +00:00
Timo Tijhof cc599c2e36 init: Bundle wgVisualEditorUnsupportedEditParams with DesktopArticleTarget.init
Bug: T219342
Change-Id: I4b5a048779bd4b957cc5d99c3a7686363ffb3df9
2019-04-16 16:33:53 +02:00
jenkins-bot c0dc4f6e7e Merge "ve.init.mw.ArticleTarget: Add sanity check against loading content in wrong mode" 2019-04-16 12:38:57 +00:00
James D. Forrester 51b68049d1 Update VE core submodule to master (6590e0ac5)
New changes:
6590e0ac5 Create generic command to move focus to context

Change-Id: Iba309ca5f7299f4157a3a43836064e17b5f4d62b
2019-04-15 14:13:42 -07:00
Translation updater bot cc2b18bdd8 Localisation updates from https://translatewiki.net.
Change-Id: I12dbe0919d2ca8247fb8098b00c0d86971799097
2019-04-15 22:54:50 +02:00
James D. Forrester f7f32c7090 Update VE core submodule to master (33847a3ec)
New changes:
ef34c19ea Make context's contents selectable
bbb39d52e Remove de-emphasis color from comment context
ce43589fe qqq.json: Add clarification to visualeditor-key- messages
5b233d7db Create more methods for finding/selecting current annotations
8fd5ec673 Fix selection behavior of table right-click
f0e7d69cd Localisation updates from https://translatewiki.net.
dd965ecf2 ve.ce.TableNode: Fix right-click to copy code

Bug: T154622
Bug: T154794
Bug: T220090
Change-Id: I483c12881f670fefc19585a2370edada1f9e9083
2019-04-15 10:10:27 -07:00
Translation updater bot e68090b168 Localisation updates from https://translatewiki.net.
Change-Id: I1f0ccca8ae4ce9a6cec47d89d6905ecc0835bc0c
2019-04-14 22:30:51 +02:00