Roan Kattouw
dbf232a7dc
Clean up deactivate mess
...
Both onDocumentKeyDown and onViewTabClick would check
this.activating and invoke deactivate() differently depending
on its value. That's ugly, so incorporate the "don't show a dialog
if deactivating during activation" logic into deactivate() itself.
Rename the override parameter to noDialog, and fix the broken
logic around it (it overrode too much).
Also move setting this.activating = false; out of these event
handlers into cancel(), where it clearly belongs because
activatingDeferred is being rejected there.
Change-Id: I6c040c74d36f829128a175f00d4e712dd19d31a7
2014-12-02 16:50:36 -08:00
jenkins-bot
45e98c7699
Merge "Cancel VE when escape key pressed"
2014-12-03 00:33:19 +00:00
Alex Monk
c0fd5e616d
Cancel VE when escape key pressed
...
Or at least open the confirmation dialog about it.
Relies on I0047bd9d to not break stuff on the second try.
Bug: T52868
Change-Id: Id178a2a0aad2f4bf5f589d66efde61aaa6fae498
2014-12-02 16:29:15 -08:00
jenkins-bot
77b507dfc7
Merge "[Browsertest]Tests for options under Advanced Settings panel"
2014-12-02 23:03:37 +00:00
ryasmeen@wikimedia.org
416d62df4f
[Browsertest]Tests for options under Advanced Settings panel
...
Change-Id: I21765e9e3d7a004d24dd620dd0da35978632d02a
2014-12-02 15:00:33 -08:00
jenkins-bot
d7f954b1b5
Merge "Make LinkCache fail more gracefully when given undefined"
2014-12-02 22:45:08 +00:00
jenkins-bot
63e09d4659
Merge "Handle encoding of links in transclusion nodes properly when determining existence"
2014-12-02 22:22:15 +00:00
Roan Kattouw
2ed648c4db
Make LinkCache fail more gracefully when given undefined
...
If you tried to do styleElement( undefined, $element ), you'd
get an exception in the mw.Title constructor from a setTimeout.
That's not very nice, and there's no point sending non-strings
through the queue and other data structures in LinkCache, so
instead just make get() return a rejected promise when given
non-string values.
Change-Id: Iab06929d7e232a8ecd8eb1eff9d1190c303421c1
2014-12-02 14:02:45 -08:00
jenkins-bot
d71279cdfe
Merge "ViewPageTarget.init: Correct docs: ve.libs.mw → mw.libs.ve"
2014-12-02 21:50:12 +00:00
jenkins-bot
6c4c3408b8
Merge "Track new pagedeleted save error in TargetEvents"
2014-12-02 02:04:11 +00:00
Roan Kattouw
915278dfea
Track new pagedeleted save error in TargetEvents
...
Change to Schema:Edit takes it to revision 10676603.
Change-Id: I87a3812585ac0dd22a66ceffdf320ad8bc326155
2014-12-01 17:58:31 -08:00
Alex Monk
db4d034fd7
Disable Apply Changes in reference dialog until changes have been made
...
Bug: T57976
Change-Id: Ib5229bdc480ec437436c5d8d351b06417d4ffd9b
2014-12-02 01:34:44 +00:00
Alex Monk
c2ed5201e5
Handle encoding of links in transclusion nodes properly when determining existence
...
Bug: T75823
Change-Id: I9398e4e1657b218043658d83b13c3dc78ffa8ff1
2014-12-02 01:09:12 +00:00
Translation updater bot
1a94745d65
Merge "Localisation updates from https://translatewiki.net ."
2014-12-01 21:25:07 +00:00
Translation updater bot
5613f53a96
Localisation updates from https://translatewiki.net .
...
Change-Id: I5c54331b5438652841ad92ed8a90a45623263563
2014-12-01 22:23:50 +01:00
James D. Forrester
3a733e83c6
Update VE core submodule to master (eed8fcb)
...
New changes:
c32754f Localisation updates from https://translatewiki.net .
41e0cbd ve.dm.Node: Fix typo in comment
27eedba Localisation updates from https://translatewiki.net .
eed8fcb Fix window manager logic
Change-Id: I2c50d403fc57b207a0296dd8b184c59c991f865a
2014-12-01 13:16:10 -08:00
Bartosz Dziewoński
e6ea9db351
ViewPageTarget.init: Correct docs: ve.libs.mw → mw.libs.ve
...
Change-Id: I265aba968d861020852ada5034e166189efd3218
2014-12-01 20:59:53 +01:00
jenkins-bot
7734e0083a
Merge "i18n: Pass value to <visualeditor-dialog-meta-settings-newsectioneditlink-help>"
2014-12-01 19:35:34 +00:00
jenkins-bot
0445ee640d
Merge "Remove duplicate startSanityCheck from ViewPageTarget"
2014-12-01 19:22:56 +00:00
James D. Forrester
7ab402eeb5
i18n: Pass value to <visualeditor-dialog-meta-settings-newsectioneditlink-help>
...
Bug: T75969
Change-Id: I6bbe2dbec74edae9fb1b09e03f3102b7a2d0be97
2014-12-01 11:22:34 -08:00
Ed Sanders
7dc4dd66a0
Remove duplicate startSanityCheck from ViewPageTarget
...
Method was moved to parent, but not deleted from child. Also move
sanityCheckPromise to parent where it is used.
Change-Id: Ie2b00330d796cd089fd4bc84d9332c316500633f
2014-12-01 19:19:51 +00:00
jenkins-bot
55eba4c1cc
Merge "Change event listener for caption surface in media dialog"
2014-12-01 19:05:09 +00:00
jenkins-bot
0cfaf9f95b
Merge "Set panels after everything is initialized in media dialog"
2014-12-01 18:48:24 +00:00
jenkins-bot
b83d8deeb8
Merge "Update VE core submodule to master (b5a0269)"
2014-12-01 17:32:30 +00:00
Translation updater bot
64604a475d
Localisation updates from https://translatewiki.net .
...
Change-Id: I6aa9f444c3e6090edcf851a51e094f0fac042b4b
2014-11-30 22:16:32 +01:00
Translation updater bot
59bccb0bd5
Localisation updates from https://translatewiki.net .
...
Change-Id: I87dde90d5069228d31da11c7dae3583fa8988320
2014-11-29 12:59:08 +01:00
James D. Forrester
3c49a18b1a
Update VE core submodule to master (b5a0269)
...
New changes:
20d9764 Move window managers to sub folder
d69c2fa Update OOjs UI to v0.2.3
62aa941 Use complex change logic if there are changes not at the selection
Change-Id: I063a38268c96db614f8870c65cdc0ed62fb96e27
2014-11-28 18:59:42 -08:00
Amir E. Aharoni
9dad03819e
Mention the "Continue" label as a parameter in visualeditor-recreate
...
Bug: T75971
Change-Id: Id075233da4e8a2978b07b5f2735ac6620ff5330d
2014-11-27 22:33:35 +02:00
Željko Filipin
15ed437331
[BrowserTest] Fixed a couple of page elements
...
Change-Id: Ia4652896243705651c86ff5f83dbd03029757705
Paired-With: Amir Aharoni
Bug: T76133
2014-11-27 11:39:02 +01:00
Roan Kattouw
d20cc324fb
Update VE core submodule to master (ddbedd1)
...
New changes:
6aecd62 Use selected annotations when replacing content
02d3a27 Only showSelection if checkSequences actually matched something
52d544b Followup 166a52b: don't disable tools that don't have commands
Change-Id: I8f43c9e85b6c43a4ebc3dfaacf4a1fdf3bd94cd0
2014-11-26 16:39:34 -08:00
jenkins-bot
a2d7d64fcf
Merge "Followup 6d21d83
: unbreak switching to edit source"
2014-11-27 00:27:39 +00:00
Moriel Schottlender
78b86cd72d
Set panels after everything is initialized in media dialog
...
Only change the panels (and focus the caption surface) after the
surface is actually appended and initialized.
Bug: T76074
Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
2014-11-26 19:26:44 -05:00
Roan Kattouw
616a9cd1bf
Followup 6d21d83
: unbreak switching to edit source
...
Forgot to pass the wikitext parameter through, oops :(
Bug: T76114
Change-Id: Ic852e4b10c17b2417f582f35fabb87823e0202e3
2014-11-26 16:24:50 -08:00
Roan Kattouw
8fc9b290c0
Followup c56a921
: use cite-transclusion-* tools in MWReferenceDialog, not cite-*
...
Because a lot of toolbar customization was removed, use an evil
hack to get this in there for now. Should be cleaned up later.
Bug: T76082
Change-Id: I0fd5ddc6fa11162deb615f0b387d6d59c5cc4a3a
2014-11-26 15:49:04 -08:00
Translation updater bot
a14f88d80e
Localisation updates from https://translatewiki.net .
...
Change-Id: Ibf83b770faf5df229365a73fb2d812d3c5fd0697
2014-11-26 22:37:44 +01:00
Moriel Schottlender
30ce139955
Change event listener for caption surface in media dialog
...
Make sure the dialog is listening to the correct event for when
caption surface changes.
Bug: T76074
Change-Id: I214947a440e4f78adf1541d8008599fe65ac8b2c
2014-11-26 20:04:07 +00:00
James D. Forrester
e90cbe6a37
Follow-up I5bc30eca7: Register <visualeditor-formatdropdown-format-blockquote>
...
Also push it into correct place in the toolbar, and disable it from media and
reference dialogs' toolbars.
Change-Id: Icc3bf056860e35def13e03e77ffc6782acc4196a
2014-11-25 19:01:02 -08:00
jenkins-bot
cee93a0758
Merge "If the user types in ':' at the beginning of a line, make it a blockquote"
2014-11-26 02:02:32 +00:00
jenkins-bot
cb9a96f845
Merge "Follow normalisation response from category status query"
2014-11-26 02:02:27 +00:00
jenkins-bot
d4e601af10
Merge "Update VE core submodule to master (f0a63dc)"
2014-11-26 02:02:24 +00:00
jenkins-bot
dc76bb63fb
Merge "If the user types in '==' at the start of a line, make it an H2"
2014-11-26 02:02:21 +00:00
James D. Forrester
e314ed9938
If the user types in ':' at the beginning of a line, make it a blockquote
...
Depends on I9507219 in VE-core.
Change-Id: I2e3219b473799194f8d305d228fc9eb3403921a8
2014-11-26 01:58:53 +00:00
Roan Kattouw
566c6d1972
Update VE core submodule to master (f0a63dc)
...
New changes:
7ac893b Editable blockquotes
Change-Id: I5bc30eca7a8006780c418a93c0057c3dd9060b1b
2014-11-25 17:58:37 -08:00
jenkins-bot
cf131ee2b7
Merge "Revert "ve.init.mw.trackSubscriber: Populate platform field with hack""
2014-11-26 01:57:09 +00:00
Catrope
64ce195fae
Revert "ve.init.mw.trackSubscriber: Populate platform field with hack"
...
Caused JS errors when invoked too early.
This reverts commit 35d3898543
.
Change-Id: Ie7dd4ef8323a16bb694e6300a096ba53cf4a0a91
2014-11-26 01:55:30 +00:00
James D. Forrester
9a7eddee79
If the user types in '==' at the start of a line, make it an H2
...
Bug: T53897
Change-Id: Ic858a38f866d929d46041fb7df93102ec89eefb3
2014-11-25 17:52:57 -08:00
jenkins-bot
8e32cc332d
Merge "Provide '[[' and '{{' to trigger the appropriate window open actions"
2014-11-26 01:51:58 +00:00
James D. Forrester
f1fa43225a
Provide '[[' and '{{' to trigger the appropriate window open actions
...
Bug: T52093
Change-Id: I917201ee07ee9a4269f5fe4cfa06aad9302aa69d
2014-11-25 17:50:10 -08:00
jenkins-bot
c8c00b78f7
Merge "Warn users who write ';' or ':' on a new line that it won't work"
2014-11-26 01:43:31 +00:00
jenkins-bot
57c4858f33
Merge "Point wikitext markup link in warning to MW.org"
2014-11-26 01:43:19 +00:00