Commit graph

9331 commits

Author SHA1 Message Date
jenkins-bot 6c5cb61139 Merge "ImageInfoCache: Don't try to access imageinfo result if it's not set" 2015-02-28 01:40:52 +00:00
Alex Monk 944e7d7a86 ImageInfoCache: Don't try to access imageinfo result if it's not set
Bug: T90916
Change-Id: Iebd393b0cff8016cc8917b86ca277eddf7810d4e
2015-02-28 01:25:12 +00:00
jenkins-bot 757e8d1950 Merge "MWCategoryWidget: Remove entries from this.categories when appropriate" 2015-02-28 01:00:15 +00:00
jenkins-bot 54b9bf76ae Merge "Make generateCitationFeatures() idempotent" 2015-02-28 00:58:43 +00:00
James D. Forrester e283be675b Update VE core submodule to master (7bcf314)
New changes:
8e09b32 Make align widget work when config is undefined
8fd594e Localisation updates from https://translatewiki.net.
d3b8d9f Prevent form submission in FragmentInspector
b87d809 ve.ce.FocusableNode.css: Quieten csslint for Firefox-specific hack
3177599 Follow-up cf1e167880: Update call to ve.ui.Toolbar constructor

Change-Id: I438f5e1ad6322e7c9a3621bb2b50ccf9f5c96dde
2015-02-27 19:53:07 -05:00
Roan Kattouw 2b67617179 Make generateCitationFeatures() idempotent
Add checks so it doesn't generate and register the same
tool twice. This makes it safe to run it multiple times.

Change-Id: I882b51bd0422222f2e80555910c69b059136a503
2015-02-27 16:18:15 -08:00
Trevor Parscal 34da7d56b8 Update VE core submodule to master (2e1a0bb)
New changes:
04a5947 Localisation updates from https://translatewiki.net.
dd4691b Update OOjs to v1.1.5
2e1a0bb Context refactor

Local changes:
Add context item support for references, citations, templates and links

Change-Id: I5d488ecbf9768dc63de6e545505dbfd5eb84cc61
2015-02-27 18:21:13 -05:00
Alex Monk 9246fcd2ff MWCategoryWidget: Remove entries from this.categories when appropriate
So for example MWCategoryWidget#getCategories doesn't return stuff that was removed.

Bug: T89923
Change-Id: Id99ea2e3b7c74e186bacbcf796b6df3a131a37b1
2015-02-27 22:05:58 +00:00
Moriel Schottlender f0f8f52080 Refactor MWMediaResultWidget to resize better
For the masonry view, the result widget resizes itself according to
the rows and other images in the row. Up until now the resize was
a bit buggy, occasionally missing height/width values. This is
mostly due to rounding errors, but also due to a small double
calculation that is now fixed with this code.

Change-Id: If18adc5280e4bdbb9174b7c7e6e4eadf3c1ab26d
2015-02-26 16:42:14 -08:00
Translation updater bot a515c4468b Localisation updates from https://translatewiki.net.
Change-Id: I7dae73e4c3fbe408613e763147e058f079656d50
2015-02-26 21:40:24 +01:00
jenkins-bot 1facc44556 Merge "Follow-up I18162f04: Send uselang parameter with paction=parse request" 2015-02-26 18:26:58 +00:00
jenkins-bot 895ffc241b Merge "Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again" 2015-02-26 12:39:29 +00:00
Amir E. Aharoni 76b50c5b34 [BrowserTest] Update the Edit tab scenario
Make it clear that this scenario is supposed to test
and take screenshots of the "Edit source" and "Edit" tabs.

Change-Id: Ia480eacb2629553c378ecad52a9b0ed1336cd0f3
2015-02-26 12:59:34 +02:00
jenkins-bot 87de0ed84e Merge "[BrowserTest] Fix VisualEditor_More_Settings scenario" 2015-02-26 10:46:24 +00:00
jenkins-bot fd44d5541a Merge "[BrowserTest] Update the scenario for Cite screenshot" 2015-02-26 10:44:57 +00:00
jenkins-bot f0c9a17fb6 Merge "[BrowserTest] Update Gemfile.lock" 2015-02-26 10:43:16 +00:00
Alex Monk a6dbdb4788 Follow-up I18162f04: Send uselang parameter with paction=parse request
Change-Id: I70c2e6c448c175ebe9d46c2003499e22a79b28b1
2015-02-26 01:45:48 +00:00
Alex Monk ac2242af5f Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again
But not all

Change-Id: If9d88bb8d6c532992e8118e504f2fae45c0ca96a
2015-02-26 01:24:16 +00:00
Moriel Schottlender b85b81c501 Correctly validate a provider for local api
Make sure that the validation method accounts for local api
vs remote api when checking for valid variables.

Bug: T90795
Change-Id: Ia6877ca6ccc4e65d1db053f107e7702721e2da3c
2015-02-25 15:59:05 -08:00
Translation updater bot bc75cf573f Localisation updates from https://translatewiki.net.
Change-Id: I776e632fcb40c2edc6b8b80fc000fe9952516697
2015-02-25 22:59:22 +01:00
James D. Forrester 83e0503895 Update VE core submodule to master (f81b990)
New changes:
8314c74 Localisation updates from https://translatewiki.net.
f81b990 Guess annotations better for complex changes

Change-Id: I2099f07f4e832aaa2da35f9503b9212a16c33f78
2015-02-25 10:50:34 -08:00
jenkins-bot d50935ffe9 Merge "Update VE core submodule to master (31fb72a)" 2015-02-25 18:33:54 +00:00
jenkins-bot b4998f0932 Merge "Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target" 2015-02-25 17:26:27 +00:00
jenkins-bot b167051f15 Merge "Follow-up I0b4b8dca: Set redirect checkbox correctly on page setup" 2015-02-25 16:57:14 +00:00
Alex Monk edd9b68ab1 Follow-up I0b4b8dca: Set redirect checkbox correctly on page setup
Use setSelected rather than setValue, as done in I0b4b8dca for the rest
of the file.

Bug: T89511
Change-Id: I16ff6f7dc872b427373df1634cfa2f1a12da54ba
2015-02-25 16:53:20 +00:00
jenkins-bot 228c0f838b Merge "Check whether template is altered before allowing apply" 2015-02-25 16:27:38 +00:00
jenkins-bot 5a9ff0e1be Merge "Follow-up I5636e744: Only set noeditsection class for no edit checkbox" 2015-02-25 16:26:42 +00:00
Matthew Flaschen 3af3bde7fe VisualEditorDataModule depends on ext.visualEditor.mediaWiki
It uses modules/ve-mw/init/ve.init.mw.Platform.js via addParsedMessages

The missing dependency triggered an error when working on the Flow/VE
integration.

Change-Id: I64347aa6a0cf94fe51dd724432c22d54eea0cfd9
2015-02-24 23:10:27 -05:00
Alex Monk 9611f50fbd Follow-up I5636e744: Only set noeditsection class for no edit checkbox
Change-Id: I0994b38bdfaff2dfb4238e60e44764b7c6fd5c42
2015-02-25 02:37:15 +00:00
Alex Monk 85373bcb9a Check whether template is altered before allowing apply
Again. Originally done in I5a664f86, the crucial part of which was reversed
in I1500f480.

Bug: T89913
Change-Id: I39b0cdcdb5f76fa75f506c874ef6223d8d8d53e6
2015-02-25 02:12:28 +00:00
Alex Monk 8e48f94580 Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target
Bug: T58659
Bug: T89435
Change-Id: I18162f04c50f48606378aed62ee99fccdc3159f6
2015-02-25 01:57:22 +00:00
Amir E. Aharoni 5a70225a6b [BrowserTest] Fix VisualEditor_More_Settings scenario
The screenshot here is supposed to capture the menu that opens
when the hamburger icon is pressed.

The previous code captured the whole toolbar. This is now fixed.

A sample screenshot is here:
https://commons.wikimedia.org/wiki/File:VisualEditor_More_Settings-en.png

Change-Id: Id9501b8b1b8d41411c2f81bf4d4954a6bb41addc
2015-02-25 00:17:15 +00:00
Amir E. Aharoni acf67c7af2 [BrowserTest] Update the scenario for Cite screenshot
This screenshot only needs the "Cite" button,
and not the whole dropdown menu.

* The clicking step is removed.
* The element is reconfigured.

Change-Id: If4b863e51db611b96186ca6381d0426a335a9a17
2015-02-25 00:16:53 +00:00
Amir E. Aharoni 049955c2cf [BrowserTest] Update Gemfile.lock
commons_upload gem is updated to 0.0.2.

Change-Id: I3658c509048e301f6ed8b5c6edb5b698bb21bffe
2015-02-25 00:16:40 +00:00
Translation updater bot 1960cc7406 Localisation updates from https://translatewiki.net.
Change-Id: Ib8d6e8caa60de4ad20db63017fefe33e39c612e4
2015-02-24 22:05:38 +01:00
James D. Forrester 40662bd7ce Update VE core submodule to master (31fb72a)
New changes:
80fa805 Remove use of getDocument/getWindow in ve.utils.js
763c0df Fix disconnect of focus change handler in surface destroy
f017882 Clear surface observer when re-activating a surface
56cf369 Revert "ve.ce.FocusableNode: Remove superfluous ve.ce.Surface#appendHighlights call"

Change-Id: I2df30e9c67da5246c0ec58e211b34c8fe0886339
2015-02-24 12:02:45 -08:00
jenkins-bot b6ad119f15 Merge "Remove unused $popupOverlay" 2015-02-24 19:15:28 +00:00
jenkins-bot bd4289241a Merge "Adjust Queue and Provider to work with generalized parents" 2015-02-24 18:42:40 +00:00
Ed Sanders e0e0cb446e Remove unused $popupOverlay
Change-Id: I17342d451833298b5b45ebd7d00cc17f3086df71
2015-02-24 18:19:07 +00:00
jenkins-bot 057b24ce13 Merge "Factor out the Parsoid API request into its own method" 2015-02-24 02:45:20 +00:00
Roan Kattouw 86e1d1214b Factor out the Parsoid API request into its own method
This will allow us to more easily split the API request
into two requests (one for the HTML, one for metadata)
by returning a $.when() promise, and to initiate these
requests earlier (by storing a promise and returning it
in this method).

Change-Id: I4a5d1b8c47a3dc2edfe89925e63dcf90d7038e45
2015-02-24 02:41:21 +00:00
jenkins-bot 2659aa632b Merge "Fix a few silly RL module dependencies" 2015-02-24 01:47:28 +00:00
Roan Kattouw aa51e6fa59 Fix a few silly RL module dependencies
* jquery.placeholder: Wasn't being used at all, removed
* rangefix: Only used in ce.Surface, moved to the module that contains ce.Surface

Change-Id: Idea65687752a9fd31e4ad7594181e402d26b579d
2015-02-23 17:37:42 -08:00
Ed Sanders d73e9d6a84 Update VE core submodule to master (e6a37e2)
New changes:
822236c Simplify slug behaviour

Local changes:
Add Vector-specific rules for slug animation

Change-Id: I812f6f8afc8733aae245f3606302f032e5e54675
2015-02-23 17:18:40 -08:00
Roan Kattouw 2e0c051a37 Load mw.feedback on demand
It depends on jQuery UI so it pulls in a bunch of things
that we can do without while loading VE.

This does mean there's a network delay while we load
mw.feedback (if it's not in localStorage cache already),
so after the user clicks "Leave feedback", nothing happens
for a little bit until the code arrives and the feedback
dialog appears. There is no spinner or anything during this
time; we may possibly want to add one.

Change-Id: Ie4dd9efcfff238fefad2783e22575ffd3fc648e7
2015-02-24 00:30:03 +00:00
jenkins-bot 5623f131ca Merge "Update VE core submodule to master (2eaf5c9)" 2015-02-23 22:20:22 +00:00
Translation updater bot 5a25f920d9 Localisation updates from https://translatewiki.net.
Change-Id: Ia832c94633883c4031f2490e7e8901c2b989101a
2015-02-23 22:01:03 +01:00
James D. Forrester f59cd38eb3 Update VE core submodule to master (2eaf5c9)
New changes:
2e75a9b newFromDocumentInsertion: Also remap store indexes in internalList data
f04b980 Transaction#newFromDocumentInsertion: Add some more tests
60d051c ve.ce.FocusableNode: Ignore children of elements using CSS column-count in Chrome
1089125 [BrowserTest] Update Gemfile.lock
3f376f5 [BrowserTest] Define Rubocop LineLength as 100
ee63e73 Work around Firefox bug allowing cursor in cE=false
505369a Unify data transfer handlers for paste and drop

Change-Id: I5e9c3bdf45610cd4a46de7af9bec78fa1847c23c
2015-02-23 12:54:32 -08:00
Timo Tijhof 4c1de2edb2 mw.ViewPageTarget: Remove obsolete transitions for margin
These were there to match Vector, however as of 4cec8a70589
Vector no longer has these. Having these in VisualEditor causes
the toolbar to be a few pixels behind (like a slingshot) when the
rest of the skin has already moved.

Change-Id: Ia5886a58316ccb3b0420553c3f466b5256089c73
2015-02-23 17:16:46 +00:00
jenkins-bot f17414f9d5 Merge "Use prefixed page title for browser title bar" 2015-02-23 17:12:20 +00:00