Was being thrown on all read pages and caused VE to no longer
load properly.
Three places make use of $.cookie():
* ve.init.mw.DesktopArticleTarget.init.js
* ve.init.mw.DesktopArticleTarget.js
* ve.ui.MWEducationPopupTool.js
Presumably this worked by luck previously due to another extension
or core module depending on it and loading earlier but no more.
Change-Id: I6b00822f1d5d17add3e298cbd77f4790899aaec2
New changes:
b558ef1 Localisation updates from https://translatewiki.net.
53476f4 Move logic for showing icon for invisibles to focusable node
Change-Id: I4bda82918cb54a3cc77523137fa297960b1b1ba0
New changes:
242ab45 DesktopContext: Float the context when it goes beyond the viewport
405c44d Rename TableContext to TableLineContext
6c564be Sort messages alphabetically
70ff8cc Introduce table and table cell context
Change-Id: I4357162bc192c90f99ca0aec12eb67bf848e5504
Some old code (pre-Icebc378f) is still relying on these existing,
and some users are getting it loaded somehow.
Bug: T125249
Change-Id: I83190da98478bc702c23dfff2091cc5480174958
New changes:
79546b8 Tables: Add slugs for missing cells in sparse tables
f723301 Tables: Multi-cell copy and paste
2548fac Spoil the fun of guessing what current[0] and current[1] mean.
db7c9aa Localisation updates from https://translatewiki.net.
526e1bf Tables: Move columns and rows
Change-Id: Id8d5f091cbca36c54f78f90bd2ac7aa2e6dacd1b
New changes:
1ab3b78 Localisation updates from https://translatewiki.net.
92abd0c [DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabled
479b902 Localisation updates from https://translatewiki.net.
7723bcc Unbreak build from i18n-bot self merging
d1c5207 Move white-space:pre-wrap hack to ContentBranchNode
7bbded7 Annotation context items: expand the selection if no annotations
c9ca0a3 Localisation updates from https://translatewiki.net.
8dfabec ve.dm.Document: Rename cloneSliceFromRange to shallowCloneFromRange
7fee02d Localisation updates from https://translatewiki.net.
2176d88 Localisation updates from https://translatewiki.net.
a5ab6f4 Unbreak i18n lists
915b8c2 Localisation updates from https://translatewiki.net.
469c8be Localisation updates from https://translatewiki.net.
34f4a48 APIResultsProvider: Refactoring resetting of queue.
584fc0f Localisation updates from https://translatewiki.net.
Change-Id: I9c165c8df7a48560ab84fabe4ee2f8d244c37203
Create a subclass for MediaSearch(Provider/Queue) and make the parent
class a more generic representation of API requests for media.
Change-Id: Iea8b90e829d532d210bfef3c96d6798c64e15eed
Usually. Unless you load VE, because then you might be loading on
`action=edit` in remember-last mode and therefore the tab text needs to
be updated from "Edit source" to "Edit". Or "Create source" to "Create".
Or the equivalent with 'local description' in the case of pages from
foreign file repos, etc.
Bug: T120970
Change-Id: I8f07be6c8e415b40ad134ee82d0bda1d63cc4f96
As of 3b44da3261673 in MediaWiki core, all MediaWiki:*.json pages are
given the JSON content model, so our hook that does the same is no
longer needed.
Change-Id: I8b39edf36b479ca22d74481c3d571d15db69aa1e
New changes:
e536779 [DEPRECATING CHANGE] Rename link inspector tools
3899967 Localisation updates from https://translatewiki.net.
0a1c09e [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets
Local changes:
* Refactor tools for the breaking change
Change-Id: I676af9c50b09ef007926240eb2327d1a0fdd80f5
Move over logic which isn't specific to the article
implementation of VE (e.g. nothing related to loading/saving).
Refactors setupSurface to use an abstract tracking method (which
does nothing by default), and moves surface CSS classes to #createSurface.
Breaking change:
* Rename onSurfaceReady to surfaceReady. We shouldn't need to listen
to our own events.
* Rename onReady to documentReady. onReady is not a listener.
Bug: T97166
Change-Id: I7242b1bb5501b7755a18a13d13e166c30cac9cdd
This makes way for a base mw.Target class which is
not specific to articles (e.g. Flow boards).
Bug: T97166
Change-Id: If72650bdf87aa9f195b004da0a4d815f1a8063a3
In addition to the couple of TODOs inline, we should do the following in
follow-up commits:
* Prevent FOUC due to changing things only on the client
* Make section link behaviour sensible
Bug: T58337
Change-Id: I65d966270491ffe017cb11a0daa915628fadf65c
New changes:
94f2edb Paste sanitization: Check for whitespace *before* newlines
c981b96 Fix-up Ie5414f62c: Fix call to non existant method
d6f2d75 FindAndReplace: Implement whole word matching
Local changes:
* Message and config for FindAndReplace whole word matching
Change-Id: I103b9b1ec92c0aae1e51e1a94db6b8b5e759dbea
New changes:
c04d8c0 Diff richtext to build model changes
25c95be Localisation updates from https://translatewiki.net.
Change-Id: Idf95b655dbed4f56633d91c52fc8b90308438d45
New changes:
ee3c787 When the cursor is inside a table cell, tab moves between cells
c6b338a Use white-space: pre-wrap instead of using for spaces
83e394b Define 'space' as a trigger key
b0c4535 Localisation updates from https://translatewiki.net.
1336c5c .mailmap: Add some extra addresses and change default for rmoen
a67ee68 AUTHORS.txt: Be more strict about 'principal' authors and update addresses
Change-Id: I4193774aa0d45d3751386bd2cfbd6d6717c0a81a
This fixes some rendering issues, and also increases the font
size of reference contexts from 12.8px (interface) to 14px (content).
Bug: T119430
Change-Id: Ib1bae8cd4cfe86903d78406a33db78e1489fde86
An MWExtensionDialog with a PreviewElement for the selected node,
or node to insert.
Depends on Icd622e15cd7 in VE core.
Change-Id: Ia0f46da2d445dd94c8aa50be73508d9f1afcb816
New changes:
3951dc1 Localisation updates from https://translatewiki.net.
a92d028 Introduce view selections to abstract getSelectionRects logic
f3030e0 Move getSelectionBoundingRect logic from TableNode to TableSelection
679300d Localisation updates from https://translatewiki.net.
5f7ebcd Update OOjs UI to v0.13.3
aa87e56 Unbreak complex HTML paste by ignoring screenshot fallbacks
afe5d45 Paste handlers: Break after the HTML data item
Change-Id: I6ce7c41fac995e718a88d8c2366ff642ef6dfd06
Follows-up 55f78fc which deleted this message.
> MessageBlobStore::fetchMessage failed to find: 'visualeditor-linkinspector-open' (en)
Change-Id: Iccfd51f597b991146209b7a639179ff0deb0e119
New changes:
fbb2b2e Localisation updates from https://translatewiki.net.
933f979 mailmap: Remove unused alias for ttijhof@wikimedia.org
72ce0e6 Better faking of onselectionchange
0d550d9 Paste sanitization: Treat <br> breaks as node splits
966b0a1 Localisation updates from https://translatewiki.net.
414cebb ContentAction: Add 'collapseToEnd' option to 'insert'
60de784 demos: Fix 'TypeError: ve.demo.target not a function' in desktop-dist.html
71f272e Localisation updates from https://translatewiki.net.
60376d2 RangeFix: Update from 0.1.1 to 0.1.2
2470042 Localisation updates from https://translatewiki.net.
7b1cdda Range offsets: Special case when adjacent to a nail
7ecde6c Add ve.ui.AnnotationContextItem
Change-Id: Iaab4cb7f9d4ec9d7120f42350fd613458c996c85
VisualEditor is usually not enabled in talk namespaces... but
sometimes it is. And when users see the button to edit with VE,
they're going to click it and expect to be able to sign their posts.
This tool is only loaded on talk pages and pages in additional
namespaces defined in $wgExtraSignatureNamespaces.
Code adapted with small tweaks from my own gadget
<https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js?oldid=13461327>,
which is already available under the MIT license.
Changes include:
* The tool is now always visible if the wiki allows signatures in any
VE namespaces, but disabled when not allowed in the current namespace.
* Register '~~~~' sequence to insert the signature.
* Code style tweaks for stricter lint checks in this repository.
* Documentation corrections.
Swedish translation provided by André Costa (already credited
as a translator as Lokal_Profil).
Depends on changes in VisualEditor core:
* I89fe53890ab59d12260ea6b41de802c38c24e8b9
* I14cd7efac521687ea38580341ae08ddc522edeeb
Bug: T53154
Change-Id: I6be5fb2118cf3eef5098d4c5320228aa81411ccb
Ensures that these styles are loaded *after* OOUI by making
them dependent on it, unlike DesktopArticleTarget.init
which isn't.
Change-Id: Ia1fff16432d20fb56707c5e21c6a930d2478e311
New changes:
cda23ea CommandHelpDialog: Layout tweak
a4fcff4 Localisation updates from https://translatewiki.net.
dac9067 Remove unused jquery.visibleText library
58beb8c lib: Add AUTHORS, LICENSE and README files for libraries missing them
efb1749 Surface drop: Show branch node drop markers for file drop
a55574b Localisation updates from https://translatewiki.net.
0ad3133 Add ve.Scheduler
55cc3e0 Close inspectors before executing a ve.ui.Tool command
6132af8 Localisation updates from https://translatewiki.net.
24fed63 Watch for hashchange on the demo
0f04339 ve.ui.Sequence: Allow sequences to insert content
Change-Id: Idf26d9fb1970b994a54085b43fcc848b005da273
VE already has a a switch icon in the options menu, so bring that
up to the main toolbar.
Append an OOUI button to the WikiEditor toolbar if present, and bind
to the same functon as the edit tab.
Bug: T49779
Change-Id: Ic1e83ea7b13c4fef68024bf05ffc244060666103
New changes:
6cae77b ElementLinearData: Add another case to hasContent
d2e15f2 SurfaceFragment: Improve handling of delete all
16db2a3 Return 'null' instead of null in ve.Filibuster observers
24de6b2 Introduce key down handlers to separate logic from ce surface
f77fe99 Localisation updates from https://translatewiki.net.
062cb26 Localisation updates from https://translatewiki.net.
Change-Id: I61c94983c7898af219266af3022761638c7578b7
Remove bottom border radii from the <textarea> and apply to
the options bar instead.
Apply different values for Apex and MediaWiki themes.
Change-Id: If727863a87547692ee499d2141c0418658609412
The extension registers a lot of sequences that don't apply to core
VisualEditor. Pretty much the opposite of the trigger situation, where
almost all are in core. So, merge them into the help dialog.
Update VE core submodule to master (be148ae)
New changes:
7380244 [BREAKING CHANGE] Include sequences in the command help dialog
Bug: T116013
Change-Id: I5ad2939c10140b954fb29e1e50414ab7d79aeab7
The widget attempts to load the ext.codeEditor.ace.modes module
and if it fails, will fall back to regular TextWidget behaviour.
Bug: T49742
Change-Id: Ie483f6eba25e3732a396c18decc0e1844b806b23
New changes:
9cb6f74 Move insertion annotation calc logic from DM Surface to ElementLinearData
04d4bfd Refactor the code that determine insertion annotations
d9efa1c DimensionsWidget: Fix alignment of labels
66ba732 Always render generated content the first time, including errors
23a957c Consistently use spaces inside brackets in CSS
f17c8ad Localisation updates from https://translatewiki.net.
f4d0643 Localisation updates from https://translatewiki.net.
ec29e77 Follow-up I553e31: Don't show error for non-rendered GCNs
5f2402b Pass staging state through Document#commit to ve.dm.Node update event
0d3e998 Fix ve.ce.Document HTML tests
7c95c6a Wrap <hr>s so their margins are clickable
164b9a3 Localisation updates from https://translatewiki.net.
Change-Id: I069082baeb45105bf2e0106879d472319a6ffe2a
As part of the plan to render extension errors in the
inspector instead of the view, append an element to
contain the error. More specifically, the element is
a div that contains a LabelWidget (in which the error
message is displayed) and a ButtonWidget (to expand
and collapse the error).
Initially the error element is hidden, but if Parsoid
returns an error, the element will be shown. If the
error is longer than 1 line, it is truncated but can
be expanded. On closing the inspector, any remaining
error is collapsed and hidden.
Depends on I6002d9870d2b to work
Bug: T113172
Change-Id: Ie84130d4ac0da9a738bf98ad0a3677d47566d585
* Make betatempdisable appear checked if autodisable is true
* Set autodisable=false only if betatempdisable is also false
* On wikis where $wgVisualEditorTransitionDefault=true, set
autodisable=true when the user disables VE
Change-Id: I3415af4a735afb10cf246f4b22b9d84ef98c882f
We want to flip the default of visualeditor-enable to true, but don't
necessarily want to turn it on for users who already have contributions but who
haven't already enabled it. Therefore we're considering adding such users to
this autodisable preference which they can self-remove (by explicitly enabling
VE) or we can target later, separate from betatempdisable users.
Bug: T112352
Change-Id: I1ce5e6c92055e30fdc82bc912a767e913b190ef6
New changes:
90ed001 Localisation updates from https://translatewiki.net.
c2f2096 Rename ve.ui.PreviewWidget to ve.ui.PreviewElement
Change-Id: I35103bc5d98b7eee77c9f5f22c441091b6453687
New changes:
4a089dd dm.Annotation: Remove unused convenience wrapper
f30ad5c PreviewWidget: De-duplicate code with a private function
c16da30 Restore scroll immediately after paste
45b1406 Links: Explicit entry/exit with cartouches
Change-Id: I48ad7fb3f68ebb5eff89cc7e2b00878cca550222
Drop beta-ness as users don't care and it confuses them. Leaving the preference
alone for now.
Bug: T99963
Bug: T112354
Change-Id: I0e039dec54d528fce24226e76b931b593dd13a9e
During testing of saveFailure for T110272, I noticed these were showing up as broken
missing messages on mobile.
Change-Id: I20ce66ba180b6f40443ba7a9a7a0da3de3b4e6f3
New changes:
5542fe9 Localisation updates from https://translatewiki.net.
0a64089 Follow-up 5542fe9: Fix build for added language 'glk'
26c8862 Update OOjs UI to v0.12.7
0481471 Make ve.ui.Sequence#execute return false if the command is missing
20fd431 Localisation updates from https://translatewiki.net.
521d281 Localisation updates from https://translatewiki.net.
a76cbef build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue
7022385 Back out "Re-use example surface across surface view tests"
3a8f7af Don't call setInsertionAnnotations on handleInsertion
10700e2 Localisation updates from https://translatewiki.net.
3b75d9d Don't descend into overflow clipped nodes for highlights
9492aca De-duplicate methods in NodeDialog and NodeInspector using mixin
Change-Id: I06a239269c68351f046f8aa221bb82899a8f57b1
Implement a special node type, context item, and inspector for
ISBN/PMID/RFC magic links. Add buttons to the link inspectors
to convert back and forth between "simple" links, and magic links.
Depends on I5d000d8b63dafdfe0a2753069d3f0ac5b03b8829 in Parsoid
for clean round-tripping of localized ISBN magic links.
Bug: T63558
Change-Id: Id5b7a2ae3c80b0e5eed598f0bd024d3e94f7e9aa
This requires https://gerrit.wikimedia.org/r/214351 in core, which adds
support for emulating the RESTBase v1 API to the
ParsoidVirtualRESTService.
$wgVisualEditorPrefix is now deprecated. Parsoid is configured using
VRS (preferred) or $wgVisualEditorDomain, which defaults to
$wgCanonicalServer.
This bumps our MW-core dependency to 1.26wmf21.
Bug: T110780
Change-Id: I9175ac8db8310f0c9574c8272b5e39932557d57e
Also store the abortable API request so it can be cancelled
by the dialog.
To test this, put sleep(4); in ApiVisualEditor.php.
Depends on Ied21e574baa in core.
Change-Id: I83ffa9e0b7164ca4a34eae86cde452d8f38dc853
New changes:
de69c36 Fix typos in function names
fa80099 [BREAKING CHANGE] Split out linear context from context
db1d28c Only show alien context for focusable nodes
1191940 build: Bump grunt-jscs to 2.0.0 and make pass
Local changes:
* Update context inheritance
Change-Id: I284e2b30cd1903770482ee1c554687b676a2d626
This invokes Parsoid to convert likely wikitext pastes.
This addresses about 20% of the <nowiki> insertion quantified at
https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis/Nowiki
for 2015-04-08 which were due to inadvertent pastes of wikitext.
For a better user experience, suppress Parsoid's P-wrapping if the
output consists of a single top-level P element. This ensures that
pasting '[[Foo]]' won't add an unexpected newline before the paste.
Bug: T54204
Bug: T109449
Change-Id: I26a4cd8dc5b7e7caf16ca081dbe7baf6a7db8e5c
New changes:
44f8204 Autolink pasted links
Local changes:
* Add UrlStringTransferHandler from core
Change-Id: I7eae6da2739fa47b22ed1e7fbf53e9473e037c5b
New changes:
61d20a1 Hide on-screen keyboard when selecting nodes on all mobile platforms
e5aff79 Localisation updates from https://translatewiki.net.
a99a897 Update OOjs UI to v0.12.3
3c01a14 Make DM nodes sensibly hashable
a611eb9 Make ve.dm.example.postprocessAnnotations fluent
496c895 Update ve.dm.ElementLinearData#hasContent documentation
fcaa035 Support RegExp sequences; trigger sequence matcher after newline
edda1d4 Add a mechanism to wait until ve.init.platform has been created
e174155 Autolink URLs when typing
ac9248f Allow drag and drop of links (and subsequent autolinking)
c88fad6 Localisation updates from https://translatewiki.net.
Local changes:
* Define `ve.init.platform.getUnanchoredExternalLinkUrlProtocolsRegexp`.
* Make `ve.ui.MWLinkAction` extend `ve.ui.LinkAction`.
* Override `ve.ui.LinkAction.getLinkAnnotation` so auto-links use the proper
`ve.ui.MWExternalLinkAnnotation` type.
Change-Id: I934f76158512e2e89b614ed92fef6481f70728e7
New changes:
8218ced Localisation updates from https://translatewiki.net.
c7f4587 Fix resizable node teardown
90869e0 Context: Store default button config in a static property
d9d747f MobileContext: Provide a delete button for nodes' context
9dadbfc MobileContext: Provide a fallback context item for alien nodes
Change-Id: If135c9309baf1af58e3c58fdec099e794bc08e64
New changes:
2464397 Move toolbar floating code up to the target
11bdc21 Separate SA target into Mobile and Desktop
7ab3389 AlignableContextItem: Fix styling in mobile
758619f CONTRIBUTING.md: Update file paths and build instructions
Local changes to mw.Target to handle toolbar floating.
Change-Id: I0751817e3a6668b120134bfcb6c611b121a46501
New changes:
a56746e Ensure demo init script runs last
ab6a1bd Context emits resize events
564701a Provide a context item for table cells in mobile
9f92a0f MobileWindowManager: Bring in styles from MW-Minerva
Change-Id: If0da9079bbab6f930979ed17be3b27cb0a5bea60
Split the toolbar into two modes depending on if the surface is focused:
* When unfocused, show a hamburger containing back and source switch
* When focused, show editing tools, and a check button to unfocus
For the editing toolbar, space the tools out using table-cell layout
and hide labels below 480px.
Depends on I06813e3ff in core (surface blur method).
Bug: T93325
Change-Id: Ibf09cb29019d7a71e1e144b326710b1f6506cd0c
New changes:
87c538a PasteRules#plainText: Fallback if rules.external is undefined
7155191 Localisation updates from https://translatewiki.net.
c2d03ea ToolContextItem: Use the target's command registry
d196838 DataTransferHandler: Improve aborting and resolution/rejection
009190e Allow the target to specify a DataTransferHandler factory
0ea9439 Split out basic functionality of tableCell so other nodes can behave as cells
999a5da ve.ce.TableCellableNode: Only apply title to nodes which are cellable
Change-Id: I56a73a26f21a6e22b6bafc850cdee35397e5d15d
* Bring in back button & save button from MobileFrontend
so they are properly styled OOUI widgets
* Accordingly, move toolbar save button code up into base
MW target.
Bug: T96186
Change-Id: Ic89dd4efb831fc3b09980da16524276f6568619d
Usage:
In a skin, that needs this offset, e.g. because it has a fixed header, it should add
this config var somewhere before the hook BeforeOutputPage is called:
$wgVisualEditorSkinToolbarScrollOffset['vector'] = 60;
(if 60px is the offset to use)
Depends on: I2e10c12df8277c84d948e48c6a132c03d6324693
Bug: T95528
Change-Id: Iaa86c2f68afa6403fcc4f5b7c655704512beead4
No retry right now, but we should at least stop failing silently. Doing this
in a window.alert() for now, as OOUI isn't available at this part of the
page load just yet (that will be coming soon).
Bug: T97041
Change-Id: Iacb195667215ee69d3991e4c41651ab6042243c5
New changes:
dc27315 ve.SelectionState: DOM selection snapshot
6cd7d91 Emit context change when any annotations change, not just covered.
d2c98d5 demos: Default to 'simple.html' instead of 'aliens.html'
3685d17 Emit change when selection changes from collapsed to not
baa21a8 Update OOjs UI to v0.11.8
Change-Id: I8a1032263f84fc2bf3aa1495229ffab8f50589d6
Starting with I21fbbd3247bf7801e5ef9bd5312f95777f4dd6ef, Parsoid
will emit a new HTML for its Cite extension, which enables CSS
styling. In I487095df8a7c4241a14f7b4480360f6774130bec the new
module 'ext.cite.style' is added to the Cite extension to style
this new HTML format.
This patch
* Loads the ext.cite.style module if the Cite extension is
present.
* Uses the new HTML format for the internal structure of
reference and reference list nodes, so they are correctly
styled.
Backwards compatibility: Only new HTML is used internally in VE,
so as long as ext.cite.style can be loaded the new styles will be
used. It does not depend on which format Parsoid returns, so this
patch only depends on the Cite extension patch, not on the Parsoid
one.
Note: The only way I've found of adding a ext.cite.style dependency
only if Cite is present is to register the whole
ext.visualEditor.mwreference module in the
onResourceLoaderRegisterModules hook. Maybe someone can point to
a better way?
Bug: T86782
Change-Id: Ibf333a502d64d2ed6e029221458b7c606554e414
