New changes:
297255a28 Localisation updates from https://translatewiki.net.
55f32beb8 Follow-up I26486e0e79: Fix when first range returns null annotation set
94ed5bb4e Don't attempt to scroll tall selections into view
Bug: T305645
Bug: T305862
Change-Id: I73dcad06e3a3b384225c16ba1b929cbe9cdaccae
New changes:
01cf60f3e Fix position of close button on wide tablet
f859601b4 Match padding of mobile context header & footer
f8675af1b getAnnotationsFromRange: Distinguish between "no annotations" and "no content"
176c2b334 Always assert diff sidebar descriptions
Bug: T304233
Bug: T305645
Change-Id: Icb32737e9222a537ed1fa1bdbeebf8c2a5d15363
The goal is to have some tests fail if a new property is added to the
API result, but it's not stored in auto-save data.
Bug: T305225
Change-Id: I9ac328c71c616a8f33e1cfb39431cd9a665adafc
New changes:
7f80d75ce Context: Move copy/delete buttons to MobileActionsContextItem
2be9610ec Move close button from contextItem to context
Bug: T304233
Change-Id: I49ce23f31afd003cf2dd6a525aeabde6332eb9a1
New changes:
7646c56c9 Localisation updates from https://translatewiki.net.
26988b80a Fix for showing "invisible icon" when root node is hidden
d9bc2297c Emit ve.ce.Surface 'position' in some more places
d5dfd326e Revert "Fix for showing "invisible icon" when root node is hidden"
Bug: T303795
Bug: T305110
Change-Id: I748d8b6c4702efd44b6b3da458d5c717076eb13a
New changes:
35b3a2ef5 Localisation updates from https://translatewiki.net.
02adce4a5 tests: Add some tests for ve.init.Target
cbe0a1011 Always show label-only button for MergeCellsContextItem button
Bug: T304233
Change-Id: Ic7b0325e856199ceaab06a34daf51c173b13d082
The refactor in I0eaeb987 broke this feature by moving
the call that modifies the response object to after it
is passed to the target.
Change-Id: Id98c1ccabde478540af34ed3356f319ae336590a
New changes:
91a762803 ve.dm.ModelRegistry: Disallow unknown types on tag and tag+func matches
8575e8ad8 PreviewElement: Document event
d24f96874 Allow unknown types for ve.dm.AlienMetaItem
106354b38 Follow-up I534ce003d: Fix height restriction calculation of desktop context
Local changes:
* Allow unknown types for ve.dm.MWExternalLinkAnnotation, it is meant
to match all <a> tags and handles unknown types in toDataElement()
Depends-On: I785be75f389136769084a8e14832a09e3a519fc1
Bug: T303298
Bug: T304847
Change-Id: I75d1e82a43f5f96a9093cd334c524527918efaa5
This was added to make the context a bit more consistent
with the regular link inspector, however with I2fec865570
we making these delete buttons strictly mobile only.
Change-Id: I52936919e332aee851ccd11a862367c97eb41b39
This is needed because the $params array is then passed on to
ApiEditPage, so if the hook implementer wants to alter the data used
with the edit, it needs to be able to modify the $params.
See I494d72a42d9103c28c4d44077cfe0f1269fc7b00 for an example where
GrowthExperiments would like to modify the 'tags' parameter for an
edit.
Depends-On: Idd052281898f99e4f13f241d5633294b59b29329
Bug: T304747
Change-Id: Ia4842a1593028f5fa145de167ccf9b72efa81351
This code is optimized for the 2 most relevant use cases:
1. When Cirrus finds 10 results, we still want to search for the top 1
prefix match. This is critical for templates like !!. This will appear
at the top. unshiftPages() makes sure the limit of 10 is enforced.
2. When Cirrus fails to find anything, we search for 10 prefix matches
and use these instead.
The code can also handle everything in between. For example, when
Cirrus finds 5 results, we search for 5 more prefix matches and add
them when Cirrus missed them. The total number in the end might be 5 to
10 depending on the number of duplicates. This is intentional. Why?
Let's say we always search for 10 prefix matches and add them to the
top when Cirrus missed them. This might remove _all_ Cirrus results.
This shouldn't happen. This extra code is only to fill in glaring gaps,
not to replace Cirrus. 5 results are fine.
Bug: T303524
Change-Id: Ib0471795124c0c7001b6901edaf8e7b380e426b1
There is already some kind of "fallback" to prefixsearch. We always
check if the top-1 prefixsearch result is part of the result set.
Because of this the current worst-case scenario is that only this
1 result is shown.
This patch implements a full fallback to prefixsearch. But only when
there are 0 CirrusSearch results. Further tuning might be done in
later patches.
Bug: T304925
Change-Id: I1927eedad60c9b9ac2021481a85376c08ccf6fdb
