wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 00:00:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Full fallback to prefixsearch when Cirrus returns nothing"

Browse source
This commit is contained in:
jenkins-bot 2022-04-01 13:24:51 +00:00 committed by Gerrit Code Review
parent 73d6973ff1 6bbf7d1907
commit 5fef22001d
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/ve-mw/ui/widgets/ve.ui.MWTemplateTitleInputWidget.js
View file

@ -274,19 +274,28 @@ ve.ui.MWTemplateTitleInputWidget.prototype.addExactMatch = function ( response )
return response;
}
var numberOfCirrusSearchResults = Object.keys( response.query.pages ).length;
var fullFallbackNeeded = !numberOfCirrusSearchResults;
return this.getApi().get( {
action: 'query',
// Can't use a direct lookup by title because we need this to be case-insensitive
generator: 'prefixsearch',
gpssearch: query,
gpsnamespace: this.namespace,
gpslimit: 1
// Fall back to prefixsearch when CirrusSearch failed, otherwise just the top-1 prefix match
gpslimit: fullFallbackNeeded ? this.limit : 1
} ).then( function ( prefixMatches ) {
// action=query returns page objects in `{ query: { pages: [] } }`, not keyed by page id
if ( prefixMatches.query ) {
if ( fullFallbackNeeded ) {
response.query.pages = prefixMatches.query.pages;
return response;
}
for ( var index in prefixMatches.query.pages ) {
var prefixMatch = prefixMatches.query.pages[ index ];
if ( !containsPageId( response.query.pages, prefixMatch.pageid ) ) {
// Move the top-1 prefix match to the top, releant for e.g. {{!!}}
unshiftPages( response.query.pages, prefixMatch );
}
}