New changes:
72bd71dbc Localisation updates from https://translatewiki.net.
b7f38d993 Re-apply "Fix for showing "invisible icon" when root node is hidden""
Local changes:
* Ensure templates are attached to DOM before rendering invisible
icon in converter hack.
Bug: T305110
Change-Id: I0e4c02619b2a06b9932f214ae482093fdb0cb22c
This option is not only buggy (it just doesn't work when the namespace
option is set the same time), it is not useful in this context even
if it would work. It doesn't make much sense to suggest non-existing
templates in the context of the template dialog. If adding a
non-existing template really is what the user wants, they can still do
this by simply typing the name of the template and submitting the form.
We never need this to show up in the suggester below the input field.
The main advantage of this change is that is saves 1 useless API
request that's potentially done every time a key is pressed.
Bug: T303524
Change-Id: I903340a06d6e6490bb58f628f41903aa044ccb21
This separates the two steps:
1. See if items in the list of `origPages` miss their `.index`
property, and add it if possible.
2. Later code doesn't need to care about redirects any more.
Note that `origPages` is not used for anything else. And even if,
it's not wrong to have the index for each search result on both the
redirect and the redirect target.
Change-Id: I12135f0430c944b4e33c49ece7779d7c3bb6c211
This is not a pageid, but a simple numeric index in an array. Luckily
it doesn't make a practical difference for this particluar way of
iterating something.
Change-Id: I7ec9ace00d4fba7adde17670058a0365b30f5617
Such comments don't add any new information. The method signature
alone already tells the full story.
We did this already to a lot of the template related code we touched.
This is just a bit of cleanup to make it consistent.
Change-Id: I932b620910924a16dc0d31d6c8a3ab11818316fe
The numeric part of these ids is never used on it's own. There is no
need to expose it.
Note we renamed the method not long ago in I6eeab8b to reflect better
what it does. This is the next step. We just forgot it back then.
Change-Id: I5da82855e99ea3a42a5d91379c6974ae9c154518
The result is guaranteed to be in formatversion=2, where the list of
pages is an array, not an object.
Change-Id: Ic73a68c3e249a70108a6a19a89f4ff6c475794ed
New changes:
297255a28 Localisation updates from https://translatewiki.net.
55f32beb8 Follow-up I26486e0e79: Fix when first range returns null annotation set
94ed5bb4e Don't attempt to scroll tall selections into view
Bug: T305645
Bug: T305862
Change-Id: I73dcad06e3a3b384225c16ba1b929cbe9cdaccae
New changes:
01cf60f3e Fix position of close button on wide tablet
f859601b4 Match padding of mobile context header & footer
f8675af1b getAnnotationsFromRange: Distinguish between "no annotations" and "no content"
176c2b334 Always assert diff sidebar descriptions
Bug: T304233
Bug: T305645
Change-Id: Icb32737e9222a537ed1fa1bdbeebf8c2a5d15363
The goal is to have some tests fail if a new property is added to the
API result, but it's not stored in auto-save data.
Bug: T305225
Change-Id: I9ac328c71c616a8f33e1cfb39431cd9a665adafc
New changes:
7f80d75ce Context: Move copy/delete buttons to MobileActionsContextItem
2be9610ec Move close button from contextItem to context
Bug: T304233
Change-Id: I49ce23f31afd003cf2dd6a525aeabde6332eb9a1
New changes:
7646c56c9 Localisation updates from https://translatewiki.net.
26988b80a Fix for showing "invisible icon" when root node is hidden
d9bc2297c Emit ve.ce.Surface 'position' in some more places
d5dfd326e Revert "Fix for showing "invisible icon" when root node is hidden"
Bug: T303795
Bug: T305110
Change-Id: I748d8b6c4702efd44b6b3da458d5c717076eb13a
New changes:
35b3a2ef5 Localisation updates from https://translatewiki.net.
02adce4a5 tests: Add some tests for ve.init.Target
cbe0a1011 Always show label-only button for MergeCellsContextItem button
Bug: T304233
Change-Id: Ic7b0325e856199ceaab06a34daf51c173b13d082