Commit graph

14651 commits

Author SHA1 Message Date
Bartosz Dziewoński 55108aaf1b Apply edit surface jQuery.makeCollapsible overrides to visual diffs too
Bug: T194725
Change-Id: I8667dae42e652ef08910c861d22606f482d8f9cd
2018-07-05 16:09:13 +00:00
Bartosz Dziewoński 6db1fd41ef Move some styles from mw.ArticleTarget to mw.Target
They look like they should also apply to Flow, ContentTranslation, etc.

And apparently CollabTarget was already loading them separately.

Change-Id: I5c502f8e060968ecee67567747f29eb630cda718
2018-07-05 18:01:10 +02:00
jenkins-bot 67e4799d39 Merge "DesktopArticleTarget.init: Fix URI comparison if it contains a port number" 2018-07-03 23:16:33 +00:00
jenkins-bot 13e4f0bbd0 Merge "DesktopArticleTarget: consolidate edit tab behavior" 2018-07-03 22:27:42 +00:00
Bartosz Dziewoński 9ef039dd4b DesktopArticleTarget.init: Fix URI comparison if it contains a port number
If the wiki runs on a host that contains a port number, section edit
links would always reload the page, and the "Add section" tab would
not work.

As it happens, my local testing wiki runs on localhost:3080.

It is an unfortunate naming mishap:
* mw.Uri#host is equivalent to location.hostname
* mw.Uri#getHostPort is equivalent to location.host

In this case, we have to compare the port too, otherwise a setup (my
setup ;) ) where one starts up another wiki on localhost:3081 to test
cross-wiki features would fail.

Change-Id: Ib7de4ba3c3a84888f24186af03bd9dcced131051
2018-07-04 00:11:48 +02:00
Translation updater bot 0d35cd8759 Localisation updates from https://translatewiki.net.
Change-Id: I0c4370afdbe00dfee217ea58e26c6092dad11eb8
2018-07-03 22:16:54 +02:00
jenkins-bot e2132eeff5 Merge "ve.ui.MWTemplatePlaceholderPage: Avoid Firefox rendering issue" 2018-07-03 18:57:11 +00:00
Bartosz Dziewoński 5827b17ad0 ve.ui.MWTemplatePlaceholderPage: Avoid Firefox rendering issue
There is something about ActionFieldLayouts with `align: 'left'` (the
default) and no label that causes Firefox to render them differently
than we expect. I am not sure if the bug is in OOUI or Firefox, but it
is easily avoided by just using `align: 'top'` instead (it looks the
same, since there is no label, and it avoids the issue).

Bug: T198274
Change-Id: Ic6077e576b504e7a0cd761c8bac24d4079ae6702
2018-07-03 20:13:28 +02:00
jenkins-bot 43d5e767e8 Merge "De-duplicate and fix updating of file link in media dialog" 2018-07-03 17:27:37 +00:00
Ed Sanders 6bf9210abe De-duplicate and fix updating of file link in media dialog
Bug: T198565
Change-Id: I7d06d3316b317fb85edb9461080f5f2e5cd439fe
2018-07-03 17:59:43 +01:00
jenkins-bot 4a7e160d4f Merge "Fix window target when opening feedbackUrl" 2018-07-03 16:55:56 +00:00
Ed Sanders 452545fa2e Fix window target when opening feedbackUrl
'_new' should be '_blank', but '_blank' is also the
default, so just remove the argument.

Change-Id: I8f922b835b2bc14e5641e0ab29bf002b32301490
2018-07-03 17:36:35 +01:00
Ed Sanders f1b506bb6a Fix toolbar group names
Bug: T198583
Change-Id: I7b2e15dc65655bf048a02d9902a8f6e1c491edef
2018-07-03 14:23:21 +01:00
David Lynch 92c4e231f2 DesktopArticleTarget: consolidate edit tab behavior
What happens when an edit tab is clicked is spread across handlers in
DesktopArticleTarget and DesktopArticleTarget.init. Consolidating the logic
into the handler in DesktopArticleTarget.init makes it easier to understand.

It could be moved further into DesktopArticleTarget, but the init handler has
to exist to activate the target in the first place.

This patches a hole where clicking "edit source" while in visual mode would
sometimes not switch to source mode, because it didn't think it was changing
the current section.

Also, fix a typo in the documentation.

Bug: T198272
Change-Id: I12d958b6af1b9fa9aca68b498eb2a1a2d76b5a82
2018-07-02 16:17:15 -05:00
jenkins-bot dd794ddd40 Merge "Replace wfMemcKey with $wgMemc->makeKey" 2018-07-02 15:06:57 +00:00
Jack Phoenix d9066c829c Replace wfMemcKey with $wgMemc->makeKey
Change-Id: I959edd0816917bc49deb40d6990517afdcbeae15
2018-07-02 14:43:06 +00:00
Translation updater bot 596579ec8e Localisation updates from https://translatewiki.net.
Change-Id: I503c8a7fa65485a9ad523520855f2dcaa2138391
2018-06-30 22:30:56 +02:00
Translation updater bot 6f2886823e Localisation updates from https://translatewiki.net.
Change-Id: I3fc6aaa516d4d988a2ce33f84bd665a52debe9d8
2018-06-29 22:28:10 +02:00
jenkins-bot 4c88fc7ef4 Merge "Pass page parameter for multipage file (PDF, DjVu) thumbnails" 2018-06-29 20:08:55 +00:00
jenkins-bot 611ef4ef1c Merge "Pass video thumbtime to thumbnail metadata request" 2018-06-29 20:07:42 +00:00
Ed Sanders 715d67b564 Pass page parameter for multipage file (PDF, DjVu) thumbnails
Bug: T182392
Change-Id: Ib3bc7b13f24493da27078631a41e9c08bcc6c0f4
2018-06-29 19:26:42 +00:00
Translation updater bot fd1ac29964 Localisation updates from https://translatewiki.net.
Change-Id: I93f6fd3175e80121b6cf430f3a2c064d7f593c12
2018-06-28 22:21:46 +02:00
Ed Sanders 5cdbc17899 Pass video thumbtime to thumbnail metadata request
Bug: T198150
Change-Id: Ic8895c359a92fcc60ac486e3daf86db02599d3ff
2018-06-28 15:52:50 +01:00
jenkins-bot 08b1d31d84 Merge "Update VE core submodule to master (49fd5e439)" 2018-06-28 11:08:10 +00:00
jenkins-bot 17041d3f07 Merge "Don't call Resizable constructor conditionally" 2018-06-27 21:49:31 +00:00
Translation updater bot eb3c3e7484 Localisation updates from https://translatewiki.net.
Change-Id: If87d2bcfbb7339de504bd0e6919b7a0d8a9a77a9
2018-06-27 22:20:50 +02:00
James D. Forrester 22979cdc8b Update VE core submodule to master (49fd5e439)
New changes:
49fd5e439 Update OOUI to v0.27.4

Change-Id: Ib70a0f2d41d9d22ed9232ba6b6dbeb604fc5eb12
2018-06-27 11:31:04 -07:00
David Lynch 56a3aa9f01 Update link contexts with label info from core
Bug: T124305
Depends-On: Iad48fb559f3dae16cc0013791b79ec71308a1f9f
Change-Id: I341a15199bddb45e2cd8391b9b00c86e1c3a193e
2018-06-26 21:16:53 +00:00
Bartosz Dziewoński e73d6f3f67 Update VE core submodule to master (fab33197b)
New changes:
664b9017b ve.dm.Document: Handle no valid offsets in #getNearestCursorOffset
879e319d4 Don't break before/after multiline insert in source mode
386344d19 LinkContextItem: add label information to the context

Bug: T124305
Bug: T197651
Bug: T198010
Change-Id: Ic0b16b7f85f91ce699eb90f8ee171fc69c9ddd53
2018-06-26 23:16:09 +02:00
Ed Sanders bb1d7271cd Pass content language in Accept-Language header to RESTBase
Bug: T198186
Change-Id: I2176f68f76fa462de0c1c2c47365de62fda4abe0
2018-06-26 16:42:35 +01:00
Ed Sanders 1b116394cf Correct documentation of $title Title object and add type hints
Change-Id: I8108161e2330d54e9e3f9969ead9352cc5810fb0
2018-06-26 16:35:46 +01:00
Translation updater bot 7a812e8fcb Localisation updates from https://translatewiki.net.
Change-Id: Id786a99a4da478dbeb514afd1b04779121c63bdc
2018-06-25 22:22:19 +02:00
jenkins-bot 4a41a1aa4c Merge "Update VE core submodule to master (c8d6dac8b)" 2018-06-25 19:07:07 +00:00
jenkins-bot d318f79a61 Merge "Show images/descriptions on import's title widget if possible" 2018-06-25 17:59:17 +00:00
jenkins-bot 13fb253532 Merge "mw.DesktopArticleTarget: remove action=edit when tearing down as single-tab" 2018-06-25 17:59:14 +00:00
James D. Forrester 8baf06a8b3 Update VE core submodule to master (c8d6dac8b)
New changes:
4418e04c5 Localisation updates from https://translatewiki.net.
12fd1e53e Add isResizable method to dynamically disable resizing
87047170d Use getter to retrieve change stores
58150e710 Use ve.dm.Change object for completeHistory
bc9a1a8af Fix appearance of source surface

Change-Id: I7654d9859741dfbfb0a053a72d0d00b34f1835d6
2018-06-25 10:47:02 -07:00
David Lynch 09a315ca69 mw.DesktopArticleTarget: remove action=edit when tearing down as single-tab
aeb4f2f2b7 added a #wpTextbox1 to the wikitext surface, which confused our
existing teardown check. This confusion only became apparent in single-tab
mode, when using the wikitext editor.

Bug: T197615
Change-Id: I98e64e7135aaf6f8fda441a91e6cbc4bac6cea39
2018-06-25 11:55:51 -05:00
jenkins-bot dfc78ad5df Merge "ve.ui.MWTemplateDialog: Prevent scrolling to top after removing a parameter" 2018-06-25 16:53:09 +00:00
jenkins-bot 1a0ea50bd6 Merge "If VE was opened on action=edit URL, redirect to view URL when closing" 2018-06-25 16:50:25 +00:00
jenkins-bot 25b50ab8aa Merge "Give up on realistic styling of mw-collapsible" 2018-06-25 15:37:59 +00:00
Translation updater bot 71252a3faa Localisation updates from https://translatewiki.net.
Change-Id: Iaedae2be454b0ab7a8dd1ad06e48114b31926a26
2018-06-24 22:26:13 +02:00
Ed Sanders ac7ed91731 Show images/descriptions on import's title widget if possible
Change-Id: Ibeb32ae3fafcabb3c5585b363496e0accab82460
2018-06-24 19:22:34 +01:00
Ed Sanders ac88166da1 Give up on realistic styling of mw-collapsible
Using display:inline causes the <p> to be destroyed
when empty.

Bug: T197987
Change-Id: Icfcb2ddc91e6793221608fac9f2995c6afeb4313
2018-06-23 14:17:21 +01:00
jenkins-bot 5d9f90ea46 Merge "Follow-up I213bd946f: Correct URL of Parsoid HTML profile" 2018-06-22 17:49:17 +00:00
C. Scott Ananian 83918e735a Follow-up I213bd946f: Correct URL of Parsoid HTML profile
The URL for the HTML profile used by Parsoid changed after 1.2.x, but
it was never updated in VE.

Change-Id: Id4ab8567dc907b71e790a04ab10044c1e081c8ce
2018-06-22 10:27:00 -07:00
jenkins-bot 7e72ef63e4 Merge "Update VE core submodule to master (52bd0592b)" 2018-06-22 07:29:20 +00:00
Ed Sanders 47e6e3f6b1 Update VE core submodule to master (52bd0592b)
New changes:
c5df99d3a Remove remaining assert.expect's
593b09992 Localisation updates from https://translatewiki.net.
14a29056c Follow-up 593b099: Add 'lfn' language to build to unbreak the repo
faba29bde Fix cursor position when adjacent to a nail
9854cc88c Sanitize message body in standalone using DOMPurify
52bd0592b ve.dm.Change: Store DOM node arrays as single strings

Local changes:
Add sanitize module

Bug: T197723
Bug: T197894
Change-Id: I572f5bcc80175cc50ef176efb961c9b10b38c7f0
2018-06-22 09:12:35 +02:00
Bartosz Dziewoński 37e349913e If VE was opened on action=edit URL, redirect to view URL when closing
We already do it after save, but not if the editor is closed without
saving.

This behavior is a bit awkward for non-existent pages (redlinks),
since MediaWiki normally doesn't display them in view mode (all links
point to action=edit). But this seems less weird than not allowing the
editor to be closed.

Bug: T122388
Bug: T168338
Change-Id: Id9ee41356f011dfbfa6e8744b8d9076f8eacaf39
2018-06-22 01:10:11 +02:00
jenkins-bot fbb83cc391 Merge "Update VE to request Parsoid HTML v1.7.0" 2018-06-21 22:31:25 +00:00
Translation updater bot e9f4ebde0f Localisation updates from https://translatewiki.net.
Change-Id: Id8a060af11c5ea1f004c2b83155cb49481ed5c6c
2018-06-21 22:42:50 +02:00