Overriding ve.ce.BranchNode#onSplice seems pretty scary, some bug
could cause two captions to be inserted and it wouldn't even be
visible in the editor.
Instead, allow normal splice handling to happen when the caption is
added/removed, and only override the position where it is inserted
(to account for the image node this.$a).
The caption node is already removed from DM/CE if the image type is
changed to one that doesn't have captions, and even if that failed it
is also hidden in CSS, so we don't need to handle this.
Change-Id: I54f52b288118d692708311512dd674cc85d5d9e3
New changes:
01609bfaa Follow-up Icf2d948bc9: Only reset lastStoredChange in storeDocState if using latest HTML
Change-Id: I9d70f9827cb84d01f7e172e444fa33cf7921ddfd
5f6664e2 in VE core changed the specificity for some of the rules this
expected to override.
Bug: T189267
Change-Id: I510e151cc431c321d1d45fde9030d56f059d84ab
Various checks didn't think a rel attribute could contain multiple values.
Mostly they don't, but to play it safe let's adjust the checks.
Change-Id: I29823b7c8c65ef6b2ff41ce9a801840000972e9c
Depends-On: I33a456351ab025d0c81cfb1a1577d5a2ae9df51a
New changes:
e10e2c0b6 Remove gecko-specific paste tests, add copy test
c555b6567 Complete test coverage of autosave methods
fc02e085e Localisation updates from https://translatewiki.net.
08a55658e CE Surface tests: Add missing </tbody> tags
ff5a766bb CE Surface tests: Avoid execCommand on tests failing in Firefox
46160f796 Run and make voting the Firefox tests in CI
Bug: T182626
Bug: T189201
Change-Id: Iee50ddf350e4a3312024b280cdeded08d325ea06
We have a Jenkins job to take screenshots of VisualEditor and upload the
result to commons.wikimedia.org. That roughly does:
npm install
node_modules/.bin/grunt screenshots-all
bundle install
bundle exec upload
However on CI, the Docker container only accepts 'npm run-script XXX' or
'bundle exec rake YYY'.
Add a npm script 'screenshots-all' invoking 'grunt screenshots-all'.
Add a rake task 'commons_upload'. I have added a basic check to make
sure environment variables are properly set before invoking the upload
script.
Thus on CI the usage will become:
npm install
npm run-script screenshots-all
bundle install
bundle exec rake commons_upload
Which match the CI convention.
Bug: T189122
Change-Id: I221ed8d6178dd036eac287f0f811834a6d4ffd22
New changes:
a687da2cc Add visual diff messages for changed dir: and style: attributes
3cf650c5a Fix node type check
b239c9313 Use equalDomElement in DiffElement & TextState tests
cd2dfc205 Don't descend into dataElement-generated nodes in renderHtmlAttributeList
61a1c351e Move isInternal from ve.dm.Node to ve.Node
c535f74fe Stop using FlatLinearData directly
5ec94b067 build: Use “OOUI” as unified name for library upgrade script
8bbd7d356 Update OOUI to v0.25.3
73a81c239 Add unit tests for autosave methods in DM surface
Bug: T160588
Bug: T182360
Bug: T189030
Bug: T189104
Bug: T189120
Change-Id: I581c206312ff5bcc6b7cb41522f1f7ba307bbd1c
New changes:
23666aff0 color-picker: Remove fallback PNGs we don't use
Local changes:
Pull through color picker lib from core
Change-Id: Ib213f801a90e400fae2838e21bbdb011dc61311a
New changes:
7551f6c66 [BREAKING CHANGE] Rename class ve.dm.IndexValueStore->ve.dm.HashValueStore
Local changes:
Follow-through rename of IndexValueStore->HashValueStore
Bug: T188900
Change-Id: If60d0c637fe92f0e7afe916c064fafb17980d063
Parsoid now handles empty headings for us in
scrub_wikitext mode (which we use).
This reverts commit 884f301aa0.
Bug: T187913
Change-Id: I8690bbced64be76622929f78f9c9e0d8f85d4be8
This lets copy-paste between documents retain the numbered status rather than
falling back on pasting "<a>[3]</a>".
Update the part of LinkCache which selects on mw:ExtLink, so it will handle
possible multiple values in the link rel.
Bug: T188429
Change-Id: Ia5e4c9fa45e94da9cbfcd2a42d017d0fda1c511f
Always store immediately if fromEditedState is true. Also
now that we only store if there is state to recover, remove
the check for transactions before deciding to show the notification.
Change-Id: I5357a9098b91e303f5c71881ea03a080d2969fff
