Commit graph

160 commits

Author SHA1 Message Date
Antoine Musso 4a97e9585f [BrowserTest] Fix i18n files lookup
The visual_editor_page used relative paths expecting the current
directory to be modules/ve-mw/tests/browser. Use absolute paths instead.

Change-Id: I8b1c4eddc2085ee80380f288bceb14c6feee0a60
2016-04-04 11:52:36 +02:00
Željko Filipin 63eb2a2f46 [BrowserTest] Increase the time Selenium waits for VisualEditor to load
I have noticed that Jenkins job that runs daily fails sometimes because
looking up the element failed after 5 seconds. The time is increased
from 5 to 10 seconds.

Bug: T94150
Change-Id: Ib23f4ac72aa6c734f297e8f9fb5ad4645ac8891e
2016-03-14 13:00:17 +01:00
Željko Filipin 8e0e40d5cc [BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError
Sauce Labs browsers raise
Selenium::WebDriver::Error::StaleElementReferenceError
if a test tries to use an element but VisualEditor is not loaded.

Bug: T128731
Change-Id: Icb01b4dee256a0270d722492d11dabf0cfc4f8c4
2016-03-03 14:58:14 +00:00
Željko Filipin 301b152ec8 [BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.

Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
2016-03-02 13:50:44 +01:00
Željko Filipin 60a08f925c [BrowserTest] Fix ve.init is undefined error messages in Selenium tests
All scenarios that are passing are enabled to run in Jenkins.
(The commit increases the number of passing scenarios from 2 to 18.)

Bug: T126966
Change-Id: I9789ca42717133120197c4625bb8dad4ea496aa8
2016-02-18 15:42:05 +01:00
Dan Duvall 96677fb74a [BrowserTest] Experimenting with JS object references
References to JS objects for VE elements can determined by referencing
the VE and OOUI API documentation[1][2] and interrogating the objects in
a browser console. Errors should be closer to what developers understand
but testers should pair with developers to better understand how to
define new page elements and where to go for documentation/help.

The VE entrypoint for the singleton reference is `ve.init.target` (if
there's only one instance of VE target; there may be multiple in some
cases like Flow).

[1] https://doc.wikimedia.org/VisualEditor/master/
[2] https://doc.wikimedia.org/oojs-ui/master/js/

Change-Id: I1f642807cdd3059d8e7e885a8b239ac01b9b3024
2016-01-06 17:07:35 -08:00
James D. Forrester 09800aa249 Replace 'source' icon with OOUI's 'wikiText' one
Change-Id: Id66d436b9140604ace7ebfbec1f80dc8f3830a20
2015-11-04 06:15:29 -08:00
Vikas S Yaligar 0971054f40 [BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set
Bug: T111525
Bug: T90577

Change-Id: I421c4c0ce7bcf7be757d31481940ada58e4c9f20
2015-11-02 12:18:07 +00:00
Ed Sanders 5bde3be8a6 Browser tests: Fix selectors for strikethrough and underline
Change-Id: I94010005369b225494f5e603d71d1f57941d7db0
2015-10-15 15:49:01 +01:00
Ed Sanders 780d42b295 Browser tests: Fix table test
Change-Id: Ib2751cd58dd134f61f94e0a0e8c9c3540a7f26ea
2015-10-14 22:27:42 +01:00
Ed Sanders 2948d0b324 Browser tests: Update link inspector tests
Change-Id: I5e902b4ab3215450a4374fb7327159d3edfc5ef2
2015-10-14 21:29:14 +01:00
Vikas S Yaligar df2c17bfd2 [BrowserTest] Load i18n messages from MediaWiki to browser tests
* translate method can be called to translate a particular string to a
specific language.

Bug: T90577
Change-Id: I7852ee0b0009e70bd9decef0dd317055d91a06a6
2015-10-09 09:49:37 +00:00
Dan Duvall 668a149103 QA: Upgrading to mw-selenium 1.x
Upgraded mw-selenium to 1.x, following the docs at
https://doc.wikimedia.org/rubygems/mediawiki-selenium/file.UPGRADE.html

Created an `environments.yml` file, converted page object definitions to
use relative paths, and refactored references to the global `ENV` using
methods of `MediawikiSelenium::Environment`.

Upgraded commons_upload as well to resolve a dependency conflict on
mediawiki_api.

Paired with: Rummana Yasmeen <ryasmeen@wikimedia.org>

Bug: T99661
Change-Id: I2a05cd816ea43afb48157e5dbe1ae42c6c124f6b
2015-08-20 09:52:16 -07:00
Ed Sanders d2c15e9eb5 Bring in code from MobileFrontend
* Use local edit source tool, and emit event to MF
* Bring in toolbar styles, bonus: remove old desktop style hacks

Bug: T96186
Change-Id: I89351e409aa4e9d626edd7151ae05bdcd58f1cee
2015-07-30 17:13:00 +00:00
Ed Sanders fecdc29a38 Replace ve-init-mw-desktopArticleTarget-* with ve-init-mw-target-*
Except in cases where it is only applied to desktop articles.

Change-Id: I40a9dabcd8454138f94affde809afee9c93732a4
2015-07-29 18:26:36 +01:00
Ed Sanders b5de6fa575 [BREAKING CHANGE] Rename (View|Mobile)PageTarget to (Desktop|Mobile)ArticleTarget
Change-Id: I6a8fa76dc4d70cc04722e30e3fea6a6112d56b40
2015-07-29 18:26:36 +01:00
Vikas S Yaligar d42e10cacb [BrowserTest] Added screenshots scenarios for links and categories
Also minor cleanup of rspec old "should" syntax, changed all occurences to
"expect" syntax.

Change-Id: I0c2dfc18d06812ed9da2f6c0056c95b7755e5afd
2015-07-18 15:39:28 +00:00
Vikas S Yaligar 8b7b20b934 [BrowserTest] Add true internationalized content support to language screenshot
* All translations will be in tests/browser/i18n folder
* Hebrew json’s are added, which needs to be translated.

Paired with Zeljko.

Bug: T105466
Change-Id: I4ae516758fb01a41f0dcf53c7cf3e609c7601cf3
2015-07-16 14:47:56 -05:00
Ed Sanders 52cb066dc7 Use new MediaWiki core TitleInputWidget
All link input/title input functionality has been moved to core, so
we can replace the link widget, redirect widget and template search
widget with it.

Depends on Ib463e60cad96 in MediaWiki core.

Change-Id: I452f3b86ead403307072cf904f0553c9771f4300
2015-06-24 17:06:00 -07:00
ryasmeen@wikimedia.org cb1612b60a [BrowserTest] Fixing the test for general markup
Identifier mismatch.Updated now.

Change-Id: Ibf7b6aea144e2435d2a23e4768481a11cb8a6619
2015-05-25 14:43:56 +02:00
ryasmeen@wikimedia.org 058da228dd [BrowserTest] Fixing broken test for Page Options test
The test was broken as some identifiers were wrong. Updated it.

Change-Id: I03541e4ae0ed7e4c121b801a036e49bebe4d5909
2015-05-24 21:30:53 +02:00
ryasmeen@wikimedia.org 0da5989eb7 [BrowserTest] Fixing the broken test for bullets
The test was broken for using wrong identifier in the test. Updated them correctly.

Change-Id: I46a9c4ebaf1b44f0db24f2b64dcd863697011203
2015-05-24 14:30:59 +00:00
jenkins-bot 2e24426fdf Merge "[BrowserTest] Fix the lists and indentation screenshot scenario" 2015-05-15 13:35:47 +00:00
jenkins-bot f7b6fea4a2 Merge "[BrowserTest] Fix the special character button screenshot" 2015-05-15 13:35:22 +00:00
Amir E. Aharoni 462315f16f [BrowserTest] Fix the lists and indentation screenshot scenario
* The element's class name changed.
* Zooming is removed - it was breaking the test and
  it's not needed anyway.
* Fix another element with the same class.

Change-Id: I46a867619ed49936c3868f6b1b15e773bdb6f6b1
2015-05-15 15:02:34 +03:00
Amir E. Aharoni e471860536 [BrowserTest] Fix the special character button screenshot
The element moved out of the Insert menu to the toolbar.

Change-Id: I7c563af858a37f360bd2e4b4ba2e8a7098bc94e6
2015-05-15 13:56:47 +03:00
Amir E. Aharoni f30f90ace0 [BrowserTest] Fix the text formatting screeshot scenario
The element's class name changed.

Change-Id: I7070c1e06f6639783097b953cc384b12eff2a23b
2015-05-15 13:49:52 +03:00
Bartosz Dziewoński e459c14442 ve.init.mw.ViewPageTarget: Simplify toolbar save button and inner toolbar code
All this is no longer needed since 121216184718e7ebe22d6ecc8f5af5fe4e202465 in
OOjs UI and started causing issues after bb9c9c4f6a2fca6aed0e671e904e469d57da5f34.

Bug: T98795
Change-Id: I6493d6b52b313aac521aee2b0cff1571ea63bbe5
2015-05-12 13:50:40 +02:00
Amir E. Aharoni 8cb387a269 [BrowserTest] Redefine the Apply changes element for language screenshot
Redefine the element to include the full button
and remove the padding, which is now not needed.

Change-Id: I1ac244bc97b38c9d8b47ddd778a653783a748a49
2015-03-27 14:16:48 +03:00
Amir E. Aharoni fb4212232d [BrowserTest] Show the full Formatting pull-down in the screenshot
The scenario for the Formatting pull-down screenshot didn't click
the "More" element in the bottom. This is now added.
The "More" element itself is redefined to be generic and work with
all pull-down menus - there is supposed to be only
one active menu at a time.

Change-Id: I27122f3192b220919311993ecd9a10d85ef5828d
2015-03-27 00:31:11 +02:00
Amir E. Aharoni f7c2edf886 [BrowserTest] Fix the lists and indentation screenshot
Capture the whole button and menu.

Change-Id: I035109916a90efbd12e5f3ddb58b98a53b8e57d3
2015-03-26 15:57:42 +02:00
Amir E. Aharoni b62be2355e [BrowserTest] Capture the whole Insert button in the screenshot
Change-Id: I7551914d57adace5ceb385f16cc93e146e4774a7
2015-03-26 15:13:47 +02:00
Amir E. Aharoni 1d1ffac74e [BrowserTest] Capture the whole formatting button in the screenshot
This makes the screenshot nicer and more complete.

Change-Id: I0dd9efd2978ff5468ab6101b11b7e6fdd3b0da30
2015-03-24 12:34:42 +02:00
Amir E. Aharoni 47af0b6449 [BrowserTest] Capture the whole dropdown indicator in the screenshot
The Headings menu screenshot started from the arrow-down element:
https://commons.wikimedia.org/w/index.php?title=File:VisualEditor_Toolbar_Headings-en.png&oldid=154425461

Now it captures the whole menu so it will look more complete

Change-Id: Iff47eaa2c3fe09264501ae82f6ee1bf7044a3556
2015-03-24 10:18:33 +02:00
Amir E. Aharoni 065d26e363 [BrowserTest] Add a screenshot for the Page settings menu item
Change-Id: I0ec601dc9559521746fe6e7fbad05f2df8f7497e
2015-03-23 12:38:45 +02:00
Amir E. Aharoni 73523eb5cf [BrowserTest] Add a screenshot for the category item
Change-Id: I3f607e1013dbdac6974b33b557d8a0fffe4d4590
2015-03-23 12:31:00 +02:00
Amir E. Aharoni 425b53a1e2 [BrowserTest] Revert the definition of the disabled_save_button element
The element is <div>, and using English text doesn't work
in other languages.

Follow up to
Icd79ec9b489557c3259ff7f2c11b2a899c767d0f

Change-Id: I3859c668921a5f3f6abafb2053fc471dbc8d80c7
2015-03-19 12:14:38 +00:00
Cmcmahon 698f36cdd4 [BrowserTest] update Cite test for new UI
* Access to Cite options changed
* Various target locators also changed

Paired with Rummana for these changes.

Change-Id: Ib7c3fbd1842879745d3d3128c66d90cc2b4f98cb
2015-03-17 15:54:14 -07:00
Cmcmahon d5f78cc6e4 [BrowserTest] Update locator for the Insert/More link changed
Change-Id: I2d4f68edb4bfad6813e9138afb77efadd75b2986
2015-03-11 17:29:46 +00:00
Cmcmahon ac5a38a03d [BrowserTest] fix edit test
This has been failing for a while, for several reasons, originally
because an updated version of Cucumber interpreted an "&"
character in an unexpected way.

Change-Id: Icd79ec9b489557c3259ff7f2c11b2a899c767d0f
2015-03-10 14:27:03 -07:00
Amir E. Aharoni 76b50c5b34 [BrowserTest] Update the Edit tab scenario
Make it clear that this scenario is supposed to test
and take screenshots of the "Edit source" and "Edit" tabs.

Change-Id: Ia480eacb2629553c378ecad52a9b0ed1336cd0f3
2015-02-26 12:59:34 +02:00
Amir E. Aharoni 5a70225a6b [BrowserTest] Fix VisualEditor_More_Settings scenario
The screenshot here is supposed to capture the menu that opens
when the hamburger icon is pressed.

The previous code captured the whole toolbar. This is now fixed.

A sample screenshot is here:
https://commons.wikimedia.org/wiki/File:VisualEditor_More_Settings-en.png

Change-Id: Id9501b8b1b8d41411c2f81bf4d4954a6bb41addc
2015-02-25 00:17:15 +00:00
Amir E. Aharoni acf67c7af2 [BrowserTest] Update the scenario for Cite screenshot
This screenshot only needs the "Cite" button,
and not the whole dropdown menu.

* The clicking step is removed.
* The element is reconfigured.

Change-Id: If4b863e51db611b96186ca6381d0426a335a9a17
2015-02-25 00:16:53 +00:00
Amir E. Aharoni a993be469b [BrowserTest] Remove extra empty line to make Rubocop pass
Change-Id: I0628cb5af5a716740150d78fce29c97f8c3cf85d
2015-02-20 13:37:56 +02:00
Vikas S Yaligar b960e4c999 [BrowserTest] Edited language screenshot steps which had iframe elements
Bug: T89370
Change-Id: If87d30fc23bfc867e6c62a3edefc8b2591c6ce48
2015-02-19 23:46:22 +05:30
Amir E. Aharoni 26763e7731 [BrowserTest] Fix ParenthesesAsGroupedExpression Rubocop failures
Change-Id: I7a6fbe0aefdd9abe3b0e7c42cc372487255f581b
2015-02-17 13:24:52 +02:00
Amir E. Aharoni 5a715d05ad [BrowserTest] Remove an empty line to make Rubocop pass
Change-Id: I110fef0f98ee7a2c5b74971b1e068bca0869e912
2015-02-17 10:20:12 +00:00
Cmcmahon df1013b7da [BrowserTest] Remove unused steps and locators
No more iframes

Change-Id: I3d6420f2a017a132d5695921daa5efb5117f3176
2015-02-12 11:53:58 -07:00
Cmcmahon 5d03721bb7 [BrowserTest] Update transclusion test for better locator
Also remove unused step and element

Change-Id: If99cde6a3ec1f0fb87628e5d8600a83034e11ee1
2015-02-12 11:27:40 -07:00
Cmcmahon 7d3e8a8ac5 [BrowserTest] Cite message no longer in iframe
Change-Id: I027bf87c0eb91edb7dc6218c3bc8f66a8c1aa69e
2015-02-12 10:54:02 -07:00