Commit graph

472 commits

Author SHA1 Message Date
Alex Monk 25933c09ec Strip RESTBase IDs from HTML generated when wikitext is pasted
Bug: T146054
Change-Id: I0013673a9e41ea191ea64f3208a06288efb2ecd3
2016-10-13 17:42:11 -07:00
Ed Sanders e1e02fa0d8 Update VE core submodule to master (90cbd62)
New changes:
abf8f41 Replace Array#concat with Array#push in converter
02aeb90 Localisation updates from https://translatewiki.net.
902ddda Use safer batchPush in converter
6368191 Use current surface's sequence registry in command help dialog
f7ce4b9 Optimize batchPush on small lists
fb43a0a ve.batchPush: add unit test to exercise long-array path
d6c7d24 Factor out RESTBase ID regular expression
ffcbf4b IndentationCommand: Use hasMatchingAncestor
d447023 Allow ommission of range from ve.dm.Document cloneFromRange
cfbc344 Don't strip empty paragraphs on paste if they are generated
01c918b Localisation updates from https://translatewiki.net.
1467947 Fix documentation of getMetadataIdRegExp

Local changes:
* Define RESTBase ID pattern in platform and fix slightly
* Bring in paste test from core, which requires platform switching.

Bug: T147607
Depends-On: Ifc1c15872a50f915e5ef8d561b3a363dc5f4d28f
Change-Id: I3eb21e115de92a67afa85b5675fcbca5b111adb6
2016-10-13 17:10:33 -07:00
Roan Kattouw bb45d984ca dm.MWInternalLinkAnnotation: Fix href normalization for special characters
<a href="Foo%3F"> would dirty-diff to <a href="Foo?"> and also render
as such, pointing to the wrong page.

We also called decodeURIComponent() on the href twice, which can't
have been good.

Move URI decoding and underscore normalization into
getTargetDataFromHref(), and add rawTitle for callers that need it.
Put rawTitle in the origTitle attribute, so that equivalence
comparisons (decode(origTitle) === title) work as intended.

Bug: T145978
Change-Id: I29331a4ab0f8f7ef059c109f6813fa670a2c7390
2016-09-22 09:10:41 -07:00
David Lynch 5bc54fd036 dm.MWInternalLinkAnnotation: Add some test cases
Change-Id: Ie338d5538959ea2cc296886b623e9dc2cd84fa8f
2016-09-21 09:57:45 -07:00
Željko Filipin f3f432e722 Disable failing Selenium tests
The tests are failing with RSpec::Expectations::ExpectationNotMetError
for 2-3 days in a row.

Bug: T145861
Change-Id: Ieec2a67857b90033cdd0ddf63025d2af9de504a5
2016-09-16 13:12:02 +02:00
Ed Sanders 5788340b49 Update VE core submodule to master (632f0a9)
New changes:
14b5fbc [BREAKING CHANGE] Move originalDomElements to the IV store and use MD5
c5d21f0 Provide methods to (de)serialize transactions

Local changes to move originalDomElements to IV store

Depends-On: I8a71c1a40ec35108d0a9a388da6f75632f8dc53c
Depends-On: I32c9b5f984fcf96e3354841ecfcd444149e8f159
Change-Id: I0fbb6324eede94558426178cbdad6b5daf0f8318
2016-08-24 18:14:14 +00:00
Željko Filipin 59d771e1ac Fix failing Selenium tests
There were a couple of pieces of language screenshots related Ruby code
left that was breaking Selenium tests.

Bug: T139613
Change-Id: I3d327b3cfd5f52e60fee07095eefdd8feecaba98
2016-08-24 16:47:14 +00:00
Željko Filipin 2fb5c18ced Upload language screenshot files using commons_upload Ruby gem
Use the latest version of commons_upload. Delete no longer needed files
from previous Ruby implementation.

Bug: T143563
Change-Id: I7c0ca64aeea54501c51eb56a950143d5af251cf7
2016-08-24 14:47:45 +00:00
Željko Filipin cbccba89a0 Remove Ruby implementation of language screenshots
It is now implemented in JavaScript/Node.js.

Bug: T132574
Change-Id: I299332ac4f849b951ba24564bd0282ca0e25afd2
2016-08-22 12:19:21 +02:00
Translation updater bot 7660980ab5 Localisation updates from https://translatewiki.net.
Change-Id: I75f5c71990c63b2a21c85ae9217476101b384cc5
2016-08-17 22:42:44 +02:00
Translation updater bot 567bc298c5 Localisation updates from https://translatewiki.net.
Change-Id: I77aca2aafa920a83a17af3e67e686f591c38c93a
2016-08-11 23:59:28 +02:00
James D. Forrester cad4066bc9 Gemfile: Bump mediawiki_api from 1.7.1 to 1.7.2
Bug: T129483
Change-Id: Ief831d41df9352a824f4bd7a2a030cc4681950a2
2016-08-08 10:54:21 -07:00
Translation updater bot 530d911dd5 Localisation updates from https://translatewiki.net.
Change-Id: I17eb6510ad35f8e60f892b10b4430432601b08ec
2016-08-02 22:47:12 +02:00
Translation updater bot 5a0b12bfb4 Localisation updates from https://translatewiki.net.
Change-Id: I92e686fa6e7018b506629fc857fb951f72e84447
2016-07-04 22:35:04 +02:00
Ed Sanders 40d606abdc Test removing all table classes
Bug: T138896
Depends-On: I2698428f0aa69e2dcec2680efed44d064bf6e542
Change-Id: I5df5d51fc5b69df6eae40ac29f6b82f446b26ae8
2016-06-30 17:41:42 +01:00
Ed Sanders aeca19c9ea Ensure text version of counter is written to external links when copying
Bug: T137503
Change-Id: Iae791253ea272847984fee5d0586dc302027f1bd
2016-06-27 22:17:58 +01:00
Translation updater bot b11b838f6e Localisation updates from https://translatewiki.net.
Change-Id: I7dbad46f1d3d13dff617e7bde9de1d416bc32882
2016-06-18 22:50:50 +02:00
Translation updater bot 953422a605 Localisation updates from https://translatewiki.net.
Change-Id: Ibc8094f70202a731d21f954e5bdab8214abc062d
2016-06-07 22:47:17 +02:00
Translation updater bot 3af1ddc490 Localisation updates from https://translatewiki.net.
Change-Id: I9c271d5ea6ae3f1a8a5c59bd462c71c1740e2a0f
2016-06-05 22:23:23 +02:00
Translation updater bot 9bdc38b864 Localisation updates from https://translatewiki.net.
Change-Id: Ib899d193506842d6a278f8e89e8672fa64bb9e73
2016-06-04 22:25:19 +02:00
Translation updater bot 3d994ac23e Localisation updates from https://translatewiki.net.
Change-Id: I6ab9559b62d7b80727795a612d3e98c4ff271ed6
2016-05-31 22:46:04 +02:00
Ed Sanders 20fa650a6b Un-blacklist Firefox versions 12,13,14
T52720 (link corruption in FF13/14) appears to be fixed.
T52780 (editor not loading in FF11/12) appears to be fixed.

FF11 has a new issue where templates are normalised even
when not touched (T136607)

Change-Id: I34358e3d90b8186e6b89c04c038ab79c908fc81b
2016-05-31 09:46:50 -07:00
Ed Sanders 7f0b56ff6c Use new action test runner
Bug: T90370
Change-Id: Ice209791f323c19743c192c5f864b2f8202b5ca9
Depends-On: I9b9275b55b367a1335bf4c4f8f52a68f6aeb9827
2016-05-13 14:21:49 +00:00
Translation updater bot 0153870e30 Localisation updates from https://translatewiki.net.
Change-Id: Ieda52ac7aec208e81de8a000d602afe705779145
2016-05-08 22:46:24 +02:00
Ed Sanders f30000ed4c Wikitext paste: Discard autoGenerated items after conversion
Otherwise the reference contents (stored in the reflist) is lost.

Bug: T134228
Depends-On: I718963e3c460a5bed38fba4152b03442bbe6169e
Change-Id: I20171eb97eb1b4757a2c8a25217adb4d680a9057
2016-05-04 10:58:01 -04:00
Translation updater bot e59a008a1e Localisation updates from https://translatewiki.net.
Change-Id: Ib1c3814addf800ff893d224b69812c436f9b27ab
2016-05-03 22:27:39 +02:00
jenkins-bot 6cf2af4f5c Merge "[BrowserTest] Migration of browsertests* Jenkins jobs to selenium* jobs" 2016-04-26 10:58:02 +00:00
Željko Filipin 58049b0c2c [BrowserTest] Migration of browsertests* Jenkins jobs to selenium* jobs
selenium* jobs are a new way of running Ruby based Selenium tests. The
jobs are triggered daily.

Bug: T128190
Change-Id: I11554b23a0e347736a67766f8c0b9879d5a6bed9
2016-04-26 12:40:45 +02:00
Ed Sanders 4479633159 Remove IE9 from blacklist, but don't add to whitelist (yet)
This puts IE9 on the greylist, meaning it will open but with
a warning.

Bug: T133094
Depends-On: I817b286e16b7923dd4dd456467466a0128805da1
Change-Id: I55fcbd1b7c4a82e11d61d3b93b4fdb7e992fba1d
2016-04-20 00:10:26 +00:00
Antoine Musso 4a97e9585f [BrowserTest] Fix i18n files lookup
The visual_editor_page used relative paths expecting the current
directory to be modules/ve-mw/tests/browser. Use absolute paths instead.

Change-Id: I8b1c4eddc2085ee80380f288bceb14c6feee0a60
2016-04-04 11:52:36 +02:00
Ed Sanders 18df6c3d47 MWWikitextStringTransferHandler: Add test for autoGenerated=true
Bug: T131153
Change-Id: I4922abe7978e1f04eb2276214c761622b44149c7
2016-03-29 19:57:45 +00:00
Ed Sanders b51b512555 MWWikitextStringTransferHandler: Factor out body tag from response
Change-Id: Ic694d1099538d2c60900d490667f2175f7f3afb3
2016-03-29 19:57:36 +00:00
Ed Sanders 818931dd9e MWWikitextStringTransferHandler: Remove data-parsoid from tests
It is ignored by VE, and isn't present in restbase responses.

Change-Id: Iaa2a6a66ba76ca0d63b4d6791ab8589191bce0f2
2016-03-29 19:57:26 +00:00
Translation updater bot f239e17a1e Localisation updates from https://translatewiki.net.
Change-Id: Ie585e9b5dd0251d35e90646f0ff79cc76cf66da8
2016-03-27 21:25:48 +02:00
Ed Sanders 6a159001ab Make data-mw/body.html attribute comparable
Change-Id: Ie23c5816a18f4da84c3d40c13a8c048710389f4b
2016-03-23 11:03:53 +00:00
James D. Forrester 7df0e7589e Update VE core submodule to master (eb97c1f)
New changes:
e661245 Localisation updates from https://translatewiki.net.
d0bac53 ElementLinearData: Add test for sanitize conversions
53988e4 ElementLinearData: Test blacklist unwrapping
8593098 ve.dm.Model: Remove unused, untested method 'hasAttributes'
6247dd2 ce.Surface: Add tests for table strip delete
bee1851 ce.Surface: Add larger table strip-delete test
42d39e7 ce.Surface: Test table navigation with enter/escape/tab/shift-tab
5d248f9 Remove TableCaptionCommand
a86ad04 PreviewElement: Check node is a GCN, and always return a boolean
b518839 Localisation updates from https://translatewiki.net.
8834e9c ce.Surface: Allow any key code in the key handler tests
6b3ea6a ce.Surface: Linear arrow tests for block node
026999d Localisation updates from https://translatewiki.net.
eb97c1f Localisation updates from https://translatewiki.net.

Change-Id: Ic5853116d97623316d9a6bbacda2ecab9e4b49d5
2016-03-22 15:12:36 +00:00
Translation updater bot eed6125ef2 Localisation updates from https://translatewiki.net.
Change-Id: I197104b10bb7aa062030a6cf22975283dbe42d28
2016-03-20 22:43:49 +01:00
Translation updater bot c37a2d11f7 Localisation updates from https://translatewiki.net.
Change-Id: Ia9b65fcfe6117d2075483bd130900c51b787eddc
2016-03-18 22:45:18 +01:00
Ed Sanders b7d25d92bc Detect the type of plain pasted links
Using the same logic we used for converting pasted URLs, detect
internal links by matching their base.

Currently link pasting is still disabled in the VE target, but
has been enabled elsewhere (Flow).

Change-Id: Iebd61abbe1fe82fd18d129e1dbc815ca75f44e87
2016-03-17 19:30:13 +00:00
Ed Sanders 5e6cbc187c Link pasting: Match RDFa-less links as external
Now that some targets support link pasting (Flow) we need to
make sure that pasted links match to an allowed type ('link/mwExternal')
instead of plain 'link' annotations which should never exist
in an MW document.

In a later commit we should auto-detect internal links.

Change-Id: I7faae834aa6e730c3cf93a691331a05fd0fe3d5c
2016-03-17 17:18:41 +00:00
Željko Filipin 63eb2a2f46 [BrowserTest] Increase the time Selenium waits for VisualEditor to load
I have noticed that Jenkins job that runs daily fails sometimes because
looking up the element failed after 5 seconds. The time is increased
from 5 to 10 seconds.

Bug: T94150
Change-Id: Ib23f4ac72aa6c734f297e8f9fb5ad4645ac8891e
2016-03-14 13:00:17 +01:00
Željko Filipin 43e9c8714f [BrowserTest] Disable failing language screenshot scenario
VisualEditor_Insert_Menu scenario fails with `Original image height is
too small! (ChunkyPNG::OutOfBounds)`.

Bug: T119482
Change-Id: I30c3a9757c5754a40921fce5225b73897eed865b
2016-03-10 15:06:56 +01:00
jenkins-bot 2e89f4f658 Merge "[BrowserTest] Disable failing language screenshots" 2016-03-09 17:32:57 +00:00
jenkins-bot 67fb8dd07f Merge "[BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError" 2016-03-09 17:31:27 +00:00
jenkins-bot 8d7baccd5f Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist" 2016-03-07 23:28:58 +00:00
James D. Forrester 79d1f92b42 DesktopArticleTarget: Add Edge and MSIE to whitelist
Bug: T128447
Change-Id: Ia7afe4ddd5abd4fd1de85ba2d2df1fefa6735d79
2016-03-07 14:58:10 -08:00
Željko Filipin dc3944726a [BrowserTest] Disable failing language screenshots
Bug: T119482
Change-Id: I165fcb2ee94430d29e287b80e13a48e05a021f77
2016-03-04 15:54:13 +01:00
Željko Filipin 8e0e40d5cc [BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError
Sauce Labs browsers raise
Selenium::WebDriver::Error::StaleElementReferenceError
if a test tries to use an element but VisualEditor is not loaded.

Bug: T128731
Change-Id: Icb01b4dee256a0270d722492d11dabf0cfc4f8c4
2016-03-03 14:58:14 +00:00
Željko Filipin 301b152ec8 [BrowserTest] Fix ve.init is undefined and ve.init.target is undefined error messages
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.

Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
2016-03-02 13:50:44 +01:00
Translation updater bot eceb548e6c Localisation updates from https://translatewiki.net.
Change-Id: Id1453f111870ee703f552fa407dab76b19d786f5
2016-03-01 22:04:45 +01:00