Commit graph

4584 commits

Author SHA1 Message Date
jenkins-bot 4e4684e7d0 Merge "Show redirect target inside target" 2016-03-17 22:54:39 +00:00
Translation updater bot d036f04573 Localisation updates from https://translatewiki.net.
Change-Id: I30e95352b17b75c8eb8dba54a4007238c28b1c63
2016-03-17 23:23:48 +01:00
Ed Sanders b7d25d92bc Detect the type of plain pasted links
Using the same logic we used for converting pasted URLs, detect
internal links by matching their base.

Currently link pasting is still disabled in the VE target, but
has been enabled elsewhere (Flow).

Change-Id: Iebd61abbe1fe82fd18d129e1dbc815ca75f44e87
2016-03-17 19:30:13 +00:00
jenkins-bot d5ef085b3e Merge "Link pasting: Match RDFa-less links as external" 2016-03-17 17:45:52 +00:00
Ed Sanders 5e6cbc187c Link pasting: Match RDFa-less links as external
Now that some targets support link pasting (Flow) we need to
make sure that pasted links match to an allowed type ('link/mwExternal')
instead of plain 'link' annotations which should never exist
in an MW document.

In a later commit we should auto-detect internal links.

Change-Id: I7faae834aa6e730c3cf93a691331a05fd0fe3d5c
2016-03-17 17:18:41 +00:00
jenkins-bot 1c27e5d51a Merge "In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId" 2016-03-17 15:39:12 +00:00
jenkins-bot 33c9055fdc Merge "Reload page after user selects multi-tab option of SET dialog" 2016-03-17 15:39:09 +00:00
Alex Monk 3288d4e3f9 Show redirect target inside target
Bug: T63861
Depends-On: I71d3d415fe918e8b0a090860cad9271092b1bd7e
Change-Id: I5a138b95e04773885ca9ee548026729805eb11f0
2016-03-17 15:21:06 +00:00
Translation updater bot 445a830d52 Localisation updates from https://translatewiki.net.
Change-Id: I2764438c78e674d492157f55fb15ae82ed114b36
2016-03-15 23:06:07 +01:00
Ed Sanders dec9aa09e4 Use keyboard icon for keyboard help tool
Change-Id: Id5e5097dfcdb5e3be2b21c89886857cb379997e6
2016-03-15 17:28:48 +00:00
Alex Monk 02953f5d64 Suppress meta dialog on refresh pages if we want to show SET dialog
Bug: T129819
Change-Id: I1176d06e5a5f56f01528acd7d099c8be9d317e51
2016-03-15 08:10:46 +00:00
Translation updater bot af64cf7b12 Localisation updates from https://translatewiki.net.
Change-Id: I85827c3e9262adf7bb6191ff68de688f744b613a
2016-03-14 22:55:30 +01:00
jenkins-bot 53d3c62d46 Merge "CommandHelpDialog: Inherit non-corruptively" 2016-03-14 20:28:56 +00:00
Ed Sanders f5873ac1db CommandHelpDialog: Inherit non-corruptively
Change-Id: Ieb497eebe930e58a02552eb9d4305280c91c92c2
2016-03-14 20:03:52 +00:00
Ed Sanders 5d5d5419c6 AceEditorWidget: Use namespaced 'require'
The un-namespaced version will soon be removed to fix RL issues.

Bug: T127643
Change-Id: Iaf4ed23d88cb955b8f8f61725f9effa6180de5bf
2016-03-14 16:56:16 +00:00
Željko Filipin 63eb2a2f46 [BrowserTest] Increase the time Selenium waits for VisualEditor to load
I have noticed that Jenkins job that runs daily fails sometimes because
looking up the element failed after 5 seconds. The time is increased
from 5 to 10 seconds.

Bug: T94150
Change-Id: Ib23f4ac72aa6c734f297e8f9fb5ad4645ac8891e
2016-03-14 13:00:17 +01:00
jenkins-bot 110c6eb057 Merge "[BrowserTest] Disable failing language screenshot scenario" 2016-03-14 11:33:53 +00:00
jenkins-bot 0cdf4393ed Merge "Prefer error *code* when logging unknown errors" 2016-03-14 01:01:48 +00:00
jenkins-bot 3a1f6a34c8 Merge "Log readonly code for readonly errors" 2016-03-14 01:00:47 +00:00
Alex Monk 612e43dc08 Prefer error *code* when logging unknown errors
See also I4a5bac24

Change-Id: I62fda9dadd24704f5930b30a2f8ad4d4a9e729cb
2016-03-14 00:27:42 +00:00
Translation updater bot 004247822d Localisation updates from https://translatewiki.net.
Change-Id: I18e35f520e9b8dde3c96e6b2c3b740d1fb48c294
2016-03-13 22:57:53 +01:00
jenkins-bot 1a0733c4f2 Merge "MWSaveDialog: Fix vertical alignment" 2016-03-13 11:43:17 +00:00
Translation updater bot 368953b808 Localisation updates from https://translatewiki.net.
Change-Id: I1c34348e0ce6227d6a3e84a969271563b0e8a6d5
2016-03-12 21:14:25 +01:00
Alex Monk 22bf016a84 In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId
There's probably more to this bug but I think we should still correct this

Bug: T125437
Change-Id: Ib32d1e69b2500578b5dc160c0c2d7481f5577ebb
2016-03-12 04:46:54 +00:00
Translation updater bot 7c8a2207d3 Localisation updates from https://translatewiki.net.
Change-Id: Ifefb57f56a762c7fcb5cab0258d018be0e7c10eb
2016-03-11 22:18:35 +01:00
Ed Sanders da9aff2421 MWSaveDialog: Fix vertical alignment
Change-Id: Ifb62375da6c872a3a4ef783e479a5476ca318b32
2016-03-11 17:37:01 +00:00
Alex Monk d1d4839f8f Log readonly code for readonly errors
I thought I did this yesterday

Change-Id: Icd2cf8fdf4263cab335a2ddfa53ab0585153dfb4
2016-03-11 17:33:57 +00:00
Alex Monk 3807a918f9 Reload page after user selects multi-tab option of SET dialog
Bug: T129510
Change-Id: I3fcac175f18d8159e6a5c4084668264d4705970c
2016-03-11 05:39:29 +00:00
Translation updater bot 55a6cd08b2 Merge "Localisation updates from https://translatewiki.net." 2016-03-10 21:33:52 +00:00
Translation updater bot 3aac2043a4 Localisation updates from https://translatewiki.net.
Change-Id: Ia3db1d0b33d4bdbde66452bcf33a7b0b0e4da5bb
2016-03-10 22:31:26 +01:00
jenkins-bot d6ec1ed86f Merge "Fix logging of event_action.saveFailure.message for responseUnknown" 2016-03-10 21:22:37 +00:00
jenkins-bot ad7c364725 Merge "Better handling of read-only mode" 2016-03-10 21:22:34 +00:00
Alex Monk 0a6f6e1bbd Fix logging of event_action.saveFailure.message for responseUnknown
Change-Id: Ic8d3066d8f6ccf8bc4a1001fd4d406b313915e82
2016-03-10 21:03:25 +00:00
Alex Monk d2a9aefba7 Better handling of read-only mode
* Don't just fail to load, action=visualeditor itself should not write to the DB
  (we have action=visualeditoredit for that)
* Send notice to the client in the usual way
* Handle read only errors on save, log as unknown

This won't let you review changes because that uses visualeditoredit

Bug: T129501
Change-Id: Id78c06b031423e47a7ddf94ec615b6d6975309d3
2016-03-10 21:02:52 +00:00
jenkins-bot 3eaaf57847 Merge "Suppress welcome dialog this time if we're showing the SET pref dialog" 2016-03-10 20:38:39 +00:00
Alex Monk 4462f2539a Suppress welcome dialog this time if we're showing the SET pref dialog
Bug: T129200
Change-Id: Iaa6d80df930cfcbd243efd31437cb8707da35c06
2016-03-10 17:54:15 +00:00
Željko Filipin 43e9c8714f [BrowserTest] Disable failing language screenshot scenario
VisualEditor_Insert_Menu scenario fails with `Original image height is
too small! (ChunkyPNG::OutOfBounds)`.

Bug: T119482
Change-Id: I30c3a9757c5754a40921fce5225b73897eed865b
2016-03-10 15:06:56 +01:00
Translation updater bot d36a099939 Localisation updates from https://translatewiki.net.
Change-Id: I32293b4f2532d15e65b71f09e53ac9c2e8817356
2016-03-09 22:48:24 +01:00
jenkins-bot 2e89f4f658 Merge "[BrowserTest] Disable failing language screenshots" 2016-03-09 17:32:57 +00:00
jenkins-bot 67fb8dd07f Merge "[BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError" 2016-03-09 17:31:27 +00:00
Timo Tijhof cf1d7c0dab mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined"
Regression from 863a2c2974.

Sometimes when clicking "Switch to source mode" in the toolbar this
error is thrown and the interface freezes because setEditorPreference()
only returns a promise if the value is different.

> Uncaught TypeError: Cannot read property 'done' of undefined
> - ve.init.mw.DesktopArticleTarget.switchToWikitextEditor

Change-Id: Ie59f06a8ed9af9c4fb8199b013c06992d0c4f700
2016-03-08 23:13:11 +00:00
Translation updater bot d8a9a11ca7 Localisation updates from https://translatewiki.net.
Change-Id: Ia668efdeff27d984848c2bca823bf41d370706f9
2016-03-08 22:46:51 +01:00
Ed Sanders d5e594b9f6 Link inspector: Remove premature call to onLinkTypeIndexSet
This causes the inspector to take focus early (line 291) on
first load, and is not necessary as this method fires when
needed anyway.

Bug: T129228
Change-Id: Ia69f76b68e89daf5cb01449c40e71de4ec32d400
2016-03-08 16:54:09 +00:00
jenkins-bot 7261cf5364 Merge "Link inspector: make height consistent" 2016-03-08 16:50:02 +00:00
Ed Sanders 7f31507e12 Link inspector: make height consistent
Make the DOM order sensible so we don't have to
use SearchWidget's position:absolute hacks.

Bug: T129173
Change-Id: I3517e0e0cfe2ab0eee4bed7390e41710d3140eb0
2016-03-08 10:26:31 +00:00
James D. Forrester 80139533ab i18n: Don't refer to the name of the tab in the beta notice given it changes
Change-Id: I9beb322aeabece0df483271b33dbaa41f5da732a
2016-03-07 16:58:32 -08:00
James D. Forrester b247ffd7bd i18n: Explain to returning users that their preferences are mutable
Change-Id: I8a47725d7271af54b30f2130e97b08edec0f0b59
2016-03-07 16:56:13 -08:00
James D. Forrester 9a6650ae1f i18n: Relabel the SET preference and dialog to 'mode'
Change-Id: Id876f4ba102800237cbc4a671d4db9a26f7f116d
2016-03-07 15:51:19 -08:00
jenkins-bot 8d7baccd5f Merge "DesktopArticleTarget: Add Edge and MSIE to whitelist" 2016-03-07 23:28:58 +00:00
jenkins-bot 7a5f34fac3 Merge "Education popup: Also handle clicks on dots" 2016-03-07 23:28:55 +00:00