Commit graph

4305 commits

Author SHA1 Message Date
Alex Monk b877e16723 DesktopArticleTarget: Handle section edit link clicks in single edit tab mode
Bug: T58337
Change-Id: Ic4c19cdfc3cfcf33604d0c4e7780b45967cdf57d
2015-12-09 09:08:46 -08:00
Ed Sanders ae26eefb05 Fix typos
Add some common ones to typos.json

Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
2015-12-09 16:47:13 +00:00
jenkins-bot 6c1e613fa4 Merge "Make clear button on numbered external links remove the node" 2015-12-09 16:26:29 +00:00
jenkins-bot 87ce2f0a20 Merge "EducationPopup: Increase z-index above toolbar dialog's" 2015-12-09 16:26:26 +00:00
David Lynch 7b66083319 Make clear button on numbered external links remove the node
Bug: T120705
Change-Id: I07d57ba95f46f0fa80f9038ccb42d8d89375fd23
2015-12-09 10:11:54 -06:00
Ed Sanders 1121dc5295 EducationPopup: Increase z-index above toolbar dialog's
Bug: T116577
Change-Id: Icb91dcebd450f954b8bae18ee57f75386de754ac
2015-12-09 15:56:08 +00:00
jenkins-bot 2efbdc670c Merge "Single edit tab and section links" 2015-12-09 00:40:46 +00:00
Ed Sanders 4513283140 ve.ui.Icons.css: Fix inpsector typo
Change-Id: I9cb7f6ff38e26632d04a1ffc65ae468a5ee301cc
2015-12-09 00:18:46 +00:00
James D. Forrester ccc087c461 MWSaveDialog: De-flag the 'return to save' button on diffs
Change-Id: Icb7c07dae23b7f3ba1b4cdf6c73f17a1bbff1bdf
2015-12-08 13:31:44 -08:00
Translation updater bot ce89f917df Localisation updates from https://translatewiki.net.
Change-Id: Ie88cfc5d6f943fb52e25c0dd54fe907120dec972
2015-12-08 22:26:41 +01:00
Alex Monk 748db015b0 Single edit tab and section links
In addition to the couple of TODOs inline, we should do the following in
follow-up commits:
* Prevent FOUC due to changing things only on the client
* Make section link behaviour sensible

Bug: T58337
Change-Id: I65d966270491ffe017cb11a0daa915628fadf65c
2015-12-08 17:47:16 +00:00
Translation updater bot bd5a6242f1 Localisation updates from https://translatewiki.net.
Change-Id: I251067f1f7b60e3972f725aa192f2cb90178dc8d
2015-12-07 23:16:10 +01:00
jenkins-bot 4be9c9178e Merge "MWTemplatePage: Re-word the no-description text to reflect being always there" 2015-12-07 22:07:17 +00:00
Bartosz Dziewoński ae8a275095 MWTemplatePage: Re-word the no-description text to reflect being always there
The <visualeditor-dialog-transclusion-no-template-description> message
is now always displayed in template transclusion dialog, both when
adding a new one and when editing existing one. I think it's best to
just remove the incorrect part, as the dialog provides sufficient
context for what is happening.

The $2 parameter is no longer used or documented, but is still
supported for compatibility with existing translations.

Bug: T87130
Change-Id: Ibaa06c3bb1e9afbf0005b1605236f4be8cb15251
2015-12-07 21:59:03 +00:00
jenkins-bot db7bec4825 Merge "MediaDialog: Remove useless empty object arg to media size widget" 2015-12-07 19:21:11 +00:00
Ed Sanders a917871505 GalleryInspector: Use namespace id constant
Change-Id: Ia51634e84cf984d8ed4ecdab87590111bf12478f
2015-12-07 18:49:53 +00:00
Ed Sanders 557eb4fe84 MediaDialog: Remove useless empty object arg to media size widget
Change-Id: Id85498616f80147cd856d4d12bf5a0e58ad66029
2015-12-07 14:12:56 +00:00
Translation updater bot 83620175ca Localisation updates from https://translatewiki.net.
Change-Id: I3d109b133ee6d709a937013bb9eb825800c98775
2015-12-06 21:45:56 +01:00
Translation updater bot db13a4d43a Localisation updates from https://translatewiki.net.
Change-Id: I0d6dede3ef71b7729db66646875c308d50296d81
2015-12-05 23:16:10 +01:00
Ed Sanders 63184600d4 Use wgNamespaceIds constants instead of hard-coded numbers
Change-Id: I71b80e59a5e24d63e68637a1ae8422974643bd3a
2015-12-04 19:57:56 +00:00
Translation updater bot 6ceb0c39e6 Localisation updates from https://translatewiki.net.
Change-Id: Ie307b6e81958bb16c96a0ffff6b3568139564f4f
2015-12-03 23:17:58 +01:00
James D. Forrester 3c9a361da0 MWMediaDialog: Add a margin back to the border checkbox
This was removed upstream in OOUI as unecessary in general, but clearly
this was the place for which the rule had been designed. :-)

Bug: T119547
Change-Id: I46a1df1141c337b436e66872f1a8cdae026816cd
2015-12-02 18:28:18 -08:00
Translation updater bot 7e50ac1ab6 Localisation updates from https://translatewiki.net.
Change-Id: I2180bc4edca07261381b2790af6ebc29e0fde97f
2015-12-02 22:01:03 +01:00
Translation updater bot d924ded91e Localisation updates from https://translatewiki.net.
Change-Id: Ia694075416ebb62d351441419089d2570943ccf8
2015-12-01 21:37:34 +01:00
Translation updater bot 3772e473d5 Localisation updates from https://translatewiki.net.
Change-Id: I4133263c6d9228e867cb54be4b706e8f21a2bbc1
2015-11-30 21:38:08 +01:00
jenkins-bot e24eaea22c Merge "Avoid embedding Git metadata in ext.visualEditor.data" 2015-11-30 11:48:28 +00:00
Ori Livneh b1db8349fe Avoid embedding Git metadata in ext.visualEditor.data
Partially reverts "Expose version information in the client" (a72099af66 / I7836e1d40).
The Git data oscillates between two values due to differences between the
staging and production environments. Each change causes the module version to
change also, leading to cache churn.

Instead fetch version information with an API call the first
time the help popup is opened.

Bug: T119750
Change-Id: Ib9c45e60d3164cfa85eb1ef247cc91cf0d8bf954
2015-11-30 12:34:56 +01:00
Translation updater bot 24046cb548 Localisation updates from https://translatewiki.net.
Change-Id: I24ccb4b7af6241ed77eb47970d821262454ac26e
2015-11-28 21:49:42 +01:00
Translation updater bot 1b176cba81 Localisation updates from https://translatewiki.net.
Change-Id: I459d7ee237ffa2ba146bbd82059e5e22f92234b5
2015-11-27 22:48:54 +01:00
Translation updater bot b367964ad6 Localisation updates from https://translatewiki.net.
Change-Id: I57f93b07e2179ec7cbb75866094dd98f64b54f9c
2015-11-26 22:06:32 +01:00
jenkins-bot 2a46cc7873 Merge "Add autocomplete options to AceEditorWidget config options" 2015-11-25 03:48:38 +00:00
Thalia 3d98b1d291 Add autocomplete options to AceEditorWidget config options
Bug: T119549
Change-Id: I57db44c876c5cb0487bda6a72e36fedaccb532b5
2015-11-24 19:44:41 -08:00
jenkins-bot 4655ba4c5c Merge "MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one" 2015-11-25 02:53:36 +00:00
James D. Forrester b68e34fdeb MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one
Depends on If4ec151a in OOUI.

Bug: T111100
Change-Id: I90af27a7ba881c588b8a432f1cc1e54ab4c80f79
2015-11-24 18:40:13 -08:00
Translation updater bot 0bfa4b7001 Localisation updates from https://translatewiki.net.
Change-Id: I4894709e82769d5161cf39a6488ae1666d5690d6
2015-11-24 23:12:39 +01:00
Ed Sanders bbdb48abdf Create MWPreviewElement which adds the mw-body-content class
This fixes some rendering issues, and also increases the font
size of reference contexts from 12.8px (interface) to 14px (content).

Bug: T119430
Change-Id: Ib1bae8cd4cfe86903d78406a33db78e1489fde86
2015-11-23 14:28:57 -08:00
Translation updater bot 23270f87f9 Localisation updates from https://translatewiki.net.
Change-Id: I045fa54ee959371101a2fc62238d8b10ccb348b0
2015-11-23 22:36:41 +01:00
jenkins-bot 22a8c76d09 Merge "When adding a label to a numbered link, force the selection" 2015-11-23 19:02:04 +00:00
jenkins-bot 5649256ceb Merge "Re-fix in-page loading" 2015-11-23 17:00:13 +00:00
jenkins-bot 4616696e0d Merge "Prevent switching from unedited section directly into VE" 2015-11-23 17:00:08 +00:00
Translation updater bot 7698beb14e Localisation updates from https://translatewiki.net.
Change-Id: I8bde2353b3bb3f950a329f033b87602b107bd722
2015-11-22 20:48:25 +01:00
David Lynch 50759e2064 When adding a label to a numbered link, force the selection
Otherwise the selection will/won't contain the opening node of the
link, depending on where in the paragraph it is. This makes the
experience of starting to type unpredictable to the user. By forcing
it to always have the contents of the node selected, typing always
just updates the label.

Bug: T114643
Depends-On: I7c46a917d9752145174919f41066b4841b203218
Change-Id: Ic1c573c2c28ced49f685ec6082506cb20d5163cd
2015-11-20 18:36:44 -06:00
Ed Sanders 0e30e328ba Update VE core submodule to master (e8c6f7d)
New changes:
b44ef6d [BREAKING CHANGE] Fix WhitespacePreservingTextInputWidget API
96e4034 Localisation updates from https://translatewiki.net.

Local changes:
* Use new WhitespacePreservingTextInputWidget API

Change-Id: I9920a3b5c8c3e8a241dcfdd1bde20f4ea1cf78b6
2015-11-20 15:44:49 -08:00
jenkins-bot 5dbe119699 Merge "MW Examples: Fix test message" 2015-11-20 23:38:56 +00:00
jenkins-bot 77f605d2a5 Merge "Add tests for RESTBase ID comparison" 2015-11-20 23:38:53 +00:00
jenkins-bot 8200cffac5 Merge "Improve tests of data-parsoid annotation comparisons" 2015-11-20 23:37:50 +00:00
Translation updater bot 3523279808 Localisation updates from https://translatewiki.net.
Change-Id: I8658191225f986b896358ebdd98fdefacb143ca0
2015-11-20 22:59:51 +01:00
Ed Sanders 68755b212e MW Examples: Fix test message
Change-Id: I4a0b9bb92fa45fca82391943b86a43fec8f2e3a1
2015-11-20 20:34:18 +00:00
Ed Sanders 287436ae25 Add tests for RESTBase ID comparison
Depends on I8323bbf34 in core.

Change-Id: I4043322361cdbbfd211133191c062eae42269ca4
2015-11-20 20:34:12 +00:00
Ed Sanders 3d7d363e9c Improve tests of data-parsoid annotation comparisons
So that it actually fails if you remove the key feature.

Depends on Iff15190e in core.

Change-Id: I1557f683241193aa4a97e04af0b4daf244a8b121
2015-11-20 12:32:29 -08:00
Ed Sanders bbfcbeb79d Use ES5 trim instead of jQuery
Change-Id: I6e8b958176385cb672380454fcc3b4970261caa9
2015-11-20 11:48:55 -08:00
Alex Monk a0462d69d4 Re-fix in-page loading
Probably broken by Ie808bcaa
Partially reverts Icad04dac, hopefully without any regressions

Change-Id: I4589bde7eac58b54027a6b9dbe6ecddf79780599
2015-11-20 01:57:24 +00:00
Alex Monk 67a51aee9b Prevent switching from unedited section directly into VE
Bug: T117713
Change-Id: Iee9ae2bbe4757cb07e9aa2bd5f41a46c0ebb391a
2015-11-20 00:10:38 +00:00
Translation updater bot 360cdacd4b Localisation updates from https://translatewiki.net.
Change-Id: Iabd0b1ea673697111e28cd959bdf1bca32f72ad6
2015-11-19 21:41:49 +01:00
jenkins-bot 8fae033411 Merge "AceEditorWidget: Ensure loadingPromise is set when setupEditor runs" 2015-11-19 16:47:13 +00:00
Ed Sanders dbdae59128 AceEditorWidget: Ensure loadingPromise is set when setupEditor runs
Change-Id: I11d37b863f28bacd4c09992d6fcc180621766577
2015-11-18 23:11:10 -08:00
jenkins-bot 9f1aedbefc Merge "Make selectRange method of AceEditorWidget focus the input" 2015-11-19 03:28:44 +00:00
Thalia 18448bb42b Make selectRange method of AceEditorWidget focus the input
The selectRange method does this in TextInputWidget, so it
should here too.

Change-Id: Ib3851e0c72876d3c25ae5992cf9732637238d117
2015-11-18 19:14:50 -08:00
jenkins-bot 718e06cf1b Merge "Add method to toggle the AceEditorWidget print margin" 2015-11-18 21:46:44 +00:00
Thalia 21fd89ba3c Add method to toggle the AceEditorWidget print margin
Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
2015-11-18 13:38:41 -08:00
Translation updater bot a09b6e3a20 Localisation updates from https://translatewiki.net.
Change-Id: I2affa2a7543343d7f5899b5b55e1cb7e0a954c92
2015-11-18 22:01:07 +01:00
jenkins-bot 52f151193a Merge "Make focus method of AceEditorWidget chainable" 2015-11-18 20:29:48 +00:00
Thalia 88d466ba23 Make focus method of AceEditorWidget chainable
The focus method of InputWidget and other descendants
of InputWidget is already chainable

Change-Id: Ib75fb7b08769e86c652c63dac069e2573e61f89a
2015-11-18 12:21:44 -08:00
Ed Sanders bd40f62c17 Introduce MWExtensionPreviewDialog
An MWExtensionDialog with a PreviewElement for the selected node,
or node to insert.

Depends on Icd622e15cd7 in VE core.

Change-Id: Ia0f46da2d445dd94c8aa50be73508d9f1afcb816
2015-11-18 19:33:32 +00:00
jenkins-bot d5562830fd Merge "MWSignatureTool: Restrict command to linear selections" 2015-11-18 06:17:56 +00:00
Ed Sanders 259ec31ece MWSignatureTool: Restrict command to linear selections
Change-Id: If6109c2ef2a18eccaccf18bd1d76c272a1dc3cd5
2015-11-17 22:08:23 -08:00
jenkins-bot 761ecc96f4 Merge "AceEditorWidget: Implement getRange" 2015-11-18 06:04:27 +00:00
jenkins-bot 2104ee1590 Merge "Wikitext paste: Fail if result has no visible content" 2015-11-18 03:39:52 +00:00
jenkins-bot df9b4b05b9 Merge "Edit mode switching: Auto-close jQuery.UI dialogs before switching" 2015-11-18 03:36:31 +00:00
Ed Sanders f9ca524ef9 Wikitext paste: Fail if result has no visible content
For example if '[[category:foo]]' is pasted.

Bug: T118191
Change-Id: I9c51846414dd6b885b33f1dc9076edadbc6464c4
2015-11-18 03:33:14 +00:00
Ed Sanders a5d700807a AceEditorWidget: Implement getRange
Depends on I109a666679 in OOUI.

Change-Id: Ie40a30a3743237c1c1cd59dd2165d313363e04cb
2015-11-18 03:32:54 +00:00
Ed Sanders e1d14099e0 Image/gallery icons: Rename and use new upstream versions
Depends on oojs-ui > 0.13.2.

Change-Id: Iee4cc52b998626e829fd92346d5ee1295c08f26f
2015-11-18 01:49:31 +00:00
Ed Sanders 19034b0416 Edit mode switching: Auto-close jQuery.UI dialogs before switching
Bug: T118282
Change-Id: I7960e4f71dd8b710f2ec2430f2946679af07012b
2015-11-17 17:26:01 -08:00
jenkins-bot 370a060ffc Merge "AceEditorWidget: Implement selectRange" 2015-11-17 23:49:46 +00:00
jenkins-bot 4785177791 Merge "Make dependencies of jquery.uls.data more specific" 2015-11-17 23:44:07 +00:00
jenkins-bot a40c0082b0 Merge "Make 'moment' a dependency of just 'mwimage', not all of VE-MW" 2015-11-17 23:42:36 +00:00
Ed Sanders 5e96050b48 AceEditorWidget: Implement selectRange
This is not trivial because Ace selections are
[column,row] tuples, so we need to translate to
one dimensional offsets.

Change-Id: I901b025b3747d61c74f49038fe4a65ed75758211
2015-11-17 23:39:33 +00:00
Ed Sanders d1da56a6cb Make dependencies of jquery.uls.data more specific
Change-Id: I135defffc71d8aa61dc74bb871da96737a3eeb0c
2015-11-17 15:34:23 -08:00
Ed Sanders b5c16ac95c Make 'moment' a dependency of just 'mwimage', not all of VE-MW
Change-Id: I23c193bfb34203aa6f2ef1d3633c208e5c692c97
2015-11-17 14:55:10 -08:00
Translation updater bot b4f2194085 Localisation updates from https://translatewiki.net.
Change-Id: I15540a448677ac4e4b6a0eba024e230ce4846b22
2015-11-17 21:55:40 +01:00
Alex Monk 889358f24c Ensure we always catch the wikiEditor-toolbar-doneInitialSections event
Don't wait for module loading. Before, this was only actually working half the
time.

Change-Id: I7fb284a800927672642c59231a322982b613f16b
2015-11-17 02:23:25 +00:00
jenkins-bot 2fcbc18dff Merge "Provide a tool to insert a signature in namespaces that need it" 2015-11-17 00:16:42 +00:00
jenkins-bot 3e9d040a79 Merge "AceEditorWidget: Allow users to force an Ace editor refresh" 2015-11-16 22:46:24 +00:00
Translation updater bot 64d8e394ce Localisation updates from https://translatewiki.net.
Change-Id: Iaf8fb457fd0b835d5b8819f5dab015c4a59e0a78
2015-11-16 22:19:07 +01:00
Ed Sanders 35c44db988 AceEditorWidget: Allow users to force an Ace editor refresh
Ace is clever about not updating the rendering of elements
which aren't visible, so allow users to force an update, for
example if they changed the value while the whole widget
was hidden.

Change-Id: I7bbbffd17489bc80fe5fa80911f29d7223e125a3
2015-11-16 12:12:10 -08:00
Ed Sanders 470a4a551b AceEditorWidget: Refactor to ensure setValue runs synchronously
Also ensure setEditorWidget is only called once when
loadingPromise resolves.

Change-Id: I1a95bda5e9ff17d7575326f29fa01d273193c4a5
2015-11-16 11:36:08 -08:00
Bartosz Dziewoński 9be5c85db4 Provide a tool to insert a signature in namespaces that need it
VisualEditor is usually not enabled in talk namespaces... but
sometimes it is. And when users see the button to edit with VE,
they're going to click it and expect to be able to sign their posts.

This tool is only loaded on talk pages and pages in additional
namespaces defined in $wgExtraSignatureNamespaces.

Code adapted with small tweaks from my own gadget
<https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js?oldid=13461327>,
which is already available under the MIT license.

Changes include:
* The tool is now always visible if the wiki allows signatures in any
  VE namespaces, but disabled when not allowed in the current namespace.
* Register '~~~~' sequence to insert the signature.
* Code style tweaks for stricter lint checks in this repository.
* Documentation corrections.

Swedish translation provided by André Costa (already credited
as a translator as Lokal_Profil).

Depends on changes in VisualEditor core:
* I89fe53890ab59d12260ea6b41de802c38c24e8b9
* I14cd7efac521687ea38580341ae08ddc522edeeb

Bug: T53154
Change-Id: I6be5fb2118cf3eef5098d4c5320228aa81411ccb
2015-11-16 18:06:32 +01:00
Translation updater bot 9d01677f75 Localisation updates from https://translatewiki.net.
Change-Id: I2e18f18c1614e74a5681ea7e8faf0ce71c1b5db1
2015-11-15 22:22:40 +01:00
jenkins-bot f44e127eb5 Merge "AceEditorWidget: Emit resize event at end of cycle" 2015-11-15 02:38:22 +00:00
Translation updater bot 8a456d3e31 Localisation updates from https://translatewiki.net.
Change-Id: I1eb678891af629bf935f2837e76ba5b856d5f9fd
2015-11-14 22:19:35 +01:00
Ed Sanders b21b939a67 AceEditorWidget: Emit resize event at end of cycle
Ensures the widget has taken its new size before emitting the event.

Bug: T117926
Change-Id: If1dab2ecadb2a581100c0ae154b341ce8d173a7c
2015-11-13 18:48:35 -08:00
C. Scott Ananian 236fad19b6 Ensure magic link nodes inherit the annotations of their text
If you create an autolink in the middle of bolded text, the magic link
should also be bolded.  Similarly, if you convert a bolded simple link
to a magic link, the magic link should stay bolded.

Change-Id: I38c7f3c0c275851049088a37f3b37d815ed38e4e
2015-11-13 13:48:18 -08:00
Translation updater bot 73918e0e1e Localisation updates from https://translatewiki.net.
Change-Id: I63a0e4185c61a42cf0d142d520fdc1e7c7f9000f
2015-11-13 21:35:36 +01:00
Translation updater bot a284d335a8 Localisation updates from https://translatewiki.net.
Change-Id: I7f7dba15312b3fda8e9a737428f4bc191604ac4f
2015-11-12 23:02:52 +01:00
jenkins-bot c6aeff4ba9 Merge "Edit mode switching: Separate styles" 2015-11-11 22:33:35 +00:00
jenkins-bot 96f91758f6 Merge "Update VE core submodule to master (77d786a)" 2015-11-11 22:10:08 +00:00
Translation updater bot c1ac8806c6 Localisation updates from https://translatewiki.net.
Change-Id: I7f3c0dfe04074271159b7f22032c587374f72836
2015-11-11 21:57:36 +01:00
Ed Sanders 9bcc61e195 Update VE core submodule to master (77d786a)
New changes:
95589a6 test: Add a Rakefile for new CI requirement
1a4497e ve.ui.DialogTool: Do not require that a command is set
cbf1bff ve.ui.Tool: Fix documentation for getCommandName
530022d Localisation updates from https://translatewiki.net.
9529093 Update OOjs UI to v0.13.2
b8d6c15 Add icon: Rename 'insert' to 'add'
2f3015b Update OOjs to v1.1.10
78ceb18 Fix deletion inside a structural node at start/end of document
ce3e9a4 ve.utils: Use binarySearch from OOjs

Local change:
* MW test cases for new structural deletion logic

Bug: T52250
Change-Id: I643449c1fa08ea12c8c3aa13f4a4b97d8876990d
2015-11-11 12:35:53 -08:00
Ed Sanders 86a1d1bfa3 Edit mode switching: Separate styles
Ensures that these styles are loaded *after* OOUI by making
them dependent on it, unlike DesktopArticleTarget.init
which isn't.

Change-Id: Ia1fff16432d20fb56707c5e21c6a930d2478e311
2015-11-11 18:50:55 +00:00
jenkins-bot c815c3242d Merge "Edit mode switching: Only show WE toolbar button once module is loaded" 2015-11-11 02:21:04 +00:00