wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 18:39:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
1321 commits 161 branches 1 tag 190 MiB
Commit graph

265 commits

Author SHA1 Message Date
Catrope 4d9299b808 Fix bugs in selectNodes(), tests pass now 
Also fix one instance of bad expected data in a selectNodes test

Change-Id: Ie226b237cf537143bce2f6b1e531b9067b140cb4
 2012-05-07 17:03:42 -07:00
Catrope 32c65cdaa8 Change 'leaf' to 'leaves' and document it 
Change-Id: I09d5995d3d9bf82670802f0efe849f40be2a18a3
 2012-05-07 17:03:42 -07:00
Catrope 770775eec0 Fix rebuildNodes tests, were messing up ve.dm.example 
Fixed by operating on a copy of the data instead

Change-Id: Ia2607d94f07b8d43e8c98ae8a94c34df90081508
 2012-05-07 17:03:42 -07:00
Trevor Parscal 4bae026190 Added additional test to rebuildNodes, now testing rebuilding after a change 
Change-Id: I669457389bf742c100dec5205b972f6d1e14ef44
 2012-05-07 16:25:39 -07:00
Trevor Parscal 811110d7c6 Simplified selectNode tests 
Change-Id: I878fd430b24661fc11c953b3303e395cdd617006
 2012-05-07 16:18:24 -07:00
Trevor Parscal 88a05b5606 Added another falling selectNodes test 
Change-Id: I1f18b0af956c98a5facaf12a88fd94ca76e50a65
 2012-05-07 16:05:40 -07:00
Trevor Parscal e1f8fef228 Changed selectNodes test to desired behavior (which fails atm) 
Change-Id: I79eb5caaa3e2193e2309d37dc1d0ca67c2602836
 2012-05-07 15:50:11 -07:00
Trevor Parscal f4fcf9663e Added documentation and tests for ve.dm.Document.selectNodes 
Also:
* Broke node lookup method out into ve.dm.example.lookupNode
* Added ve.dm.example.nodeSelectionEqual

Change-Id: I437cdd3f3154d10782f03f78df6d5c457ecfc845
 2012-05-07 15:15:21 -07:00
Trevor Parscal cbb868577e Whitespace and syntax fixes 
Change-Id: I5a553272c1faf1e83a5e8be8ecf7911a11ec27a8
 2012-05-07 13:40:09 -07:00
Catrope 4427122f90 Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-05-07 12:00:59 -07:00
Catrope 93d6adb5f2 Add an isWrapped property and make getOuterLength use it 
This gets rid of the length == outerLength-2 hack in getDataFromNode()
and will make it easier to implement similar logic in selectNodes()

Change-Id: I1294350b67ca3eefde2b7fe9fea0bc6d8b90f772
 2012-05-07 12:00:07 -07:00
Trevor Parscal 39b3755310 Line-length fixes 
Change-Id: I5258ad2e550313a95ae5b7bba951992db2db966c
 2012-05-07 11:45:31 -07:00
Trevor Parscal e34ec4b479 Added canHaveChildren and canHaveGrandchildren to all nodes 
Change-Id: Ibe53292f7269736750e03da49e5bb5913c0124ab
 2012-05-04 17:50:54 -07:00
Trevor Parscal 1d74945dfc Fixes for Roan's crazy half-baked commit 
Change-Id: Ic104debc3a941e4cf8e4dca19633dcad04a0fe0a
 2012-05-04 16:13:54 -07:00
Trevor Parscal 0433717b29 Added attribute add and remove tests and cleaned some things up 
Change-Id: If339e0b59a8cdd90a151128138cec85b902681a8
 2012-05-04 15:50:50 -07:00
Trevor Parscal bce509195b Removed unused attributes in example data 
Change-Id: I0ce52456113e6efc5d879041270e06fd0b6bdebe
 2012-05-04 15:50:32 -07:00
Rob Moen d42e738636 - Optimize surface model and write unit tests 
Change-Id: I8de24c840c5aa2d4232e6e2cc5f72cbd30be96b4
 2012-05-04 15:29:47 -07:00
Trevor Parscal dc27d8acb4 Refactored dom wrapper functionality in ce nodes 
* Moved implementation of getting and updating a DOM wrapper to ve.ce.BranchNode
* Updated ve.ce.BranchNode tests
* Renamed ve.NodeFactory.createNode to ve.NodeFactory.create
* Added  ve.NodeFactory.lookup which gets the constructor of a type
* Added attribute pass-through to ve.dm.BranchNodeStub

Change-Id: I8f5b7d3d3ae616cc5f39828b24b655163d782ae5
 2012-05-04 13:31:14 -07:00
Trevor Parscal 9887dbd96f Split Broke DefinitionListNode out of ListNode and DefinitionListItemNode out of ListItemNode 
* Makes it simpler in the linear model because we don't have to use style: "item" for regular list items and style: "definition" for definition lists
* Enforces correct nesting through existing node rules systems
* Updates tests accordingly

Change-Id: I64d80af938e325f1961226505bdc386bb35ccdda
 2012-05-04 11:56:32 -07:00
Catrope 11a3b6886b Implement basic replace processor 
* Implement basic TransactionProcessor.replace(), only does content
  replacements
* Add ve.dm.Document.containsElementData()
* Fix bug in attribute()
* Write basic tests for attribute() and replace()

Change-Id: Ie9c22aec3f2631be5b0bd66790408ad283565491
 2012-05-04 11:09:10 -07:00
Trevor Parscal a9b26c8b55 Removed recursive rendering calls in favor of 100% event driven updates 
Change-Id: I636222518e4cbeddb1c02901b79a9dcb09eeb952
 2012-05-03 17:19:01 -07:00
Trevor Parscal 458ba0b7d5 Added tests for getModel, getParent, attach and detach on ve.ce.Node 
Change-Id: I064b2a13cbfe7a7ebc11af83fb7744ebbad39da1
 2012-05-03 17:06:23 -07:00
Trevor Parscal f738e75caa Fixed mistakes in the linear and tree example models 
Change-Id: Id19ac7b2efb5c5f3147a4abf5e62fab3044b5fd7
 2012-05-03 14:54:27 -07:00
Rob Moen 8518e1cc1d Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-05-03 13:12:36 -07:00
Trevor Parscal b1b9fb5133 Added tests for getDataFromNode 
Change-Id: Ic762832dcdda3bdaf92dbd989659235fdff73596
 2012-05-03 13:11:36 -07:00
Rob Moen 424e58ab1d - write tests for ve.dm.BranchNode setDocument 
Change-Id: I7aa2dc0ff5a9b7b7f190da29ac62a5e9c7817dbc
 2012-05-03 13:08:37 -07:00
Trevor Parscal 71f36aa52b Added tests for getOffsetFromNode 
Change-Id: I4dc06e9ea3b634fbd5034df721162098441ea368
 2012-05-03 11:52:17 -07:00
Inez Korczynski a3b32b6615 Big refactoring to TextNode to make it work with new format of storing 
annotations.

Change-Id: If84fcfdd04ff42e9b2449e1c8186d64fec4fb1ac
 2012-05-02 22:28:57 -07:00
Inez Korczynski 9f11f437d2 Merge branch 'dmrewrite' of ssh://review/mediawiki/extensions/VisualEditor into dmrewrite 2012-05-02 19:29:49 -07:00
Inez Korczynski d81b972cdf Very dirty but working version of getHtml method for TextNode (with bunch 
of tests that are passing now).

Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
 2012-05-02 19:29:03 -07:00
Trevor Parscal 64d56971a9 Removing unused code 
Change-Id: I23213531eeef95110d0a3d1e2476449c580b55b7
 2012-05-02 17:05:22 -07:00
Trevor Parscal 6a60c1f60b Removed console.log 
Change-Id: I7cd2e1cf5e1cf7a2e9864090cfab391faba10997
 2012-05-02 16:46:36 -07:00
Trevor Parscal b7b2fc1179 Made render for ce leaf nodes abstract and added a test for it 
Change-Id: Iee228d5f1a18a5c9618680fa81ab132a85472fa6
 2012-05-02 15:59:43 -07:00
Trevor Parscal 16e12debdc Added ve.getHash and ported ve.Json 
Change-Id: I4a5d86426902e0473cdb0f98c3d121eed607f93c
 2012-05-02 15:23:01 -07:00
Trevor Parscal 6792762285 Added insertion and removal tests to ve.ce.BranchNode.onSplice 
Change-Id: Ic4fc51f3f8f869b03e9ae0fced88c74d2ddf4388
 2012-05-02 14:59:07 -07:00
Trevor Parscal d97864a92e Added removal test for ve.ce.BranchNode.onSplice 
Change-Id: I54b622fa05ce02965a2ae48fc78958b6408bca4d
 2012-05-02 14:50:28 -07:00
Inez Korczynski dd6094842e Created a test file for ve.ce.TextNode and fixed some minor issues. 
Change-Id: Ifbf6b7ba2a27eedf6d5d4f6cb06b98c38eb52c5b
 2012-05-02 14:18:02 -07:00
Trevor Parscal fd28fff50f Added test for replaceDomWrapper and onSplice in ve.ce.BranchNode 
* Also fixed calls to addListenerMethod
* Also routed adding children in the constructor of ve.dm.BranchNode to the splice method
* Renamed types of ve.dm stub nodes to avoid collisions (since we have to register ce nodes by the same names for them to be generated by onSplice)

Change-Id: Ia2e75cf0a62186cc0e214683feb25c619590318a
 2012-05-02 13:58:50 -07:00
Trevor Parscal 8bd0d385eb Added test for whitespacePattern, getDomText and getDomHash in ce 
* Also fixed some naming typos in the units under test

Change-Id: I17f753a122f94dd16f7783f60b5c0eb1c6d3e480
 2012-05-02 12:54:42 -07:00
Trevor Parscal f1505a0e62 Merge remote-tracking branch 'origin/master' into dmrewrite 
Change-Id: I43a3cd999ec0a5d3d05ee1e5bb71c450d485bc01
 2012-05-02 10:17:44 -07:00
Trevor Parscal cac3c6efd0 Merge branch 'dmrewrite' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor into dmrewrite 2012-04-30 19:39:02 -07:00
Trevor Parscal 370070dfa2 Lots of ce porting, got text nodes fully supported 
* Fixed constructor of ve.ce.BranchNode which was calling the wrong method to perform an onSplice and with the wrong arguments
* Removed/renamed events emitted from ve.ce.BranchNode.onSplice
* Reintroduced .$ to all ce nodes
* Ported over functionality for DOM node type variance used in headings, lists and list items
* Moved the old ve.ce.Content guts to ve.ce.TextNode
* Added getOffsetFromNode and getDataFromNode to ve.dm.DocumentFragment
* Added setDocument and getDocument to dm nodes

Change-Id: I185423ba2f1a858dde562cb2f5bc3852aec930db
 2012-04-30 19:38:42 -07:00
Catrope d9cd1392fc Add TransactionProcessor tests, and fix TP to make them pass 
* Add .process() and its helpers from ve1
* Fix applyAnnotations()
** Use data[i] rather than data[j]
** Don't add empty annotation objects for no reason
** Remove empty annotation objects
*** I thought this wasn't needed, but it is needed for clean rollbacks
* Remove unused second parameter in applyAnnotations() call

Change-Id: Ia338f62d2eaf2a76f8ef653eead05bc44757a122
 2012-04-30 19:06:20 -07:00
Trevor Parscal 7a0e086879 Fixed test name to match method name 
Change-Id: I06a4e63c5032b74253bcc3a1cd4e36f48d3f424a
 2012-04-30 17:41:24 -07:00
Trevor Parscal 35af704173 Added initial ce nodes 
Change-Id: Ibdcb4502a8fdc5b1a6c22ae0e9c42c86b3a7d4dc
 2012-04-30 17:36:22 -07:00
Trevor Parscal de0debb866 Added skeleton tests for ce nodes 
Change-Id: I1f5988b31fdef1bf5c5f9266d0bfa8da91d97c3a
 2012-04-30 17:04:58 -07:00
Trevor Parscal c2d4a2d928 Added basic ve.ce nodes 
* Also removed beforeSplice and afterSplice in favor of just plain splice which is the same as afterSplice used to be - beforeSplice was never used and it was making things more complex looking than needed

Change-Id: Icbbc57eac73a2a206ba35409ab57b3d1a49ab1a5
 2012-04-30 16:58:41 -07:00
Trevor Parscal aaa322642b Added ve.ce.NodeFactory and tests 
Also added tests for initialization of factories at ve.ce.factory and ve.dm.factory

Change-Id: Ic6ac74aab86ecdfd4f094d9bb1fa16de930387b7
 2012-04-30 16:36:02 -07:00
Trevor Parscal a667425874 Moved canHaveChildren and canHaveGrandchildren back to ve.NodeFactory 
This is generally useful information, not only for dm

Change-Id: I9511467285e9594b4a7aa659bf65bb0417da25a1
 2012-04-30 16:25:44 -07:00
Trevor Parscal 2cee2adb6d Split node factory into dm specific implementation 
* Added support for asking if a given node type can have children or grandchildren and what types of nodes can be it's parent or child
* Removed canHaveChildren methods from leaf and branch nodes and converted use of them to depend on factory to read static rules from constructor lookup by type

Change-Id: I9769f95647066576416bacb791c4b68dd0285b35
 2012-04-30 15:42:36 -07:00