mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced 2024-09-27 12:16:51 +00:00
Line-length fixes
Change-Id: I5258ad2e550313a95ae5b7bba951992db2db966c
This commit is contained in:
Trevor Parscal
parent
1ef380984f
commit
39b3755310
|
|
@ -1,88 +1,160 @@
|
|||
module( 've.dm.Transaction' );
|
||||
|
||||
test( 've.dm.Transaction', function() {
|
||||
var tx = new ve.dm.Transaction(), expectedOps = [], expectedLD = 0;
|
||||
deepEqual( tx.getOperations(), expectedOps, 'New Transaction object has no operations' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'New Transaction object has length difference zero' );
|
||||
var tx = new ve.dm.Transaction(),
|
||||
ops = [],
|
||||
diff = 0;
|
||||
|
||||
deepEqual( tx.getOperations(), ops, 'new transactions have no operations' );
|
||||
deepEqual( tx.getLengthDifference(), diff, 'new transactions have zero length difference' );
|
||||
|
||||
// Retain
|
||||
tx.pushRetain( 5 );
|
||||
expectedOps.push( { 'type': 'retain', 'length': 5 } );
|
||||
deepEqual( tx.getOperations(), expectedOps, 'pushRetain adds a retain operation' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Retain operations do not affect the length difference' );
|
||||
ops.push( { 'type': 'retain', 'length': 5 } );
|
||||
deepEqual( tx.getOperations(), ops, 'pushRetain adds a retain operation' );
|
||||
deepEqual( tx.getLengthDifference(), diff, 'pushRetain does not change length difference' );
|
||||
|
||||
// Multiple retain
|
||||
tx.pushRetain( 3 );
|
||||
expectedOps[expectedOps.length - 1].length += 3;
|
||||
deepEqual( tx.getOperations(), expectedOps, 'Successive retain operations are combined into one' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Successive retain operations do not affect the length difference' );
|
||||
ops[ops.length - 1].length += 3;
|
||||
deepEqual(
|
||||
tx.getOperations(),
|
||||
ops,
|
||||
'successive pushRetain calls grow last retain operation instead of adding a new one'
|
||||
);
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'successive retain operations do not change length difference'
|
||||
);
|
||||
|
||||
// Insert
|
||||
var abcParagraph = [ { 'type': 'paragraph' }, 'a', 'b', 'c', { 'type': '/paragraph' } ];
|
||||
tx.pushInsert( abcParagraph );
|
||||
expectedOps.push( { 'type': 'insert', 'data': abcParagraph } );
|
||||
expectedLD += abcParagraph.length;
|
||||
deepEqual( tx.getOperations(), expectedOps, 'pushInsert adds an insert operation' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'pushInsert updates the length difference' );
|
||||
ops.push( { 'type': 'insert', 'data': abcParagraph } );
|
||||
diff += abcParagraph.length;
|
||||
deepEqual( tx.getOperations(), ops, 'pushInsert adds an insert operation' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'pushInsert increases the length difference correctly'
|
||||
);
|
||||
|
||||
// Multiple insert
|
||||
var deParagraph = [ { 'type': 'paragraph' }, 'd', 'e', { 'type': '/paragraph' } ];
|
||||
tx.pushInsert( deParagraph );
|
||||
expectedOps[expectedOps.length - 1].data = expectedOps[expectedOps.length - 1].data.concat( deParagraph );
|
||||
expectedLD += deParagraph.length;
|
||||
deepEqual( tx.getOperations(), expectedOps, 'Successive insert operations are combined into one' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Successive insert operations update the length difference correctly' );
|
||||
ops[ops.length - 1].data = ops[ops.length - 1].data.concat( deParagraph );
|
||||
diff += deParagraph.length;
|
||||
deepEqual( tx.getOperations(), ops, 'successive pushInsert calls are merged' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'Successive insert operations increase the length difference correctly'
|
||||
);
|
||||
|
||||
// Insert + Retain
|
||||
tx.pushRetain( 3 );
|
||||
expectedOps.push( { 'type': 'retain', 'length': 3 } );
|
||||
deepEqual( tx.getOperations(), expectedOps, 'pushRetain adds a retain operation' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Retain operations do not affect the length difference' );
|
||||
ops.push( { 'type': 'retain', 'length': 3 } );
|
||||
deepEqual( tx.getOperations(), ops, 'pushRetain after pushInsert adds a retain operation' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'pushRetain after pushInsert does not change length difference'
|
||||
);
|
||||
|
||||
// Remove
|
||||
var hi = [ 'h', 'i' ];
|
||||
tx.pushRemove( hi );
|
||||
expectedOps.push( { 'type': 'remove', 'data': hi } );
|
||||
expectedLD -= hi.length;
|
||||
deepEqual( tx.getOperations(), expectedOps, 'pushRemove adds a remove operation' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'pushRemove updates the length difference' );
|
||||
ops.push( { 'type': 'remove', 'data': hi } );
|
||||
diff -= hi.length;
|
||||
deepEqual( tx.getOperations(), ops, 'pushRemove adds a remove operation' );
|
||||
deepEqual( tx.getLengthDifference(), diff, 'pushRemove decreases the length difference' );
|
||||
|
||||
// This one is long on purpose, so the LD will drop below zero
|
||||
// Multiple remove - this one is long on purpose, so the LD will drop below zero
|
||||
var jklmnopq = [ 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q' ];
|
||||
tx.pushRemove( jklmnopq );
|
||||
expectedOps[expectedOps.length - 1].data = expectedOps[expectedOps.length - 1].data.concat( jklmnopq );
|
||||
expectedLD -= jklmnopq.length;
|
||||
deepEqual( tx.getOperations(), expectedOps, 'Successive remove operations are combined into one' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Successive remove operations update the length difference correctly' );
|
||||
ops[ops.length - 1].data = ops[ops.length - 1].data.concat( jklmnopq );
|
||||
diff -= jklmnopq.length;
|
||||
deepEqual( tx.getOperations(), ops, 'successive remove operations are merged' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'successive remove operations decrease the length difference correctly'
|
||||
);
|
||||
|
||||
// Replace
|
||||
var rst = [ 'r', 's', 't' ], R = [ 'R' ];
|
||||
tx.pushReplace( rst, R );
|
||||
expectedOps.push( { 'type': 'replace', 'remove': rst, 'replacement': R } );
|
||||
expectedLD -= rst.length;
|
||||
expectedLD += R.length;
|
||||
deepEqual( tx.getOperations(), expectedOps, 'pushReplace adds a replace operation' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'pushReplace updates the length difference' );
|
||||
ops.push( { 'type': 'replace', 'remove': rst, 'replacement': R } );
|
||||
diff -= rst.length;
|
||||
diff += R.length;
|
||||
deepEqual( tx.getOperations(), ops, 'pushReplace adds a replace operation' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'pushReplace change the length difference correctly'
|
||||
);
|
||||
|
||||
// Multiple replace
|
||||
var uv = [ 'u', 'v' ], UVWUVWUV = [ 'U', 'V', 'W', 'U', 'V', 'W', 'U', 'V' ];
|
||||
tx.pushReplace( uv, UVWUVWUV );
|
||||
expectedOps.push( { 'type': 'replace', 'remove': uv, 'replacement': UVWUVWUV } );
|
||||
expectedLD -= uv.length;
|
||||
expectedLD += UVWUVWUV.length;
|
||||
deepEqual( tx.getOperations(), expectedOps, 'Successive replace operations are NOT combined into one' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Successive replace operations update the length difference correctly' );
|
||||
ops.push( { 'type': 'replace', 'remove': uv, 'replacement': UVWUVWUV } );
|
||||
diff -= uv.length;
|
||||
diff += UVWUVWUV.length;
|
||||
deepEqual( tx.getOperations(), ops, 'successive replace operations are NOT merged' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'successive replace operations change the length difference correctly'
|
||||
);
|
||||
|
||||
// Replace attribute
|
||||
tx.pushReplaceElementAttribute( 'style', 'bullet', 'number' );
|
||||
expectedOps.push( { 'type': 'attribute', 'key': 'style', 'from': 'bullet', 'to': 'number' } );
|
||||
deepEqual( tx.getOperations(), expectedOps, 'pushReplaceElementAttribute adds an attribute operation' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Attribute operations do not affect the length difference' );
|
||||
ops.push( { 'type': 'attribute', 'key': 'style', 'from': 'bullet', 'to': 'number' } );
|
||||
deepEqual( tx.getOperations(), ops, 'pushReplaceElementAttribute adds an attribute operation' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'attribute operations do not change the length difference'
|
||||
);
|
||||
|
||||
// Replace multiple attributes
|
||||
tx.pushReplaceElementAttribute( 'level', 2, 3 );
|
||||
expectedOps.push( { 'type': 'attribute', 'key': 'level', 'from': 2, 'to': 3 } );
|
||||
deepEqual( tx.getOperations(), expectedOps, 'Successive attribute operations are NOT combined into one' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Successive attribute operations do not affect the length difference' );
|
||||
ops.push( { 'type': 'attribute', 'key': 'level', 'from': 2, 'to': 3 } );
|
||||
deepEqual( tx.getOperations(), ops, 'successive attribute operations are NOT merged' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'successive attribute operations do not change the length difference'
|
||||
);
|
||||
|
||||
// Annotation
|
||||
tx.pushStartAnnotating( 'set', { 'type': 'textStyle/bold' } );
|
||||
expectedOps.push( { 'type': 'annotate', 'method': 'set', 'bias': 'start', 'annotation': { 'type': 'textStyle/bold' } } );
|
||||
deepEqual( tx.getOperations(), expectedOps, 'pushStartAnnotating adds an annotate operation' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Annotate operations do not affect the length difference' );
|
||||
ops.push( {
|
||||
'type': 'annotate',
|
||||
'method': 'set',
|
||||
'bias': 'start',
|
||||
'annotation': { 'type': 'textStyle/bold' }
|
||||
} );
|
||||
deepEqual( tx.getOperations(), ops, 'pushStartAnnotating adds an annotate operation' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'annotate operations do not change the length difference'
|
||||
);
|
||||
|
||||
// Multiple annotations
|
||||
tx.pushStartAnnotating( 'clear', { 'type': 'textStyle/italic' } );
|
||||
expectedOps.push( { 'type': 'annotate', 'method': 'clear', 'bias': 'start', 'annotation': { 'type': 'textStyle/italic' } } );
|
||||
deepEqual( tx.getOperations(), expectedOps, 'Successive annotate operations are combined into one' );
|
||||
deepEqual( tx.getLengthDifference(), expectedLD, 'Successive annotate operations do not affect the length difference' );
|
||||
ops.push( {
|
||||
'type': 'annotate',
|
||||
'method': 'clear',
|
||||
'bias': 'start',
|
||||
'annotation': { 'type': 'textStyle/italic' }
|
||||
} );
|
||||
deepEqual( tx.getOperations(), ops, 'successive annotate operations are combined into one' );
|
||||
deepEqual(
|
||||
tx.getLengthDifference(),
|
||||
diff,
|
||||
'successive annotate operations do not change the length difference'
|
||||
);
|
||||
} );
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue