Commit graph

16855 commits

Author SHA1 Message Date
Bartosz Dziewoński 73dcfb7122 ApiVisualEditorEdit: Fix handling of 'minor' parameter
The client-side code sends the empty string as the value of this
parameter when the edit should be marked as minor, and doesn't set it
at all when it shouldn't (this is the normal convention for boolean
parameters). However, the API code here was incorrectly handling the
empty string, and not marking the edit as minor as a result.

This was revealed by 50883dd7fe. Prior
to that change the original 'minor' parameter was forwarded to the
action=edit call if it was provided, overriding the 'notminor'
parameter, which was effectively added unconditionally.

Bug: T248257
Change-Id: I37fd73851d94906d79943692fb9136da03ea95fa
2020-03-23 17:36:34 +01:00
Translation updater bot fa3363972d Localisation updates from https://translatewiki.net.
Change-Id: I0412c631608f401ecf5d38f3c2138f394089e536
2020-03-23 09:04:53 +01:00
libraryupgrader ad8e396f1c build: Updating npm dependencies
* mkdirp: 0.5.1 → 0.5.3
  * https://npmjs.com/advisories/1179
* eslint: 6.6.0 → 6.8.0
  * https://npmjs.com/advisories/1179

Change-Id: Id41d07d66980cb34e6a8053a54a01364417b188c
2020-03-21 08:51:54 +00:00
jenkins-bot 8384559296 Merge "ApiVisualEditorEdit: Remove unused output values 'basetimestamp', 'starttimestamp'" 2020-03-20 19:37:47 +00:00
Translation updater bot 316161de03 Localisation updates from https://translatewiki.net.
Change-Id: I95b3ff58b3fb984175117754399beff16a02a9be
2020-03-20 08:25:21 +01:00
libraryupgrader e88f23f9ad build: Updating minimist to 1.2.5
* https://npmjs.com/advisories/1179

Change-Id: Ic6036834e3af1ed97d8e36882922ffedf09b37ae
2020-03-19 20:59:47 +00:00
jenkins-bot 3a598e4543 Merge "Update VE core submodule to master (61d8fefba)" 2020-03-19 20:07:11 +00:00
jenkins-bot 6c29d69e33 Merge "MWTransclusionDialog: Set 'aria-expanded' on "Show/hide options" button" 2020-03-19 19:57:37 +00:00
James D. Forrester 993cd8949d Update VE core submodule to master (61d8fefba)
New changes:
2e0e2a303 build: Upgrade grunt from 1.0.4 to 1.1.0
301ab9ab1 Add accessibility labels to all `type: 'list'` toolbar groups

Bug: T245776
Change-Id: Ic4c309e755c03790a8d0303363a2ecdf096695f0
2020-03-19 12:53:50 -07:00
jenkins-bot 007604dd24 Merge "Update VE core submodule to master (cf72879d2)" 2020-03-19 19:51:19 +00:00
Akinwale Alagbe 2aeae1c3f9 MWTransclusionDialog: Set 'aria-expanded' on "Show/hide options" button
Adding the ability for screen reader to announce 
the state of the Transclusion dialog 
when the show/hide options button is clicked.

Bug: T248089
Change-Id: I89b86179bcb63376e480cb8df55e24b9d29df037
2020-03-19 19:43:14 +00:00
jenkins-bot fe15e3cc89 Merge "Add accessibility labels to all type: 'list' toolbar groups" 2020-03-19 19:35:52 +00:00
Ed Sanders 788c57a3ea Update VE core submodule to master (cf72879d2)
New changes:
cf72879d2 Show sum/average when selecting multiple numeric cells

Local changes:
Implement number parsing/formatting for table summing

Bug: T247877
Change-Id: I52af622dc8cfe7e77fd7ce88428be092d5b092a2
2020-03-19 12:26:26 -07:00
Translation updater bot 884ffbb0b9 Localisation updates from https://translatewiki.net.
Change-Id: I246d4c306bba7bb56da090fe5f6a77696435c958
2020-03-19 08:34:47 +01:00
Bartosz Dziewoński e2cb9ce93e Remove incorrect handling for 'T-' prefix in section numbers
When a page is preprocessed for transclusion, sections are numbered
differently, and the 'T-' prefix indicates this. It can't just be
removed.

It seems that all of our other code can handle section "numbers" like
"T-1" just fine.

Bug: T246164
Change-Id: If19a2d48f94411a89525fb605169c7f8dd4b1797
2020-03-18 21:23:38 +01:00
Translation updater bot e1e1656818 Localisation updates from https://translatewiki.net.
Change-Id: I45098df48cffb567a9d81b5e9a4e55e39d0393a2
2020-03-18 09:33:45 +01:00
Bartosz Dziewoński 9e859a6145 ApiVisualEditorEdit: Remove unused output values 'basetimestamp', 'starttimestamp'
Our client-side code doesn't use them, and they should not be needed.

ApiVisualEditor still returns those, and they are needed there; this
method used to be shared by both classes until 25afae342a.

ApiVisualEditorEdit still has 'basetimestamp' and 'starttimestamp'
input parameters.

Change-Id: I7108468df2ff20f05bd141cb617e4e0f90c027ce
2020-03-17 21:04:51 +01:00
Bartosz Dziewoński 0039ca5bd3 ApiVisualEditorEdit: Remove unused variable $links
It was added in 78a52f1f80 (2014)
and apparently was never used?

Change-Id: I44a3305f805333f8ea3d35f4f937cc6210eb54eb
2020-03-17 20:38:53 +01:00
Bartosz Dziewoński 6d254de92e ApiVisualEditorEdit: Remove use of deprecated 'modulescripts'
It's unused and always empty, as of MediaWiki 1.33 (c6f34408).

Change-Id: I7997e8dcc5ce7221cf5586173dbb0fe62f9a7953
2020-03-17 20:31:45 +01:00
Translation updater bot d6de945517 Localisation updates from https://translatewiki.net.
Change-Id: Ic5c68c2001225d62c44757f9624af82a2daac83a
2020-03-17 10:26:37 +01:00
jenkins-bot f22a8733df Merge "Update VE core submodule to master (31fe99c3f)" 2020-03-17 00:14:18 +00:00
jenkins-bot 39a8ecf890 Merge "Remove X-Parsoid-Variant configuration value, which is no longer needed" 2020-03-17 00:13:39 +00:00
Bartosz Dziewoński 7367881daf Update VE core submodule to master (31fe99c3f)
New changes:
31fe99c3f Localisation updates from https://translatewiki.net.

This restores translations for the 'visualeditor-pagemenu-tooltip'
message, which was moved to the submodule.

Change-Id: I9095d3d5450cd3517d70d590fde568e4f44672b8
2020-03-16 17:47:16 +00:00
Translation updater bot 6efa7b337a Localisation updates from https://translatewiki.net.
Change-Id: I58c766e7efcfd9a08574755c5efb98f6b0399a61
2020-03-16 16:03:04 +01:00
Bartosz Dziewoński 7b47575a45 Add accessibility labels to all type: 'list' toolbar groups
Bug: T245776
Change-Id: I67d8e239f4fed7dd7ac4b98be3362426e753076b
2020-03-14 14:13:53 +01:00
Bartosz Dziewoński bf58f16931 Update VE core submodule to master (3ee49173e)
New changes:
b7c110646 Localisation updates from https://translatewiki.net.
3ee49173e Add missing localisation message

Local changes:
* Remove duplicate of the localisation message

Change-Id: Ic34c22a12befabd6d8e0b1ea411d18f1e5405cba
2020-03-13 22:35:07 +01:00
Bartosz Dziewoński 8f106c9eca Remove two unused localisation messages
They were moved to mediawiki/core and renamed, and should have been
removed here, in 2ee9e62a4d.

* visualeditor-dialog-media-noresults → mw-widgets-mediasearch-noresults
* visualeditor-media-input-placeholder → mw-widgets-mediasearch-input-placeholder

Change-Id: I73e75bf6c6420af5774bc93e54a16f4360f2bcfe
2020-03-13 21:34:32 +01:00
Akinwale Alagbe a65c905287 Adding aria-label to the widgets in page settings that fail accessibility
Bug: T247048
Change-Id: I08469c9a38d905b8953b471f11839a5b99f4e7c8
2020-03-13 20:54:43 +01:00
jenkins-bot 2c1383b79e Merge "Move checkbox widget creation to mw.libs.ve" 2020-03-13 18:13:46 +00:00
Ed Sanders e3d3e0869d Move checkbox widget creation to mw.libs.ve
So this can be used other VE API users (e.g. DiscussionTools).

Bug: T245222
Change-Id: I1e0e9bb9da53a62f8a20126e579dcd6300bd2376
2020-03-13 18:00:44 +00:00
Translation updater bot f43d76e1a6 Localisation updates from https://translatewiki.net.
Change-Id: Ib8eca312f8fe91a51277586b184ed9619f53735a
2020-03-13 08:55:26 +01:00
Translation updater bot b6bdbcd3bf Localisation updates from https://translatewiki.net.
Change-Id: I60a5e2c7fb8e6054f5f2e840058b698d9f38fecf
2020-03-12 08:43:52 +01:00
jenkins-bot a5420c624a Merge "Update VE core submodule to master (ff82c0966)" 2020-03-11 23:32:23 +00:00
jenkins-bot cb9895e304 Merge "Ensure that ve.init.target is correct when re-activating an ArticleTarget" 2020-03-11 23:28:23 +00:00
jenkins-bot c2975804a8 Merge "Don't pass through edit API params we've already handled" 2020-03-11 23:28:20 +00:00
Ed Sanders 0091d69231 Update VE core submodule to master (ff82c0966)
New changes:
8a3e25b98 build: Updating acorn to 7.1.1
032a2520d Localisation updates from https://translatewiki.net.
ff82c0966 [BREAKING CHANGE] Remove ve.init.target lookup from TargetWidget

Local changes:
* Pass toolbarGroups explicitly form Target to TargetWidget

Change-Id: I4ff6f432412ab958f2858879b2b857278866350a
2020-03-11 23:59:10 +01:00
jenkins-bot cb1330ae45 Merge "Localisation updates from https://translatewiki.net." 2020-03-11 20:04:25 +00:00
C. Scott Ananian ce094c72d4 Remove X-Parsoid-Variant configuration value, which is no longer needed
Reverts Ib1403638b12ec5808f6b81bd114949043aa9ac2e.

Bug: T229074
Change-Id: I9bbc02821d5ee82c9944516ab07d3cb380d2f3a8
2020-03-11 13:24:43 -04:00
jenkins-bot 74ee640664 Merge "ve.ui.MWSaveDialog: Remove meta element filtering from wikitext preview" 2020-03-11 15:26:05 +00:00
Ed Sanders bcfb250f56 Ensure that ve.init.target is correct when re-activating an ArticleTarget
Change-Id: Ic30cd99583019823b51f52ab97ee6f9d7adc53f2
2020-03-11 14:45:37 +00:00
Translation updater bot ebbc1e9eb7 Localisation updates from https://translatewiki.net.
Change-Id: I6de4334333a36a893250359905193e5000eabfa5
2020-03-11 08:30:19 +01:00
jenkins-bot ee43838e79 Merge "Making Categories page in page option dialog accessible" 2020-03-10 19:48:57 +00:00
Translation updater bot dbb375c4aa Localisation updates from https://translatewiki.net.
Change-Id: Iecb6efe352b61cf3d0722af215922c1ccdd4e153
2020-03-10 08:16:01 +01:00
Ed Sanders 8726a71342 Move switchToWikitext to switchToFallbackWikitext
This should be a no-op as the inherited switchToWikitext
implementation will always call switchToFallbackWikitext
if 'source' is not passed as a supported mode (which it
isn't currently in MobileFrontend).

Change-Id: I213e7d54d158127b5c42bc05ff9ea2dececc42fe
2020-03-09 18:55:15 +00:00
Ed Sanders bc29a8cdd1 MobileArticleTarget: Remove definition of editSource, identical to parent
Change-Id: I939b34416722fe81f643ca48fe1c5f8ea9e3cbc5
2020-03-09 18:55:05 +00:00
Translation updater bot 23d3b7c579 Localisation updates from https://translatewiki.net.
Change-Id: I449ab510b15b70a9b28e6f8159d66ec1aa0c89d7
2020-03-09 08:58:26 +01:00
libraryupgrader a2db14e6a5 build: Updating acorn to 7.1.1
* https://npmjs.com/advisories/1488

Change-Id: I48ad37864879342fbcf63c8a2d9a435c3b4129de
2020-03-08 15:32:45 +00:00
Akinwale Alagbe 30c90b867a Making Categories page in page option dialog accessible
Bug: T247122
Change-Id: Id91438bf6bc1bf0781fbbcbed32326c5700bfb7d
2020-03-06 13:32:48 -08:00
Bartosz Dziewoński 734c929ea0 Add some accessibility labels to buttons on mobile
Various buttons have a label on desktop, but only an icon on mobile.
We should still use the label for accessibility.

Change-Id: I2b49a80e174dc30ae997a69662643b28b428263a
2020-03-06 15:09:44 +01:00
Bartosz Dziewoński 59cc4b10aa Update VE core submodule to master (f7f72b5c5)
New changes:
42fea96be Add some accessibility labels to buttons on mobile

Change-Id: I37f03d547b1891c05b50fb1761620e7af9209e2b
2020-03-06 15:09:44 +01:00