Commit graph

14778 commits

Author SHA1 Message Date
Thalia 4a1d52ccb3 Show signatures in NWE visual diff
Parse document with pre-save transform for the diff.

Bug: T184166
Change-Id: Iffc9ed8ba88dcb55bef73f1708118663b0c38068
2018-08-16 21:45:28 +01:00
Translation updater bot a37e9abe53 Localisation updates from https://translatewiki.net.
Change-Id: I0ba9e84a8c841a29df9cccecf7c1195ccc2a5df5
2018-08-15 22:18:55 +02:00
jenkins-bot 0491369ff2 Merge "ApiVisualEditor: Use MediaWikiServices rather than $wgContLang" 2018-08-15 05:00:19 +00:00
James D. Forrester 5c9f4f9820 Update VE core submodule to master (e7fd43cfb)
New changes:
b1e14c16a build: Update eslint-config-wikimedia to 0.7.2 and simplify config
e7fd43cfb Move DOM selection from a block slug even if model selection is unchanged

Bug: T201599
Change-Id: I7e53da897f6cb4910a180ff86cae18982a9453e4
2018-08-14 14:08:08 -07:00
Translation updater bot d606e427c5 Localisation updates from https://translatewiki.net.
Change-Id: I017f26780081052542e376690e5f69cd9dd1c191
2018-08-14 22:35:42 +02:00
James D. Forrester 4755d7f1be build: Upgrade eslint-config-wikimedia to 0.7.2 and simplify config
Change-Id: Ib78c51a177b9f4b4764587232c7d32ffcfdd8aca
2018-08-14 11:02:20 -07:00
James D. Forrester 1f452626d6 ApiVisualEditor: Use MediaWikiServices rather than $wgContLang
Change-Id: Ie0a5deaa17db91f0866e35bd51e1e7067345d796
2018-08-14 17:10:40 +00:00
jenkins-bot 2270987788 Merge "ve.init.mw.MobileArticleTarget: Tweak toolbar items' height" 2018-08-14 17:03:48 +00:00
jenkins-bot ad675d06d7 Merge "Add Converter test cases for captions in images and gallery images" 2018-08-14 17:03:45 +00:00
jenkins-bot 2b43a24eea Merge "ve.init.mw.ArticleTarget: Skip prompt when switching to VE from NWE section editing if unchanged" 2018-08-14 16:09:49 +00:00
Bartosz Dziewoński 2512baa68e Add Converter test cases for captions in images and gallery images
Many of the details of the behavior don't really matter, but
I suppose it doesn't hurt to document them.

We really want to test two things:
* When converting from DOM to model data, a <mwImageCaption>
  or <mwGalleryImageCaption> is always generated, even if
  DOM has no caption.
* Model data that doesn't have <mwImageCaption> or
  <mwGalleryImageCaption> is nevertheless still valid and
  converting it to DOM doesn't fail.

Follow-up to Ie82fb339f6bd8ae1b289235bf5402490722d9a7c.

Change-Id: I0a10351e9c1589afbee76d8a85f869987de3de22
2018-08-14 11:02:09 +02:00
Bartosz Dziewoński 39208b7d40 Update VE core submodule to master (2859146e5)
New changes:
fa5d35054 Only re-use session token if docname matches
58d7cd280 Localisation updates from https://translatewiki.net.
d0716d8e7 Update files generated with new l10n language 'my'
2cc7a4423 Create unit tests for sequences
873fdd01e Upstream horizontalRule sequence and fix command

Local changes:
* Register unit test file for sequences
* Remove duplicate horizontal rule sequence

Change-Id: Ibc65cf5c086428bb0d13c8e2f2de5819e1e23d43
2018-08-14 09:20:07 +02:00
Bartosz Dziewoński 835b68db2a ve.init.mw.MobileArticleTarget: Tweak toolbar items' height
This padding needs to come out to an exact integer pixel value (14px),
otherwise things are off by less than a pixel and look ugly: F24664180

1em = 16px
0.875em = (14/16)em = 14px

Bug: T190596
Change-Id: Ieb292ed14e0b9205d15254667e97613fbf339260
2018-08-14 07:12:51 +02:00
Translation updater bot 3a4c923192 Localisation updates from https://translatewiki.net.
Change-Id: I8c21a5a4b67d181f5f951d1e4193be06415bbdf2
2018-08-13 22:15:11 +02:00
Translation updater bot 2e2f9d49f3 Localisation updates from https://translatewiki.net.
Change-Id: Ic0a2f3004e4562d28eb1f8109dda80819b457919
2018-08-12 22:18:07 +02:00
jenkins-bot f1fad0b8d7 Merge "Store importTitle in document, and display in sub heading" 2018-08-12 18:31:10 +00:00
jenkins-bot e6d52648ff Merge "Pop pending when API call fails" 2018-08-12 18:24:23 +00:00
Ed Sanders 5be3be4ba4 Store importTitle in document, and display in sub heading
Change-Id: I431b721d8af3180b78a565e322a45745d06f67a1
2018-08-12 16:13:00 +01:00
Translation updater bot f227b6e1ec Localisation updates from https://translatewiki.net.
Change-Id: I194f91827d84f129d762617a0a993c4b14f2a0ea
2018-08-11 22:18:36 +02:00
Ed Sanders 68f83cab37 Pop pending when API call fails
Change-Id: I633355d48f6e684be09f8bdeed5c1745cdcb43e0
2018-08-11 18:15:14 +01:00
Translation updater bot a722d56b23 Localisation updates from https://translatewiki.net.
Change-Id: Ida0c592af419599a891ba69ad9a05fab39b02784
2018-08-10 22:19:15 +02:00
Bartosz Dziewoński a387778ac3 ve.init.mw.ArticleTarget: Skip prompt when switching to VE from NWE section editing if unchanged
Bug: T136267
Change-Id: I30eae20baca2e16fa5f710485eab213edd5c4a08
2018-08-10 18:07:59 +00:00
James D. Forrester 3f3849261a Update VE core submodule to master (e2ce88ff1)
New changes:
424c47fc8 Remove duplicated usage of article "the"
677052c92 Localisation updates from https://translatewiki.net.
806b221af ve.dm.Document: Replace empty nodes after inserting non-text data
9758fd70f Replace Bugzilla numbers with Phab numbers
131a68caa ve.ui.Sequence: Revert sequence stripping changes
c63d3d585 ve.dm.Document: Improve docs of #fixupInsertion
163041e05 ve.ui.Sequence: Strip sequence before running the command

Bug: T201491
Bug: T201573
Change-Id: I2902af41a0de7528339b3e11a8e27d77ffac7aee
2018-08-10 10:00:49 -07:00
jenkins-bot c0c94668c9 Merge "DesktopArticleTarget.init: always bind to #ca-edit" 2018-08-09 22:18:55 +00:00
David Lynch e99749aa80 DesktopArticleTarget.init: always bind to #ca-edit
Refactoring in 92c4e23 didn't account for the case where there are multiple
tabs and source mode isn't NWE, which caused the "edit source" tab to just be
a page- navigation that always discarded changes. onEditTabClick handles this
case fine, so just always bind the handler.

Bug: T199655
Change-Id: I3dca87a7a3b0ea88ef0008be89cd1f6007167916
2018-08-09 23:36:08 +02:00
Translation updater bot 5f2cc44db6 Localisation updates from https://translatewiki.net.
Change-Id: Id335ead338f5d25c19ce44e885563ca5f7389916
2018-08-09 22:24:21 +02:00
jenkins-bot 083d436a4b Merge "Replace Bugzilla numbers with Phab numbers" 2018-08-09 16:03:32 +00:00
Ed Sanders 4ee09f75af Replace Bugzilla numbers with Phab numbers
Change-Id: I0e91d63b3872520b8f66002615967b2cfe235bf5
2018-08-09 15:11:27 +01:00
Bartosz Dziewoński 57b46158e8 Update VE core submodule to master (7e57bf17b)
New changes:
56b799abb Restore cursor trapping functionality to table cells
8befef408 ui.Sequence: fix post-sequence cleanup

Bug: T200525
Bug: T201472
Change-Id: Ie989bc7033cfc5f8e893efeeb35a39231bd67fc2
2018-08-08 22:56:42 +02:00
jenkins-bot 60982f3369 Merge "Include wpUltimateParam when switching from VE to source editor" 2018-08-08 20:23:16 +00:00
Translation updater bot 9d71f6e904 Localisation updates from https://translatewiki.net.
Change-Id: I17a6f5296290d83e4fbc337c817982ec819002d5
2018-08-08 22:14:25 +02:00
David Lynch 51beff9327 Include wpUltimateParam when switching from VE to source editor
Bug: T199554
Change-Id: I032f822a11840ca16687322bfa051418bc7e9c06
2018-08-08 21:50:59 +02:00
jenkins-bot e171ca96ce Merge "Wikitext surface getCaretPosition: Handle null ranges" 2018-08-08 19:33:14 +00:00
Ed Sanders efaf98d414 Wikitext surface getCaretPosition: Handle null ranges
Bug: T199484
Change-Id: Ica84a87c7cda7135c062f38d3f5b671d6dc3d049
2018-08-08 18:52:39 +00:00
jenkins-bot 948d4502bd Merge "rebaser: Use upstream username persistence" 2018-08-07 22:38:26 +00:00
Translation updater bot 93a1bc584a Localisation updates from https://translatewiki.net.
Change-Id: I93a5a4d7a5413fa0eeaa798aee7c059017dc3956
2018-08-07 22:32:21 +02:00
Ed Sanders 8d56212632 rebaser: Use upstream username persistence
Change-Id: Id07b3d829e4662df9c51dcf122a5d050a92bb2fa
Depends-On: I3bd55a910cc306c3c22fe349b6193f5a3f165495
2018-08-07 19:36:32 +00:00
James D. Forrester 102afd9179 Update VE core submodule to master (efccd8b41)
New changes:
b7e84c989 rebaser: Make create/edit button primary+progressive
316496c15 Localisation updates from https://translatewiki.net.
65fd7fb40 Update OOUI to v0.27.6
a7b2cb4e2 rebaser: Unpaint authors on disconnect
4b549306b ve.ce.Surface: Handle null native selections in #getSelectionState and #showSelectionState
76d1afe62 Localisation updates from https://translatewiki.net.
14d29a5c0 rebaser: Force user state back to active=true when connecting
8530b6762 rebaser: Methodise AuthorList/Widget
9c79de597 rebaser: Emit author colors as well as names in initDoc
5d44160eb rebaser: De-activate surface when author list popup is visible
243e02650 rebaser: Upstream storing username in session storage
22de08438 Remove unused second parameters to ve.ce.Document#getNodeAndOffset

Bug: T199011
Bug: T199754
Bug: T200128
Bug: T201017
Bug: T201244
Change-Id: I2f053c986a5720ddc66cb310ff642b33556e270c
2018-08-06 15:59:01 -07:00
jenkins-bot 68b8bfd92e Merge "rebaser: Fix disable of refs while not supported" 2018-08-06 21:50:17 +00:00
Translation updater bot 3d976d388c Localisation updates from https://translatewiki.net.
Change-Id: I4e9991aed2b445811ef617bc4d150724248151f6
2018-08-06 22:22:52 +02:00
jenkins-bot 9a3d759c00 Merge "Always generate empty wrapper paragraph inside image captions (slugs begone!)" 2018-08-05 18:23:05 +00:00
Ed Sanders 1220efd9e4 rebaser: Fix disable of refs while not supported
Some tools were still showing in the 'insert' menu.

Change-Id: I755e234641623fccd893e78fc3d9973a8a19eb44
2018-08-04 09:41:12 -04:00
Kunal Mehta 8ca03768a1 API: Check whether content is deflated before trying to inflate it
Bug: T201083
Change-Id: I5cad1848b19460ba86043d4627413f939b6d3a5f
2018-08-02 12:38:55 -07:00
Translation updater bot 8025610b8a Localisation updates from https://translatewiki.net.
Change-Id: I331c065708837fa829c1eec99b59f34234b7e740
2018-08-01 22:10:55 +02:00
jenkins-bot 8e43d40cbd Merge "rebaser: Make create/edit button primary+progressive" 2018-08-01 20:02:39 +00:00
Ed Sanders 36d15222bf rebaser: Make create/edit button primary+progressive
Change-Id: I4dc5225ae691a9f8b11d2c7c4a980a2bbc169fd4
2018-08-01 15:34:43 -04:00
David Lynch 5dc09c5cd7 Add horizontal rule sequence (----)
Bug: T199925
Change-Id: I9f76e1e10ff8511252c3b9e5fbe7a9b94dade427
Depends-On: I7a41fa64f2b14ce58aca91feddc791b8648995d0
Depends-On: Ifb7bd4f75aeba38f3ae63fe6ba81cf7fe086461a
2018-08-01 19:28:14 +00:00
Bartosz Dziewoński b159fc4aad Update VE core submodule to master (3c30cac86)
New changes:
76103bb49 Add Horizontal Rule insert command
72c167fe2 Clean up after sequence insertion

Bug: T199925
Change-Id: Id3411dc1e09ca0a0f11cc5bfe452566f932a4b33
2018-08-01 21:27:22 +02:00
James D. Forrester 8f2598f6ee Update VE core submodule to master (9bb7abf84)
New changes:
29331acd8 lib: Update jQuery.i18n to 1.0.5
9bb7abf84 libs/CLDRPluralRuleParser/README.md: Drop `x` flag from file

Change-Id: I7d6446bd3a4a87b77a8569d8279b3fc984b1529c
2018-08-01 14:19:59 -04:00
Bartosz Dziewoński 86f2057c81 Always generate empty wrapper paragraph inside image captions (slugs begone!)
While all of the following are valid in the model:

1. <mwBlockImage></mwBlockImage>
   Image with no caption. Must use the media dialog to insert one.
2. <mwBlockImage><mwImageCaption></mwImageCaption></mwBlockImage>
   Image with empty caption. There is a slug to insert a paragraph.
3. <mwBlockImage><mwImageCaption><paragraph></paragraph></mwImageCaption></mwBlockImage>
   Image with caption with empty paragraph. Nice and intuitive!

(Same for <mwGalleryImage> / <mwGalleryImageCaption>.)

The third option is the most convenient for the user. We should always
generate that when converting documents from HTML and from the editing
tools (MWGalleryDialog, MWMediaDialog/MWImageModel).

Previously, the editing tools generated option 2 if no caption text
was entered, and the converter generated option 2 if there was no
caption node or if it was empty. Curiously, option 1 was never used.

Wikitext for manual testing:

```
[[File:Foo.png|thumb]]
[[File:Foo.png|thumb|]]
[[File:Foo.png|thumb|Caption]]

<gallery mode="packed">
File:Foo.png
File:Foo.png|
File:Foo.png|Caption
</gallery>
```

Bug: T200387
Change-Id: Ie82fb339f6bd8ae1b289235bf5402490722d9a7c
2018-08-01 05:40:57 +02:00