Commit graph

955 commits

Author SHA1 Message Date
WMDE-Fisch 83c30099ec Move obvious Outline related CSS into own file
Should be a noop. Also moving one rule further up to the set of
similar selectors.

Removing one rule that was disabled for some time now.

Optimizations follow.

Change-Id: I8da70a52c13afd8ac1c3ff43bae63a203c3bf86a
2022-07-07 22:05:09 +02:00
Adam Wight 483528affe Drop StackLayout
Gets rid of some unused behaviors that we've already disconnected.
Brings the remaining styling into VE files.

Bug: T312524
Change-Id: Ie94472019ba41124831621c45713861297219594
2022-07-07 13:06:24 +02:00
Andrew Kostka d5b8107902 Use "Add template" label in the sidebar and as the header
Bug: T311107
Change-Id: Ib85c08c5d72e621a7687dc393b2f8d9443f13b06
2022-07-06 10:55:43 +00:00
Jan Drewniak d88fd9b6a8 Prevent skinStyles from applying to the Vector 2022 skin.
With related changes to the DOM in the new Vector skin, most skin
styles are no longer necessary for Vector 2022.

This patch also fixes an issue with the font-size of the toolbar
when $wgVectorTitleAboveTabs = true.

Bug: T310197
Depends-On: Idae6755c90eacaab1a9daa88c6e28850d427810c
Change-Id: I6776f08b24f83cf4daeef70bfdeb73dfeafc785a
2022-06-28 19:51:42 +02:00
WMDE-Fisch ff7eaf5a9b Move MWAddParameterPage styles to own file
Change-Id: I829de89445fd1927209506f5cfbdd9b796953bfe
2022-06-28 14:37:35 +00:00
WMDE-Fisch ecb00afdab Move MWTemplatePlaceholderPage styles to own file
Change-Id: I5eb98c58a8f429622273fbead492bcca12177aee
2022-06-28 14:10:44 +02:00
jenkins-bot 1e094a8868 Merge "Fix broken error message 'visualeditor-saveerror'" 2022-06-27 19:07:18 +00:00
Adam Wight 6de61ccf77 Fork OutlineControlsWidget
Bug: T311223
Change-Id: Id2f9fc89c607c8001e8b150add1ffbcaa318993a
2022-06-27 16:46:11 +02:00
Andrew Kostka 54f4b47794 Add initial tests for ve.ui.MWTwoPaneTransclusionDialogLayout
Bug: T311116
Change-Id: Ie4e1f9f203055f68add6fea0cf04b03215a32942
2022-06-26 17:15:11 +02:00
Umherirrender ab823c0115 Replace deprecated WikiPage::factory
Remove WikiFilePage instance check, isLocal exists also on WikiPage and
newFromTitle never returns null

Bug: T297688
Change-Id: I925771a84afe4402fdb0f201c0b562c7028c44b2
2022-06-24 23:06:39 +02:00
WMDE-Fisch a556661fc7 Order transclusion CSS/LESS files alphabetically
Should have no dependencies on the order in that case.

Change-Id: I9f0dacbc76875f27e6def2b883b0b22bfda6d055
2022-06-24 14:51:17 +02:00
WMDE-Fisch a80f662cfb Merge some CSS rules into the layout less file
Includes adding a less file for minerva layout rules. To make best
use of the less shortcuts and avoid duplication, some selectors
have been slightly changed. Outcome should still be identical.

Change-Id: I92179ecf6045c938cace0e7e809b7ad4cf035727
2022-06-24 13:50:59 +02:00
Adam Wight 004adeef80 Switch to forked BookletLayout
Bug: T310865
Change-Id: If6fcac589fcafffd46beba0b7ea6a6bfb6c0061c
2022-06-23 10:33:12 +02:00
jenkins-bot 8793ef69b4 Merge "Use SkinTemplateNavigation::Universal" 2022-06-22 22:57:33 +00:00
jenkins-bot c19a44e246 Merge "Remove unused media info messages" 2022-06-22 19:36:00 +00:00
Adam Wight 15ef2dc3c6 Remove inaccessible ARIA annotation from old sidebar
This was added via I3b792ff. It's about the old sidebar which isn't
accessible any more.

Bug: T311069
Change-Id: I29919285255a84bd58aa06ee1b2816d25a8112a6
2022-06-22 13:44:23 +02:00
Thiemo Kreuz f0bce1c845 Remove unused media info messages
The "visualeditor-dialog-media-info-…" messages are part of a larger
info panel that appears after searching for an image. This was
introduced via I7b4d019, a patch with 52 patchsets, developed between
September 2014 and January 2015.

The "credit" message appeared first in patchset 2, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/2/modules/ve-mw/i18n/en.json

The "dateformat" message appeared first in patchset 12, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/11..12/modules/ve-mw/i18n/en.json
This message appears to be special in so far that it was never used
to begin with.

The other two messages appeared first in patchset 21, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/20..21/modules/ve-mw/i18n/en.json

3 of the 4 messages are used at this point. The message keys are
constructed in code via `"visualeditor-dialog-media-info-" + key`.
This piece of code was also introduced in patchset 21, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/20..21/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js#629

This was entirely rewritten in patchset 41, see
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/161342/40..41/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js#b670
Since then the messages are unused. The info panel still exists and
still shows all information, but the 3 fields "ImageDescription",
"LicenseShortName", and "Credit" just show an icon and the field's
value, but no label (any more).

Change-Id: Ief35a85d8c5cbf49b662adbfd068dbecd8e4f154
2022-06-22 09:09:07 +00:00
jenkins-bot 1ba1bc76f4 Merge "Remove dead code in MWTemplatePage" 2022-06-22 06:29:47 +00:00
jenkins-bot 4eceae3962 Merge "Remove two unused placeholder messages from gallery dialog" 2022-06-22 00:38:19 +00:00
WMDE-Fisch 11f5f6cb59 Remove dead code in MWTemplatePage
Bug: T310859
Change-Id: Ie55d82fb6f3be0b90b8f42aecdd761624b94afca
2022-06-22 00:20:00 +00:00
Jon Robson 3d4e0f71b1 Use SkinTemplateNavigation::Universal
Web team plans to deprecate the SkinTemplateNavigation
and  SkinTemplateNavigation::SpecialPage hook. The
Universal hook can cater for both cases.

Bug: T255319
Change-Id: Ifad4918cf5d3d6b3f4d7abeb48d27fc5a46764b3
2022-06-21 22:34:55 +00:00
jenkins-bot 3b9e0bf0dc Merge "Remove unused media position messages" 2022-06-21 17:37:06 +00:00
WMDE-Fisch 8535fa72ab Remove dead code in MWTransclusionDialog
Removing CSS will go into a follow up.

Bug: T310859
Change-Id: I05a0c12ab98ca428aca64181469d8c9cf6311f03
2022-06-21 14:22:47 +02:00
Thiemo Kreuz ec2a961d00 Remove two unused placeholder messages from gallery dialog
Both messages are unused since I1e93c3a. As I understand the patch
what it did was replacing two plain text input fields with WYSIWYG
editors. These don't use placeholders.

Change-Id: Ia4ac7d7c9ae86dedd02040a81300a9722e94d1b7
2022-06-21 14:20:33 +02:00
Thiemo Kreuz a01163d097 Remove unused media position messages
All 4 messages are introduced via I15fbd1e in January 2014.

The "none" message is unused since Iddd78c9 from February 2014. It
was replaced with a checkbox with a different label.

The other 3 messages are unused since I7057997 from February 2015.
A more generic widget is used since then. It uses messages that are
named "visualeditor-align-widget-center" and so on.

Change-Id: I7ad4772cb4fdec7e478cee23dccd5ae600834caf
2022-06-21 14:11:53 +02:00
WMDE-Fisch 6396b030d5 Remove dead code in MWTemplatePlaceholderPage
Bug: T310859
Change-Id: I04de9c4bd3828e8769136d5776037e927ba7b4ab
2022-06-20 10:30:31 +02:00
WMDE-Fisch bf2f40e8d4 Remove dead code in MWTransclusionContentPage
The outline item is only used by the new sidebar for the move and
remove flags it seems.

Bug: T310859
Change-Id: Ia74e5b0e3dbf81e745137b181ed34a4d48dac42c
2022-06-17 16:46:30 +02:00
jenkins-bot e2a3629aa8 Merge "Remove redundant error message used sometimes when switching" 2022-06-17 13:24:10 +00:00
WMDE-Fisch 3273b7e5bd Remove dead code in MWParameterPage
Parameters do not have an "OutlineItem" anymore so the code for
that was completely removed.

Bug: T310859
Change-Id: Ie57f462b8fda4505b99ee5bc9d788908d18d9c64
2022-06-17 12:25:40 +02:00
Thiemo Kreuz 218ac78960 Remove obsolete "search for a parameter" page and widgets
… as well as messages, CSS, and icons that are now unused.

Bug: T310859
Change-Id: I1a2797728788cf1a86299414c1430ded0b362d4e
2022-06-17 10:23:00 +02:00
Thiemo Kreuz cf9fea9688 Force "new template dialog sidebar" feature flag to be true
I suggest this as the first, most minimal step. This allows us to
slowly remove all the code that uses this flag without breaking
anything on wikis where the feature flag is not enabled. In other
words: this patch turns all code that expects this flag to be false
into dead code. We can then slowly remove said dead code.

Bug: T289049
Change-Id: I523978f7ca72dfc1cc7b64741e2f4f20ed3adfb7
2022-06-16 18:09:26 +02:00
jenkins-bot 5a406a14d0 Merge "Load mediawiki.diff with mediawiki.diff.styles" 2022-06-16 01:02:44 +00:00
Bartosz Dziewoński 5622576ef9 Fix broken error message 'visualeditor-saveerror'
The message 'visualeditor-error-invalidresponse' doesn't exist,
it has been removed in 5f1c68945d.
MediaWiki API methods can return an error message for this case.

The message 'visualeditor-saveerror' is not used anywhere else.

Change-Id: I3f5617b94135fa602b714aafc0eb6b16f2cd77df
2022-06-16 00:35:13 +00:00
Bartosz Dziewoński 559d85f0f4 Remove redundant error message used sometimes when switching
The API error messages already explain everything well enough,
we pass them directly into a very similar popup in #loadFail.
This message is older than the pretty API error responses,
and didn't work with them well.

Bug: T306763
Change-Id: Ie0d8dc24c967cce02579d6c0539a55ba14372f84
2022-06-16 01:28:19 +02:00
WMDE-Fisch 82718bf70a Remove feedback message link
The testing phase for the implemented features is finished. So the
feedback link for the project can be removed.

Also added missing documentation for a message key used.

Bug: T307188
Change-Id: I2e2e4ff58d2bacda5ae841bcf6f418e786a3967e
2022-06-15 12:37:14 +00:00
Adam Wight 1b4c81c27d Remove $wgVisualEditorTransclusionDialogInlineDescriptions feature flag
The feature is always enabled now.

Bug: T307188
Change-Id: Id8b39d44901dee9118837fc4670d7faa4ef19b43
2022-06-15 12:09:47 +02:00
Adam Wight e1ea921f76 Remove $wgVisualEditorTemplateSearchImprovements feature flag
The feature is always enabled now.

Bug: T307188
Change-Id: I34a3db44355d93413f611b99cd80b876d8737413
2022-06-14 10:48:19 +02:00
jenkins-bot d7140912c7 Merge "Fix tab messages being changed wrong by JavaScript" 2022-06-13 21:15:09 +00:00
Bartosz Dziewoński dc842277c7 Fix tab messages being changed wrong by JavaScript
Following the MediaWiki changes from T301203, we should use
the messages 'skin-view-edit' and 'skin-view-create' instead
of 'edit' and 'create'.

(Also remove redundant definitions in extension.json, we load
all messages listed in 'VisualEditorTabMessages'.)

Bug: T310529
Change-Id: If055fa2a4dc009be869425e6c2262c9b62056179
2022-06-13 20:21:32 +02:00
jenkins-bot fcf849ddb0 Merge "Remove $wgVisualEditorTransclusionDialogBackButton feature flag" 2022-06-13 08:12:40 +00:00
xiplus 8fe04b2555 Load mediawiki.diff with mediawiki.diff.styles
Improve copy and pasting experience.

Bug: T309441
Change-Id: I62f04d08a9e2e5c994224088a24f9e309b1b63cb
2022-06-12 10:32:24 +08:00
Adam Wight 2e2e40e76e Remove $wgVisualEditorTransclusionDialogBackButton feature flag
Feature is always enabled now.

Bug: T307188
Change-Id: I70305ec3d2ed9cfb767ee9ea90e8ed6c93cfbdbb
2022-06-10 17:33:56 +02:00
Adam Wight 23f0bdf822 Remove $wgVisualEditorTransclusionDialogSuggestedValues feature flag
Feature is always enabled now.

Bug: T307188
Change-Id: I6f8288d31fecc6827a7a9e5e9705239e15c86ae2
2022-06-10 16:40:06 +02:00
Svantje Lilienthal 58fd0531d9 Remove updated feature message about search
Bug: T296471
Change-Id: Ie6eea76dacdc614ecb910c48e7e1f519b8c69322
2022-06-10 13:13:51 +00:00
jenkins-bot b23600fe70 Merge "Split advanced language variants messages" 2022-06-08 19:47:24 +00:00
Reedy 9ee13d8471 Remove global class aliases
Change-Id: Id9b021f47d2ec181e5267e454a39ed3cafdec9d2
2022-06-06 17:23:23 +00:00
Amir E. Aharoni 646a812ef4 Split advanced language variants messages
These messages are quite advanced, and they are strongly needed
only in a handful of languages. To make VE localization easier
for volunteer translators, they should be in a separate file,
clearly labeled and with a different priority.

I'll make a separate patch for corresponding translatewiki
configuration.

Change-Id: I64a70b9b4756efea7dfa7cf3cb4dbe9251b73211
2022-05-29 22:16:26 +03:00
jenkins-bot e1d40a958f Merge "Use new ResourceLoader namespace" 2022-05-24 23:46:12 +00:00
Tim Starling b9b6695c5a Use new ResourceLoader namespace
Extensions using Phan need to be updated simultaneously with core due
to T308443.

Bug: T308718
Depends-On: Id08a220e1d6085e2b33f3f6c9d0e3935a4204659
Change-Id: I9a20c25b9cea26e1fbe0f0434a0800632e9e0fc7
2022-05-24 22:59:39 +00:00
Ed Sanders 3e1c562898 Remove duplicate dependency on mwsave from mobileArticleTarget
The dependency on mwsave is in articletarget.

Change-Id: Ifb454978aa15974855b60095aeb76263bcb8c190
2022-05-19 14:18:14 +01:00