* Remove need for manual hacking of sub groups via "msg" strings
carefully prepended to every assertion.
* Improve CI details, by reporting the specific case that failed,
and local dev via ability to re-run each case, and reporting names
directly in the HTML Reporter and CLI summary.
* Reduce need for assert.async() and tracking of callbacks, especially
to improve failure details in case of Promise rejection.
Current logic was likely to cause a confusing timeout instead of a
clear failure if the promise ends up rejected.
QUnit propagates these as part of awaiting and asserting the test
closure's promise value (as async fn) automatically.
This approach also avoids the pitfal of a falsely passing test
when an assertion inside a done() handler was never reached.
* Use modern for-of where possible to remove need for closures and
arrow functions. Thus reducing complexity of test code, where
complexity should be kept lowest to avoid false confidence.
* Use plain for-in instead of overly complex Object.keys().forEach().
Change-Id: I934a266e75e64371081f104cfb867fb2c282c84a
This is not great, but it's a start (and unblocks other pull-throughs).
New changes:
c401efc98 build: Replace jsduck with jsdoc for documentation
16ba162a0 JSDoc: @mixins -> @mixes
9e0a1f53b JSDoc: Fix complex return types
449b6cc0f Prefer arrow function callbacks
1539af2c8 Remove 'this' bindings in arrow functions
b760f3b14 Use arrow functions in OO.ui.Process steps
57c24109e Use arrow functions in jQuery callbacks
9622ccef9 Convert some remaining functions callbacks to arrow functions
f6c885021 Remove useless local variable
1cd800020 Clear branch node cache when rebuilding tree
Bug: T250843
Bug: T363329
Change-Id: I0f4878ca84b95e3f388b358b943f105637e455f9
New changes:
841103234 Localisation updates from https://translatewiki.net.
ed71cf839 Fix rebaser demo to work with LESS
d5b32df6b Use LESS functions for color calculations
3e06b9f21 Localisation updates from https://translatewiki.net.
ea99cd9b3 Use LESS variables for dimension calculations
e34322127 ve.dm.ProtocolServer#welcomeClient: Fix rebaser demo
976c3861b CommandHelpDialog: Remove unused clear:right
f32ab7c9c Remove group property from FindAndReplaceDialog
ff915550d HelpCompletionAction: Allow character skipping in input
40b53053e Localisation updates from https://translatewiki.net.
1cd1b89ef Add langauge->language to typos.json
570674754 Use fast-glob to improve CI performance
e822cc23f LanguageInputWidget: Document that lang and dir can be null
37c482ee4 Fix cursoring off focused block nodes with shift
707da5208 Localisation updates from https://translatewiki.net.
231787a06 Localisation updates from https://translatewiki.net.
0c7642e9f Update OOUI to v0.49.1
9590d6bbc Localisation updates from https://translatewiki.net.
440e63473 Localisation updates from https://translatewiki.net.
c2d7ce249 ve.init.platform: Add #hasLanguageCode
62238cca1 Instruct developers to set FIREFOX_BIN in their environment during setup
836dae588 Use transitionend events instead of hard coding animation time
f52df2ca0 ve.ce.Surface: Use transitionend events
76e93fd07 Make slug animation skin-agnostic
d7fe7b56b Localisation updates from https://translatewiki.net.
e0d43475c Use mutation observer to detect structural deletions
0414276bc build: Updating eslint-config-wikimedia to 0.27.0
0f4edf247 Localisation updates from https://translatewiki.net.
f428c59fa Localisation updates from https://translatewiki.net.
Bug: T131361
Bug: T230323
Bug: T361490
Bug: T362333
Change-Id: Ie74d580fbc7da40a8b8252fbc7f6404a7d57a1a5
Despite its generic name, this class exists just for the
template dialog and does 3 things:
1. Provides generic accept/reject override messages
2. Provides a new function signature when the prompt
and success callback are passed
3. Focuses the delete button
(1) and (2) can be provided by a local helper function.
(3) should be implemented upstream, although given this
was done to prevent users taking destructive actions
accidentally I'm not sure why this should be overridden
here.
Change-Id: Id5aa018310eded7a3552a182d19ca16b040abcbd
