Commit graph

13027 commits

Author SHA1 Message Date
Ed Sanders 3999fb1eb6 VisualDiff: Check save dialog is still visible when re-rendering diff
Change-Id: I1d740b767d150699863f18ee6dd9eca8a35b2bf1
2017-04-27 18:36:07 +01:00
Ed Sanders fefb76eebc Rewrite logic for choosing initial editor
Expanding from a single if-expression lets us make the
code much more readable, and reveals some minor bugs.

Change-Id: I49e57bfc093e019c837a73eab5c25fdbd14de0af
2017-04-26 12:07:51 -07:00
jenkins-bot a93888afd5 Merge "EditModeTool: Use state-describing, not action-describing labels" 2017-04-26 18:42:42 +00:00
Ed Sanders d1017bfd48 EditModeTool: Use state-describing, not action-describing labels
Follows-up 914eb1cde3; reverts the logic to have the label change, but
sticks with new "-current" i18n messages, so the "X editing" instead of
"Switch to X editing"; the old i18n messages are now dropped entirely.

Bug: T162864
Change-Id: Icdad6c5bb06ff86e9b8976840bb1a94b939609a8
2017-04-26 11:33:14 -07:00
David Lynch e1e89e8b14 DesktopArticleTarget: only destroy notices tool if it exists
Bug: T163813
Change-Id: Ib957eac2d3d407f8e683082938ec51d882c2d041
2017-04-26 18:03:39 +00:00
James D. Forrester ca512cf4a1 Update VE core submodule to master (15d5124ee)
New changes:
15d5124ee TransactionBuilder.test: Don't use `static` as the variable name

Change-Id: I498232ba215b4c0511eb67cfb078fa01645963d9
2017-04-26 10:51:05 -07:00
James D. Forrester b534e8c735 Update VE core submodule to master (5936b9521)
New changes:
f1d1ddda4 Fix typo in newBlankDocument
b01a800d6 Update OOjs UI to v0.21.2
87621a9ee Add paragraphType parameter to newBlankDocument

Change-Id: Iebac082fc509be4938ab8e13ec06f01f9ccff20d
2017-04-26 10:18:35 -07:00
jenkins-bot 5b42eb8a31 Merge "Update VE core submodule to master (00f0a0bf8)" 2017-04-26 01:44:54 +00:00
Translation updater bot 06a6abae2b Localisation updates from https://translatewiki.net.
Change-Id: I3da20c65994635e306a799b81a9814c9071a6c65
2017-04-25 23:02:08 +02:00
jenkins-bot c8f919a880 Merge "MWCategoryWidget: batch requests for category data" 2017-04-25 18:32:52 +00:00
L10n-bot e5706fcd9f Merge "Localisation updates from https://translatewiki.net." 2017-04-24 21:01:40 +00:00
Translation updater bot a7b4bfe522 Localisation updates from https://translatewiki.net.
Change-Id: I06af2815f231bc169dba8bb82a009170a39bb176
2017-04-24 23:01:33 +02:00
jenkins-bot 83b331e04e Merge "MWTemplatePage: Show a different message if the template doesn't exist" 2017-04-24 20:43:54 +00:00
jenkins-bot 233415cf50 Merge "MWTransclusionModel: Update for change in TemplateData" 2017-04-24 20:43:52 +00:00
James D. Forrester c787df90c5 MWTemplatePage: Show a different message if the template doesn't exist
Bug: T162694
Change-Id: Icad5abb240efd10fadbfdb287acb98afe2361719
2017-04-24 20:30:35 +00:00
jenkins-bot b268b4f80f Merge "ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error" 2017-04-24 19:48:35 +00:00
James D. Forrester 8fd621ad74 MWTransclusionModel: Update for change in TemplateData
Depends-On: I7905502d0c419a04e4487095214634f1513b461c
Change-Id: I97a1bfc9f9ead082a673a91b9d2053630a90309c
2017-04-24 19:13:59 +00:00
James D. Forrester 58474dcf8a Update VE core submodule to master (00f0a0bf8)
New changes:
04c3aa3aa [BREAKING CHANGE] Remove deprecated TransactionBuilder aliases

Change-Id: I38affac50ff2f2394c6f304451bda61f7f5db3d5
2017-04-24 11:28:19 -07:00
jenkins-bot 112ebdf704 Merge "Update VE core submodule to master (7b494035e)" 2017-04-24 18:27:38 +00:00
jenkins-bot 7df78e1ec1 Merge "MWSaveDialog: Check diffElement still exists after setTimeout" 2017-04-24 18:12:10 +00:00
James D. Forrester 53dbdbe973 Update VE core submodule to master (7b494035e)
New changes:
705f9df8d Node/NodeFactory: Minor documentation fixes
28aa7b6ca Refactor newFromAnnotation & addAnnotationsToData
d5c2fdbfe FragmentInspector.css: Fix documentation typo
7b494035e Localisation updates from https://translatewiki.net.

Bug: T162278
Change-Id: I77a5f9badabb91196cc8aa18e8224da7c06660d4
2017-04-24 11:10:37 -07:00
Ed Sanders df3a4fb171 MWSaveDialog: Check diffElement still exists after setTimeout
Bug: T162642
Change-Id: Iec01a8ebbda39d83fd1c2f4dbbef17793d9af1e4
2017-04-24 18:03:35 +00:00
Translation updater bot 82792c5249 Localisation updates from https://translatewiki.net.
Change-Id: I1f6839c2c0486ebc30a4d4cbc873f45314c84a16
2017-04-23 22:53:34 +02:00
Translation updater bot e2309aa3ce Localisation updates from https://translatewiki.net.
Change-Id: Icfc5631209c09ff5ca286de2ec583264b32d7c43
2017-04-21 23:07:58 +02:00
Bartosz Dziewoński 70dd0c0d16 Remove unused message 'visualeditor-differror'
Unused since a6b4258f47.

Change-Id: Ia4d8ca252dfe04416f1b45ae72f771bc53607ec3
2017-04-21 18:43:36 +02:00
jenkins-bot 67d6ac38e6 Merge "Show a different label for the current mode in the editor mode selector" 2017-04-21 15:56:04 +00:00
jenkins-bot 1862f74f11 Merge "ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only" 2017-04-20 22:34:33 +00:00
Bartosz Dziewoński 371ac353cf ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only
Sites like to customize 'readonlywarning' with things that we can't parse.
Instead, use 'apierror-readonly'. The old message is still shown in edit
notices.

Bug: T163455
Change-Id: I592accde17b256ecee27820df12d9d312499f8f7
2017-04-21 00:08:57 +02:00
David Lynch f7d0df2449 MWCategoryWidget: batch requests for category data
API query cuts off after 50 results.

Bug: T163406
Change-Id: I6e83843dd1a22334d9ddec7103ddf318fb181112
2017-04-20 16:47:16 -05:00
L10n-bot 08a02f0b29 Merge "Localisation updates from https://translatewiki.net." 2017-04-20 21:16:54 +00:00
Translation updater bot 0e5f238f6b Localisation updates from https://translatewiki.net.
Change-Id: I2636ef1e36cfce806d637e906f421cf1cd48548c
2017-04-20 23:16:48 +02:00
jenkins-bot dd6113bb76 Merge "Load notices when switching, just don't show them" 2017-04-20 21:05:40 +00:00
Bartosz Dziewoński 91a75e3fef ve.init.mw.ArticleTarget: Only retry once after a 'badtoken' error
If we retry and get another 'badtoken' error, something is very wrong,
and trying again and again is probably pointless. This behavior also
matches how mw.Api#postWithToken handles bad tokens.

Bug: T163493
Change-Id: I488fd7e74e37922044491695d6c9025a45531281
2017-04-20 22:42:10 +02:00
Ed Sanders c02c529537 Load notices when switching, just don't show them
Previously we completely disabled the loading of notices
when switching, instead of just not showing them (so they
don't clash with the "switched" popup).

Bug: T162812
Change-Id: I3f8e787630e196cee1dbb1aa449b3558b74fcd04
2017-04-20 21:20:10 +01:00
James D. Forrester 914eb1cde3 Show a different label for the current mode in the editor mode selector
Bug: T162864
Change-Id: I2242f85f8c4607411e65b64c8e43181bb139945f
2017-04-20 13:00:34 -07:00
James D. Forrester bef15b7a1e Update VE core submodule to master (bfb35aaef)
New changes:
57f8064b6 tests: Enforce dm unit test coverage at 20% per file and 80% globally
6f757c670 LinkAnnotation: add a getFragment method for consistency with MWInternalLinkAnnotation
c40a3f152 Drop the classList polyfill for IE9
d1af6c6bb Update OOjs UI to v0.21.1
bfb35aaef Localisation updates from https://translatewiki.net.

Bug: T162277
Change-Id: I5146bc421bb88e56bafadccefc7bbdee106504ea
2017-04-20 09:48:46 -07:00
jenkins-bot 6c4b3d68f7 Merge "Move out Cite-specific unit tests in WT transfer handler" 2017-04-20 16:32:55 +00:00
Ed Sanders a7477a869f Move out Cite-specific unit tests in WT transfer handler
Change-Id: Ibea6994a208e4b0b1022896eb31dd2f36f0fd6c6
2017-04-20 17:07:46 +01:00
jenkins-bot 06777e20a3 Merge "MWCategoryItemWidget: remove DraggableElement's padding" 2017-04-20 15:23:29 +00:00
jenkins-bot 0c31c3c243 Merge "ve.ui.MWCategoryPopupWidget: Fix popup positioning" 2017-04-20 07:52:24 +00:00
David Lynch 1c47d71e7d MWCategoryItemWidget: remove DraggableElement's padding
OOjs UI v0.21.0 changed DraggableElement's padding. Override it here, so it doesn't look broken any more.

Bug: T163404
Change-Id: Ic0bc4f9e3e060cf89e6bc7cb22068d1fe1441d75
2017-04-20 02:05:42 -05:00
jenkins-bot babba81a66 Merge "Fix logic for redirecting unsupported browsers to old editor" 2017-04-19 21:45:44 +00:00
Translation updater bot 0a18ebcfe5 Localisation updates from https://translatewiki.net.
Change-Id: I15974fc59db78fad152b63361d0aae8942888f8a
2017-04-19 23:19:02 +02:00
Bartosz Dziewoński 4b7d188735 ve.ui.MWCategoryPopupWidget: Fix popup positioning
Figuring out why it broke doesn't seem like a very interesting task,
so let's just throw the whole logic out and use OOjs UI PopupWidget's
new built-in ability to position itself relative to anything.

Bug: T163269
Change-Id: Ie464e4668001f4bc6151b40cef469937aa8c6e48
2017-04-19 22:48:16 +02:00
jenkins-bot 459dac8de2 Merge "Make onUserLoggedIn() check read-only mode" 2017-04-19 18:03:05 +00:00
Aaron Schulz e7f430e5a0 Make onUserLoggedIn() check read-only mode
Also try to defer the master connection to post-send.

Change-Id: I6c8f5b2e48493cd09de3c93604b3a546d7fa1454
2017-04-19 08:15:06 -07:00
Ed Sanders 08bfe509df Screenshots: Hack the toolbar to display "Article" instead of "Help page"
Change-Id: Iad632a23939712d8d7feb3097b714bfa30d362a1
2017-04-19 13:07:34 +01:00
Željko Filipin ca46a67843 Fix LanguageScreenshotBot by using an existing article
LanguageScreenshotBot failed because it tries to open VisualEditor on a
page that does not exist.

Bug: T162454
Change-Id: I5539c54b7c0ce1f302df0962dad19797d26953da
2017-04-19 12:28:38 +01:00
Bartosz Dziewoński 21bd2a5b18 Fix logic for redirecting unsupported browsers to old editor
Browsers that support JavaScript, but that get served a no-JS
experience by MediaWiki (for example, IE 6), would always get
redirected to an URL with &venoscript=1 - even when it was unnecessary
because we're not in single-tab mode, and even when the form was
previously submitted, causing the loss of user input.

Follow-up to 188ec0f5d2.

Bug: T163226
Change-Id: I212baa0f4305559fa6f6abdfa230b76c122d4909
2017-04-18 20:05:25 +02:00
Translation updater bot 6654de8f0b Localisation updates from https://translatewiki.net.
Change-Id: Ic69f81d75182144f16a90375bc26c55d48a76998
2017-04-17 23:21:48 +02:00