Commit graph

19869 commits

Author SHA1 Message Date
Ed Sanders 7afbe7516d Always sanitize href attribute in CE nodes
Bug: T322704
Change-Id: I0ce6d57adf7c688d11f6fc39af291b44c4b5aeeb
2022-11-30 18:26:37 +00:00
Bartosz Dziewoński 1ea3bf3013 Handle errors when rendering visual diffs
There are some known bugs that we probably will not investigate
(T313809, T317455). Do something better than an infinite loading bar.

Follow-up to ee7c5d9d1a.

Change-Id: I339de7662ff68c2ea9bb1a738bb4207d1c399e59
2022-11-30 18:17:54 +00:00
jenkins-bot d386acf9b0 Merge "selenium: Toolbar should open special characters menu" 2022-11-30 18:01:54 +00:00
jenkins-bot 79b64eb837 Merge "selenium: Toolbar should open notices popup as soon as it loads" 2022-11-30 14:18:35 +00:00
Esther Akinloose fb5cbbd6c8 selenium: Toolbar should open special characters menu
Bug: T296187
Change-Id: Iab55907f648a99f7a7a56dc49bc0686df619c6dd
2022-11-30 14:17:33 +00:00
jenkins-bot 0e4bda00e9 Merge "selenium: Toolbar should open help popup" 2022-11-30 14:08:37 +00:00
jenkins-bot ed3cb2fc61 Merge "selenium: Toolbar should open page options" 2022-11-30 14:05:23 +00:00
Esther Akinloose 5f8dbcf2dd selenium: Toolbar should open notices popup as soon as it loads
Bug: T296187
Change-Id: I705d4d3e8a0135b500ec63749f519f7b86855a2f
2022-11-30 13:43:32 +00:00
Esther Akinloose 329574d645 selenium: Toolbar should open help popup
Bug: T296187
Change-Id: Ic818a97405e93e7545b6655073a62fd7e5b4e8a3
2022-11-30 12:36:42 +00:00
Translation updater bot 34fbdd781b Localisation updates from https://translatewiki.net.
Change-Id: I8c516c7837bb8d7d223db6dea45f8f42cb7f1414
2022-11-30 08:53:40 +01:00
Bartosz Dziewoński c9a9b619aa Only hide #siteNotice on skins where it's shown in the editable area
Bug: T324055
Change-Id: I07139358d0e20582a53fc6820ae022b9edc0ba95
2022-11-29 21:19:46 +01:00
Bartosz Dziewoński 62d80ff88d ve.init.mw.DesktopArticleTarget.init: Remove redundant selector
Hiding '.ve-init-mw-desktopArticleTarget-editableContent #toc' is not needed
when we already hide '.ve-init-mw-desktopArticleTarget-editableContent'.

Change-Id: I9f7dc5f64be1f392e846da5bcfcd0a5d17a65014
2022-11-29 20:52:03 +01:00
Translation updater bot 982cbe31ea Localisation updates from https://translatewiki.net.
Change-Id: I932d2ee994d85c199e1b4b5b1b5b09cce2c08fa0
2022-11-29 08:59:30 +01:00
Esther Akinloose 552e82c308 selenium: Toolbar should open page options
Bug: T296187
Change-Id: I46b5c7c2c3dd4d823a9727ea0c4eb8c2e9aaf207
2022-11-28 15:02:47 +00:00
Translation updater bot acc6e62a84 Localisation updates from https://translatewiki.net.
Change-Id: I24e9806cb9ee84f3e6baa994282f95f8fc22769c
2022-11-28 08:50:36 +01:00
Translation updater bot c91df29059 Localisation updates from https://translatewiki.net.
Change-Id: I69b3a20b8a5167a98dce66bb2de88a3e669e615c
2022-11-25 08:27:02 +01:00
jenkins-bot a4919ff345 Merge "Do not grey out page title while loading NWE on Vector 2022" 2022-11-24 14:00:35 +00:00
Bartosz Dziewoński a7395a04d7 Do not grey out page title while loading NWE on Vector 2022
The "uneditable content" styles should not be applied if the page
title is outside of the editor, like on Vector 2022 since T310839.

Bug: T322725
Change-Id: I212e41e3770807d43b4c58377ce77f4521e6b489
2022-11-24 13:43:45 +00:00
Ed Sanders 95b4bd1a4b Update VE core submodule to master (099b95023)
New changes:
e8c13e337 Localisation updates from https://translatewiki.net.
e59d14a98 Localisation updates from https://translatewiki.net.
347e09eac Localisation updates from https://translatewiki.net.
8592cdc07 Make use of native .map() in ve.ui.LanguageSearchWidget
6412add28 Localisation updates from https://translatewiki.net.
921892af2 Localisation updates from https://translatewiki.net.
a8aa6b475 Localisation updates from https://translatewiki.net.
69e6e5473 Localisation updates from https://translatewiki.net.
8ce65a801 Add test for use of ve.sanitize (DOMPurify) in external paste handler
e11290da1 Add unit tests for ve.sanitize
d248b851a Upgrade DOMPurify to 2.4.1
57eeb8b87 Sanitize href attribute in LinkContextItem and LinkAnnotation
099b95023 Localisation updates from https://translatewiki.net.

Local changes:
* Add ve.sanitize.test.js to test module

Bug: T322704
Change-Id: Ibb34f3cff9e9d891d6d9fd37151a704a67535ab0
2022-11-24 12:51:18 +00:00
Translation updater bot 0e3fb7dc4c Localisation updates from https://translatewiki.net.
Change-Id: I999dc9a2e6109807408661448ce1a069daf1c7a2
2022-11-24 08:18:33 +01:00
Translation updater bot 46a3c0c805 Localisation updates from https://translatewiki.net.
Change-Id: I3c63b32c421dde8458d950928518c6e1a8e9f6c7
2022-11-23 08:33:52 +01:00
Translation updater bot 5c93d514d2 Localisation updates from https://translatewiki.net.
Change-Id: Ieddebab9e640560eaa1f4c4a57edc8c7e307ce68
2022-11-22 08:34:51 +01:00
jenkins-bot b64626a4b8 Merge "Localisation updates from https://translatewiki.net." 2022-11-21 08:17:17 +00:00
Translation updater bot 783a20bccb Localisation updates from https://translatewiki.net.
Change-Id: I3fd5e993e9cc76a05e4bed30a2636be1df2a3348
2022-11-21 08:17:29 +01:00
daniel f36572432b Use PageRestHelperFactory
This isolates this extension from knowledge about the constructor
signature of the helper classes. Constructore signatures are not stable
interfaces.

Needed-By: Ie430acd0753880d88370bb9f22bb40a0f9ded917
Depends-On: I10af85b2da96568cfffd03867d1cb299645fb371
Change-Id: If1914dbfbefc3501b4d4cef4beb1fae307c36455
2022-11-19 21:21:11 +00:00
Ed Sanders 4bf8955c18 Link inspector: Avoid focussing a input when it isn't visible
Bug: T321026
Change-Id: I4edcf9c0cbe13eac450bc8e05883c7506b8dbfaf
2022-11-18 13:25:40 +00:00
Translation updater bot 4d59bf627a Localisation updates from https://translatewiki.net.
Change-Id: If4f19cd77980b939e5a649d60fdcb7b998fc699f
2022-11-18 09:20:14 +01:00
Translation updater bot 5f9fc0ad10 Localisation updates from https://translatewiki.net.
Change-Id: I3152dd1bc8ec012492b17a03fe704da42ab9d3a8
2022-11-17 08:28:19 +01:00
jenkins-bot a584e73975 Merge "Remove usage of User::isBlockedGlobally and User::getGlobalBlock" 2022-11-16 15:22:09 +00:00
csimiyu 4bdb4917f0 Remove usage of User::isBlockedGlobally and User::getGlobalBlock
Bug: T318898
Change-Id: I727cda9008866b665395cd0e9969c920dc9c28d6
2022-11-16 17:22:17 +03:00
jenkins-bot f805005145 Merge "Collect timing metrics for ParsoidClient" 2022-11-15 13:50:04 +00:00
Translation updater bot 62a93b066a Localisation updates from https://translatewiki.net.
Change-Id: I011e4e5bde6112f0dd809d27e358f4382a630150
2022-11-15 08:24:50 +01:00
daniel 7da2df9724 Collect timing metrics for ParsoidClient
We want to be able to measure how backend performance changes
when we switch from RESTbase to calling Parsoid directly.
We expect to see a performance boost, in particular for
html/to/wikitext, since we avoid the network overhead.

Since we will make the switch by wiki, we need to be able to compare
the metric before vs. after for a single wiki. So, this adds the
wiki ID as a prefix to all existing metrics. Once fully rolled out,
we should get rid of the wiki prefix.

We will need to update the dashboard found at this url:
https://grafana.wikimedia.org/d/000000249/edit-stash?orgId=1

Change-Id: Iac9070b27f4b0d25b0e31c9fad38abc08c433a28
2022-11-15 01:15:28 +00:00
jenkins-bot b9e38dab69 Merge "build: Update mediawiki/mediawiki-codesniffer" 2022-11-14 22:19:34 +00:00
Umherirrender 2ea2796605 build: Update mediawiki/mediawiki-codesniffer
Apply the latest version to libup-canary repo

Change-Id: Ifd3f356f713cc70257c88e7ec6fb8ff608f5f4a9
2022-11-14 22:43:38 +01:00
Umherirrender 4f4549c438 build: Update stylelint-config-wikimedia
Apply the latest version to libup-canary repo

Change-Id: I20fa0d8f30c27e73e90273cb405c5e048d46d927
2022-11-14 22:34:01 +01:00
Translation updater bot 9d8772b07d Localisation updates from https://translatewiki.net.
Change-Id: Iabc7cd99af4fddb799ac35eae1436d867446e8ef
2022-11-14 08:11:33 +01:00
Translation updater bot d47a0b7c3f Localisation updates from https://translatewiki.net.
Change-Id: I7aa5fd1ec34dd787a6e7bf05117ea92096bba43f
2022-11-11 08:42:47 +01:00
Translation updater bot d584c5414a Localisation updates from https://translatewiki.net.
Change-Id: Ib80991107be4535df64d183d40ceec44bb8addf3
2022-11-10 08:13:00 +01:00
Translation updater bot 60227b0b4e Localisation updates from https://translatewiki.net.
Change-Id: Ia39b26cad63b0ada5f433bf85d50d5bf27a1ce26
2022-11-09 08:59:54 +01:00
Translation updater bot c137b51e39 Localisation updates from https://translatewiki.net.
Change-Id: I4631e29409fc513a8f891a6eb329ce2337b41a57
2022-11-08 08:21:47 +01:00
jenkins-bot 82c845d30d Merge "Always allow switching to visual when using DirectParsoidClient." 2022-11-07 23:04:10 +00:00
daniel ea62ee6b19 Always allow switching to visual when using DirectParsoidClient.
When using DirectParsoidClient, switching should be lossless.

Depends-On: I86c611fa0b717ef619e5ffe550b6c2be49a28c99
Change-Id: Ie30ccbc8c12ce48f481b9f727f28e60d21ee37b9
2022-11-07 21:25:27 +01:00
Translation updater bot 1e9a456365 Localisation updates from https://translatewiki.net.
Change-Id: Id2e137fa1b4ed1de20b5f55008a54a309cf60aa6
2022-11-07 08:36:20 +01:00
jenkins-bot 2b5aeaf649 Merge "Improve smooth scroll to section with visual section editing on desktop" 2022-11-06 22:53:44 +00:00
jenkins-bot a46d76bc1e Merge "Platform: Handle invalid JSON in the other path in #getUserConfig" 2022-11-06 22:47:50 +00:00
Bartosz Dziewoński 288159d65c Platform: Handle invalid JSON in the other path in #getUserConfig
I discovered recently that I had 64 KB of text stored in the
'visualeditor-findAndReplace-findText' preference.

I must have accidentally copy-pasted a whole page into the "Find"
field, the JSON that VisualEditor tried to save became invalid after
MySQL chopped off the string after 64 KB, and since then VisualEditor
was unable to update the find-and-replace dialog preferences.

Change-Id: Ib1d853263d873d969c7b015b3842524e1f7fc351
2022-11-06 22:40:40 +01:00
jenkins-bot 74bc24d362 Merge "Use setters to initialize helpers" 2022-11-04 21:20:02 +00:00
jenkins-bot 9cf8d8d205 Merge "Don't log errors due to missing edit buttons" 2022-11-04 19:41:39 +00:00
Bartosz Dziewoński d2bbd0ed76 Improve smooth scroll to section with visual section editing on desktop
Follow-up to 8101b6511e.
$toolbarPlaceholder.outerHeight() only needs to be added when not
using visual section editing.

Change-Id: Idc7d9d59dea9eacbb8ee584c69e6bc4798562ea1
2022-11-04 19:53:43 +01:00