The previous attempt to fix this didn't preserve any attributes
but removing data-parsoid can result in a loss of wikitext formatting.
This reverts commit bdfd4b6d8f.
Bug: T207325
Change-Id: I2a38e651d17262889eddb149c72c9e08b4e56ed0
It was broken on desktop and on mobile, but for different reasons:
Desktop: In change 5f1c68945d,
I removed some code from DesktopArticleTarget that was checking for
`typeof errorDetails === 'string'`. I thought it was unused, but it
was actually needed for this code.
Mobile: overlay.reportError() doesn't work here: that method displays
the error inside the save panel, which is not visible at this point.
This is now solved by treating those errors as if they were API errors,
which is something we were already doing in ArticleTargetSaver.
Change-Id: I5207836f56d65171b1240cef02fc17b9956036ef
Follow-up to 5f1c68945d, which renamed
these messages while moving them into MediaWiki core.
Also, parse HTML in them. This is consistent with real API error
messages, and with the behavior of mw.Api#getErrorMessage. (And also
fixes potential HTML escaping issues.)
Change-Id: I307ca9873e245169a0d4b43499317acbac69fb9b
It was already added for visual diffs inside the editor. This fixes
some minor styling issues, e.g. the arrow after external links is now
shown.
Bug: T244673
Change-Id: I3ea72930ee7822a7579ebe787654d716f5947224
When opening the old wikitext editor, 'wgRevisionId' is always set to
0, and remains that way even if we switch to visual editor.
Elsewhere in the code, we handle this case by reading the revision ID
from the old wikitext edit form, so do that here as well. (This still
works after switching to visual editor.)
Bug: T230133
Change-Id: I9d3a23beb6b1393633b94ac3c9c6c667d7560308
New changes:
99d766aee ve.ce.BranchNode: Force re-applying of selection if tag name changes
d7b6b1650 Unwrap unsupported section tags when pasting
Bug: T243852
Bug: T244109
Change-Id: Id33b4dc4e0dfafcc2414e8b083bc6869964de38f
It turns out anonymous users can't apply change tags, so change
I2c1d0f8d69bc03e5c1877c790247e165f160e966 broke editing for them.
Bug: T242184
Change-Id: I7c27e4d9995428e213a980819810f235fdfe9435
New changes:
fb4f0a83b Completion framework
Local changes to wire in the completion framework
Bug: T232601
Depends-On: If6aee9df67e7a1234d47c0ba0c2f05ef47e5bd51
Change-Id: I075cac9aa195574c3d416a40bbdc5ec2d64424e2
New changes:
07c028575 Require two clicks on link for label editing after closing context item
ff0e814ad update-ooui: Fix link to release notes
0d9bdde76 Update OOUI to v0.36.4
c09049edc Change toolbar border hack to add borders instead of remove them
b888802f5 Rebaser: Bump dependency versions
624ec74b7 Localisation updates from https://translatewiki.net.
Bug: T232003
Bug: T232172
Change-Id: I7a74108c08fced3df33617993e98e39649bb4b41
The message wasn't updated when we changed our minds during the
development of d85d30f9b3. Now the
normal tagging is done in client-side code, so it's effectively
always "suppressed" when calling the API.
Change-Id: Ie75ce31e7c723ff2677e8caa205666f5394405fa
* Changing the 'mode' did not clear the old class, only add a new one.
* Clearing the 'class' or 'style' did not really clear it if the field
was left empty.
Both of these could result in the action not taking effect visually.
* Setting a class unintentionally also removed internal VE classes.
This doesn't seem to have any negative effects at a glance, but it's
probably a bad idea.
Change-Id: I304c222a2c8bc9d35b1cfaee401ab1f815251fde
New changes:
ab2f2ca1a ve.ce.BranchNode: Detach all children first when calling #detach
dae5a8c7e Localisation updates from https://translatewiki.net.
98e69f146 Remove hack to avoid iOS Safari menu bar area tap stealing
Bug: T206278
Bug: T227628
Change-Id: Id9442f433277bb32b7a581286ab3308bb0b16aae
New changes:
c5582eab7 Localisation updates from https://translatewiki.net.
33f0680f2 Always use excludeInsertion when translating table selections
6d9d86720 eslint: Use /mediawiki ruleset
48cf4045e ve.dm.SourceConverter: Add a trailing newline to each full paragraph
Bug: T243606
Bug: T243860
Change-Id: Ib2a2025dea1c393e436c0bad1ad42b6aa8a3717e