Commit graph

8517 commits

Author SHA1 Message Date
Cmcmahon af988015bb QA: update to fix deprecated API token call
Change-Id: Ibad3aa773dcf5390eb7c729a2731ef2fe76b174c
2014-08-27 09:27:52 -07:00
jenkins-bot 323fb9e712 Merge "Remove delete button from required parameters in template dialog" 2014-08-27 10:04:39 +00:00
jenkins-bot 5d482e16af Merge "Make the Resolve conflict button actually appear" 2014-08-27 01:08:44 +00:00
Roan Kattouw 6fce4c6359 Make the Resolve conflict button actually appear
If you got an edit conflict, the save dialog would
dead-end: there was no way for you to actually get to
the edit conflict resolution page because we were
hiding the resolve button.

Bug: 69150
Change-Id: Iaccb7d0ec25d8f15398e437d614184433c33e6eb
2014-08-27 01:06:54 +00:00
jenkins-bot d97d57d106 Merge "Categories: Don't suggest empty or old categories" 2014-08-26 20:00:41 +00:00
Translation updater bot e46bff4afc Localisation updates from https://translatewiki.net.
Change-Id: I4d177742d10d421c0ba834b3e1d34ffead0c0062
2014-08-26 21:53:44 +02:00
James D. Forrester 719acdb42f Update VE core submodule to master (a96cb00)
New changes:
c66e7a8 Update oo#compare usages
bbff57b Followup 8c71904: use getter for availableTools
f9587e8 Add myself to AUTHORS.txt
ffc9358 Localisation updates from https://translatewiki.net.
1025f3b Fix JS error in ce.LanguageAnnotation when dir is set but lang isn't
4ad483f Check IME simulations actually fail as expected
aaa991a Followup bbff57b, 8c71904: use getter for availableTools, again

Change-Id: I5bfa1201f38f2b86234535ed97a1c394d9cf8e58
2014-08-26 09:59:48 -07:00
Derk-Jan Hartman a270fc396d Categories: Don't suggest empty or old categories
The categories table holds all categories that exist OR have at one
point existed. This means it also contains a lot of vandalism and
other inappropriate names that happily come up in the suggestions.
This is undesirable. This changes the query to only list categories
with at least 1 entry.

Though technically it can be argued that an empty category with an
existing page might 'exist' and should thus be listed, with this
change they won't be. I don't think that is terribly incorrect to
say that such would be a 'new category', but we could also consider
renaming the label in the suggestion list to say:
'Currently unused category' or something similar.

As far as I can tell there is no way to test for page existance OR
generate a list based on allcategories with one API query.

Bug: 70025
Change-Id: I0e195d3ce26e69d4710d6a505b9da7d1b7678d92
2014-08-26 11:25:54 +02:00
Alex Monk 11fef44a08 Remove delete button from required parameters in template dialog
Bug: 60358
Change-Id: I5d03f466475bfafd4569480431969f5001365eb8
2014-08-26 01:39:51 +01:00
jenkins-bot aa95f70c4e Merge "Switch 'disallowQuotedKeysInObjects' jscs rule on and fix up" 2014-08-25 18:00:07 +00:00
Translation updater bot 1d7962c619 Localisation updates from https://translatewiki.net.
Change-Id: Ic9fc4852d5cd5f33704f539839698e756c4de173
2014-08-23 22:02:15 +02:00
Juliusz Gonera d074da3558 Add myself to AUTHORS.txt
Change-Id: I905218ed86c0c4c6b164685f4203f19deceacd93
2014-08-22 16:40:12 -07:00
jenkins-bot 8462907ae3 Merge "Do not focus CE on mobile when editor opens" 2014-08-22 22:50:59 +00:00
Ed Sanders 9a1e3852fc Update VE core submodule to master (c231b71)
New changes:
c9f1027 Remove broken ve.isMsie() function
6571da1 Fix case on language annotation CSS class
c231b71 Fix case in all annotation classes

Local changes:
Fix case in all annotation classes

Change-Id: Iba2596cde52d8f8be27e0257893ef8ec77798ae8
2014-08-22 14:27:14 -07:00
jenkins-bot 67877be2a2 Merge "Blacklist plain block images from MW paste" 2014-08-22 21:07:17 +00:00
jenkins-bot ccac83f395 Merge "Don't apply a background to language annotations in IE" 2014-08-22 20:57:21 +00:00
James D. Forrester a232147b11 Switch 'disallowQuotedKeysInObjects' jscs rule on and fix up
Change-Id: I75ac4b378ef485feead9d0eff34ed7877b94b5d0
2014-08-22 13:50:48 -07:00
Roan Kattouw c5281a4e4d Don't apply a background to language annotations in IE
Because doing that makes the text disappear if dir="rtl" is also set.

Bonus: explain why we're changing which nodes to set highlight
opacities on for IE.

Change-Id: I061e372b26a7b523fc1f307ad9897b884803fdf4
2014-08-22 13:34:45 -07:00
Ed Sanders 4af79bf3d5 Re-order methods in MWImageNode
So static methods are actally in the section marked 'Static methods',
before non-static methods, per our coding standards.

Change-Id: I17bea17a1409b02f263375c6434be872e4d239ba
2014-08-22 13:33:08 -07:00
Ed Sanders 57cd852543 Blacklist plain block images from MW paste
Same as inline images, only MW images are allowed.

Change-Id: I0272ebb44c044cd6bcdb85cd5e11d3b50530cc73
2014-08-22 21:31:29 +01:00
Juliusz Gonera 7864de472e Do not focus CE on mobile when editor opens
Extract the part of mw.Target#restoreEditSection responsible for moving
cursor to a separate method and move the cursor only on desktop.

Bug: 68832
Change-Id: I4ffc54ced64ce9e52d0cbcffb2fb4d082239098c
2014-08-22 12:37:00 -07:00
Roan Kattouw 2cf3c8bcd8 Update VE core submodule to master (f1fd9a8)
New changes:
eaa4528 Queue up annotation changes to make operations safer
09fc01f [BREAKING CHANGE] Remove span-wrapping of images
b59f85f Followup b141a7d2: make inspectors not close immediately in IE
1088cac Define kbd font-family explicity in case environment overrides
137add3 Fix embeddable desktop context popups
a2f0f80 Rename getRelativeOffset to getBoundingRect and use in getSelectionRect
fc09114 Fallback to node position when getting selection rectangle
1506099 Change comment to meta in whitespace test case to actually test whitespace handling
7dc4854 Remove global overlay classes when destroying MobileSurface
6e6b08a Update OOjs UI to v0.1.0-pre (d6008381aa)
e0a8089 Destroy WindowManagers in Context and Surface destructors
8c71904 Never embed the context when an inspector is present
163bd50 [BREAKING CHANGE] Rename 'image' to 'inlineImage'
5dd8bad Make focusables behave correctly when $element != $focusable
ba6fba7 Basic block image (figure/figcaption) support

Update changes:
* ImageNode was renamed to InlineImageNode in VE core
* BlockImageNode and BlockImageCaptionNode were added in VE core
* ve.ce.ImageNode.css was removed in VE core

Change-Id: Ide31b47448a4b4d6388f84a7a6ee9d471c1331f6
2014-08-22 11:51:50 -07:00
jenkins-bot 989b7ab684 Merge "Select the correct annotation in MWLinkTargetInputWidget" 2014-08-22 00:15:31 +00:00
Trevor Parscal c446a164b1 Select the correct annotation in MWLinkTargetInputWidget
The solution to this problem was two-fold:
* Initialize the menu selection based on current annotation data
* Don't re-open the LinkTargetInput suggestions menu after choosing

It unfortunately involves assuming that setAnnotation will always synchronously emit 'change' events.

Bug: 65343
Change-Id: Ia92751add5ee59ba581141a31c8433c5e7e521a5
2014-08-22 00:09:53 +00:00
Cmcmahon 0755c16e85 [BrowserTest] language screenshot update
I think I broke this by accident, fixing

Change-Id: I51051fdf71c593bf14ad3fca9a12c554ade5274a
2014-08-21 15:46:53 -07:00
Cmcmahon b9b76bb5e1 [BrowserTest] UI has new text in buttons and headers
Change-Id: Ifb2fac1ec47672751f9a585a2a60827d7981ac00
2014-08-21 14:56:03 -07:00
jenkins-bot 9bd21b6a30 Merge "Remove div-wrapping of block images" 2014-08-21 20:31:26 +00:00
jenkins-bot 80cab577c7 Merge "Remove span-wrapping of link='' images" 2014-08-21 20:31:24 +00:00
jenkins-bot 60808e5d54 Merge "[BrowserTest] add News and Journal to Cite test" 2014-08-21 20:19:19 +00:00
Cmcmahon bc9ecd1d46 [BrowserTest] add News and Journal to Cite test
Change-Id: I86922627de85371e6c5447a92f0671bea42cda5f
2014-08-21 13:17:01 -07:00
jenkins-bot bea941d213 Merge "Followup 67f304a: use .openWindow(), not .open(), to open save dialog" 2014-08-21 19:06:16 +00:00
Roan Kattouw e33bcb02cc Followup 67f304a: use .openWindow(), not .open(), to open save dialog
Calling .open() directly doesn't work any more.

Change-Id: I986ad063f7b83992a8f96969ccb5f7e08fb9f386
2014-08-21 12:00:40 -07:00
Bartosz Dziewoński 8bb55d683b mw.ViewPageTarget: Be more careful when updating page title
If there is more than one span in #firstHeading, we only want to
update the first one.

This will still break if something inserts elements *before* the title
span, but fixing that would take more thought (we probably should
rebuild the entire heading element and fire 'wikipage.content' on it).

Bug: 69857
Change-Id: Id78b9b8275a57c9b3f3f1dbd0aaca356f94d0f03
2014-08-21 18:36:01 +02:00
jenkins-bot 0af7c2d634 Merge "Correct MWImage* resource regex to find literal .s rather than characters" 2014-08-21 02:07:50 +00:00
jenkins-bot da5191ce01 Merge "Re-label inserting mode of transclusion dialog from "New template" to "Add a template"" 2014-08-21 02:07:21 +00:00
jenkins-bot 30bccf6ce3 Merge "Only build reference search index when it's been changed" 2014-08-21 01:56:06 +00:00
jenkins-bot df85006b03 Merge "Refactoring ImageModel constructor" 2014-08-21 01:54:46 +00:00
James D. Forrester 1e68d0cb5e Re-label inserting mode of transclusion dialog from "New template" to "Add a template"
Bug: 69692
Change-Id: Ia762d35117b01a908e04cf4b7ac1582f3d148f6f
2014-08-21 01:52:23 +00:00
James D. Forrester 67f304a414 Update VE core submodule to master (c4ce5ee)
New changes:
c4ce5ee Update OOjs UI to v0.1.0-pre (466a8762ac)

Update changes:
* Remove manager arugment from window constructors
* Use this.$content instead of this.frame.$content
* Use this.getDir() instead of this.frame.getDir()
* this.loading is now a promise, not a boolean

Change-Id: Ia83449a60078dd24ea4f976221c0859e5a121279
2014-08-20 18:42:52 -07:00
James D. Forrester 5148a0836a Rename "reference list" to "references list" internally
That's what we call them in human-speak, and it makes sense to have them align.

Bug: 49923
Change-Id: I8dcfba249fb9ea13c2b4052e98a4d253c302b1ba
2014-08-20 18:26:54 -07:00
James D. Forrester 7d3f9797c0 Correct MWImage* resource regex to find literal .s rather than characters
Change-Id: Ie5db0b4b6cdb607985b53228c4ceb26c57af9dfc
2014-08-20 18:16:13 -07:00
Moriel Schottlender 88a0790aab Refactoring ImageModel constructor
This change creates the scalable object that's attached to the image
model through its constructor. Also adds a 'resourceName' variable
to store attributes.resource, which is mostly used for API calls.

Change-Id: I713c59d1cec5f87387a87c98a59e75b3d5c1050e
2014-08-20 18:13:12 -07:00
James D. Forrester 54f609324f Update VE core submodule to master (59a25cb)
New changes:
5e35cc0 ve.Filibuster: Scrupulous state logging
82961d0 Re-sync bin/update-oojs.sh with equivalent script in MediaWiki core
2b540a7 Don't blank .static in ve.dm.Document
cfbb0e6 Update OOjs to v1.0.12
59a25cb Update OOjs UI to v0.1.0-pre (944c47c5fe)

Change-Id: I4713b73a7897c54da30db32db0ac66e8bcc1b208
2014-08-20 17:42:52 -07:00
James D. Forrester 97c0894379 Label 'insert' buttons with just "Insert" instead of varying by content
Depends on VE-core change I23b0772a

Change-Id: Ia8fb88d3501ffa2c26add4419da5463a926f45d1
2014-08-20 14:23:57 -07:00
Roan Kattouw c4b7d2ca95 Update VE core submodule to master (c6085d9)
New changes:
449ecfa Fix check for left/right annotations
41d85fd Label 'insert' buttons with just "Insert" instead of varying by content

Local changes:
* Add new message to VisualEditor.php

Change-Id: I61fe1bc0fd4d7ac1736f1b182b54a631bcad10ed
2014-08-20 14:11:46 -07:00
jenkins-bot f7d621e498 Merge "Update VE core submodule to master (d515ce6)" 2014-08-20 21:08:37 +00:00
jenkins-bot 50bedc69d3 Merge "Bring MWTransclusion example data out of the stone age" 2014-08-20 21:08:22 +00:00
James D. Forrester d1ef4fd01c Update VE core submodule to master (d515ce6)
New changes:
c600eb4 Ignore whitespace when generating paste context
3b1b740 Add an event to updating current values in scalable
5140616 Add description to title attribute of focusable highlight
6df8830 Default dimensions to null, not empty objects
d515ce6 Update OOjs UI to v0.1.0-pre (51f513f9d3)

Change-Id: Ie2446b4a767cb56de392f8f0315d0289fe6da570
2014-08-20 13:55:39 -07:00
Roan Kattouw c43dc5e362 Bring MWTransclusion example data out of the stone age
The example data still used the old format for data-mw that predates
support for multi-template transclusions in Parsoid. The old format
has now been retired, and any attempt to interpret it will cause
JS errors.

Also removed data-parsoid from most of these examples while I was
at it.

Change-Id: I2b7816b7edc580cec0ed29fb166458351a0c6ed3
2014-08-20 13:54:46 -07:00
Translation updater bot 1febff3e78 Merge "Localisation updates from https://translatewiki.net." 2014-08-20 20:37:05 +00:00