Commit graph

21420 commits

Author SHA1 Message Date
David Lynch d2899153ea Phan wasn't checking the editcheck includes
Have to ignore some calls to AbuseFilter/SpamBlacklist rather than
adding those extensions to directory_list because those extensions don't
pass checks themselves.

Change-Id: If3db9df8a49d8319b08695410a056e1d8e068c15
2024-06-08 13:55:43 -05:00
C. Scott Ananian 6bb86cbaaf Remove use of deprecated HtmlInputTransformHelper::init() method
Depends-On: I1e1213597c6be012f2bc024c2b370c968ff3b472
Change-Id: I8b5cd59f839446709ffd0ce1b78c1bba40195ae0
2024-06-07 21:40:10 +00:00
Jan Drewniak 2fc809dc17 Replace hardcoded colors with Codex design tokens
Replaces hardcoded color hex values with their equivalent
values from Codex, via the "mediawiki.skin.variables" system.

Bug: T366197
Change-Id: Ia929a1a8d6351222acb454c8ec750e920ae6d072
2024-06-07 14:40:07 -04:00
jenkins-bot 4b1622f68b Merge "getTargetDataFromHref: catch error if passed invalid URL" 2024-06-07 10:21:18 +00:00
Translation updater bot d0b99c7144 Localisation updates from https://translatewiki.net.
Change-Id: Ie70043ca98d1656cbc2f2752102841299fd7d7ab
2024-06-07 09:47:01 +02:00
David Lynch b10fb53f8c getTargetDataFromHref: catch error if passed invalid URL
Could trigger this by typing `https://` into the internal link
annotation inspector.

Bug: T366822
Change-Id: Ie58ded247dbfb6c001d8177953ea148cd82ec03d
2024-06-06 10:57:35 -05:00
Ed Sanders 0378be0f27 eslint: Remove no-op config
Change-Id: Ibacf810f0d31c0aada34d3c6ca84007db506017d
2024-06-06 16:36:51 +01:00
Ed Sanders 0a23f31227 SurfaceFragment tests: Put isolateAndUnwrap tests in a loop
Change-Id: I8791da02a91f5ddc801290121031dde290883d6c
2024-06-05 17:50:29 +00:00
Ed Sanders 291844dbee build: Update stylelint-config-wikimedia to 0.17.1
Change-Id: I8e0f087ae3d2644df85a85791b9c49c09567c0f4
2024-06-05 18:47:49 +01:00
Ed Sanders a3d4388bc1 Follow-up Ic9fad12fe: Move .css file to .less
MWCategoryWidget was converted to LESS syntax but wasn't
moved in the previous commit.

Change-Id: Ifd3e6228b96872ba40fa6d8db1617fb65b781dc0
2024-06-05 18:40:36 +01:00
C. Scott Ananian 443e67c5c1 Remove use of deprecated HtmlOutputRendererHelper::init() method
Depends-On: I1e1213597c6be012f2bc024c2b370c968ff3b472
Change-Id: Id63d93db801d0bfb3fdb4c69bf7dfeea4e68ea8f
2024-06-05 12:22:29 -04:00
Translation updater bot 3bc0b9b1b8 Localisation updates from https://translatewiki.net.
Change-Id: I7ab69d3c6dfb1f3e2ffa275066617e8cdbd239b9
2024-06-05 09:24:19 +02:00
jenkins-bot 9a73262215 Merge "Turn property into const in ResourceLoaderData class" 2024-06-04 18:48:04 +00:00
jenkins-bot 2c7607ce94 Merge "Fix type hint in ApiVisualEditorEdit" 2024-06-04 18:44:00 +00:00
jenkins-bot 932df6759e Merge "Add type declarations and remove redundant PHPDoc tags" 2024-06-04 18:24:54 +00:00
Bartosz Dziewoński cc096f1bb8 Fix "implicit-arrow-linebreak" ESLint violation
Change-Id: I61bbfb0762438927c0f7bd5b8e8bf1365861d909
2024-06-04 18:58:25 +02:00
thiemowmde 1d449787ef Add type declarations and remove redundant PHPDoc tags
Most of this code was already typed, but not everything. Using
language-level type declarations allows us to remove extra PHPDoc
blocks that just repeat the same information.

I'm also using the more narrow UserIdentity instead of User in a
few places where this is possible.

Change-Id: I7661824fcb34180af1a4fd3030fcd6c0b7d34089
2024-06-04 16:55:00 +00:00
jenkins-bot 81a1c990e0 Merge "build: Updating eslint-config-wikimedia to 0.28.0" 2024-06-04 13:53:03 +00:00
jenkins-bot 595db906cc Merge "MWExtensionDialog: Fix documentation of confirmAbandon" 2024-06-04 10:57:59 +00:00
jenkins-bot 132606f01d Merge "Localisation updates from https://translatewiki.net." 2024-06-04 07:34:06 +00:00
Translation updater bot f81e2335de Localisation updates from https://translatewiki.net.
Change-Id: I7d60f54f2794777308632eea5afa39c16fd52bf8
2024-06-04 09:32:58 +02:00
jenkins-bot 0e5882b4d5 Merge "MWTemplateTitleInputWidget: Fix unstable sort affecting Firefox" 2024-06-04 07:31:38 +00:00
libraryupgrader 702677220d build: Updating eslint-config-wikimedia to 0.28.0
The following rules are failing and were disabled:
* modules/ve-mw/tests:
  * implicit-arrow-linebreak

Change-Id: If857233c0de24c8cf619dbb1347ebb375f3ab1ba
2024-06-04 03:40:00 +00:00
James D. Forrester 7789b55666 build: Upgrade stylelint-config-wikimedia and grunt-stylelint for stylelint 16
Change-Id: I19ee70def0180bb8504d47b4a65e1e817d9cffcd
2024-06-03 13:07:16 -04:00
Translation updater bot d6a487113d Localisation updates from https://translatewiki.net.
Change-Id: I2e28790004ebaca53f066f7bde83e684ad97cc42
2024-06-03 09:33:32 +02:00
Ed Sanders 1274d03c5d Update VE core submodule to master (4e956f400)
New changes:
c82195c52 JSDoc: convert @cfg to @param
204f48a3e ve.ui.FindAndReplaceDialog: Use flexbox instead of tables
9205fbc97 Tests: Use spread syntax on string literals
84be2efbd Avoid Array.concat
4e956f400 Localisation updates from https://translatewiki.net.

Bug: T250843
Change-Id: Ic68fd49b00d87306a264f4a2d31cbe8955b03f16
2024-05-31 18:42:08 +01:00
Timo Tijhof ad6e0e332e MWTemplateTitleInputWidget: Fix unstable sort affecting Firefox
I'm going to assume the order in production with Chrome, as asserted
by the unit test, is the preferred order whereby negative numbers are
intended to be prepended before the positive numbers.

This came up in I6ecbd5743f3e, where this was the only unit test across
MediaWiki core and WMF gated extensions, that fails in Firefox.

It is reproducible locally with plain MW core + VisualEditor as well.

Bug: T366299
Change-Id: I6f8546e6e604cbb41e11bd2b59f8b5f19350c676
2024-05-31 17:12:29 +01:00
Translation updater bot 74ab74376f Localisation updates from https://translatewiki.net.
Change-Id: I1f4e29585832d90a6ae8c3afb038231b28e8c7ed
2024-05-31 09:57:44 +02:00
Translation updater bot baea7baab2 Localisation updates from https://translatewiki.net.
Change-Id: Ic6face4d35fc68db5f958c367d0b46dee6ada61f
2024-05-30 09:37:44 +02:00
jenkins-bot 8e4d4959fc Merge "Avoid Array.concat" 2024-05-29 22:02:03 +00:00
Ed Sanders b9b966de6e Avoid Array.concat
See I9addf43b2857de7bcac.

Change-Id: Ic1998ab6f7dedf6946d7ae63a985a76031f8eecf
2024-05-29 21:16:25 +01:00
jenkins-bot 66c6fa294c Merge "Change confirmation behaviour when abandoning template edits" 2024-05-29 16:58:43 +00:00
Translation updater bot e089bb4911 Localisation updates from https://translatewiki.net.
Change-Id: Ib7d2781895091d4c2323ff4e790e0d686552e974
2024-05-29 09:32:42 +02:00
jenkins-bot 28fae02c8b Merge "Tests: Use spread syntax on string literals" 2024-05-28 19:39:59 +00:00
jenkins-bot 8990a273e7 Merge "Update VE core submodule to master (e3298c4a5)" 2024-05-28 19:37:16 +00:00
jenkins-bot 48823cad4b Merge "JSDoc: convert @cfg to @param" 2024-05-28 15:13:20 +00:00
jenkins-bot f41d5740c1 Merge "Consolidate minor code duplications in DiffPage" 2024-05-28 15:12:39 +00:00
jenkins-bot c3204463de Merge "Remove redundant elements from Unicode-enabled regex" 2024-05-28 15:11:37 +00:00
Zoë 3c6f0a918c Change confirmation behaviour when abandoning template edits
Previously, it was possible to close a dialog with active edits by
pressing the "<" button or pressing escape. A change was made to confirm
the user's intent before abandoning their changes, see Ia8935b5b1acb

This patch fixes a bug where the user's intent is always confirmed while
editing a template, even if the user has made no changes. This was
because for technical reasons we trimmed whitespace before making a
comparison with the new template case, but that caused the comparison
with the edit case to always fail because existing templates are padded
with whitespace.

This could have been solved by moving the trim operation into the new
template flow. This patch would still have been necessary to prevent
a bug if the default value had trimmable whitespace. I have opted to
keep the whitespace behaviour for edits for consistency.

Bug: T334513
Change-Id: I7b3370c86df67c36fc63a1f1d0e7004a098a1950
2024-05-28 15:49:19 +01:00
Translation updater bot 5d42b0dc4e Localisation updates from https://translatewiki.net.
Change-Id: Ibce2d79bec7f603d0eaf15bb24ea60eab95b9567
2024-05-28 09:31:37 +02:00
Translation updater bot adaf850420 Localisation updates from https://translatewiki.net.
Change-Id: I7a7a57812ac174ae50f16531fffaf8ed17e72019
2024-05-27 09:30:17 +02:00
Novem Linguae 9ffbfc77cd JSDoc: convert @cfg to @param
Bug: T250843
Change-Id: I53ef4fa4a65b017eec90cc1f2cbb7e7f0681e317
2024-05-26 21:59:02 -07:00
Ed Sanders 155549ab60 Tests: Use spread syntax on string literals
Because `...'Foo'` is more legible than `'F', 'o', 'o'`.

Change-Id: I09ac584ee79b8f89c48f135182e60d7fb1b54557
2024-05-24 22:23:42 +01:00
Bartosz Dziewoński b498d2bfd3 Update VE core submodule to master (e3298c4a5)
New changes:
7ff4a9eac Use arrow functions in tests
2d0800ea6 Tests: Use variadic args
f399101cf ve.ce.TestRunner: Fix return type documentation
e29d42433 Allow ES2018 syntax in tests
f675c0ad7 Test: Use (assert,caseItem) signature for test runners
adc47cb9b Localisation updates from https://translatewiki.net.
88abebb2b Update OOUI to v0.49.2
b4c8921aa build: Updating grunt-banana-checker to 0.13.0
7c31e4f25 Run TableAction/ListAction tests with a full view
24340c13b Localisation updates from https://translatewiki.net.
8ae691114 ESLint: Autofix no-var violations
043558ab3 ESLint: Manually fix remaining no-var errors
5f88cf5eb Move let/const declarations closer to usage
06b7b0da8 ESLint: Enforce prefer-const
4c654dca5 Prefer arrow callbacks in build, collab, demos & rebaser
e3298c4a5 Remove unnecessary context variables

Bug: T365052
Change-Id: I9e8e6287ca077e21f74bd4fbd8d9c0993cceb653
2024-05-24 22:05:05 +02:00
thiemowmde 3a7d345093 Remove redundant elements from Unicode-enabled regex
Same as in If6c7e85 in the TemplateWizard codebase. [a-z] is already
part of \p{L}, and [0-9] is part of \p{N}.

Change-Id: I8008ac7e504739b8f4b5fb5dd732b0deca20cefc
2024-05-24 15:47:02 +02:00
thiemowmde e867a49a69 Consolidate minor code duplications in DiffPage
Change-Id: I4969616c75cf201dde1094715ccbb796a92c1d92
2024-05-24 15:45:20 +02:00
thiemowmde c3953814e4 Fix typos and outdated links in comments
That property in the magic word class doesn't exist any more.

Change-Id: Ife275944bd1c8dec603bd01dea6075ad36acf59e
2024-05-24 15:40:01 +02:00
Translation updater bot a8d1907e69 Localisation updates from https://translatewiki.net.
Change-Id: I4413677d60eb0325c1d916a6be452d04b4ceb157
2024-05-24 09:44:34 +02:00
jenkins-bot c1b3daddb1 Merge "ESLint: Re-enable prefer-const and fix" 2024-05-23 16:17:38 +00:00
jenkins-bot c003151db5 Merge "ESLint: Enforce no-var and autofix" 2024-05-23 16:17:37 +00:00