Commit graph

21420 commits

Author SHA1 Message Date
Bartosz Dziewoński 8ec439d417 Remove handling of Minerva edit links
After the other changes in T346944, desktop Minerva can display
multiple edit tabs and section edit links without these hacks.

Bug: T346944
Change-Id: I3721f9387303386493664366988961242a26dba5
2023-10-24 03:27:09 +02:00
Translation updater bot bc1df07882 Localisation updates from https://translatewiki.net.
Change-Id: Ic6f9a113df466d621b30612b250042426d572160
2023-10-23 09:51:43 +02:00
jenkins-bot 6d2020fa0a Merge "Link EditCheck activated tag to false positives reporting page" 2023-10-20 16:01:37 +00:00
Ed Sanders 4bb80d4031 Link EditCheck activated tag to false positives reporting page
Bug: T349264
Change-Id: I92718b2ff45597e53dfb5ab74a34dea108f072ce
2023-10-19 13:52:25 +01:00
Translation updater bot ba3229a943 Localisation updates from https://translatewiki.net.
Change-Id: I0e0f2c57ff4ca316bae871b0c60606b98c7f25c3
2023-10-19 08:44:14 +02:00
jenkins-bot 8049f0ee28 Merge "Update VE core submodule to master (8328d7330)" 2023-10-17 14:32:43 +00:00
jenkins-bot 7601bcd9f3 Merge "Gallery image nodes: fall back to alt attributes in container mw-data" 2023-10-16 18:59:32 +00:00
David Lynch c65662ebfc Gallery image nodes: fall back to alt attributes in container mw-data
Video thumbnails have no alt attributes, and so we were causing dirty
diffs in any edit of a page that had a gallery containing a video.

Bug: T348703
Change-Id: I02ea8421e468635ba6297bb5cda488a5a79c9a1d
2023-10-16 11:58:50 -05:00
David Lynch 5dc7179d95 Update VE core submodule to master (8328d7330)
New changes:
5982328d9 DiffElement: Remove unnecessary duplicate variable
7ab6f7500 Localisation updates from https://translatewiki.net.
8328d7330 Fragment inspector: Don't apply padding to hidden panels

Bug: T348994
Change-Id: I9cfba6c2f28217ddb9191bd7d1eebb71e99ce2d4
2023-10-16 11:15:45 -05:00
Translation updater bot 1d267e1db8 Localisation updates from https://translatewiki.net.
Change-Id: Id9a017fb93736280210466b03f49258228d62d1d
2023-10-16 09:16:50 +02:00
jenkins-bot 6e34b3b730 Merge "Use options-messages to delay message parsing on Special:Preferences" 2023-10-13 23:37:16 +00:00
Umherirrender 4cc8926974 Use options-messages to delay message parsing on Special:Preferences
This also removes double escaping from the messages as 'options'
for type = select gets escaped by the html form

Change-Id: I31cc19cbe1f6e61849f3ff806e53a14082e06849
2023-10-13 22:12:02 +02:00
jenkins-bot a06398c685 Merge "Don't try to update tab text if a custom message is incompatible" 2023-10-13 15:31:36 +00:00
jenkins-bot ed18e0480a Merge "Fix handling of 'edit-local' and 'create-local' messages" 2023-10-13 15:31:12 +00:00
jenkins-bot a664de74f2 Merge "Change icon for supported skins for section edit links, too" 2023-10-13 15:29:12 +00:00
jenkins-bot 0e370a84cd Merge "Remove 'VisualEditorTransitionDefault' and AutodisableVisualEditorPref.php" 2023-10-13 15:27:59 +00:00
jenkins-bot b6af32f5e6 Merge "Exclude node_modules directories from phpcs" 2023-10-13 13:09:25 +00:00
Ed Sanders b30b886bf1 Update VE core submodule to master (9deab94e2)
New changes:
fce188dd0 Localisation updates from https://translatewiki.net.
2c64caab0 Use white-space:break-spaces where appropriate
07a9fd1fb Strip bold from headings when pasting
a310aac44 Localisation updates from https://translatewiki.net.
9deab94e2 Fix logic for unwrapping wrapper paragraphs next to inline nodes

Bug: T348006
Bug: T348467
Change-Id: I3930c712ddcd152d0149c0e0b272f52c880028f1
2023-10-13 10:22:37 +01:00
David Lynch 099e7a80c4 Exclude node_modules directories from phpcs
The `flatted` module in lib/ve/node_modules includes some php files that
keep causing errors.

Add the --cache just because it seems to be common practice in other MW
extensions.

Change-Id: Ia791e569587d76e991711b93011cb1df3796f532
2023-10-12 16:52:22 -05:00
Bartosz Dziewoński a60b3719f6 Don't try to update tab text if a custom message is incompatible
Some wikis customize messages, e.g. 'skin-view-create-local', in ways
that are not compatible with the client-side message parser.

Bug: T306807
Change-Id: Ie2f2ba4bba3b5b6f4fd6dbed6773d87f096a8944
2023-10-12 21:01:39 +02:00
Bartosz Dziewoński fa889154c2 Fix handling of 'edit-local' and 'create-local' messages
* Remove incorrect overrides in VisualEditorTabMessages. Since
  I44bd632682d5cc52b2660ad72a492f95a04be36e, the interface should use
  'skin-view-edit-local' and 'skin-view-create-local' respectively.

* Fix the fallback mechanism in DesktopArticleTarget.init.js
  to handle these keys correctly.

Change-Id: I7dad7e3a6fb920c5caf175e0e7500fd0c4b4d0ae
2023-10-12 20:05:06 +02:00
Translation updater bot e485fa0a6c Localisation updates from https://translatewiki.net.
Change-Id: Id34913501f7cd45264f9021594b8bea9e61a8433
2023-10-12 09:30:12 +02:00
Translation updater bot f40a487360 Localisation updates from https://translatewiki.net.
Change-Id: Ia2b9ab188d30ef3ee1953774c054470dc3ae2bd8
2023-10-11 08:46:30 +02:00
Translation updater bot d54f6459e1 Localisation updates from https://translatewiki.net.
Change-Id: If46b98030d4a01ec5646a4f6ab6e5710fdfdc629
2023-10-10 08:53:08 +02:00
Bartosz Dziewoński 137914de28 Change icon for supported skins for section edit links, too
Bug: T346944
Change-Id: I4653671ccb2bba2da3940897371d7dfac4bbd0f2
2023-10-09 20:13:24 +02:00
jenkins-bot 9ac3b2cff5 Merge "Edit check: avoid a hardcoded "continue" in the rejection dialog" 2023-10-09 16:50:47 +00:00
jenkins-bot 69d124756c Merge "Disable $wgVisualEditorUseSingleEditTab on mobile site" 2023-10-09 15:34:52 +00:00
David Lynch 9ed539235c Edit check: avoid a hardcoded "continue" in the rejection dialog
Change-Id: I6a771dd6a7508fc44c1d8c67812d6b4b6111cb7a
2023-10-09 10:02:19 -05:00
Translation updater bot 4e1e1cb994 Localisation updates from https://translatewiki.net.
Change-Id: I08e99c5a530327488be60205a97276660c6444b6
2023-10-09 08:57:21 +02:00
David Lynch 87145e818a Edit check: stop an error on save if no reference-needing content added
saveProcessDeferred will only exist if content was actually added. This
wasn't causing any functional issues, just an error in the console after
you save.

This issue was introduced via I1dccc3c.

Bug: T344382
Change-Id: Icb0c29b64d960308343ddbb3f9d2ee641552b814
2023-10-07 17:47:53 +00:00
Jon Robson bc4c367bba Disable $wgVisualEditorUseSingleEditTab on mobile site
Bug: T348353
Depends-On: I92f7c2c5f4691bd511219432c53379ddd928eae2
Change-Id: I3108f884173526f95d86d975d7421b4af1cff447
2023-10-06 16:29:48 -05:00
Umherirrender b8a85b50db build: Restore .phan/config.php
Got lost in c180c2f5

Change-Id: Ic30632604bb80d739f0913515a507b97ccbfa67f
2023-10-06 16:51:51 +02:00
Translation updater bot 5cdb12b5e1 Localisation updates from https://translatewiki.net.
Change-Id: Ib1ec48a074a132eb4ede3bcc88ed5ded51964fba
2023-10-06 09:21:57 +02:00
jenkins-bot d3b933726e Merge "config: Mention ecenable in edit check config" 2023-10-05 14:50:10 +00:00
jenkins-bot 61f3414a49 Merge "DesktopArticleTarget.init: Remove code for updating edit links" 2023-10-05 13:44:34 +00:00
Translation updater bot 1ff766d01d Localisation updates from https://translatewiki.net.
Change-Id: Id5c359aed309d9a1bdacf705e9e64ed3ee9bd500
2023-10-05 09:12:43 +02:00
Bartosz Dziewoński be36f1fab1 DesktopArticleTarget.init: Remove code for updating edit links
This JS code duplicates the PHP implementation in VisualEditorHooks
in order to allow changes to the configuration of edit tabs
(e.g. wgVisualEditorUseSingleEditTab and wgVisualEditorTabPosition)
to take effect for logged-out users immediately, without waiting
for the HTML caches to clear.

It was worthwhile 10 years ago when VisualEditor was being rolled out
to new wikis or reconfigured daily, but it is not today when we hardly
ever change these settings.

It proved difficult to maintain as the skins change, it has several
known bugs (T292125, T306807, T346944), and probably several more
unknown ones, given that it hasn't been tested in about 10 years.

Let's remove it and save ourselves the headache. (Also also reduce the
amount of code we ship on all page views by almost a kilobyte.)

Bug: T292125
Bug: T306807
Bug: T346944
Change-Id: Ib82f5402872a2429445463a1e1ef92806d3326f9
2023-10-05 03:11:40 +02:00
jenkins-bot 86fb65ba90 Merge "Change icon for supported skins when both VE and source edit icons are present" 2023-10-04 23:20:19 +00:00
Jon Robson 47815e9d2b Change icon for supported skins when both VE and source edit icons are present
This introduces an extension attribute EditIconSkins which allows extensions
or skins to request the rendering of edit icons.

This will be used by Minerva in I3c9d59f49f1b939981a7b2b450448db6736d5958

Bug: T346944
Change-Id: I401805224c0f387ac85b52b50c1f298b83c03a91
2023-10-04 22:16:13 +00:00
Translation updater bot c066dc745a Localisation updates from https://translatewiki.net.
Change-Id: I6f6c46192e404a30cbf8a103eac20383f91330b2
2023-10-04 09:09:22 +02:00
jenkins-bot 8c21352cd5 Merge "Fix wikitext mixed toggling" 2023-10-03 21:31:20 +00:00
hmonroy 3e223bdf52 Fix wikitext mixed toggling
Allow Core to handle the toggling for Wikitext when the inline switch is
present to avoid duplicated functionality.

Bug: T345836
Bug: T346213
Bug: T346299
Depends-On: Ib88836f13cdb5cd2344e3ba12f6c942baa0fc1f1
Change-Id: I3bb9fcabe17a20c9934274766e3335f63d51aac4
2023-10-03 16:15:37 +00:00
Ed Sanders 70c116a17a Edit check: Simplify "experience" config to "maximumEditcount"
There's no product need for anything other than an upper limit
on edit count. If one arises in the future we can adjust accordingly,
but better to keep the JSON, and any UI implementation, simple
for now.

Change-Id: I892847ad78b19695f0f0f664002d3c566f7806de
2023-10-03 16:20:51 +01:00
Translation updater bot 47dc22d6c0 Localisation updates from https://translatewiki.net.
Change-Id: I33a2510f8dcc7b2ff9f05867839b7e5ea1fe3d23
2023-10-03 09:33:33 +02:00
David Lynch 177f07a759 Update VE core submodule to master (ca5f6c26d)
New changes:
ff87fe63c TableNode: Remove hack for ancient browser (FF39)
45516acbd Remove ve.isPassiveEventsSupported
f1cc17fb3 ve.ce.Surface: Remove IE support in copy/paste code
59b572c89 Localisation updates from https://translatewiki.net.
ab2524e41 RebaserTarget toolbar: use findIndex
599ffff20 Localisation updates from https://translatewiki.net.
b6b0b2f01 Localisation updates from https://translatewiki.net.
1c5dce24a build: Update linters
64fa7d401 Localisation updates from https://translatewiki.net.
8e6468945 Localisation updates from https://translatewiki.net.
169f721fc Localisation updates from https://translatewiki.net.
81d298f58 Localisation updates from https://translatewiki.net.
22527ef88 Localisation updates from https://translatewiki.net.
5560459a3 Only log context-shows if they're on a non-null fragment
b8cab4086 .gitreview: Swap to track=1
629b48057 Localisation updates from https://translatewiki.net.
2a2665a0d Localisation updates from https://translatewiki.net.
506d4c01f ve.repeatString: Use native implementation
c6dcc87b3 Localisation updates from https://translatewiki.net.
8cf97e8c8 ChromeHeadless: Do not pass a spurious empty flag
61990513c Provide alternate keyboard shortcut for toolbar search for mac Firefox
ca5f6c26d Localisation updates from https://translatewiki.net.

Bug: T324735
Bug: T341603
Bug: T347380
Change-Id: Ic1172a3eee32f688f2fab32a3a8eaf6dc829e600
2023-10-02 16:46:25 -05:00
Translation updater bot d6e9e9af06 Localisation updates from https://translatewiki.net.
Change-Id: I4a17e4464c6d0fae1a737003dabb7d75408515a0
2023-10-02 10:58:37 +02:00
jenkins-bot 9ce1a1d44e Merge "build: Upgrade grunt-banana-checker from 0.11.0 to 0.11.1" 2023-09-28 07:27:22 +00:00
Translation updater bot 63d4d6966b Localisation updates from https://translatewiki.net.
Change-Id: I23a7e91c0da62b69512585da8ad4187e108a1309
2023-09-27 09:21:21 +02:00
jenkins-bot de9b3936b8 Merge "Update comment w/ rename of Article::getRedirectHeaderHtml()" 2023-09-26 19:35:23 +00:00
James D. Forrester c7ee116f07 build: Upgrade grunt-banana-checker from 0.11.0 to 0.11.1
Change-Id: I9390d6f36ef029b0a29126421b4647948bac7147
2023-09-26 14:39:59 -04:00