Commit graph

10966 commits

Author SHA1 Message Date
James D. Forrester 2368171fb7 DesktopArticleTarget: Consolidate editor preference setting code
Change-Id: I82e3975233eee0473b513d0931a2d6770fc0f86d
2015-12-11 17:12:28 -08:00
jenkins-bot 580605c418 Merge "Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks" 2015-12-12 00:31:34 +00:00
jenkins-bot 94ac79bc87 Merge "Remember switching into VE from WT when discarding changes" 2015-12-12 00:28:51 +00:00
Alex Monk 0774bdf924 Try to clean up the WT->VE prompt opened -> closing -> closed data callbacks
To use
	.then( function ( opened ) { return opened; } )
	.then( function ( closing ) { return closing; } )
	.then( function ( data ) {
etc. instead of nesting them in .done functions

Change-Id: Ic8cee9639b90cb378ce0b7e58dc04eab0ff4cbc7
2015-12-11 23:43:13 +00:00
jenkins-bot 8e4f888274 Merge "Check that we really want VE before loading it for section edits" 2015-12-11 23:40:10 +00:00
Alex Monk 155d0240a4 Remember switching into VE from WT when discarding changes
Bug: T120966
Change-Id: I9a7b87cb2561416b72f53afa5140e9d2a4330cfe
2015-12-11 23:35:59 +00:00
jenkins-bot c98e6d1390 Merge "build: Update various devDependencies to latest" 2015-12-11 23:25:21 +00:00
Alex Monk 9e5a01aa6b Check that we really want VE before loading it for section edits
Bug: T121189
Change-Id: I34371bf78d34e9d362e9cf5c64bdd108478969b9
2015-12-11 23:19:07 +00:00
Translation updater bot e71f1d67d6 Localisation updates from https://translatewiki.net.
Change-Id: Ife97e1435802802dfeb7754fcea6874433bc6b0d
2015-12-11 23:56:38 +01:00
James D. Forrester 90045db7a3 build: Update various devDependencies to latest
* grunt-contrib-copy     : 0.8.0 -> 0.8.2
* grunt-jsonlint         : 1.0.4 -> 1.0.6
* grunt-jscs             : 2.1.0 -> 2.5.0

Change-Id: Ia66996d4ccf48bb8baab792fda5cd67863b31575
2015-12-11 12:59:17 -08:00
jenkins-bot e24e2ed7cf Merge "[BREAKING CHANGE] Create ve.init.mw.Target base class" 2015-12-11 18:16:22 +00:00
jenkins-bot 2e6719c0d7 Merge "Use upstreamed actionGroups functionality" 2015-12-11 18:09:50 +00:00
Ed Sanders aa2e0af348 Update VE core submodule to master (19e50b7)
New changes:
e536779 [DEPRECATING CHANGE] Rename link inspector tools
3899967 Localisation updates from https://translatewiki.net.
0a1c09e [BREAKING CHANGE] ve.init.Target: Upstream the action toolbar from sa/mw desktop targets

Local changes:
* Refactor tools for the breaking change

Change-Id: I676af9c50b09ef007926240eb2327d1a0fdd80f5
2015-12-11 10:03:02 -08:00
Ed Sanders fbb05fb8ed Use upstreamed actionGroups functionality
Depends on I272175dff3 in ve core.

Change-Id: I94cef0f3d8c1b903780890934c2c4963cbe05989
2015-12-11 16:43:48 +00:00
Ed Sanders 21d5856000 [BREAKING CHANGE] Create ve.init.mw.Target base class
Move over logic which isn't specific to the article
implementation of VE (e.g. nothing related to loading/saving).

Refactors setupSurface to use an abstract tracking method (which
does nothing by default), and moves surface CSS classes to #createSurface.

Breaking change:
* Rename onSurfaceReady to surfaceReady. We shouldn't need to listen
  to our own events.
* Rename onReady to documentReady. onReady is not a listener.

Bug: T97166
Change-Id: I7242b1bb5501b7755a18a13d13e166c30cac9cdd
2015-12-11 16:41:47 +00:00
Ed Sanders 672c91f41b DesktopArticleTarget: Fix signature of editNotices
Also ensure it is always an array.

Change-Id: I8498463d3131817b90fa91404289c839110bdeaa
2015-12-11 16:41:47 +00:00
Alex Monk 98a456b189 Single edit tab: Fall back to the wikitext editor when certain parameters show up
We can't handle these yet. There's also 'preview' but I think we probably
qualify as supporting that.

Bug: T121126
Change-Id: I4602992a77f460b9bfcbad0eac1bdd79d67df04d
2015-12-10 23:13:25 +00:00
jenkins-bot 69778a65e5 Merge "Let the feedback tool be configured for a remote wiki" 2015-12-10 22:04:23 +00:00
Translation updater bot 46b901e640 Merge "Localisation updates from https://translatewiki.net." 2015-12-10 22:02:32 +00:00
Translation updater bot 536ff00e5a Localisation updates from https://translatewiki.net.
Change-Id: Ide641aaf9ffec8558271116f9a3a29c1307ed588
2015-12-10 23:01:35 +01:00
jenkins-bot 3db4f22ecf Merge "MWSaveDialog: De-flag the 'return to save' button on diffs" 2015-12-10 21:51:01 +00:00
James D. Forrester 356b6e153f Update VE core submodule to master (601ba8c)
New changes:
234da0b Annotation: Rename 'inferFromDom' to 'inferFromView'
8c1ed4c Fix more typos
c515123 Fix typos
36a7d1f Count chunk list bounds more carefully

Change-Id: Ibc1b385e0c6d8fafdcd5ab4ff6e613c6d491e2a7
2015-12-10 12:42:02 -08:00
James D. Forrester 705199753c Let the feedback tool be configured for a remote wiki
Bug: T92661
Change-Id: Id48729c89db208714f67fec1eabafe577a834b51
2015-12-10 12:12:59 -08:00
Ed Sanders 29f33a57d5 Rename mw.Target to mw.ArticleTarget
This makes way for a base mw.Target class which is
not specific to articles (e.g. Flow boards).

Bug: T97166
Change-Id: If72650bdf87aa9f195b004da0a4d815f1a8063a3
2015-12-10 16:26:20 +00:00
jenkins-bot 0d9643e9e2 Merge "Single edit tab: Update preference value" 2015-12-10 01:33:25 +00:00
Alex Monk 128901866a Don't check editor preferences etc. if user wants veaction=edit
Bug: T120978
Change-Id: I39e28c80440260959b7f1c25b82a057c21de43be
2015-12-09 23:04:02 +00:00
Alex Monk bca222912c Hide VE tabs preference when user has disabled VE
Bug: T120965
Change-Id: I846124f762d811be4fbfb32c08063fc57a029cb4
2015-12-09 22:54:28 +00:00
Alex Monk e8a682f567 Single edit tab: Update preference value
It's all Timo's fault for suggesting the new values in I65d96627 PS21, obviously.

Bug: T120969
Change-Id: Ib0309342a831ec1950c1be8c7a0c79a31c413163
2015-12-09 22:51:16 +00:00
jenkins-bot 212300af1f Merge "Avoid useless jQuery.click shortcut" 2015-12-09 22:18:12 +00:00
Translation updater bot d08da2d62f Localisation updates from https://translatewiki.net.
Change-Id: Ibbc339a27888a391c6c40ced26c154cabb29acf7
2015-12-09 21:43:17 +01:00
Ed Sanders e7ccc77000 Edit mode switching: Tell VE if the wikitext was modified
Currently we assume that any document state from WE is modified
but that is not necessarily the case.

Change-Id: I085825152528ae5a5e973e8b44f68cb07ee92416
2015-12-09 17:44:43 +00:00
Ed Sanders e9250d87fd Avoid useless jQuery.click shortcut
Why have one event API when you can have ten...

Change-Id: I645cbeb4e486aba9e734ba47d2e7c3958a694f19
2015-12-09 17:34:00 +00:00
jenkins-bot a9894809f6 Merge "DesktopArticleTarget: Handle section edit link clicks in single edit tab mode" 2015-12-09 17:16:12 +00:00
Alex Monk b877e16723 DesktopArticleTarget: Handle section edit link clicks in single edit tab mode
Bug: T58337
Change-Id: Ic4c19cdfc3cfcf33604d0c4e7780b45967cdf57d
2015-12-09 09:08:46 -08:00
Ed Sanders ae26eefb05 Fix typos
Add some common ones to typos.json

Change-Id: I3830be4949ab6a5fd998d6937ed83e9f18091c2b
2015-12-09 16:47:13 +00:00
jenkins-bot 6c1e613fa4 Merge "Make clear button on numbered external links remove the node" 2015-12-09 16:26:29 +00:00
jenkins-bot 87ce2f0a20 Merge "EducationPopup: Increase z-index above toolbar dialog's" 2015-12-09 16:26:26 +00:00
David Lynch 7b66083319 Make clear button on numbered external links remove the node
Bug: T120705
Change-Id: I07d57ba95f46f0fa80f9038ccb42d8d89375fd23
2015-12-09 10:11:54 -06:00
Ed Sanders 1121dc5295 EducationPopup: Increase z-index above toolbar dialog's
Bug: T116577
Change-Id: Icb91dcebd450f954b8bae18ee57f75386de754ac
2015-12-09 15:56:08 +00:00
James D. Forrester a7d2123d60 Update VE core submodule to master (cd979fe)
New changes:
d05ccd6 LinkInspectorTool: Move link specific code to LinkInspectorTool
51f5358 Localisation updates from https://translatewiki.net.
98d86e5 TextState(Chunk): Rename 'tag' to 'element'
6b1ea16 TextState: Recover annotation models via .data('view').
2d72d37 Localisation updates from https://translatewiki.net.
72b50d9 Update OOjs UI to v0.14.1
cd979fe build: Add grunt-tyops and make pass

Change-Id: Ic1be59b024993ed817a4045d7d7950a073b0005d
2015-12-08 17:53:20 -08:00
James D. Forrester fe8a9eff91 build: Add grunt-tyops
Change-Id: Idb30814e69356eb2b3282fae018c142295df922f
2015-12-09 00:53:34 +00:00
jenkins-bot 2efbdc670c Merge "Single edit tab and section links" 2015-12-09 00:40:46 +00:00
Ed Sanders 4513283140 ve.ui.Icons.css: Fix inpsector typo
Change-Id: I9cb7f6ff38e26632d04a1ffc65ae468a5ee301cc
2015-12-09 00:18:46 +00:00
James D. Forrester ccc087c461 MWSaveDialog: De-flag the 'return to save' button on diffs
Change-Id: Icb7c07dae23b7f3ba1b4cdf6c73f17a1bbff1bdf
2015-12-08 13:31:44 -08:00
Translation updater bot ce89f917df Localisation updates from https://translatewiki.net.
Change-Id: Ie88cfc5d6f943fb52e25c0dd54fe907120dec972
2015-12-08 22:26:41 +01:00
Alex Monk 748db015b0 Single edit tab and section links
In addition to the couple of TODOs inline, we should do the following in
follow-up commits:
* Prevent FOUC due to changing things only on the client
* Make section link behaviour sensible

Bug: T58337
Change-Id: I65d966270491ffe017cb11a0daa915628fadf65c
2015-12-08 17:47:16 +00:00
Translation updater bot bd5a6242f1 Localisation updates from https://translatewiki.net.
Change-Id: I251067f1f7b60e3972f725aa192f2cb90178dc8d
2015-12-07 23:16:10 +01:00
jenkins-bot 4be9c9178e Merge "MWTemplatePage: Re-word the no-description text to reflect being always there" 2015-12-07 22:07:17 +00:00
Bartosz Dziewoński ae8a275095 MWTemplatePage: Re-word the no-description text to reflect being always there
The <visualeditor-dialog-transclusion-no-template-description> message
is now always displayed in template transclusion dialog, both when
adding a new one and when editing existing one. I think it's best to
just remove the incorrect part, as the dialog provides sufficient
context for what is happening.

The $2 parameter is no longer used or documented, but is still
supported for compatibility with existing translations.

Bug: T87130
Change-Id: Ibaa06c3bb1e9afbf0005b1605236f4be8cb15251
2015-12-07 21:59:03 +00:00
jenkins-bot db7bec4825 Merge "MediaDialog: Remove useless empty object arg to media size widget" 2015-12-07 19:21:11 +00:00