Alex Monk
87affb5ca4
Restructure education popup code to work without overriding onSelect
...
That code was breaking on mobile which uses a subclass of the normal
link inspector.
Bug: T117603
Change-Id: I75541230c21b1ee9eb73f6fb4b1fe5a5f9c14e75
2015-11-09 23:18:01 +00:00
Ed Sanders
216d0ea7a7
Update CommandHelpRegistry calls for breaking change in core
...
New changes:
281b543 Slugs: Remove vertical alignment hack
d6ddbe4 Localisation updates from https://translatewiki.net .
94bb263 Follow-up d6ddbe4: Fix build for added language 'sd'
bc8579d [BREAKING CHANGE] CommandHelp: Cleanup registry API
Change-Id: I65e2bfc299fbd60d6bdc7a57a030980b6cb8ab18
2015-11-05 07:29:44 -08:00
Ed Sanders
3716682570
CommandHelpDialog: Move registrations to where sequences are defined
...
Change-Id: I031575bbf40cd789252ac5e082bb5fa435eab257
2015-11-04 15:03:58 -08:00
David Lynch
6df227d4e0
MWCommandHelpDialog: update for core changes
...
Also: update VE core submodule to master (61f3fe7)
New changes:
4ef3666 Localisation updates from https://translatewiki.net .
cfa3482 Localisation updates from https://translatewiki.net .
d3486d4 CommandHelpDialog: Rename 'category' to 'groupName'
b5578d1 Localisation updates from https://translatewiki.net .
926595e Update OOjs UI to v0.13.1
61f3fe7 [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog
Change-Id: If651ed30ab85175c7a262d9ccccc2e1613b0f3d6
2015-11-04 12:01:45 -06:00
Alex Monk
6341c4a3b5
Apply same hide/show logic to both education popup dots
...
Bug: T117627
Change-Id: Icbde23f396935b7f6275ed89ce264ce5e49ebf6a
2015-11-04 15:56:40 +00:00
Ed Sanders
42b3463e7d
Source icon: Use double brakcets
...
This is now a candidate for upstreaming to OOUI as the
'wikitext' icon, which is slightly larger.
Bug: T111038
Change-Id: I19a287926d6f100d2cb5ed1d713387a2dac56b37
2015-11-04 14:07:41 +00:00
Alex Monk
b550323b53
Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit
...
Change-Id: If03dab6130aed7662b04000b809884a514bb2762
2015-11-03 23:55:17 +00:00
Ed Sanders
6dd7576941
AceEditorWidget: Add method to clear undo stack
...
After the widget is initialised the caller will probably
want to clear the undo stack, so that the first state
is the initial value provided.
Bonus: Add documentation for the widget.
Change-Id: Ia331acc4177e32784061cae55c450eb0f83fd744
2015-11-03 13:41:09 -08:00
Ed Sanders
1b40e6434f
VESwitchConfirmDialog: Set pending on the correct button
...
Button indices were the wrong way around; find the button by
name to avoid future problems.
Change-Id: I778ff11875539d38f5a8905c9ff472fd3bd6baae
2015-11-03 18:58:59 +00:00
Ed Sanders
28a5d0db84
VESwitchConfirmDialog: Use modes to hide 'keep' button
...
Change-Id: I92110ea14ded335db330721c08314c7a20169886
2015-11-03 18:57:15 +00:00
Ed Sanders
17898270ee
CommandHelpDialog: Move insertions into a separate group
...
Also add table and comment insertions.
Change-Id: If87261bf3d01854ab1f7ce1b447589fa8098dcf2
2015-11-03 17:03:56 +00:00
Ed Sanders
91152e2c05
CommandHelpDialog: Use new method for getting access key prefix
...
Change-Id: I85628e9282d7b78a4fdd2ea2f3b0b72019302dcc
2015-11-03 11:06:54 +00:00
jenkins-bot
adb0c427ef
Merge "[PULL THROUGH] Remove resize detection now that TextInputWidget implements it"
2015-11-03 01:47:41 +00:00
Alex Monk
f71a5a5bca
Dialog for switching between wikitext and visual editing
...
Change-Id: I7046ffbe318d046b4baee11f4148ab77fc2af7fd
2015-11-03 01:36:29 +00:00
jenkins-bot
097482bbff
Merge "MWEducationPopupTool: Changes to the dot"
2015-11-03 01:24:35 +00:00
jenkins-bot
ab42a490d9
Merge "AceEditorWidget: Preserve selection on setValue"
2015-11-03 01:17:18 +00:00
Alex Monk
5eaa211d43
MWEducationPopupTool: Changes to the dot
...
Make the dot more like the one in the designs, with two circles etc.
Change-Id: Ic3e1b2dcd846c5825455b68697acab44016ee598
2015-11-03 01:15:44 +00:00
Ed Sanders
e582fae840
[PULL THROUGH] Remove resize detection now that TextInputWidget implements it
...
This depends on the OOUI release which contains Iaadaf1f9f.
Change-Id: I24d3756d627fc3514d8b476f9af87fdecbaa1e09
2015-11-03 01:13:26 +00:00
jenkins-bot
fdafb7e887
Merge "ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up"
2015-11-02 19:08:06 +00:00
David Lynch
8bda88f661
Add mediawiki-specific sequences to the command help dialog
...
The extension registers a lot of sequences that don't apply to core
VisualEditor. Pretty much the opposite of the trigger situation, where
almost all are in core. So, merge them into the help dialog.
Update VE core submodule to master (be148ae)
New changes:
7380244 [BREAKING CHANGE] Include sequences in the command help dialog
Bug: T116013
Change-Id: I5ad2939c10140b954fb29e1e50414ab7d79aeab7
2015-10-31 21:28:57 -05:00
Ed Sanders
bd22be33db
AceEditorWidget: Preserve selection on setValue
...
Also avoid calling setValue when the value hasn't changed
so as not to pollute the undo stack.
Change-Id: I07fc5db0480a8583b361d472723f863ca90046f7
2015-10-30 16:14:09 +00:00
Thalia
7731508134
Make new error element
...
Bug: T114754
Change-Id: I5839ba62fe4b4708ff51dc549c5294189d7f8843
2015-10-29 22:32:42 +00:00
Bartosz Dziewoński
0238c53262
ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up
...
Depends on I65a92e3915a6844056fb7b3a2758a168eb12e6b8 in MediaWiki core.
Change-Id: If59979f30315c7a2164457108362803544431615
2015-10-28 22:31:45 +01:00
Ed Sanders
def886b845
AceEditorWidget: Make setters chainable and support invalid flag
...
Change-Id: I78f395459f526164c0c506beec62a0083817e64b
2015-10-27 19:02:17 +00:00
Ed Sanders
35b9c4119a
AceEditorWidget: Use mw.loader#getState instead of private moduleRegistry
...
Change-Id: I845651af837ccc042b6193876e17ba2b571dfe9c
2015-10-26 09:31:37 +00:00
Ed Sanders
21aec73795
AceEditorWidget: Use showLineNumbers instead of showGutter
...
The gutter is still useful even if line numbers are hidden.
Change-Id: Ia85ce7cd4987eb0b7022dc35cfd1029fbe78e3dc
2015-10-23 00:04:57 +01:00
jenkins-bot
2018249d97
Merge "Create more MW sequences"
2015-10-22 21:49:54 +00:00
Ed Sanders
07d56b6b5d
Create more MW sequences
...
* '{|' for tables
* '<!--' for comments
* '<gallery' for galleries
Change-Id: Ib78c411bf8676bc1974bb80515fd56c642cd67b7
2015-10-22 22:23:13 +01:00
Bartosz Dziewoński
cf6178f3a1
ve.ui.MWMediaDialog: Reset upload booklet when done uploading
...
Bug: T115380
Change-Id: I7c252a08cc2f09385102650e4d437e74d3919e59
2015-10-22 20:30:44 +02:00
jenkins-bot
9e74b26c41
Merge "ve.ui.MWMediaDialog: Correct harmless typo in method name"
2015-10-22 18:26:15 +00:00
Bartosz Dziewoński
777fc0445e
ve.ui.MWMediaDialog: Correct harmless typo in method name
...
Change-Id: Ibeb037896123349edac6bc74ab0d9541a2a63e93
2015-10-22 20:18:43 +02:00
Bartosz Dziewoński
c5434b2db8
ve.ui.MWMediaDialog: Only disable 'upload' and 'save' actions on setup, not on tab switch
...
When the tab is switched, we already set a mode that doesn't allow
using these actions.
Bug: T116299
Change-Id: Ib3ba50f578face3d49bcd14e41afe01a3b3d15af
2015-10-22 20:12:03 +02:00
Bartosz Dziewoński
bc9487cc8e
ve.ui.MWMediaDialog: Move upload booklet init further up
...
The first time this is called, it will try to switch panels, so it has
to be done before we switch to the right panel.
Bug: T116217
Bug: T116219
Change-Id: I22411024995e22ae65bde1e6418748aedf026b1b
2015-10-22 19:44:39 +02:00
jenkins-bot
bc15c3e189
Merge "Move sequence registrations adjacent to commands"
2015-10-22 16:12:38 +00:00
jenkins-bot
ca982073aa
Merge "Introduce Ace editor widget"
2015-10-22 15:47:07 +00:00
Ed Sanders
57d33a291e
Move sequence registrations adjacent to commands
...
If a command is not registered because a file/module is not
loaded, the sequence should not be loaded either.
Change-Id: I45d86ad371c7b717601b6593eaa573292ebdd4ed
2015-10-22 15:15:41 +01:00
Ed Sanders
524c2c9ee0
'<ref' sequence: Trigger basic dialog if Citoid not installed
...
Change-Id: Ibb7589e760e5583e12581cd4fc07dc88101420ea
2015-10-22 11:21:20 +01:00
Ed Sanders
60c1ee7d56
Introduce Ace editor widget
...
The widget attempts to load the ext.codeEditor.ace.modes module
and if it fails, will fall back to regular TextWidget behaviour.
Bug: T49742
Change-Id: Ie483f6eba25e3732a396c18decc0e1844b806b23
2015-10-21 20:59:08 +01:00
Ed Sanders
760d9c130c
EducationPopup: Tidy up DOM and CSS
...
Change-Id: I4effa34a4d3ddfca0f6ee61fe169a726dc0ec3f6
2015-10-15 22:35:30 +01:00
Roan Kattouw
17a5cf6a93
Followup 9d6fbc894e
: fix JS error in education popup
...
If a tool had an education popup bound to it, but it was
suppressed because the user has already seen it (according to
the cookie or localStorage), then clicking that tool would
cause a JS error.
Also remove a workaround for a ClippableElement problem
that appears to be unnecessary.
Change-Id: I73a3f5f9cc1726e28e70fc545b72960afc5ac41c
2015-10-14 16:32:14 -07:00
jenkins-bot
81a89952ef
Merge "Educational popups and highlights for links+citations"
2015-10-14 21:52:50 +00:00
Ed Sanders
4943127cde
Link inspector: Show redlink in suggestions
...
This feature was accidentally dropped when the widget was moved to core.
Change-Id: I302b4b001f1db64b023dae73e36c85e491617e92
2015-10-14 17:24:53 +01:00
Prateek Saxena
d1bf196f68
Media upload: Initialize booklet before setting file on drag drop
...
Calling initialize will clear all fields including the
OO.ui.SelectFileWidget that was just set.
Follows up I521909d27c390faad7d62f717f2b97b7676e5a63.
Bug: T40031
Change-Id: Ibc7ddafae9cb7718372520245a356938f4731479
2015-10-14 12:49:31 +00:00
Ed Sanders
e1f9adebfe
Rename ImageTransferHandler to MediaTransferHandler
...
Change-Id: If68e2e4a9dbff4707fb9cbbadcd69a7ff8375a4b
2015-10-14 12:41:25 +00:00
Ed Sanders
a6c4c3b3e1
Follow-up Id473b45: Call getResults on input widget
...
Bug: T115448
Change-Id: I8bfbb3092aa49750930c6437b0526a8b900722f1
2015-10-14 11:34:36 +00:00
jenkins-bot
cbddb00638
Merge "Stop using raw HTML for 'visualeditor-dialog-transclusion-no-template-description'"
2015-10-14 02:39:50 +00:00
Ed Sanders
7f2d9d0042
Media upload: Use new setFile method
...
Depends on I30ec98be0 in MW core.
Change-Id: Ied82ac8fd25a1c4b9818029429231ce2f39916d4
2015-10-13 18:25:09 +00:00
Ed Sanders
557340426f
Media upload: Initiate upload process on image drop
...
Bug: T40031
Change-Id: I521909d27c390faad7d62f717f2b97b7676e5a63
2015-10-13 11:24:34 -07:00
jenkins-bot
3efea1d05e
Merge "MWLinkAnnotationInspector: Close inspector when a search result is clicked"
2015-10-13 16:07:33 +00:00
jenkins-bot
7ac49bcfd9
Merge "ReferenceContextItem: Factor out getReferenceNode and use correct node"
2015-10-13 12:16:01 +00:00