wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-25 23:05:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
11134 commits 29 branches 0 tags 191 MiB
Commit graph

4404 commits

Author SHA1 Message Date
jenkins-bot 6c1e613fa4 Merge "Make clear button on numbered external links remove the node" 2015-12-09 16:26:29 +00:00
jenkins-bot 87ce2f0a20 Merge "EducationPopup: Increase z-index above toolbar dialog's" 2015-12-09 16:26:26 +00:00
David Lynch 7b66083319 Make clear button on numbered external links remove the node 
Bug: T120705
Change-Id: I07d57ba95f46f0fa80f9038ccb42d8d89375fd23
 2015-12-09 10:11:54 -06:00
Ed Sanders 1121dc5295 EducationPopup: Increase z-index above toolbar dialog's 
Bug: T116577
Change-Id: Icb91dcebd450f954b8bae18ee57f75386de754ac
 2015-12-09 15:56:08 +00:00
jenkins-bot 2efbdc670c Merge "Single edit tab and section links" 2015-12-09 00:40:46 +00:00
Ed Sanders 4513283140 ve.ui.Icons.css: Fix inpsector typo 
Change-Id: I9cb7f6ff38e26632d04a1ffc65ae468a5ee301cc
 2015-12-09 00:18:46 +00:00
James D. Forrester ccc087c461 MWSaveDialog: De-flag the 'return to save' button on diffs 
Change-Id: Icb7c07dae23b7f3ba1b4cdf6c73f17a1bbff1bdf
 2015-12-08 13:31:44 -08:00
Translation updater bot ce89f917df Localisation updates from https://translatewiki.net. 
Change-Id: Ie88cfc5d6f943fb52e25c0dd54fe907120dec972
 2015-12-08 22:26:41 +01:00
Alex Monk 748db015b0 Single edit tab and section links 
In addition to the couple of TODOs inline, we should do the following in
follow-up commits:
* Prevent FOUC due to changing things only on the client
* Make section link behaviour sensible

Bug: T58337
Change-Id: I65d966270491ffe017cb11a0daa915628fadf65c
 2015-12-08 17:47:16 +00:00
Translation updater bot bd5a6242f1 Localisation updates from https://translatewiki.net. 
Change-Id: I251067f1f7b60e3972f725aa192f2cb90178dc8d
 2015-12-07 23:16:10 +01:00
jenkins-bot 4be9c9178e Merge "MWTemplatePage: Re-word the no-description text to reflect being always there" 2015-12-07 22:07:17 +00:00
Bartosz Dziewoński ae8a275095 MWTemplatePage: Re-word the no-description text to reflect being always there 
The <visualeditor-dialog-transclusion-no-template-description> message
is now always displayed in template transclusion dialog, both when
adding a new one and when editing existing one. I think it's best to
just remove the incorrect part, as the dialog provides sufficient
context for what is happening.

The $2 parameter is no longer used or documented, but is still
supported for compatibility with existing translations.

Bug: T87130
Change-Id: Ibaa06c3bb1e9afbf0005b1605236f4be8cb15251
 2015-12-07 21:59:03 +00:00
jenkins-bot db7bec4825 Merge "MediaDialog: Remove useless empty object arg to media size widget" 2015-12-07 19:21:11 +00:00
Ed Sanders a917871505 GalleryInspector: Use namespace id constant 
Change-Id: Ia51634e84cf984d8ed4ecdab87590111bf12478f
 2015-12-07 18:49:53 +00:00
Ed Sanders 557eb4fe84 MediaDialog: Remove useless empty object arg to media size widget 
Change-Id: Id85498616f80147cd856d4d12bf5a0e58ad66029
 2015-12-07 14:12:56 +00:00
Translation updater bot 83620175ca Localisation updates from https://translatewiki.net. 
Change-Id: I3d109b133ee6d709a937013bb9eb825800c98775
 2015-12-06 21:45:56 +01:00
Translation updater bot db13a4d43a Localisation updates from https://translatewiki.net. 
Change-Id: I0d6dede3ef71b7729db66646875c308d50296d81
 2015-12-05 23:16:10 +01:00
Ed Sanders 63184600d4 Use wgNamespaceIds constants instead of hard-coded numbers 
Change-Id: I71b80e59a5e24d63e68637a1ae8422974643bd3a
 2015-12-04 19:57:56 +00:00
Translation updater bot 6ceb0c39e6 Localisation updates from https://translatewiki.net. 
Change-Id: Ie307b6e81958bb16c96a0ffff6b3568139564f4f
 2015-12-03 23:17:58 +01:00
James D. Forrester 3c9a361da0 MWMediaDialog: Add a margin back to the border checkbox 
This was removed upstream in OOUI as unecessary in general, but clearly
this was the place for which the rule had been designed. :-)

Bug: T119547
Change-Id: I46a1df1141c337b436e66872f1a8cdae026816cd
 2015-12-02 18:28:18 -08:00
Translation updater bot 7e50ac1ab6 Localisation updates from https://translatewiki.net. 
Change-Id: I2180bc4edca07261381b2790af6ebc29e0fde97f
 2015-12-02 22:01:03 +01:00
Translation updater bot d924ded91e Localisation updates from https://translatewiki.net. 
Change-Id: Ia694075416ebb62d351441419089d2570943ccf8
 2015-12-01 21:37:34 +01:00
Translation updater bot 3772e473d5 Localisation updates from https://translatewiki.net. 
Change-Id: I4133263c6d9228e867cb54be4b706e8f21a2bbc1
 2015-11-30 21:38:08 +01:00
jenkins-bot e24eaea22c Merge "Avoid embedding Git metadata in ext.visualEditor.data" 2015-11-30 11:48:28 +00:00
Ori Livneh b1db8349fe Avoid embedding Git metadata in ext.visualEditor.data 
Partially reverts "Expose version information in the client" (a72099af66 / I7836e1d40).
The Git data oscillates between two values due to differences between the
staging and production environments. Each change causes the module version to
change also, leading to cache churn.

Instead fetch version information with an API call the first
time the help popup is opened.

Bug: T119750
Change-Id: Ib9c45e60d3164cfa85eb1ef247cc91cf0d8bf954
 2015-11-30 12:34:56 +01:00
Translation updater bot 24046cb548 Localisation updates from https://translatewiki.net. 
Change-Id: I24ccb4b7af6241ed77eb47970d821262454ac26e
 2015-11-28 21:49:42 +01:00
Translation updater bot 1b176cba81 Localisation updates from https://translatewiki.net. 
Change-Id: I459d7ee237ffa2ba146bbd82059e5e22f92234b5
 2015-11-27 22:48:54 +01:00
Translation updater bot b367964ad6 Localisation updates from https://translatewiki.net. 
Change-Id: I57f93b07e2179ec7cbb75866094dd98f64b54f9c
 2015-11-26 22:06:32 +01:00
jenkins-bot 2a46cc7873 Merge "Add autocomplete options to AceEditorWidget config options" 2015-11-25 03:48:38 +00:00
Thalia 3d98b1d291 Add autocomplete options to AceEditorWidget config options 
Bug: T119549
Change-Id: I57db44c876c5cb0487bda6a72e36fedaccb532b5
 2015-11-24 19:44:41 -08:00
jenkins-bot 4655ba4c5c Merge "MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one" 2015-11-25 02:53:36 +00:00
James D. Forrester b68e34fdeb MWMediaDialog: Use OOUI's 'clock' icon rather than a home-brew one 
Depends on If4ec151a in OOUI.

Bug: T111100
Change-Id: I90af27a7ba881c588b8a432f1cc1e54ab4c80f79
 2015-11-24 18:40:13 -08:00
Translation updater bot 0bfa4b7001 Localisation updates from https://translatewiki.net. 
Change-Id: I4894709e82769d5161cf39a6488ae1666d5690d6
 2015-11-24 23:12:39 +01:00
Ed Sanders bbdb48abdf Create MWPreviewElement which adds the mw-body-content class 
This fixes some rendering issues, and also increases the font
size of reference contexts from 12.8px (interface) to 14px (content).

Bug: T119430
Change-Id: Ib1bae8cd4cfe86903d78406a33db78e1489fde86
 2015-11-23 14:28:57 -08:00
Translation updater bot 23270f87f9 Localisation updates from https://translatewiki.net. 
Change-Id: I045fa54ee959371101a2fc62238d8b10ccb348b0
 2015-11-23 22:36:41 +01:00
jenkins-bot 22a8c76d09 Merge "When adding a label to a numbered link, force the selection" 2015-11-23 19:02:04 +00:00
jenkins-bot 5649256ceb Merge "Re-fix in-page loading" 2015-11-23 17:00:13 +00:00
jenkins-bot 4616696e0d Merge "Prevent switching from unedited section directly into VE" 2015-11-23 17:00:08 +00:00
Translation updater bot 7698beb14e Localisation updates from https://translatewiki.net. 
Change-Id: I8bde2353b3bb3f950a329f033b87602b107bd722
 2015-11-22 20:48:25 +01:00
David Lynch 50759e2064 When adding a label to a numbered link, force the selection 
Otherwise the selection will/won't contain the opening node of the
link, depending on where in the paragraph it is. This makes the
experience of starting to type unpredictable to the user. By forcing
it to always have the contents of the node selected, typing always
just updates the label.

Bug: T114643
Depends-On: I7c46a917d9752145174919f41066b4841b203218
Change-Id: Ic1c573c2c28ced49f685ec6082506cb20d5163cd
 2015-11-20 18:36:44 -06:00
Ed Sanders 0e30e328ba Update VE core submodule to master (e8c6f7d) 
New changes:
b44ef6d [BREAKING CHANGE] Fix WhitespacePreservingTextInputWidget API
96e4034 Localisation updates from https://translatewiki.net.

Local changes:
* Use new WhitespacePreservingTextInputWidget API

Change-Id: I9920a3b5c8c3e8a241dcfdd1bde20f4ea1cf78b6
 2015-11-20 15:44:49 -08:00
jenkins-bot 5dbe119699 Merge "MW Examples: Fix test message" 2015-11-20 23:38:56 +00:00
jenkins-bot 77f605d2a5 Merge "Add tests for RESTBase ID comparison" 2015-11-20 23:38:53 +00:00
jenkins-bot 8200cffac5 Merge "Improve tests of data-parsoid annotation comparisons" 2015-11-20 23:37:50 +00:00
Translation updater bot 3523279808 Localisation updates from https://translatewiki.net. 
Change-Id: I8658191225f986b896358ebdd98fdefacb143ca0
 2015-11-20 22:59:51 +01:00
Ed Sanders 68755b212e MW Examples: Fix test message 
Change-Id: I4a0b9bb92fa45fca82391943b86a43fec8f2e3a1
 2015-11-20 20:34:18 +00:00
Ed Sanders 287436ae25 Add tests for RESTBase ID comparison 
Depends on I8323bbf34 in core.

Change-Id: I4043322361cdbbfd211133191c062eae42269ca4
 2015-11-20 20:34:12 +00:00
Ed Sanders 3d7d363e9c Improve tests of data-parsoid annotation comparisons 
So that it actually fails if you remove the key feature.

Depends on Iff15190e in core.

Change-Id: I1557f683241193aa4a97e04af0b4daf244a8b121
 2015-11-20 12:32:29 -08:00
Ed Sanders bbfcbeb79d Use ES5 trim instead of jQuery 
Change-Id: I6e8b958176385cb672380454fcc3b4970261caa9
 2015-11-20 11:48:55 -08:00
James D. Forrester 285eb85eb8 ReferenceEducationPopup: Don't flip the numbers in the RTL image 
Bug: T117949
Change-Id: Ia4164773a9c4f1510b8795efb4c93260a3abe672
 2015-11-19 19:31:21 -08:00
Alex Monk a0462d69d4 Re-fix in-page loading 
Probably broken by Ie808bcaa
Partially reverts Icad04dac, hopefully without any regressions

Change-Id: I4589bde7eac58b54027a6b9dbe6ecddf79780599
 2015-11-20 01:57:24 +00:00
Alex Monk 67a51aee9b Prevent switching from unedited section directly into VE 
Bug: T117713
Change-Id: Iee9ae2bbe4757cb07e9aa2bd5f41a46c0ebb391a
 2015-11-20 00:10:38 +00:00
Translation updater bot 360cdacd4b Localisation updates from https://translatewiki.net. 
Change-Id: Iabd0b1ea673697111e28cd959bdf1bca32f72ad6
 2015-11-19 21:41:49 +01:00
jenkins-bot 8fae033411 Merge "AceEditorWidget: Ensure loadingPromise is set when setupEditor runs" 2015-11-19 16:47:13 +00:00
Ed Sanders dbdae59128 AceEditorWidget: Ensure loadingPromise is set when setupEditor runs 
Change-Id: I11d37b863f28bacd4c09992d6fcc180621766577
 2015-11-18 23:11:10 -08:00
jenkins-bot 9f1aedbefc Merge "Make selectRange method of AceEditorWidget focus the input" 2015-11-19 03:28:44 +00:00
Thalia 18448bb42b Make selectRange method of AceEditorWidget focus the input 
The selectRange method does this in TextInputWidget, so it
should here too.

Change-Id: Ib3851e0c72876d3c25ae5992cf9732637238d117
 2015-11-18 19:14:50 -08:00
jenkins-bot 718e06cf1b Merge "Add method to toggle the AceEditorWidget print margin" 2015-11-18 21:46:44 +00:00
Thalia 21fd89ba3c Add method to toggle the AceEditorWidget print margin 
Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
 2015-11-18 13:38:41 -08:00
Translation updater bot a09b6e3a20 Localisation updates from https://translatewiki.net. 
Change-Id: I2affa2a7543343d7f5899b5b55e1cb7e0a954c92
 2015-11-18 22:01:07 +01:00
jenkins-bot 52f151193a Merge "Make focus method of AceEditorWidget chainable" 2015-11-18 20:29:48 +00:00
Thalia 88d466ba23 Make focus method of AceEditorWidget chainable 
The focus method of InputWidget and other descendants
of InputWidget is already chainable

Change-Id: Ib75fb7b08769e86c652c63dac069e2573e61f89a
 2015-11-18 12:21:44 -08:00
Ed Sanders bd40f62c17 Introduce MWExtensionPreviewDialog 
An MWExtensionDialog with a PreviewElement for the selected node,
or node to insert.

Depends on Icd622e15cd7 in VE core.

Change-Id: Ia0f46da2d445dd94c8aa50be73508d9f1afcb816
 2015-11-18 19:33:32 +00:00
jenkins-bot d5562830fd Merge "MWSignatureTool: Restrict command to linear selections" 2015-11-18 06:17:56 +00:00
Ed Sanders 259ec31ece MWSignatureTool: Restrict command to linear selections 
Change-Id: If6109c2ef2a18eccaccf18bd1d76c272a1dc3cd5
 2015-11-17 22:08:23 -08:00
jenkins-bot 761ecc96f4 Merge "AceEditorWidget: Implement getRange" 2015-11-18 06:04:27 +00:00
jenkins-bot 2104ee1590 Merge "Wikitext paste: Fail if result has no visible content" 2015-11-18 03:39:52 +00:00
jenkins-bot df9b4b05b9 Merge "Edit mode switching: Auto-close jQuery.UI dialogs before switching" 2015-11-18 03:36:31 +00:00
Ed Sanders f9ca524ef9 Wikitext paste: Fail if result has no visible content 
For example if '[[category:foo]]' is pasted.

Bug: T118191
Change-Id: I9c51846414dd6b885b33f1dc9076edadbc6464c4
 2015-11-18 03:33:14 +00:00
Ed Sanders a5d700807a AceEditorWidget: Implement getRange 
Depends on I109a666679 in OOUI.

Change-Id: Ie40a30a3743237c1c1cd59dd2165d313363e04cb
 2015-11-18 03:32:54 +00:00
Ed Sanders e1d14099e0 Image/gallery icons: Rename and use new upstream versions 
Depends on oojs-ui > 0.13.2.

Change-Id: Iee4cc52b998626e829fd92346d5ee1295c08f26f
 2015-11-18 01:49:31 +00:00
Ed Sanders 19034b0416 Edit mode switching: Auto-close jQuery.UI dialogs before switching 
Bug: T118282
Change-Id: I7960e4f71dd8b710f2ec2430f2946679af07012b
 2015-11-17 17:26:01 -08:00
jenkins-bot 370a060ffc Merge "AceEditorWidget: Implement selectRange" 2015-11-17 23:49:46 +00:00
jenkins-bot 4785177791 Merge "Make dependencies of jquery.uls.data more specific" 2015-11-17 23:44:07 +00:00
jenkins-bot a40c0082b0 Merge "Make 'moment' a dependency of just 'mwimage', not all of VE-MW" 2015-11-17 23:42:36 +00:00
Ed Sanders 5e96050b48 AceEditorWidget: Implement selectRange 
This is not trivial because Ace selections are
[column,row] tuples, so we need to translate to
one dimensional offsets.

Change-Id: I901b025b3747d61c74f49038fe4a65ed75758211
 2015-11-17 23:39:33 +00:00
Ed Sanders d1da56a6cb Make dependencies of jquery.uls.data more specific 
Change-Id: I135defffc71d8aa61dc74bb871da96737a3eeb0c
 2015-11-17 15:34:23 -08:00
Ed Sanders b5c16ac95c Make 'moment' a dependency of just 'mwimage', not all of VE-MW 
Change-Id: I23c193bfb34203aa6f2ef1d3633c208e5c692c97
 2015-11-17 14:55:10 -08:00
Translation updater bot b4f2194085 Localisation updates from https://translatewiki.net. 
Change-Id: I15540a448677ac4e4b6a0eba024e230ce4846b22
 2015-11-17 21:55:40 +01:00
Alex Monk 889358f24c Ensure we always catch the wikiEditor-toolbar-doneInitialSections event 
Don't wait for module loading. Before, this was only actually working half the
time.

Change-Id: I7fb284a800927672642c59231a322982b613f16b
 2015-11-17 02:23:25 +00:00
jenkins-bot 2fcbc18dff Merge "Provide a tool to insert a signature in namespaces that need it" 2015-11-17 00:16:42 +00:00
jenkins-bot 3e9d040a79 Merge "AceEditorWidget: Allow users to force an Ace editor refresh" 2015-11-16 22:46:24 +00:00
Translation updater bot 64d8e394ce Localisation updates from https://translatewiki.net. 
Change-Id: Iaf8fb457fd0b835d5b8819f5dab015c4a59e0a78
 2015-11-16 22:19:07 +01:00
Ed Sanders 35c44db988 AceEditorWidget: Allow users to force an Ace editor refresh 
Ace is clever about not updating the rendering of elements
which aren't visible, so allow users to force an update, for
example if they changed the value while the whole widget
was hidden.

Change-Id: I7bbbffd17489bc80fe5fa80911f29d7223e125a3
 2015-11-16 12:12:10 -08:00
Ed Sanders 470a4a551b AceEditorWidget: Refactor to ensure setValue runs synchronously 
Also ensure setEditorWidget is only called once when
loadingPromise resolves.

Change-Id: I1a95bda5e9ff17d7575326f29fa01d273193c4a5
 2015-11-16 11:36:08 -08:00
Bartosz Dziewoński 9be5c85db4 Provide a tool to insert a signature in namespaces that need it 
VisualEditor is usually not enabled in talk namespaces... but
sometimes it is. And when users see the button to edit with VE,
they're going to click it and expect to be able to sign their posts.

This tool is only loaded on talk pages and pages in additional
namespaces defined in $wgExtraSignatureNamespaces.

Code adapted with small tweaks from my own gadget
<https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js?oldid=13461327>,
which is already available under the MIT license.

Changes include:
* The tool is now always visible if the wiki allows signatures in any
  VE namespaces, but disabled when not allowed in the current namespace.
* Register '~~~~' sequence to insert the signature.
* Code style tweaks for stricter lint checks in this repository.
* Documentation corrections.

Swedish translation provided by André Costa (already credited
as a translator as Lokal_Profil).

Depends on changes in VisualEditor core:
* I89fe53890ab59d12260ea6b41de802c38c24e8b9
* I14cd7efac521687ea38580341ae08ddc522edeeb

Bug: T53154
Change-Id: I6be5fb2118cf3eef5098d4c5320228aa81411ccb
 2015-11-16 18:06:32 +01:00
Translation updater bot 9d01677f75 Localisation updates from https://translatewiki.net. 
Change-Id: I2e18f18c1614e74a5681ea7e8faf0ce71c1b5db1
 2015-11-15 22:22:40 +01:00
jenkins-bot f44e127eb5 Merge "AceEditorWidget: Emit resize event at end of cycle" 2015-11-15 02:38:22 +00:00
Translation updater bot 8a456d3e31 Localisation updates from https://translatewiki.net. 
Change-Id: I1eb678891af629bf935f2837e76ba5b856d5f9fd
 2015-11-14 22:19:35 +01:00
Ed Sanders b21b939a67 AceEditorWidget: Emit resize event at end of cycle 
Ensures the widget has taken its new size before emitting the event.

Bug: T117926
Change-Id: If1dab2ecadb2a581100c0ae154b341ce8d173a7c
 2015-11-13 18:48:35 -08:00
C. Scott Ananian 236fad19b6 Ensure magic link nodes inherit the annotations of their text 
If you create an autolink in the middle of bolded text, the magic link
should also be bolded.  Similarly, if you convert a bolded simple link
to a magic link, the magic link should stay bolded.

Change-Id: I38c7f3c0c275851049088a37f3b37d815ed38e4e
 2015-11-13 13:48:18 -08:00
Translation updater bot 73918e0e1e Localisation updates from https://translatewiki.net. 
Change-Id: I63a0e4185c61a42cf0d142d520fdc1e7c7f9000f
 2015-11-13 21:35:36 +01:00
Translation updater bot a284d335a8 Localisation updates from https://translatewiki.net. 
Change-Id: I7f7dba15312b3fda8e9a737428f4bc191604ac4f
 2015-11-12 23:02:52 +01:00
jenkins-bot c6aeff4ba9 Merge "Edit mode switching: Separate styles" 2015-11-11 22:33:35 +00:00
jenkins-bot 96f91758f6 Merge "Update VE core submodule to master (77d786a)" 2015-11-11 22:10:08 +00:00
Translation updater bot c1ac8806c6 Localisation updates from https://translatewiki.net. 
Change-Id: I7f3c0dfe04074271159b7f22032c587374f72836
 2015-11-11 21:57:36 +01:00
Ed Sanders 9bcc61e195 Update VE core submodule to master (77d786a) 
New changes:
95589a6 test: Add a Rakefile for new CI requirement
1a4497e ve.ui.DialogTool: Do not require that a command is set
cbf1bff ve.ui.Tool: Fix documentation for getCommandName
530022d Localisation updates from https://translatewiki.net.
9529093 Update OOjs UI to v0.13.2
b8d6c15 Add icon: Rename 'insert' to 'add'
2f3015b Update OOjs to v1.1.10
78ceb18 Fix deletion inside a structural node at start/end of document
ce3e9a4 ve.utils: Use binarySearch from OOjs

Local change:
* MW test cases for new structural deletion logic

Bug: T52250
Change-Id: I643449c1fa08ea12c8c3aa13f4a4b97d8876990d
 2015-11-11 12:35:53 -08:00
Ed Sanders 86a1d1bfa3 Edit mode switching: Separate styles 
Ensures that these styles are loaded *after* OOUI by making
them dependent on it, unlike DesktopArticleTarget.init
which isn't.

Change-Id: Ia1fff16432d20fb56707c5e21c6a930d2478e311
 2015-11-11 18:50:55 +00:00
jenkins-bot c815c3242d Merge "Edit mode switching: Only show WE toolbar button once module is loaded" 2015-11-11 02:21:04 +00:00
jenkins-bot 53dbf3ac2f Merge "Replace 'source' icon with OOUI's 'wikiText' one" 2015-11-11 01:42:00 +00:00
jenkins-bot 1f2905c39f Merge "DesktopTarget: Fix opacity of #siteSub and #contentSub" 2015-11-10 23:39:03 +00:00
Translation updater bot 7bb161d5f7 Localisation updates from https://translatewiki.net. 
Change-Id: Ia25e40a77c416e2dde09b7e68d6e836baf9b3adc
 2015-11-10 22:36:30 +01:00
Ed Sanders cfe3d9b561 Edit mode switching: Only show WE toolbar button once module is loaded 
No point showing the icon if we don't have the functionality to
make it do anything. Also this reduces the number of RL requests
made as we never fetch OOUI separately.

Change-Id: Iac9aa6f34c485223e73981b3377c7d0cfd31dae9
 2015-11-10 10:43:33 -08:00
Alex Monk 6213c23db1 Fix updating of display title upon save 
Bug: T117643
Change-Id: Ibd3d4f056a2d175e52b60b6e3a4c0ece04f26f50
 2015-11-10 13:50:00 +00:00
Alex Monk 87affb5ca4 Restructure education popup code to work without overriding onSelect 
That code was breaking on mobile which uses a subclass of the normal
link inspector.

Bug: T117603
Change-Id: I75541230c21b1ee9eb73f6fb4b1fe5a5f9c14e75
 2015-11-09 23:18:01 +00:00
Alex Monk 5f162522eb Merge "ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work" 2015-11-09 22:42:34 +00:00
Translation updater bot e87b56b53e Localisation updates from https://translatewiki.net. 
Change-Id: Ie37b9b551d0af53d2420af4a798a26c1954ecf0b
 2015-11-09 21:50:10 +01:00
Bartosz Dziewoński 7d69e86265 ve.init.mw.DesktopArticleTarget.init: Make switching to VE for new pages work 
Work around RESTBase problem that causes errors if we try to switch to
VE when the wikitext is empty. This would prevent non-power-users from
opening VE entirely.

This only solves the issue for new empty pages, and not when the user
intentionally empties the edit box. In that case, though, they get a
dialog where they can choose to "keep" or "discard" changes, and
discarding lets you open the editor.

Bug: T118152
Change-Id: Ie808bcaa9826deacac392dd6cbc90a9446602b79
 2015-11-09 18:55:21 +01:00
jenkins-bot b966333009 Merge "Unset 'action' query parameter from veEditUri, which should always point to VE" 2015-11-09 15:26:18 +00:00
Translation updater bot 280b68b183 Localisation updates from https://translatewiki.net. 
Change-Id: I96650b4066bf3a33e0b31e53ddefa15dac49d5b7
 2015-11-08 22:14:22 +01:00
Alex Monk 1e4889bbc7 Unset 'action' query parameter from veEditUri, which should always point to VE 
Bug: T117780
Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
 2015-11-08 20:32:28 +00:00
Translation updater bot a8dbf5f828 Localisation updates from https://translatewiki.net. 
Change-Id: I37ec76d17c9c7f24c6691d8cb85faf7422f28633
 2015-11-07 22:45:38 +01:00
Alex Monk 3e23d3b96d Only load switching module (depending on OOUI etc.) on edit pages 
This wasn't as bad as T112401 (that was blocking render), but we
still shouldn't be loading the module on page views.

Bug: T118088
Change-Id: If86701ed7ff4e8d6defb1c682aa9a38c211be0fa
 2015-11-07 19:08:29 +00:00
jenkins-bot 69bce26579 Merge "Drop any beforeunload handlers when loading from existing wikitext" 2015-11-07 16:09:50 +00:00
Alex Monk 6247a2f430 WikiEditor integration: Fix dependencies for switch button 
Change-Id: Ic8fb607e8c467e89c0b9af0a9baab84e59b19ba8
 2015-11-07 04:15:14 +00:00
Alex Monk 2910cd2384 Drop any beforeunload handlers when loading from existing wikitext 
Bug: T117769
Change-Id: I823737b17e5af8ed15bc2b62db61a31886e8d418
 2015-11-07 03:57:19 +00:00
jenkins-bot 4a582d7abf Merge "WikiEditor integration: Only add VE switch button if VE is available" 2015-11-06 22:13:36 +00:00
Translation updater bot 5a771525dd Localisation updates from https://translatewiki.net. 
Change-Id: I50f024e4704930c59b8dd225f7ea975351c3e895
 2015-11-06 22:29:08 +01:00
Alex Monk 87931fb3f2 WikiEditor integration: Only add VE switch button if VE is available 
Bug: T117968
Change-Id: Ibfe73b7170083bc9ee0a0322768999c8650da4e7
 2015-11-06 18:23:44 +00:00
Translation updater bot db5c453648 Localisation updates from https://translatewiki.net. 
Change-Id: Ifa98bbba31c83dbd4052674081333991cf7b473d
 2015-11-05 21:46:47 +01:00
jenkins-bot 9f036c10f6 Merge "Update CommandHelpRegistry calls for breaking change in core" 2015-11-05 15:35:48 +00:00
Ed Sanders 216d0ea7a7 Update CommandHelpRegistry calls for breaking change in core 
New changes:
281b543 Slugs: Remove vertical alignment hack
d6ddbe4 Localisation updates from https://translatewiki.net.
94bb263 Follow-up d6ddbe4: Fix build for added language 'sd'
bc8579d [BREAKING CHANGE] CommandHelp: Cleanup registry API

Change-Id: I65e2bfc299fbd60d6bdc7a57a030980b6cb8ab18
 2015-11-05 07:29:44 -08:00
Bartosz Dziewoński 4a1a9bbf82 ve.init.mw.Target: Update TitleBlacklist error code 
The error code has changed after T115258 and is now consistently
'titleblacklist-forbidden' for all TitleBlacklist errors.

The API now also provides information about the exact error message to
display (error.message) and the TitleBlacklist rule that matched
(error.line), but we probably don't have that message client-side, so
we're not trying to display it. Maybe when we can load it (T40280).

Bug: T116198
Change-Id: I32fccc7d0b2b66c739d59db05c568a56d9f07eec
 2015-11-05 04:07:38 +01:00
Ed Sanders 3716682570 CommandHelpDialog: Move registrations to where sequences are defined 
Change-Id: I031575bbf40cd789252ac5e082bb5fa435eab257
 2015-11-04 15:03:58 -08:00
Translation updater bot 3b6ee5ca68 Localisation updates from https://translatewiki.net. 
Change-Id: I09939347d8aec3aadc28673736f50eba94b42c1b
 2015-11-04 21:22:59 +01:00
David Lynch 6df227d4e0 MWCommandHelpDialog: update for core changes 
Also: update VE core submodule to master (61f3fe7)

New changes:
4ef3666 Localisation updates from https://translatewiki.net.
cfa3482 Localisation updates from https://translatewiki.net.
d3486d4 CommandHelpDialog: Rename 'category' to 'groupName'
b5578d1 Localisation updates from https://translatewiki.net.
926595e Update OOjs UI to v0.13.1
61f3fe7 [BREAKING CHANGE] Create CommandHelpRegistry for CommandHelpDialog

Change-Id: If651ed30ab85175c7a262d9ccccc2e1613b0f3d6
 2015-11-04 12:01:45 -06:00
jenkins-bot dd897a3e67 Merge "Don't allow keeping changes when switching from wikitext *section* editing" 2015-11-04 16:34:54 +00:00
jenkins-bot 633bc55f9d Merge "Apply same hide/show logic to both education popup dots" 2015-11-04 16:21:22 +00:00
Alex Monk 9c7a058b09 Don't allow keeping changes when switching from wikitext *section* editing 
Bug: T117713
Change-Id: I16f17fa2aa4c9a1b74d8cde072c611e2685f5448
 2015-11-04 16:19:36 +00:00
jenkins-bot d24844af2e Merge "Unbreak 404 handling code" 2015-11-04 16:06:09 +00:00
Alex Monk 6341c4a3b5 Apply same hide/show logic to both education popup dots 
Bug: T117627
Change-Id: Icbde23f396935b7f6275ed89ce264ce5e49ebf6a
 2015-11-04 15:56:40 +00:00
Alex Monk dbf79f15fd Unbreak 404 handling code 
Broken in I2a529434

Bug: T117697
Change-Id: Ic34ef81afdde0851f4935971a808f22cdd5cde89
 2015-11-04 15:31:19 +00:00
James D. Forrester 09800aa249 Replace 'source' icon with OOUI's 'wikiText' one 
Change-Id: Id66d436b9140604ace7ebfbec1f80dc8f3830a20
 2015-11-04 06:15:29 -08:00
jenkins-bot 3b30ea8916 Merge "Source icon: Use double brakcets" 2015-11-04 14:14:52 +00:00
jenkins-bot 4dacc683f5 Merge "Target init: Add edit mode switch icons to VE and WE toolbars" 2015-11-04 14:14:49 +00:00
Ed Sanders 42b3463e7d Source icon: Use double brakcets 
This is now a candidate for upstreaming to OOUI as the
'wikitext' icon, which is slightly larger.

Bug: T111038
Change-Id: I19a287926d6f100d2cb5ed1d713387a2dac56b37
 2015-11-04 14:07:41 +00:00
Ed Sanders b05d9fcb0e Target init: Add edit mode switch icons to VE and WE toolbars 
VE already has a a switch icon in the options menu, so bring that
up to the main toolbar.

Append an OOUI button to the WikiEditor toolbar if present, and bind
to the same functon as the edit tab.

Bug: T49779
Change-Id: Ic1e83ea7b13c4fef68024bf05ffc244060666103
 2015-11-04 14:07:41 +00:00
Alex Monk bc6fe7dc77 Set wgAction when messing with the action URL parameter 
Also get rid of an unused variable.

Bug: T117596
Change-Id: I8479fa930397cff48c3a103f3a2c99e89190dc4a
 2015-11-04 01:41:46 +00:00
Alex Monk eb63b57d32 Fix check for loading from modified action=edit 
Bug: T117596
Change-Id: Icad04dac7dc94927cff9b93b175d4a6c4dddee5a
 2015-11-03 16:19:26 -08:00
Alex Monk b550323b53 Use mw.loader.using instead of weird hacks to load OOjs UI on action=edit 
Change-Id: If03dab6130aed7662b04000b809884a514bb2762
 2015-11-03 23:55:17 +00:00
Ed Sanders 6dd7576941 AceEditorWidget: Add method to clear undo stack 
After the widget is initialised the caller will probably
want to clear the undo stack, so that the first state
is the initial value provided.

Bonus: Add documentation for the widget.

Change-Id: Ia331acc4177e32784061cae55c450eb0f83fd744
 2015-11-03 13:41:09 -08:00
Translation updater bot a9befc64b3 Localisation updates from https://translatewiki.net. 
Change-Id: I9dd2d16b514a0f576f6b886ba16c4db8fc112069
 2015-11-03 21:54:34 +01:00
Ed Sanders 1b40e6434f VESwitchConfirmDialog: Set pending on the correct button 
Button indices were the wrong way around; find the button by
name to avoid future problems.

Change-Id: I778ff11875539d38f5a8905c9ff472fd3bd6baae
 2015-11-03 18:58:59 +00:00
Ed Sanders 28a5d0db84 VESwitchConfirmDialog: Use modes to hide 'keep' button 
Change-Id: I92110ea14ded335db330721c08314c7a20169886
 2015-11-03 18:57:15 +00:00
Alex Monk 07c6c17e5c Unbreak loading of VE in the read page 
Change-Id: Ic3e4e65296fa63b3a7d5114366f2859f4ce3f21d
 2015-11-03 18:16:47 +00:00
Ed Sanders 17898270ee CommandHelpDialog: Move insertions into a separate group 
Also add table and comment insertions.

Change-Id: If87261bf3d01854ab1f7ce1b447589fa8098dcf2
 2015-11-03 17:03:56 +00:00
Ed Sanders 91152e2c05 CommandHelpDialog: Use new method for getting access key prefix 
Change-Id: I85628e9282d7b78a4fdd2ea2f3b0b72019302dcc
 2015-11-03 11:06:54 +00:00
jenkins-bot 36e2e85e53 Merge "Update VE core submodule to master (062cb26)" 2015-11-03 10:59:23 +00:00
James D. Forrester c714eb173c Update VE core submodule to master (062cb26) 
New changes:
6cae77b ElementLinearData: Add another case to hasContent
d2e15f2 SurfaceFragment: Improve handling of delete all
16db2a3 Return 'null' instead of null in ve.Filibuster observers
24de6b2 Introduce key down handlers to separate logic from ce surface
f77fe99 Localisation updates from https://translatewiki.net.
062cb26 Localisation updates from https://translatewiki.net.

Change-Id: I61c94983c7898af219266af3022761638c7578b7
 2015-11-03 10:36:53 +00:00
jenkins-bot adb0c427ef Merge "[PULL THROUGH] Remove resize detection now that TextInputWidget implements it" 2015-11-03 01:47:41 +00:00
Alex Monk f71a5a5bca Dialog for switching between wikitext and visual editing 
Change-Id: I7046ffbe318d046b4baee11f4148ab77fc2af7fd
 2015-11-03 01:36:29 +00:00
jenkins-bot 56af2bb742 Merge "MWSaveDialog: Fix styling of border radii" 2015-11-03 01:28:30 +00:00
jenkins-bot 097482bbff Merge "MWEducationPopupTool: Changes to the dot" 2015-11-03 01:24:35 +00:00
Ed Sanders 926d39d54d MWSaveDialog: Fix styling of border radii 
Remove bottom border radii from the <textarea> and apply to
the options bar instead.

Apply different values for Apex and MediaWiki themes.

Change-Id: If727863a87547692ee499d2141c0418658609412
 2015-11-03 01:20:52 +00:00
jenkins-bot ab42a490d9 Merge "AceEditorWidget: Preserve selection on setValue" 2015-11-03 01:17:18 +00:00
Alex Monk 5eaa211d43 MWEducationPopupTool: Changes to the dot 
Make the dot more like the one in the designs, with two circles etc.

Change-Id: Ic3e1b2dcd846c5825455b68697acab44016ee598
 2015-11-03 01:15:44 +00:00
Ed Sanders e582fae840 [PULL THROUGH] Remove resize detection now that TextInputWidget implements it 
This depends on the OOUI release which contains Iaadaf1f9f.

Change-Id: I24d3756d627fc3514d8b476f9af87fdecbaa1e09
 2015-11-03 01:13:26 +00:00
jenkins-bot a0a0f0e2c0 Merge "Allow switching from wikitext to VE" 2015-11-02 23:18:33 +00:00
Translation updater bot 05ce5efbdf Localisation updates from https://translatewiki.net. 
Change-Id: I78ab1b44b18ed3080ee1a1e9ceca58501544abf7
 2015-11-02 22:40:02 +01:00
Alex Monk 85b745666f Allow switching from wikitext to VE 
Just by pressing the VE tab for now

Requires a relatively new version of restbase

Bug: T49779
Change-Id: I2a5294345f5e0f469c1dd1bdd29dbce211571a4e
 2015-11-02 20:55:19 +00:00
jenkins-bot fdafb7e887 Merge "ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up" 2015-11-02 19:08:06 +00:00
jenkins-bot df5eff257c Merge "Add mediawiki-specific sequences to the command help dialog" 2015-11-02 17:33:52 +00:00
jenkins-bot 54782884d5 Merge "[BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set" 2015-11-02 12:22:39 +00:00
Vikas S Yaligar 0971054f40 [BrowserTest] Select English when LANGUAGE_SCREENSHOT_CODE environment variable is not set 
Bug: T111525
Bug: T90577

Change-Id: I421c4c0ce7bcf7be757d31481940ada58e4c9f20
 2015-11-02 12:18:07 +00:00
Translation updater bot 6096916701 Localisation updates from https://translatewiki.net. 
Change-Id: I1c0c5dd11c8a900da883c4e53d554fcd9d4ac1a8
 2015-11-01 21:41:46 +01:00
David Lynch 8bda88f661 Add mediawiki-specific sequences to the command help dialog 
The extension registers a lot of sequences that don't apply to core
VisualEditor. Pretty much the opposite of the trigger situation, where
almost all are in core. So, merge them into the help dialog.

Update VE core submodule to master (be148ae)
New changes:
7380244 [BREAKING CHANGE] Include sequences in the command help dialog

Bug: T116013
Change-Id: I5ad2939c10140b954fb29e1e50414ab7d79aeab7
 2015-10-31 21:28:57 -05:00
Translation updater bot 3791e5658a Localisation updates from https://translatewiki.net. 
Change-Id: I75b45bcfab4a86d785dfd8052c950ad5edd4e4f3
 2015-10-31 21:08:22 +01:00
Translation updater bot 8303873ced Localisation updates from https://translatewiki.net. 
Change-Id: I86d151740c187a018a7e33afc88c601e614f8dd7
 2015-10-30 21:51:06 +01:00
Ed Sanders bd22be33db AceEditorWidget: Preserve selection on setValue 
Also avoid calling setValue when the value hasn't changed
so as not to pollute the undo stack.

Change-Id: I07fc5db0480a8583b361d472723f863ca90046f7
 2015-10-30 16:14:09 +00:00
Thalia 7731508134 Make new error element 
Bug: T114754
Change-Id: I5839ba62fe4b4708ff51dc549c5294189d7f8843
 2015-10-29 22:32:42 +00:00
Translation updater bot a3dc541e0c Localisation updates from https://translatewiki.net. 
Change-Id: I2fdbb79b00eec6579f53e66c7395998d209424d2
 2015-10-29 21:27:15 +01:00
Ed Sanders 2c2f8c8a04 MediaSearch: Order search results correctly 
Bug: T117036
Change-Id: Ia11f3486214425f203695a6060e304a90eba7734
 2015-10-29 12:51:22 +00:00
Bartosz Dziewoński 0238c53262 ve.ui.MWMediaDialog: Wait for upload booklet to initialize when setting up 
Depends on I65a92e3915a6844056fb7b3a2758a168eb12e6b8 in MediaWiki core.

Change-Id: If59979f30315c7a2164457108362803544431615
 2015-10-28 22:31:45 +01:00
Translation updater bot 3583645f59 Localisation updates from https://translatewiki.net. 
Change-Id: I949f0feecd93fb5d5de5427b760240c9432a3704
 2015-10-28 21:56:56 +01:00
Translation updater bot bd80afd598 Localisation updates from https://translatewiki.net. 
Change-Id: I803c50fa52067ed7912adb800b84dc28f27a9d8b
 2015-10-27 21:33:59 +01:00
Ed Sanders def886b845 AceEditorWidget: Make setters chainable and support invalid flag 
Change-Id: I78f395459f526164c0c506beec62a0083817e64b
 2015-10-27 19:02:17 +00:00
Ed Sanders b222696675 DesktopTarget: Fix opacity of #siteSub and #contentSub 
siteSub and contentSub are both children of bodyContent so
no need to give them opacity directly.

Bonus: Make them user-select:none to avoid confusion as they
are in the edit area.

Bug: T116755
Change-Id: Iea4c35abc1eedb892e02c54b61e40726fa2b096e
 2015-10-27 14:41:45 +00:00
Krinkle 59f55fbb9b Revert "DesktopArticleTarget.init: Tolerate missing wgRelevantPageName" 
Shouldn't be needed once T116693 is fixed.

This reverts commit 39bb635a60.

Change-Id: I545a9eba85f15dcae00c5f117939960acf4113d2
 2015-10-27 01:07:47 +00:00
Roan Kattouw 39bb635a60 DesktopArticleTarget.init: Tolerate missing wgRelevantPageName 
For some reason this happens on some zhwiki pages.

Bug: T116693
Change-Id: I2880b8e7f2ed933928b155dd8727012f79854e1d
 2015-10-26 16:31:44 -07:00
Translation updater bot 4245756344 Localisation updates from https://translatewiki.net. 
Change-Id: I6877fd0a9b91bc25e162dd45d366018e7b05e2af
 2015-10-26 21:05:19 +01:00
Ed Sanders 35b9c4119a AceEditorWidget: Use mw.loader#getState instead of private moduleRegistry 
Change-Id: I845651af837ccc042b6193876e17ba2b571dfe9c
 2015-10-26 09:31:37 +00:00
Translation updater bot 565a10da61 Localisation updates from https://translatewiki.net. 
Change-Id: I937839d0970a94312dfa12aa2aa282b45a4d9d80
 2015-10-25 22:09:01 +01:00
Timo Tijhof 51369ab9ab mw.TargetLoader: Avoid private mw.loader#moduleRegistry property 
Follows-up 28f3a02e56.

* Use mw.loader#getState() instead of private 'moduleRegistry'.
  This property is not a supported API and may change at any time.

* Use plain push() instead of splice(). The order of modules
  is insignificant as dependencies are enforced by module registry
  only. Besides, the order is additionally normalised both
  client-side and server-side by ResourceLoader.

Change-Id: Id9291c97c3bfc01c4cf203aa7b15629fb8412f5b
 2015-10-24 22:26:14 +01:00
jenkins-bot bc5e827ffb Merge "AceEditorWidget: Use showLineNumbers instead of showGutter" 2015-10-22 23:24:53 +00:00
jenkins-bot 724aeb9b33 Merge "Add theme-specific drop shadows to target loading bar" 2015-10-22 23:06:58 +00:00
jenkins-bot a67c62a754 Merge "Create separate skinStyles for target loading bar" 2015-10-22 23:06:56 +00:00
Ed Sanders 21aec73795 AceEditorWidget: Use showLineNumbers instead of showGutter 
The gutter is still useful even if line numbers are hidden.

Change-Id: Ia85ce7cd4987eb0b7022dc35cfd1029fbe78e3dc
 2015-10-23 00:04:57 +01:00
jenkins-bot 2018249d97 Merge "Create more MW sequences" 2015-10-22 21:49:54 +00:00
Ed Sanders 07d56b6b5d Create more MW sequences 
* '{|' for tables
* '<!--' for comments
* '<gallery' for galleries

Change-Id: Ib78c411bf8676bc1974bb80515fd56c642cd67b7
 2015-10-22 22:23:13 +01:00
Translation updater bot 7317ee1f2c Localisation updates from https://translatewiki.net. 
Change-Id: Ic63f9b48379735da1b506ea7f7e447c0196c761e
 2015-10-22 22:05:34 +02:00
Bartosz Dziewoński cf6178f3a1 ve.ui.MWMediaDialog: Reset upload booklet when done uploading 
Bug: T115380
Change-Id: I7c252a08cc2f09385102650e4d437e74d3919e59
 2015-10-22 20:30:44 +02:00
jenkins-bot 9e74b26c41 Merge "ve.ui.MWMediaDialog: Correct harmless typo in method name" 2015-10-22 18:26:15 +00:00
Bartosz Dziewoński 777fc0445e ve.ui.MWMediaDialog: Correct harmless typo in method name 
Change-Id: Ibeb037896123349edac6bc74ab0d9541a2a63e93
 2015-10-22 20:18:43 +02:00
Bartosz Dziewoński c5434b2db8 ve.ui.MWMediaDialog: Only disable 'upload' and 'save' actions on setup, not on tab switch 
When the tab is switched, we already set a mode that doesn't allow
using these actions.

Bug: T116299
Change-Id: Ib3ba50f578face3d49bcd14e41afe01a3b3d15af
 2015-10-22 20:12:03 +02:00
Bartosz Dziewoński bc9487cc8e ve.ui.MWMediaDialog: Move upload booklet init further up 
The first time this is called, it will try to switch panels, so it has
to be done before we switch to the right panel.

Bug: T116217
Bug: T116219
Change-Id: I22411024995e22ae65bde1e6418748aedf026b1b
 2015-10-22 19:44:39 +02:00
jenkins-bot bc15c3e189 Merge "Move sequence registrations adjacent to commands" 2015-10-22 16:12:38 +00:00
jenkins-bot ca982073aa Merge "Introduce Ace editor widget" 2015-10-22 15:47:07 +00:00
Ed Sanders c9fc5fb171 Add theme-specific drop shadows to target loading bar 
As a modal popup it should have a drop shadow

Change-Id: I5b4a07c268c30124ed7ba6cc5391005595abeb7b
 2015-10-22 16:02:25 +01:00
Ed Sanders 9749ff5187 Create separate skinStyles for target loading bar 
Change-Id: I74eff697711641a7c111564ddb9e493ad358b8d4
 2015-10-22 16:01:44 +01:00
Ed Sanders 57d33a291e Move sequence registrations adjacent to commands 
If a command is not registered because a file/module is not
loaded, the sequence should not be loaded either.

Change-Id: I45d86ad371c7b717601b6593eaa573292ebdd4ed
 2015-10-22 15:15:41 +01:00