I don't think it make sense to always fallback to the inital mode.
The wikipage.diff hook can be fired from 3rd parties to update the
diff. If the users then changes the mode inbetween without a page
reload, every following diff page update should have the latest
option as a default instead of the original option.
Bug: T346369
Change-Id: I2d0f6cbb89a2d98f247fcd77fa4d79708a4220c1
Since Parsoid now treats DEFAULTSORT like any other template, we have to
scan mw:Transclusion spans.
Bug: T337398
Change-Id: Icba92fc14c1c56ec4711ba49407e8be368d57842
New changes:
b3a237415 Grunt: Simplify ignore pattern for node_modules
78bbdf1d4 Localisation updates from https://translatewiki.net.
538d8ad4d Make VisualDiff#compareNodes static
8652432c4 Tree diffs: Add failing test case for templates in table diff
79eebb566 Tree diffs: Use VisualDiff#compareNodes
32d8c3180 Tree diffs: Use compareElementsUnannotated when comparing structural nodes
53970774a Visual diff: Describe list type changes
23cd3d886 Update diff-match-patch, removing cleanupSemanticLossless
Bug: T332791
Bug: T337698
Bug: T346424
Bug: T350032
Change-Id: I1707d50b06703aae74c654e354cce95541ac5a96
In MediaWiki, OO.ui.getTeleportTarget() is overridden to return
a different element (itself attached to body), which is supposed
to be styled appropriately by skins (e.g. z-index above any
floating header, font-size same as body text, etc.).
As a result, we no longer need to do weird things with the
'vector-body' class to achieve correct font size on Vector,
and we can remove some font-size overrides for Vector and MonoBook.
Bug: T348288
Bug: T339058
Change-Id: I6329b3023573b3dcfc8f471c4693be9bb1e9e430
According to EventLogging 'editattemptstep' data the error hasn't
happened in the last 90 days.
It probably can't happen since we switched from RESTBase to direct
Parsoid access, but keep the checks as assertions just in case.
Change-Id: I0bad1e4364c2f1b154383bc1a984c4ccc83e1700
The wikitext table tool is re-using messages meant for other
things anyway, so might as well use a message that is still
in use elsewhere, as opposed to one for a tool that was removed
7 years ago (in Ife3f3505b845d).
Change-Id: I305f5f5a67e0340f89160e6654ad86f81609f9ab
Was lost when we converted it from a PopupTool
in I81d217bc1ab9.
Also visualeditor-help-title is unused since that commit,
and remove debugging code.
Change-Id: Ic1d40bac8ef76fbb6f009dd8cecec8dc74c1aa4b
New changes:
ea961803e Localisation updates from https://translatewiki.net.
c886092d3 Attach content to teleport target instead of <body>
bacf54a22 Localisation updates from https://translatewiki.net.
c1562081b Consistent usage of header/title in toolbar groups
f8a25c2ca Remove unused messages
af9ff31db Fix remaining uses of 'parent'->'super'
Local changes:
* Remove references to unused messages
Bug: T120821
Bug: T348288
Change-Id: I82dbbc5a8f82ca6bb5b225cb1c2e1734470ed9c8
This number is from 2020. It's certainly meaningless by now. Even
causes extra confusion, see e.g.
https://www.mediawiki.org/wiki/Topic:Xsi5ull7fkcnbzuw
Depends-On: If1bbb57919af4948cecb0a63472ac323175f90c1
Depends-On: Iaae0ac43174f471d8d210958704f98182e9979c5
Change-Id: Iaa56abbc7b54f4a551ca330ff08d542cb5a2b895
Using 'mediawiki.skin.variables.less' with Codex tokens now that
it's available. Also removing a comment that's OOUI variable specific.
Bug: T334934
Change-Id: Id697baa9537013c9e240dbfaa9ead1eb15280133
The observation that the href for wrappers with mw-file-description
class will be the same as the resource still holds. However, on the
other end, if the href is null, setting it to resource doesn't work.
Timed media and when the "|link=|" media option is used, result in an
imgWrapper that's just a span and wouldn't have an href.
This patch fixes a dirtying of timed media in galleries that was
preventing selser from being used. Note, that <source>s in <audio> and
<video> tags are still dropped, so selser won't work yet.
Change-Id: Iefc520b8513e833665dae9d5c3a9dca2762264a6
Follow up to I02ea8421e468635ba6297bb5cda488a5a79c9a1d the depends on
I7a5c24f6ffc15ff0455adf5b025b695ee71501b6 in Parsoid.
Note that the mediaTag isn't currently being passed around for gallery
image nodes so, for example, a <video> becomes an <img> as is. But,
that's independent of this patch, and a follow up will fix it.
Noted in T348703#9278332
Bug: T348703
Bug: T214603
Change-Id: I5f7d3dfe0a41fac1568c97dccc41209c14e741d0
Replacing several values with MediaWiki skin variables featuring new
Codex design tokens, available since >= v1.41.0.
The values are 1:1 visual replacements in the default Codex
'WikimediaUI' theme, a continuation of the base vars, and the default
for Vector and MinervaNeue skins.
Also replacing
- other static color values with variables
- and outline value as the Codex default brings an accessibility
advancement for free
Bug: T334934
Change-Id: I512427803cffce1c16879015c45cf1e35fe17480