The only places where this dialog is used now will have the same
button labels and format. We want to use "normal" destructive here
so no additional "primary" styling.
It seems that the focus on the action will only be applied
automatically when it is primary. So extra code is needed.
Bug: T299647
Change-Id: Ib5250b79e85d27ea197b83c6380863d0749e5d89
The search field is of not much use when there is not really anything
to search. It wastes more space than the actual list of parameters.
Approved by UX, see T298259#7626538.
Bug: T298259
Change-Id: I01784a1c463d8b0b504897b20179719f91597d19
New changes:
73e2b73c4 Localisation updates from https://translatewiki.net.
4e7e0a002 DiffElement: Handle diffs where ref list groups are inserted/removed
1cf051b44 VisualDiff: Remove documentation of non-existent params
Bug: T298569
Change-Id: Ie8d438a894f6152cb4431da46c3fe3b28ced0dd9
For most nodes, isDeletable() returns false on desktop and true on
mobile. Change e0bbf0b979 meant to
change the desktop version to depend on the new config settings, but
accidentally changed mobile too.
Bug: T298828
Change-Id: I8ec5e8031a27eee18c16dfcd267937cc76722c50
Double clicks have been tracked as "window-open-from-command", but are
now tracked as "window-open-from-context". This patch changes this
back.
Bug: T297773
Change-Id: Icabc5db526c35d681d077043c54ca009b2296bbe
The first click opens a little context menu (…ContextItem in the
code). This patch makes a double click trigger the "Edit" button in
this context item instead of executing the "open window" command
itself. This is needed to trigger the "Loading…" code in the context
item.
Bug: T297773
Change-Id: Ie1daa2e6b460c5c506a847bd767af2cb48e73a61
From the user's perspective nothing changes. A template without
parameters doesn't show anything. (Technically there was an empty
<div>, but it doesn't do anything.) The moment the first parameter
is added the required sub-widget is created and available from there
on.
This saves loading time and memory, especially when a multi-part
template contains many templates without parameters.
Bug: T298259
Change-Id: Ib1bd2cd0be4fece4acc92e6e5f63133a7986cf81
The checkboxes are actually indented a bit more than the search box
with this change the extra indentation is applied and the hide
button text is alligned accordingly.
Bug: T298259
Change-Id: I5508ab883c23e7285c023dc127529ffa4dbe58c7
From the user's perspective this is the same as before: When a
template doesn't have any parameters, there is no search field. The
moment the first (undocumented) parameter is added the search field
appears.
This is just delayed now. The widgets are only created the moment
they are actually needed.
This saves loading time and memory, especially in a multi-part
transclusion with many zero-parameter templates.
This also makes it a lot easier to change the minimal number of
parameters from 1 to e.g. 4.
Includes reverting the flexible header composition done in
Ib050e30a50ef965c1524e977d3a600c3ff836774
Bug: T298259
Change-Id: Ied7541d8d5c0b478a439dd31ce072e634287f181
New changes:
0c1a95a5d Localisation updates from https://translatewiki.net.
0f31d4996 DiffElement: Add test cases for table merges
89356a90a DiffElement: Improve description of colspan/rowspan changes
0cb95be10 DiffElement: Add more table tests
82b1d170c DiffElement: Move some more var declarations inline
3bf324d84 DiffElement: Handle a node index of 0
429dd0c56 DiffElement: Show whole node when DocList has attribute change
ed551058c Follow-up I1bd7171: Test colspan/rowspan values of 1 being the same as undefined
7a5a14235 DiffElement: Collapse tree diff with no described changes
07ff4af98 Follow-up Ib79a964c: Fix test HTML
3f5bb3be4 Follow-up I9a67730: Pass current list node to appendListItem
83c3e959b Improve AlienNode matching
9fa17d0a3 Alienate when trying to <p>-wrap an annotation where <p> isn't allowed
653dd2d58 DiffElement: Handle AlienBlockNode in list
20902e538 DiffElement: Fix rendering of internal list items with multiple child nodes
Bug: T259957
Bug: T278186
Bug: T299475
Change-Id: I88a1c8ce43e129f2117672d8f7570dca19d6c608
The search field will stay at the top of the window while scrolling a
single template. In multi-part transclusions, the header will also
be sticky.
Hides the template header in single-part transclusions.
Bug: T298618
Change-Id: Ib050e30a50ef965c1524e977d3a600c3ff836774
New changes:
1685748d5 Tests: Add tests for ve.ce.Surface#getViewportRange
d7d777667 getViewportRange: Handle node not being rendered
61ee718b4 ve.ce.Surface: Use selectFirstVisibleContentOffset when focusing a document
Bug: T296910
Change-Id: I3e7dd7095d10d618e0f2c6da8021eadd0ec92da2
New changes:
d90d1fb78 DiffElement: Change order of z-index fixes
bb46539c9 DiffElement: Move more var declarations inline
eb46b62ed DiffElement: Make processQueue a method
12c078f2c DiffElement: Separate processQueue and renderQueue
57e82187b DiffElement: Collapse context to spacers in isDiffedAsDocument nodes
Bug: T188170
Change-Id: Icf1ecd042d8c1da99d665580a4c16c1a55b5b53a
New changes:
67d78e763 Fix type hint in ve.ui.Command
c0a5da784 Use boolean RegExp.test() instead of .match() where possible
2a7c5f994 Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused
c55e24a67 Always convert to wrapper paragraph inside lists
Bug: T297773
Bug: T298609
Change-Id: Ic100641be04c81e17627c820d7dde10cd98ce4d8
New changes:
c138462d7 selectFirstVisibleContentOffset: Only apply line height hack when scrolling
1982be888 ve.dm.example: Build test code for commentNodePreview using a real widget
70c15c80b Update OOUI to v0.43.0
29482de0f getViewportRange: don't error in a no-contentoffsets document
Bug: T296910
Change-Id: I1bb6aa75b28f263543ea069496cf34bdaa5d02e0
