Commit graph

21142 commits

Author SHA1 Message Date
jenkins-bot 51d89e53bc Merge "Use arrow callbacks in other modules" 2024-05-09 11:19:08 +00:00
jenkins-bot c53bdb8407 Merge "Convert local functions to arrow functions and remove this bindings" 2024-05-09 11:17:01 +00:00
Ed Sanders 72048d59b0 checkModules.js: Warn about unused ignore paths, and remove currently unused ones
Change-Id: Icaffa37d540cab11fb7344a8e0d6371d6a3be0ac
2024-05-09 11:16:39 +01:00
jenkins-bot c24d3e02f6 Merge "checkModules.js: Use require to load JSON" 2024-05-09 10:11:59 +00:00
Ed Sanders 2eafc3ddc2 checkModules.js: Run as part of CI
* Add to npm run test, and exit with error code
* Improve output message, with instructions on
  how to add to ignore list.

Change-Id: Id4ed56673e84073ac06468bdc429c138466e2501
2024-05-09 11:07:37 +01:00
Ed Sanders fc9c8bed20 checkModules.js: Move out of build/tasks
All scripts in build/tasks get loaded by grunt, which
we don't need this script to do.

Change-Id: If4b97e5d3f31214e160d35bf0e72bffe5c3ecd04
2024-05-09 10:53:25 +01:00
Ed Sanders 28f14321b6 checkModules.js: Use require to load JSON
Change-Id: Id91314272f7170b6e66746bc63fce2d3df9e4bbd
2024-05-09 10:49:34 +01:00
Ed Sanders 1980827aec Use arrow callbacks in other modules
Change-Id: Ib07720923de6657ae55ac29a07c5cc85b088a70d
2024-05-09 10:33:44 +01:00
Ed Sanders a5de8d5653 Convert local functions to arrow functions and remove this bindings
Change-Id: I7987de8737103a1fc568944496c4d707dde60bc3
2024-05-09 10:33:44 +01:00
Ed Sanders d8e803818d Remove trailing whitespace breaking CI
Change-Id: I56e688edb2bc8eb26d9a91a4be5e03bd7816e549
2024-05-09 10:33:20 +01:00
Translation updater bot 7622d72592 Localisation updates from https://translatewiki.net.
Change-Id: I70f34840a4085c36779f01991d6cf28fb3de5357
2024-05-09 09:41:06 +02:00
Translation updater bot 78abaa7ee6 Localisation updates from https://translatewiki.net.
Change-Id: Ie14f7e6a53bf09b10840496f7c056fbdb012302a
2024-05-08 09:24:31 +02:00
Bartosz Dziewoński 12613a6ad0 Disable eslint security regexp warnings
They generate a lot of false positives in this extension.

Since this is client-side code, the worst that could happen is a
browser tab hanging, not any real security issues.

Change-Id: I177cfa7e57a6b7b528d558d2cba076e85fd0271f
2024-05-07 20:54:42 +02:00
jenkins-bot ebfd3299c7 Merge "Parse a message correctly" 2024-05-07 18:45:05 +00:00
libraryupgrader 70c2179025 build: Updating npm dependencies
* grunt-banana-checker: 0.11.1 → 0.12.0
* jsdoc-wmf-theme: 1.0.0 → 1.0.1

Change-Id: I18e09b6afbefa39fd79d1315dd435d763be63812
2024-05-07 13:08:22 +00:00
James D. Forrester 73f31545cc Update VE core submodule to master (273812741)
New changes:
7f2382ade Convert local functions to arrow functions and remove `this` bindings
273812741 build: Update grunt-banana-checker to 0.12.0

Change-Id: I816e212d3d83da464e83620a02e4eb39dd1b7d4f
2024-05-07 14:07:59 +01:00
Amir E. Aharoni 3ab0128bfd Parse a message correctly
Follow-up to
I2495fe32c2d540be50450d715b049173f2f8727d

Done with the help of Matma Rex at Wikimedia Hackathon 2024.

Bug: T361103
Change-Id: Ica328233cb6172277e66d2341cfb53f87f8aff67
2024-05-07 12:06:37 +00:00
Translation updater bot c6499e166a Localisation updates from https://translatewiki.net.
Change-Id: Ib82c353d3ed2323d5167d5932396cc1770e5a21a
2024-05-07 09:23:53 +02:00
Translation updater bot f049c5f76a Localisation updates from https://translatewiki.net.
Change-Id: I0ee0490814fad24dd0f2296713e5f83bf52117b3
2024-05-06 09:26:50 +02:00
jenkins-bot 4fa86e99f8 Merge "Update minus-x to 1.1.3" 2024-05-04 17:17:20 +00:00
Alexander Vorwerk 63deb35205 Update minus-x to 1.1.3
this repo is a libup canary

Change-Id: Ic89fd967fae36eb252a7635f209bbe30de0467e4
2024-05-04 18:38:03 +02:00
James D. Forrester 0d48df9927 Update VE core submodule to master (55a4050b9)
New changes:
14e855b40 README.md: Update doc link; add coverage; drop live demo
074cc8bde README.md: Fix Coverage/Code coverage link name split
f94cae724 JSDoc: Load all theme plugins
608c8194c README.md: Mark [[mw:VisualEditor/Setup]] link, as JSDoc doesn't autolink
9e65bfde3 eslint: Switch all code from jsduck to jsdoc mode
fdc0addee Prefer short arrow functions
5bbdc2f3e JSDoc: Fix some missing complex returns types
00b5bcdc4 Use ES6 variadic arguments
0a4a7e3a7 JSDoc: {Mixed} -> {any}
419162782 LanguageInputWidget: Fix logic for checking if language exists
2bc827327 Use more variadic args

Change-Id: I40fdc33b7b46fb38c597308e2615a37c89406378
2024-05-04 18:33:44 +03:00
jenkins-bot 6bdd8e21a3 Merge "Fix displaying of "<Invalid>" when an language code isn't found" 2024-05-04 14:48:12 +00:00
Amir E. Aharoni c1386d615f Replace <> with <em> in a message
Bug: T361103
Change-Id: I2495fe32c2d540be50450d715b049173f2f8727d
2024-05-04 08:36:49 +00:00
jenkins-bot 8f75500ef7 Merge "Fix media dialog layout." 2024-05-03 23:23:17 +00:00
Ed Sanders acd075a4d7 Fix displaying of "<Invalid>" when an language code isn't found
Bug: T361109
Depends-On: I1e85a9d41c017fc3e3897b8b69177f342c5a43ef
Change-Id: I2ef072c3265fa9477ca2be539a7084454a8d8cae
2024-05-03 17:38:14 +01:00
Ed Sanders eb757c4c9f Remove unnecessary context binding when using arrow functions
Change-Id: Ie25e90aeb0519b1e0f793348b27d4d4a6b686698
2024-05-03 12:47:47 +01:00
Translation updater bot 9fa475d66e Localisation updates from https://translatewiki.net.
Change-Id: I1780f8a639f94bd051f60d20c73481a8887e5635
2024-05-03 09:29:54 +02:00
jenkins-bot 8a35d3cf83 Merge "JSDoc: {Mixed} -> {any}" 2024-05-02 18:20:12 +00:00
Zoë f0cef27552 Fix media dialog layout.
Restored a selector lost in Ic9fad12f

Bug: T363992
Change-Id: I68b3052665db6ad09c594debbc593b11b7edebff
2024-05-02 18:59:29 +01:00
libraryupgrader c107fd0cd8 build: Updating ejs to 3.1.10
* https://github.com/advisories/GHSA-ghr5-ch3p-vcr6

Change-Id: I5473d3a5535044973edf4904a32e1df559d94e33
2024-05-02 15:06:18 +00:00
Ed Sanders 29e42695e4 Follow-up Ifdb15ea9: Restore deleted 'new' keyword
Change-Id: I6cd6a617ae63347df1a2b7de111cac6860950cf3
2024-05-02 12:28:51 +01:00
Ed Sanders 673dea4852 JSDoc: {Mixed} -> {any}
Change-Id: I457475a9c436c40a384675027c052294e6b1305d
2024-05-02 10:39:25 +01:00
Translation updater bot c05851aa4f Localisation updates from https://translatewiki.net.
Change-Id: I883d7f93aee32b044635d3072952284d7dbc1491
2024-05-02 09:20:26 +02:00
Timo Tijhof 6cbedbf9d2 tests: Adopt QUnit.test.each() and native async-await in a few places
* Remove need for manual hacking of sub groups via "msg" strings
  carefully prepended to every assertion.

* Improve CI details, by reporting the specific case that failed,
  and local dev via ability to re-run each case, and reporting names
  directly in the HTML Reporter and CLI summary.

* Reduce need for assert.async() and tracking of callbacks, especially
  to improve failure details in case of Promise rejection.
  Current logic was likely to cause a confusing timeout instead of a
  clear failure if the promise ends up rejected.

  QUnit propagates these as part of awaiting and asserting the test
  closure's promise value (as async fn) automatically.

  This approach also avoids the pitfal of a falsely passing test
  when an assertion inside a done() handler was never reached.

* Use modern for-of where possible to remove need for closures and
  arrow functions. Thus reducing complexity of test code, where
  complexity should be kept lowest to avoid false confidence.

* Use plain for-in instead of overly complex Object.keys().forEach().

Change-Id: I934a266e75e64371081f104cfb867fb2c282c84a
2024-05-01 19:01:19 +01:00
jenkins-bot a85e1f44e4 Merge "Use forEach loops for cases" 2024-05-01 15:22:39 +00:00
Ed Sanders 4db99d7a27 Use more arrow functions
Change-Id: Ifdb15ea9e5ca606e02ddaf822bfd6397c3ce639e
2024-05-01 14:11:55 +01:00
Ed Sanders 33db46e6fa Use arrow callbacks with OO.ui.Process
Change-Id: I9bf32a382ffc2c0f1915f70bd8909668722cfb16
2024-05-01 14:11:55 +01:00
Ed Sanders e3659d4846 Prefer arrow callbacks
Change-Id: Ia05b27f7c71c33580ffd0718e3bbc673dd8b3d63
2024-05-01 14:11:54 +01:00
Ed Sanders c360e550de Fix incorrect uses of context
Change-Id: Ib8b2dd12db567e9373b633c5c7a0b2990c638d97
2024-05-01 14:10:32 +01:00
Ed Sanders e382d3af0a Use forEach loops for cases
Change-Id: Ica8773f54572bd90d4ee1ecde43254331fd2e313
2024-05-01 14:02:29 +01:00
jenkins-bot 92b82c67fe Merge "docs: Escape __magicwords__ to avoid bold formatting by markdown" 2024-05-01 07:45:35 +00:00
jenkins-bot a8a19e9975 Merge "Readme: Mark links, as JSDoc doesn't autolink" 2024-05-01 07:44:09 +00:00
Translation updater bot 43c0ac58a6 Localisation updates from https://translatewiki.net.
Change-Id: I36167ac379fe1789c15b9f9fff0b08b5ad1c2e8e
2024-05-01 09:23:00 +02:00
Ed Sanders 41cce182fe docs: Escape __magicwords__ to avoid bold formatting by markdown
Change-Id: Ic4660b12091429dd3f34d241b326350049a0019a
2024-04-30 22:32:03 +01:00
jenkins-bot 5c929ab457 Merge "Rename isModified to isSaveable and deprecate the old name." 2024-04-30 17:14:58 +00:00
jenkins-bot 3fec1cf55c Merge "Confirm abort if saving would make a change to the underlying document" 2024-04-30 17:14:47 +00:00
jenkins-bot ff6ea23256 Merge "Remove unused files" 2024-04-30 16:48:50 +00:00
Zoë 2df1b00f18 Rename isModified to isSaveable and deprecate the old name.
Bug: T334513
Change-Id: I9f639dae88787774cf362c15cd134d50bd73abee
2024-04-30 16:43:01 +01:00
Zoë a6f826e989 Confirm abort if saving would make a change to the underlying document
Bug: T334513
Change-Id: Ia8935b5b1acb87a351fd02d07f72875e4d7a005c
2024-04-30 16:20:45 +01:00