Commit graph

13628 commits

Author SHA1 Message Date
jenkins-bot 12e8f5cdbb Merge "init.mw.Target: make getSurfaceConfig aware of modes" 2017-10-10 22:02:36 +00:00
Translation updater bot f6d891b216 Localisation updates from https://translatewiki.net.
Change-Id: I7b4a7018ede70f025c9d6969b7fba07794604754
2017-10-10 23:13:47 +02:00
David Lynch 4e938e58c7 init.mw.Target: make getSurfaceConfig aware of modes
ve.init.Target sets up TriggerListeners based on getSurfaceConfig if there's
no Surface instantiated. As such, loading directly in source mode would have
those listeners present and assuming the document is in visual mode. So, if
there's not a Surface already, we'll assume we're going to get one created
with the defaultMode, and set things up expecting that.

Bug: T153959
Change-Id: Ia0afe32e6b63ea0d3418137ca5c8bc32c009ecfa
2017-10-10 15:14:25 -05:00
jenkins-bot 762429e99f Merge "DesktopArticleTarget.init: Load 'mediawiki.action.view.postEdit' via loader" 2017-10-10 05:04:22 +00:00
jenkins-bot 220771a812 Merge "Update VE core submodule to master (c5c5123)" 2017-10-09 21:12:14 +00:00
Translation updater bot bfe3e66c5e Localisation updates from https://translatewiki.net.
Change-Id: Ib298629b582138e653c5e807c09a76339544fb8f
2017-10-09 23:11:04 +02:00
Roan Kattouw 48826bd0f0 Update VE core submodule to master (c5c5123)
New changes:
1c8ca38 Don't assume events have an originalEvent object
c5c5123 Localisation updates from https://translatewiki.net.

Bug: T176104
Change-Id: I2e503ee6b3d4484a4f1b3567fde7281bef68a7b9
2017-10-09 13:59:54 -07:00
James D. Forrester 307f6c605b Update VE core submodule to master (4e29d197d)
New changes:
b64a2a6db Replace abandoned colors wo WikimediaUI palette ones
4e29d197d Align `border-radius` to WikimediaUI Base values

Change-Id: I8c1d68346ba189cf77f004553923c21b405a33e7
2017-10-06 18:15:31 -07:00
Translation updater bot 1d689c9bd2 Localisation updates from https://translatewiki.net.
Change-Id: Icd5cecac5b2d5c7f21b9f2bd9450f8c5f191cd11
2017-10-06 22:58:01 +02:00
James D. Forrester bd2deb3ac4 DesktopArticleTarget.init: Load 'mediawiki.action.view.postEdit' via loader
Bug: T164148
Change-Id: I537144bfd52ff84499f5d086f5d05efe2ba0493b
2017-10-05 15:54:20 -07:00
Translation updater bot ccac68067f Localisation updates from https://translatewiki.net.
Change-Id: I728c4e56f6e5a91ddca133607a01cfb910e4be61
2017-10-05 22:58:55 +02:00
Ed Sanders 43763f0a75 Target teardown refactor
* Rename 'deactivate' to 'tryDeactivate' as it may prompts
  the user to deactivate.
* Merge 'cancel' and 'teardownSurface' in to 'teardown',
  extending the parent method.
* Rename elementsThatHadOurAccessKey to $saveAccessKeyElements
  and move teardown to parent class where it is setup.
* Move toolbarSaveButton teardown to parent class where it is setup.
* Cleanup changeDocumentTitle

Depends-On: I9d97614695272dca6936ef6f3461178fcf0368a8
Change-Id: Ie998a04c21f6615b4415edf471310db5edca3b5a
2017-10-05 10:26:46 -07:00
James D. Forrester 0b574b88b8 Update VE core submodule to master (0c062b9b2)
New changes:
0aa3e79d2 Update OOjs UI to v0.23.3
0c00812bc Localisation updates from https://translatewiki.net.
0c062b9b2 Cleanup target teardown API

Change-Id: I41e07963a6565ed29752645ae8acf64350daa677
2017-10-05 10:26:05 -07:00
jenkins-bot 65ede4fc4f Merge "Use destroy event to teardown new section inputs" 2017-10-05 17:24:57 +00:00
jenkins-bot 5d9c66497a Merge "Use parent #clearSurfaces method to clear surfaces" 2017-10-05 17:22:41 +00:00
jenkins-bot e657612068 Merge "Strip RESTBase IDs from historical diffs" 2017-10-05 16:06:43 +00:00
jenkins-bot db438b436e Merge "Make sure content is set" 2017-10-05 15:59:09 +00:00
Ed Sanders 1256b19d72 Use destroy event to teardown new section inputs
Change-Id: I4990a162b62b7195016efba47cc5926b9e3a0f21
2017-10-05 16:20:48 +01:00
Ed Sanders e0f7f30bbd Use parent #clearSurfaces method to clear surfaces
Move mwTocWidget teardown to a destroy event listener.

Change-Id: If96be96aa67da55d3b17dd2565f5e954786ff3ff
2017-10-05 16:03:55 +01:00
Ed Sanders a1583a7310 Move 'parentheses' message to MWSaveDialog's modules
Bug: T177446
Change-Id: I26a1a5eed5aca4dec55624927011204eb4d1c263
2017-10-05 13:11:56 +01:00
David Lynch 9878f4ddeb Make sure content is set
Change-Id: I59a5146a1186937a643818d02441563c5cc63319
2017-10-05 00:43:48 -05:00
Translation updater bot e0d047973a Localisation updates from https://translatewiki.net.
Change-Id: I5762bd8184d2b88c686f8b1c27787a6c279bbd73
2017-10-04 22:59:44 +02:00
jenkins-bot 2df3e5dc32 Merge "ApiVisualEditor: avoid some unset variable notices" 2017-10-04 15:58:37 +00:00
jenkins-bot 6e2589d1a6 Merge "Abort loading when 'escape' is pressed" 2017-10-04 15:40:57 +00:00
David Lynch c89a2a9e76 ApiVisualEditor: avoid some unset variable notices
Bug: T176440
Change-Id: I571fbea79bd7f656cd367a5d8a773408fd80c7cf
2017-10-04 09:44:58 -05:00
Ed Sanders 58237588ad Abort loading when 'escape' is pressed
Bug: T117359
Change-Id: I2c60588f14b9f80b18a7ac8da753fee224be35a4
2017-10-04 14:09:19 +01:00
jenkins-bot 28d4ed974f Merge "Remove reference to editfont-default" 2017-10-03 18:48:21 +00:00
jenkins-bot d0193b3eda Merge "Update VE core submodule to master (cb52d8b7a)" 2017-10-03 05:06:36 +00:00
Ed Sanders ff896e0be6 Always use trackingName for tracking
Change-Id: Ifc7d3275277628b310f5c017c43a76f5a7c25ea7
2017-10-02 22:20:53 +01:00
James D. Forrester 09cde07c45 DesktopArticleTarget: Retain 'mwTarget' stats tracking object
Bug: T177250
Change-Id: I1584f452e16272886af459bac3e24c4995af2231
2017-10-02 21:03:09 +00:00
jenkins-bot fb4bb65a74 Merge "Allow MediaWiki extensions to use self closing tags" 2017-10-02 18:04:08 +00:00
James D. Forrester 8c611571d8 Update VE core submodule to master (cb52d8b7a)
New changes:
46c8b6ec8 ce.Surface: in observed selection changes, only make cursorable selections
0c76240a4 Localisation updates from https://translatewiki.net.
cb52d8b7a Follow-up Iea80013: Re-define this.$bounding after GCN re-render

Bug: T148679
Bug: T176766
Bug: T176936
Change-Id: I3b6e156e007a7bdda427225f6c85d1a7ebca3f41
2017-10-02 10:55:01 -07:00
Ed Sanders cd097bed3d Allow MediaWiki extensions to use self closing tags
Parsoid now supports this by setting body to null.

Change-Id: I24d856f0cffeacb00cb2b757e34315bc02b595d0
2017-10-02 10:52:48 -07:00
jenkins-bot 21bd98df61 Merge "ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission" 2017-10-02 17:44:46 +00:00
jenkins-bot e7ac894a94 Merge "MWExtensionWindow: Always send a string to setValueAndWhitespace" 2017-10-02 17:25:02 +00:00
jenkins-bot 2d2ed0094f Merge "MWAlienExtensionNode: Listen to attribute changes" 2017-10-02 17:22:51 +00:00
Ed Sanders ddc056a40a MWExtensionWindow: Always send a string to setValueAndWhitespace
Bug: T177180
Change-Id: I3a32e1b22e82bc0c182d26a952e7592aafd4b5e4
2017-10-02 16:26:16 +01:00
Ed Sanders 852e1ababe MWAlienExtensionNode: Listen to attribute changes
Also:
* Disconnect change event on this.input, which doesn't
  get destroyed on teardown
* Add padding between attributes and this.input
* Assume the alien extensions can have a rendering when
  their body is empty.

Bug: T177181
Bug: T177183
Change-Id: I2e59f8195b255f33f91901213c92ea14793635b4
2017-10-02 16:22:41 +01:00
Bartosz Dziewoński 2b3998df4b ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission
Bug: T177041
Change-Id: I28a7ec0710595977e5ec889016dd280d60e93034
2017-10-02 17:09:04 +02:00
Translation updater bot e667ebe5cb Localisation updates from https://translatewiki.net.
Change-Id: Ifd08290884dbeed1cc97dd04159d2b6161b31ce5
2017-10-01 22:48:18 +02:00
Translation updater bot 4ca4ddd991 Localisation updates from https://translatewiki.net.
Change-Id: I2ad37bcad504d1c0a6fb94e20fa9dc16f5003f59
2017-09-30 23:02:54 +02:00
jenkins-bot ff7c57489a Merge "Set padded=false for link inspector" 2017-09-29 16:42:29 +00:00
jenkins-bot e4ef863b4d Merge "Update VE core submodule to master (84ec68dfb)" 2017-09-29 16:39:37 +00:00
jenkins-bot 8032b97fa9 Merge "Remove upstreamed link inspector page icons" 2017-09-29 16:37:12 +00:00
Ed Sanders 582a3e62fb Remove upstreamed link inspector page icons
Change-Id: I997b299d9a61ec9307025a7f4d106f185283eb40
Depends-On: I297648d14b4a2540a40f3a0b7d22a7905ef7c035
2017-09-29 16:27:50 +00:00
James D. Forrester fb053d1418 Update VE core submodule to master (84ec68dfb)
New changes:
ade04f53b Highlight locale substring match in language search
6b21b1962 Unify monospace font family stack
015d19968 Detach icon before updateInvisibleIcon
5092d2e8c Follow-up Iea80013: $attachable -> $bounding
a564d5ace Localisation updates from https://translatewiki.net.
84ec68dfb Make a clear API for setting inspector padding

Bug: T176636
Bug: T177080
Change-Id: Ia8fea335a41342fcdb86fd691966624ce57e95e3
2017-09-29 12:26:00 -04:00
Ed Sanders ef46e45b43 Set padded=false for link inspector
Logically depends on I615b485a272.

Bug: T177080
Change-Id: Ica54238d891fa41eefb0b9216eb4f2190818a502
2017-09-29 16:14:29 +01:00
Željko Filipin fe09c22e33 Delete Ruby Selenium tests
Tests are broken most of the time. Ruby framework will be deprecated next month. Selenium tests
that are needed should be implemented in Node.js.

Bug: T164479
Change-Id: I8ec1d9b19b9538936c508daf2b50249a705b3170
2017-09-29 16:55:12 +02:00
Ed Sanders dc500697e1 Follow-up Ia08dbb44: $attachable -> $bounding
Change-Id: I88101426998c7f11a7dfd3b971a1274e5aad638a
2017-09-28 17:36:37 +01:00
Bartosz Dziewoński 81d567bfdc ve.init.mw.DesktopArticleTarget: Fix the code to reorder tabs
This code is meant to fix up the tabs if wgVisualEditorTabPosition
was changed and we're seeing cached HTML with the tabs in wrong order.
But it seems it has never worked. `$caEdit[ 0 ].nextSibling` is a text
node and obviously not equal to `$caVeEdit[ 0 ]`, and vice versa for
the other case. The logic is actually correct, so let's fix it to skip
over text nodes.

Also, remove a stray 'eslint-enable' comment left over in
a0f934ed26.

Bug: T50017
Change-Id: I23663a9bfcfdbf52918452c878a128e6960b1191
2017-09-28 15:54:55 +02:00