Commit graph

17513 commits

Author SHA1 Message Date
Ed Sanders 1ec49384dc MWSaveDialog: Use MessageWidget (inline, warning) to show save dialog warnings
This is the same style that is recommended for form warnings.

Change-Id: I163f5180c66b9eb165a610184b153bb1da99caab
2021-01-20 19:41:17 +00:00
Bartosz Dziewoński bb4b06275a Update VE core submodule to master (36e21385b)
New changes:
b92ce3445 Add missing check for move=null in internal list diff
f503f6aa9 Deduplicate logic for marking data/HTMLElement as moved
36e21385b Create a separate descriptionItemsStack for each reflist

Bug: T272314
Bug: T272315
Depends-On: I9a73d0e0ee3c8b12e0b5c3202eb5882258539920
Change-Id: Idcd11e864cde5ff3dab52898b9ce1f3797c69424
2021-01-20 18:57:36 +00:00
Translation updater bot bc11188d0c Localisation updates from https://translatewiki.net.
Change-Id: I018d3c70c1855ff007313fb840f2cf51535b847f
2021-01-20 08:27:41 +01:00
Ed Sanders 4e33a6ff0a Follow-up e04e98458: Add missing "Moved down/up" messages
Change-Id: I3cea39f7915e1627f68c3280357517e607b90772
2021-01-19 22:55:03 +00:00
Translation updater bot 04e3657b11 Localisation updates from https://translatewiki.net.
Change-Id: I467480f8b98763cdf4bf6c989185b6abd43170b1
2021-01-19 08:20:28 +01:00
Bartosz Dziewoński f888ebe04c Update VE core submodule to master (c7ecbcb39)
New changes:
5def0c76c setNullSelection: don't clear a selection outside the surface
da7ee751f Localisation updates from https://translatewiki.net.
af8193cf6 Cache offset keys used in adjustmentTree's adjustmentNodes

Bug: T272219
Change-Id: Ied5afcb46b7d75ecdcbd9ab5464ef1d1d6070c72
2021-01-19 01:08:56 +01:00
jenkins-bot 1cc0eae940 Merge "ApiVisualEditor: Return notices as an associative array" 2021-01-19 00:03:44 +00:00
Ed Sanders 5e1b299c0b ApiVisualEditor: Return notices as an associative array
A couple of things make this quite a simple change:
* Most messages are generated from a single message key
* $title->getEditNotices() already returns an array
  keyed in the same way, we just currently flatten it.
* The VE client already flattens the array immediately
  in ArticleTarget#parseMetadata, so no change required.
* PHP preserves the order in which keys are added, not
  that notice order is particularly important.

This partially undoes c824dc383a,
which changed the format from a mixed array to an indexed array.

Bug: T272188
Change-Id: I646667fe2513e371e0c8270761553253d1abe2b6
2021-01-18 23:35:56 +00:00
jenkins-bot 4decac59fb Merge "MWSaveDialog: Remove wrap option from showMessage" 2021-01-18 23:29:34 +00:00
jenkins-bot 59889add65 Merge "MWSaveDialog: Restore focus to edit summary widget after resize" 2021-01-18 23:27:01 +00:00
jenkins-bot da10567e52 Merge "Move newline-stripping filter into MWEditSummaryWidget" 2021-01-18 23:26:59 +00:00
Translation updater bot 515dc166cb Localisation updates from https://translatewiki.net.
Change-Id: I846e4dc3c36f38a80e076e82320d48f60e096451
2021-01-18 08:40:33 +01:00
Ed Sanders e20decc77c MWSaveDialog: Remove wrap option from showMessage
This was used when we used to pass API errors to showMessage, but
is now unused by the two remaining users (missing edit summary, and
"press ctrl+enter to submit").

Change-Id: I8a6b4db78d4e451cf3ec85fcdfd8293328aaaa3c
2021-01-16 16:22:23 +00:00
Ed Sanders 598cb943de MWSaveDialog: Restore focus to edit summary widget after resize
Change-Id: I1fc1e43d947e9e8472a470bb5eabf67fda07be5d
2021-01-16 16:18:18 +00:00
Ed Sanders 443eaded40 Move newline-stripping filter into MWEditSummaryWidget
Edit summaries should always strip newlines, wherever
this widget is used.

Change-Id: I37177771fef831037067d6244fb27cba5e06528b
2021-01-16 16:16:49 +00:00
Bartosz Dziewoński df43a1ef96 Update save failure logging for EditAttemptStep schema, simplify code
* Remove custom internal events in ArticleTarget for every error type.
  The indirection was just making it harder to figure out what data
  goes where.

* Centralize the actual logging in ArticleTarget, instead of doing it
  in a dozen methods.

* Directly use the error code from the API for 'save_failure_message'.
  Previously we'd lose the original error code and generate a new one
  in the event indirection stuff, except for 'responseUnknown'.

* Update 'save_failure_type' map. Remove unused error codes, update
  the ones that changed, and sort in the order in which the types are
  listed on the schema page.

Bug: T272162
Change-Id: Ied602c456f4b0e7e9bb135e3200bec5ce65641ba
2021-01-15 20:06:20 +01:00
James D. Forrester f2c70a25e4 Update VE core submodule to master (462eee058)
New changes:
2f20d3082 Localisation updates from https://translatewiki.net.
0bf82047b stripMetaLoadInfo: Call earlier, and use ve.copy instead of ve.cloneObject
462eee058 Update UnicodeJS to v13.0.2

Change-Id: I48630eac248a068d1e39d5b57892b4a3ac5cf35e
2021-01-15 09:25:40 -08:00
Translation updater bot f246a0584c Localisation updates from https://translatewiki.net.
Change-Id: I926e640d09c686873f9f8963729192d05655dcf8
2021-01-15 08:40:20 +01:00
jenkins-bot 5a370aafb1 Merge "Update VE core submodule to master (ad72a726d)" 2021-01-13 17:38:25 +00:00
jenkins-bot 187a5fe7ac Merge "Preserve vehidebetadialog URL flag when switching editor mode" 2021-01-13 17:38:22 +00:00
Bartosz Dziewoński 91a2683aca Update VE core submodule to master (ad72a726d)
New changes:
dfa40a4a4 Localisation updates from https://translatewiki.net.
5324b686a Localisation updates from https://translatewiki.net.
ad72a726d Don't do whitespace substitutions in hasSignificantWhitespace nodes

Bug: T271198
Change-Id: Id5f6647cf95181f4898e0ff48bd61250fa957202
2021-01-13 18:07:24 +01:00
Translation updater bot fa863e5050 Localisation updates from https://translatewiki.net.
Change-Id: I2a3a2d57f898df39a3a873833d55de89d77864d6
2021-01-13 08:37:20 +01:00
Translation updater bot 8c48722e52 Localisation updates from https://translatewiki.net.
Change-Id: I47271ac438febe5126d9252a526574fdf8c5cb56
2021-01-12 08:38:45 +01:00
jenkins-bot 3bd0d4056a Merge "Instrument media search interactions in MWMediaDialog" 2021-01-11 20:23:40 +00:00
Translation updater bot 15f4812feb Localisation updates from https://translatewiki.net.
Change-Id: I3f4b214d6415cd68c93c31fc60db1541a4a3ae54
2021-01-11 08:35:47 +01:00
Translation updater bot 6b692b944e Localisation updates from https://translatewiki.net.
Change-Id: I8267b01d438e99c28b5124d55a7aa124dbdf1f45
2021-01-08 08:56:42 +01:00
Thiemo Kreuz f1dcc5d3c8 Prefer UserIdentity::isRegistered over isAnon
isRegistered is part of the slick UserIdentity interface, i.e.
it's the more "canonical" form. This change makes it a bit
easier to move away from using the huge (4000+ LOC) User class
everywhere, in favor of the UserIdentity interface, where
possible.

This patch is meant as a small step towards this goal. I tried
to replace some usages of User type hints already, but prefer
to go in small, incremental steps.

Change-Id: I827b83a5304b1975437d5fd5083f2877dba6f6d8
2021-01-07 17:01:22 +01:00
Translation updater bot 621a76b251 Localisation updates from https://translatewiki.net.
Change-Id: I1128d9d1f6d681b9003289cc8a2f18f549db945b
2021-01-07 08:32:54 +01:00
jenkins-bot c4676d025a Merge "Try/catch Uri creation" 2021-01-05 20:11:48 +00:00
jdlrobson b89e97f8d8 Try/catch Uri creation
This is generating hard to filter logspam.

Seen on:
https://no.wikipedia.org/w/index.php?oldid=prev&diff=20998556&title=Uformelt%20spr%E5k

Bug: T270331
Change-Id: I4ba537dbb942e977cb01d5943e83e4646cbccfe0
2021-01-05 19:39:45 +00:00
jenkins-bot 883d37fbb2 Merge "ArticleTargetLoader: Allow customizing 'editintro' parameter" 2021-01-05 14:23:28 +00:00
jenkins-bot 349a6e8568 Merge "ApiVisualEditor: Support 'preload' etc. for new sections in visual mode" 2021-01-05 14:23:26 +00:00
jenkins-bot 47b79cd606 Merge "Update VE core submodule to master (6a765924a)" 2021-01-05 14:02:42 +00:00
Translation updater bot 718a3b3d3b Localisation updates from https://translatewiki.net.
Change-Id: I371f4f2a1e70d6fa1f920004eb04ca4bc614c334
2021-01-05 08:28:43 +01:00
Gergő Tisza c88ee8cd54
Preserve vehidebetadialog URL flag when switching editor mode
Switching from visual editor to old wikitext editor results in a
page reload and loss of the mw.libs.ve.disableWelcomeDialog()
flag. Use an URL parameter to preserve the flag.

Bug: T235812
Change-Id: I3968e5b7ae536d45fd764a8b7c3ea1f6d616033f
2021-01-04 19:54:32 -08:00
James D. Forrester db96090bde Update VE core submodule to master (6a765924a)
New changes:
5a9b8e76f Localisation updates from https://translatewiki.net.
0c6f2ccb8 Link diff: Use getDisplayTitle instead of href attribute
8db7cef9a Localisation updates from https://translatewiki.net.
6a765924a build: Unbreak language lists, adding 'kcg'

Change-Id: I4b4748f7b6be42a19b5ea1cac87b753b923c6f99
2021-01-04 18:13:28 -08:00
Translation updater bot e577416a0e Localisation updates from https://translatewiki.net.
Change-Id: I24c403dbec8b8e75e22284ce9a102623876bc728
2021-01-04 08:45:14 +01:00
jenkins-bot 2d7a9faa9c Merge "AceEditorWidget: Fix toggleLineNumbers" 2021-01-03 01:15:03 +00:00
Ed Sanders 3cde92d60e AceEditorWidget: Fix toggleLineNumbers
Change-Id: I1a48e4351b2249b1ccf0af5c9b2fadd9a97d5f04
2021-01-03 00:23:08 +00:00
jenkins-bot aa58894051 Merge "ApiVisualEditorEdit: the 'html' parameter should be raw to avoid normalization" 2021-01-01 00:33:19 +00:00
jenkins-bot 86a3dd4f9d Merge "Update VE core submodule to master (d0d57d2bc)" 2020-12-31 00:46:28 +00:00
Translation updater bot 94621896a4 Localisation updates from https://translatewiki.net.
Change-Id: I7d2d6b407d9035b05b81e21043d25b1d1c764252
2020-12-30 10:15:37 +01:00
Translation updater bot ac7a16700b Localisation updates from https://translatewiki.net.
Change-Id: I32351fc435270e3dafbc396a40362af996bd4ceb
2020-12-29 09:49:14 +01:00
Ed Sanders a7d7401d40 Update VE core submodule to master (d0d57d2bc)
New changes:
60ea9df7d Localisation updates from https://translatewiki.net.
974f93488 Improve SourceConverter.getSourceTextFromDataRange performance
4bee84667 Revert "ve.ce.Surface: Allow tabbing out of surfaces without indentation features"

Bug: T269094
Change-Id: Ia26537cb67f68c8c7a52aaa1e2c0ce70461901be
2020-12-28 23:16:57 +00:00
Translation updater bot c1f81c7a64 Localisation updates from https://translatewiki.net.
Change-Id: If861741a2bcc9580ef0d915141f1d2764ad7f204
2020-12-28 10:40:30 +01:00
Translation updater bot 85c8c00004 Localisation updates from https://translatewiki.net.
Change-Id: I9d8141534f63909ccda8f2aaf21c6cc33c6e1991
2020-12-22 08:33:15 +01:00
C. Scott Ananian aceea5b623 ApiVisualEditorEdit: the 'html' parameter should be raw to avoid normalization
Although wikitext is (expected to be) in Unicode Normalization Form C,
the output HTML may not be, due to the presence of explicit entities in
the wikitext representing non-NFC codepoints.

Bug: T266140
Depends-On: I2e78e660ba1867744e34eda7d00ea527ec016b71
Change-Id: I0d34c9a01f1132c2616ed3392ea40d8b73e15325
2020-12-21 20:55:37 -05:00
Translation updater bot ad703f1c08 Localisation updates from https://translatewiki.net.
Change-Id: I6861b0c614e98d70f72608d13072cb5c36b079ae
2020-12-21 08:40:39 +01:00
Bartosz Dziewoński e04e984586 Update VE core submodule to master (c20aed327)
New changes:
c66f05d00 Compare meta items by hash
8acd3bf34 ve.ce.Surface: Allow tabbing out of surfaces without indentation features
cf90fc8b9 DiffElement: Simplify data-diff-move=up|down selectors
fd1a8bd03 DiffElement: Ensure move indicators are always visible
c20aed327 Show moves in the sidebar with a label

Bug: T172694
Bug: T270557
Bug: T270561
Change-Id: I107978d8cbd0f910cdf80bf589a595528ca829c7
2020-12-20 19:29:44 +01:00
James D. Forrester 075d976f25 Update VE core submodule to master (3fc99cc9c)
New changes:
d1928f49d Describe text style annotation changes, instead of showing remove-insert
3fc99cc9c Describe link addition/removals

Bug: T160588
Change-Id: I44ffe020e22f8602fc0d5abbac66bfcda0f873e8
2020-12-18 12:49:14 -08:00