Commit graph

15227 commits

Author SHA1 Message Date
Translation updater bot 6b44441632 Localisation updates from https://translatewiki.net.
Change-Id: I26661ef7a280d1c5b95e2c60261cc49a37d8f964
2018-11-29 22:27:56 +01:00
jenkins-bot 98955dfafd Merge "ve.init.mw.ArticleTarget: Stop when we fail to load metadata" 2018-11-29 19:54:36 +00:00
Ed Sanders 041e7b77a1 Create SaveErrorHandler class to better define structure
Change-Id: I036ee32847cc3b25a1cc478247cfe54599781098
2018-11-29 15:47:03 +00:00
jenkins-bot 3878db588d Merge "Remove captcha handler, moved to ConfirmEdit extension" 2018-11-29 03:33:54 +00:00
Bartosz Dziewoński 32f5256736 ve.init.mw.ArticleTarget: Stop when we fail to load metadata
This early return in loadSuccess() has been incorrectly removed in
b2718b186a.

As a very unexpected result of loading the editor twice in case
loading metadata is retried, the "Publish" button was staying
disabled. See the task for investigation.

Bug: T209542
Change-Id: If528afe1ca052062005937f03fe822c5c8d0958b
2018-11-29 04:23:42 +01:00
jenkins-bot fc126c1260 Merge "Rename configs for tracking block notices on visual editor" 2018-11-29 00:43:31 +00:00
Ed Sanders f0295ee01c Remove captcha handler, moved to ConfirmEdit extension
Change-Id: I6938d10d10be80e780294e4d4a32152827ccb5f9
2018-11-29 00:29:09 +00:00
Thalia 2516753c53 Rename configs for tracking block notices on visual editor
* Also make sure block notices have type 'block'.
* Remove old flag for tracking since we'll be using one
  from core

Change-Id: I4b66e73c8a4c4dd7bffd7c0239b1d5ec06eed12f
Depends-On: I6bd1c95548616677e1f72ba6bcfc6f2b551c1ca6
2018-11-28 15:26:15 -05:00
jenkins-bot 4de0e1a04c Merge "MWSaveDialog: Use ve.targetLinksToNewWindow" 2018-11-28 17:05:05 +00:00
Ed Sanders b76e40b2f3 MWSaveDialog: Use ve.targetLinksToNewWindow
Change-Id: I1515901f05de1a7b1ef2aa3cb34f3043ab02acce
2018-11-28 15:44:52 +00:00
Ed Sanders 41bb0a5fd2 Show timings of mwedit events in trackdebug
Change-Id: Ifc2135d99f4bec917dac60992098958b72c37fc6
2018-11-28 12:50:01 +00:00
Ed Sanders 1df0564690 Don't require editSchema to be setup to use trackdebug
Change-Id: I030f5e903d152b1e663f9155ee5235cb611ad63b
2018-11-28 12:49:27 +00:00
Ed Sanders 7dafd87829 eslint: Drop 'dot-notation' rule
Also upstreamed max-statements-per-line

Bug: T210552
Change-Id: Iea5036d5acab8dba46b573ee58da901169b5ab95
2018-11-27 22:41:53 +00:00
jenkins-bot 11f73e89da Merge "Debug flag for tracking" 2018-11-27 21:50:16 +00:00
jenkins-bot e0e40561e7 Merge "Blacklist javascript links" 2018-11-27 21:39:46 +00:00
Translation updater bot ec74391bed Localisation updates from https://translatewiki.net.
Change-Id: I3a93523a02f956183915aac30eb291b0cf4a7ef5
2018-11-27 22:14:46 +01:00
David Lynch bff72c679d Debug flag for tracking
Change-Id: Ie21c9e3a7bbbf4c3575af50acedf0f002d11cfcc
2018-11-27 14:10:55 -06:00
Derk-Jan Hartman 71ceb51c81 Blacklist javascript links
These aren't supported by VE-MW, so must just be
garbage from a browser plugin, possibly Citavi.

Bug: T200971
Change-Id: I9f34e9890e7f59d76cd464778481c415cc3c5dbd
2018-11-27 21:10:09 +01:00
jenkins-bot 23c6c3b6e0 Merge "Use mw.Title.wantSignaturesNamespace" 2018-11-27 19:31:13 +00:00
Ed Sanders 0d54a62858 Use mw.Title.wantSignaturesNamespace
Change-Id: I60187f0a3eb9cf5d56a4fdaa3401b107758bd8e3
Depends-On: Ib2faa22c429096d545ddb829a6b4025427ad6071
2018-11-27 18:42:44 +00:00
Bartosz Dziewoński b983538038 ve.ui.MWSaveDialog: Improve handling of links in edit summary preview
* Pass the page title, so that links to section point to the current
  page rather than "API"
* Make all links open in a new window, instead of producing a warning
  about losing your changes

Bug: T208978
Change-Id: Ia1924e1af644ee41ebcaa1da40ca004cb72dcdaf
2018-11-27 02:39:47 +01:00
jenkins-bot b34e625f4c Merge "ve.init.mw.ArticleTarget: Fix typo" 2018-11-27 00:04:20 +00:00
Bartosz Dziewoński c3dcdbe5f0 ve.init.mw.ArticleTarget: Fix typo
Change-Id: Ic4e886ca37c41e9c488b960c06a8de1d2fd1bb07
2018-11-27 00:45:24 +01:00
Bartosz Dziewoński c9ddb8b204 ApiVisualEditorEdit: Add a comment to a tiny but important line
Code added in 393807462e.

Change-Id: I0393a68939c8b103f09d4b25585637faeb76090d
2018-11-26 23:11:29 +01:00
Bartosz Dziewoński eb064877f8 Update VE core submodule to master (6a2233f68)
New changes:
73a231157 Only handle document selectionchange events when focussed
083272487 Localisation updates from https://translatewiki.net.
b5f36f1ea Localisation updates from https://translatewiki.net.
6a2233f68 Workaround native selection bug for number inputs in Firefox

Bug: T209646
Change-Id: I78fc21e88ead9ff6e181e1a88f3f0ddbdcd8e4d8
2018-11-26 20:28:48 +01:00
jenkins-bot 827e3661ec Merge "Track when block notices are shown on visual editor" 2018-11-26 12:35:21 +00:00
Translation updater bot cd1d40e691 Localisation updates from https://translatewiki.net.
Change-Id: Ib46f74af0dde52d38a3987c480e4faa5f2f91a78
2018-11-25 22:34:22 +01:00
jenkins-bot 3562de0c9e Merge "Move extension save error handlers into a registry" 2018-11-24 02:41:07 +00:00
jenkins-bot c6563ebdec Merge "Update VE core submodule to master (c9b894467)" 2018-11-23 17:28:56 +00:00
Ed Sanders 7bd58c52a5 Move extension save error handlers into a registry
These can now be moved to their respective extensions.

Bug: T136859
Change-Id: I2c35b9443208928db43bcfd515864641b10cc602
2018-11-23 17:19:36 +00:00
Ed Sanders 70253d450a Cleanup save-error handling
* Use ve.getProp
* Use .abusefilter key instead of string search (the key
  didn't exist when we first implemented AF support)
* Move AF handler next to captcha handler, and comment
  both as should-be-moved-to-plugin.

Change-Id: I171d63844b84b5a12396b6d6746f92110fc06c6c
2018-11-23 15:42:39 +00:00
Thalia a5c5bc5116 ve.dm.MWExtensionNode: check for body in describeChanges
Bug: T210257
Change-Id: Iffda3dc0b5b9dc84d294240546193e4b55c45bb7
2018-11-23 12:27:13 +00:00
Translation updater bot 9441222619 Localisation updates from https://translatewiki.net.
Change-Id: If1e3578d855ea739c8bf7aec41e978c9a0411b1e
2018-11-22 22:22:28 +01:00
jenkins-bot c5252fd968 Merge "Avoid HTML string parsing" 2018-11-21 21:46:33 +00:00
Translation updater bot abbdb1354d Localisation updates from https://translatewiki.net.
Change-Id: I1d8665aa451f415a02692c921d1ceb1a31475c8e
2018-11-21 22:29:34 +01:00
Bartosz Dziewoński 89126ad660 Update VE core submodule to master (c9b894467)
New changes:
d5d971214 Replace $.isFunction with typeof
b185014a2 Avoid stray tabs
c9b894467 build: Upgrade eslint to 0.9.0

Change-Id: I8d2b663a1b6b612f3ee90d56af0bc3450a1f3f4c
2018-11-21 21:40:58 +01:00
jenkins-bot 6291dff109 Merge "build: Use eslint-config-wikimedia v0.9.0 and make pass" 2018-11-21 20:25:39 +00:00
Ed Sanders f2a9ccd5bd Avoid HTML string parsing
Identified using https://github.com/wikimedia/eslint-plugin-jquery/pull/12

Change-Id: I138e018fdc037d688e055eacddfdc5bfc2cc5abe
2018-11-21 18:47:19 +00:00
Ed Sanders 1a3e8a958c build: Use eslint-config-wikimedia v0.9.0 and make pass
Change-Id: Idb57fc12e7822cf17e10dbb726480fc7de0ae199
2018-11-21 16:51:20 +00:00
Thalia 883e0c23a5 Track when block notices are shown on visual editor
When an edit notice is passed through from the API, allow
a type to be specified, and specify type 'block' if the
notice is a block notice.

If VisualEditorTrackBlockNotices config is true, track
when a message with type 'block' is shown.

Bug: T209633
Change-Id: If5fecc2c2c1c39f4b7245b9a215e1120c93b2b22
2018-11-21 11:22:50 +00:00
jenkins-bot 44fcea9f65 Merge "Track when block notices are returned on the api" 2018-11-20 22:31:27 +00:00
jenkins-bot cf32ca44d9 Merge "ve.ui.MWTransclusionContentPage: Fix missing icon" 2018-11-20 16:58:14 +00:00
jenkins-bot 71b127b48c Merge "Filter out junk from the HON browser plug-in" 2018-11-20 15:51:18 +00:00
Dayllan Maza 3269bb136c Track when block notices are returned on the api
Tracking is behind $VisualEditorTrackBlockNotices config flag
which is set to false by default. Additional data will be logged
into a different bucket on the client and both metrics will be
considered with their known limitations.

The reason behind this is to get an idea on how frequently blocked
users attempt to edit a page. Similar tracking is being added to
MobileFrontend and mediawiki/core.

Bug: T201718
Change-Id: I51576276b97be0716c2c22348eaa756ffb04fe50
2018-11-19 23:02:02 -05:00
Bartosz Dziewoński 120788db59 ve.ui.MWTransclusionContentPage: Fix missing icon
It's missing here: https://phabricator.wikimedia.org/F27262533
We forgot this in 09800aa249 (in 2015).
Oops.

Change-Id: I0f1cda43c6566accf45c82a858158f15c2229f47
2018-11-20 04:04:25 +01:00
James D. Forrester a5c5176333 Filter out junk from the HON browser plug-in
Bug: T209619
Change-Id: If399319b2675ac8ca6d3d17acbf96634ab5f6395
2018-11-19 15:25:12 -08:00
Thalia ceb02d3296 Remove needless function call in DesktopArticleTarget
Change-Id: I6e691e97fe7330496cdf45a2439d8fd373cf221f
2018-11-19 18:58:38 +00:00
Bartosz Dziewoński a9684ebc37 Update VE core submodule to master (812b2140a)
New changes:
eac3c90d5 Revert "TargetWidget: 'change' on document transact, not surface history"
812b2140a Localisation updates from https://translatewiki.net.

Bug: T209648
Change-Id: I18b89b6c03bc09d40f7f314c36b5540ca9c0a27b
2018-11-19 19:14:42 +01:00
jenkins-bot 974afc4849 Merge "ve.ui.MWTemplateDialog: Unbreak the logic to enable/disable "Apply" button" 2018-11-19 17:53:06 +00:00
Translation updater bot 0f862703fd Localisation updates from https://translatewiki.net.
Change-Id: I8b37d79b9739eb528cab7b5e9eaf31c25b096b9a
2018-11-18 22:48:53 +01:00