Commit graph

10253 commits

Author SHA1 Message Date
Ed Sanders 0e62e577e4 MWMobileSaveDialog: Use short save messages for space
Change-Id: I04e01a8941f905384e385caf1267d7c36cb2aa52
2015-08-07 17:38:52 +00:00
jenkins-bot 79a95bc30a Merge "MobileArticleTarget: Use platform's iOS detection, not MobileFrontend's" 2015-08-07 15:39:58 +00:00
Ed Sanders 0d8914c48d MobileArticleTarget: Use platform's iOS detection, not MobileFrontend's
Change-Id: Ic206d54aee712e6309e34a0414d28c27363dfbc3
2015-08-07 15:37:05 +00:00
Ed Sanders e018dc4519 MobileArticleTarget: Remove incorrect border from toolbar
Change-Id: I9fcb7251afd0e3aa1601c31a684b15bf880b1152
2015-08-07 15:34:28 +00:00
Ed Sanders ac9f1a0919 MobileArticleTarget: Give toolbar split focused/unfocused modes
Split the toolbar into two modes depending on if the surface is focused:
* When unfocused, show a hamburger containing back and source switch
* When focused, show editing tools, and a check button to unfocus

For the editing toolbar, space the tools out using table-cell layout
and hide labels below 480px.

Depends on I06813e3ff in core (surface blur method).

Bug: T93325
Change-Id: Ibf09cb29019d7a71e1e144b326710b1f6506cd0c
2015-08-06 15:43:36 -07:00
jenkins-bot daa099f09e Merge "MobileArticleTarget: Fix over-sized debug bar" 2015-08-06 22:10:12 +00:00
Ed Sanders b93a521163 MobileArticleTarget: Fix over-sized debug bar
Change-Id: I3e92474d7a46a4da420c1ba7a766bf0e17144e47
2015-08-06 21:59:56 +00:00
jenkins-bot 0c49c03c10 Merge "[BREAKING CHANGE] Use save dialog in mobile" 2015-08-06 21:57:56 +00:00
jenkins-bot ea5f60001d Merge "*Dialog: Flag back/cancel actions" 2015-08-06 21:57:49 +00:00
Ed Sanders 707628cfb1 [BREAKING CHANGE] Use save dialog in mobile
Bug: T96186
Change-Id: I4319e23da2d1bfd0cbba9719dbc9642a233bdf67
2015-08-06 21:52:14 +00:00
Ed Sanders f579ce52a2 *Dialog: Flag back/cancel actions
Change-Id: If3772863078a020eba9b9b43f58044a5aacb7296
2015-08-06 21:51:32 +00:00
James D. Forrester 87b506cb24 Update VE core submodule to master (1360bca)
New changes:
3753f8b ve.ui.ToolbarDialog.css: Move Apex-specific hacks to Apex stylesheet
4650555 Localisation updates from https://translatewiki.net.
40f31a2 DebugBar: Re-style linmod dump hide button to left with '^' icon
5ff7c26 ve.ui.Surface: Teardown the view after window managers
03193a6 ve.ce.Surface: Provide #blur to pair with #focus
ab26ac6 Fixup I06813e3ff: Activate surface before blurring
4f2e832 Flag back/cancel actions so they can be restyled in mobile
a499a73 Localisation updates from https://translatewiki.net.

Change-Id: Iefdd8e7db47e6a53913c0a95a95559fe2c0a9dc2
2015-08-06 14:45:40 -07:00
Translation updater bot 4602beba6d Localisation updates from https://translatewiki.net.
Change-Id: I208aec94262c922c88243256b74c8cee13da5958
2015-08-06 21:39:32 +02:00
jenkins-bot 173fbc8df2 Merge "Remove use of deprecated wfRunHooks" 2015-08-06 18:19:37 +00:00
addshore aea5ebab38 Remove use of deprecated wfRunHooks
Change-Id: I390f731564d02866f2724284e2a5e0639f4a889d
2015-08-06 19:09:19 +01:00
jenkins-bot c61661c20a Merge "DesktopArticleTarget.init: Don't overwrite mw.libs.ve" 2015-08-05 21:58:07 +00:00
Roan Kattouw ef2d23c36a DesktopArticleTarget.init: Don't overwrite mw.libs.ve
Extend it instead, if it already exists.

Bug: T107979
Change-Id: I70bce7c82dce8199cfe36f810629c5d22b583f0a
2015-08-05 14:48:38 -07:00
Translation updater bot 165c4c8ef0 Localisation updates from https://translatewiki.net.
Change-Id: I9820f9acaff2187368611ae644384f250dc59fbb
2015-08-05 22:37:38 +02:00
Ed Sanders 90e2111c95 Add aliases for old ve init modules
Due to HTML caching, these need to be available for 30 days
after the change.

Change-Id: Ia92ecc03623ef9b42d1948d32c69951672bee146
2015-08-05 19:26:11 +01:00
Frédéric Bolduc 0ce3baf66d mw.Target: Add jsconfigvars and modules to the save mechanism
* On save, VE will now fetch and append modules and jsconfigvars to the save
  event, which respectively contains necessary JS config module data and the
  list of required modules to be added on the page.
* The jsconfigvars are now properly added to mw.config on edit save.
* If any new modules are now required by the page after an edit, they will be
  loaded by ResourceLoader through mw.loader.load.

Change-Id: Ib3990078a22ad9e46debf3ce174e7cf27b86d944
2015-08-04 19:00:09 -07:00
Translation updater bot 51dae38da6 Localisation updates from https://translatewiki.net.
Change-Id: I666ab2ef0e864ce5166a2fe5a95b033514b04f36
2015-08-04 23:18:28 +02:00
jenkins-bot 11286c8994 Merge "Move theme style files to appropriate skinStyles sections" 2015-08-04 20:55:16 +00:00
jenkins-bot f4192a7847 Merge "Make transclusions which are td/th elements behave as table cells" 2015-08-04 20:37:41 +00:00
jenkins-bot d103896e4a Merge "[BREAKING CHANGE] Target*: Replace target events with methods" 2015-08-04 20:35:35 +00:00
jenkins-bot ec771efc6b Merge "Update VE core submodule to master (15e5545)" 2015-08-04 19:48:48 +00:00
Ed Sanders b3972c1e26 Move theme style files to appropriate skinStyles sections
Bug: T107928
Change-Id: Icad7569f828409f53d6c744593a58f835ae70b9b
2015-08-04 20:43:12 +01:00
Ed Sanders 2c24efae29 [BREAKING CHANGE] Target*: Replace target events with methods
When you bind to your own events you're probably using the wrong
design pattern.

The events are kept (without arguments) for the purpose of tracking.

Change-Id: I6983319f9e0ca179e609afb00c821e3eab2161c9
2015-08-04 11:49:54 -07:00
Ed Sanders de98382a55 Make transclusions which are td/th elements behave as table cells
Depends on Ic94242c0 in core.

Bug: T85648
Change-Id: I0f65fca37fe94486d0a736d763270b3dc5503649
2015-08-04 17:52:13 +00:00
James D. Forrester ffe075f21e Update VE core submodule to master (15e5545)
New changes:
87c538a PasteRules#plainText: Fallback if rules.external is undefined
7155191 Localisation updates from https://translatewiki.net.
c2d03ea ToolContextItem: Use the target's command registry
d196838 DataTransferHandler: Improve aborting and resolution/rejection
009190e Allow the target to specify a DataTransferHandler factory
0ea9439 Split out basic functionality of tableCell so other nodes can behave as cells
999a5da ve.ce.TableCellableNode: Only apply title to nodes which are cellable

Change-Id: I56a73a26f21a6e22b6bafc850cdee35397e5d15d
2015-08-04 10:51:35 -07:00
Ed Sanders 529248f831 Target*: Remove 'on' from methods which aren't event handlers
Allows us to rename onSaveEvent back to onSave.

Before this change,
* ve.init.mw.Target.prototype.save ->
* ve.init.mw.Target.prototype.onSave, emit save event ->
* ve.init.mw.DesktopArticleTarget.prototype.onSaveEvent (or MF equivalent)

With this change,
* ve.init.mw.Target.prototype.save ->
* ve.init.mw.Target.prototype.saveSuccess, emit save event ->
* ve.init.mw.DesktopArticleTarget.prototype.onSave (or MF equivalent)

Change-Id: I016262b38a941c93c0978391491baa6d5a32fe28
2015-08-04 17:47:05 +00:00
James D. Forrester 86212df814 Follow-up fd2ef3e: Keep passing data.isRedirect in #onSave
Also fix ve.init.mw.DesktopArticleTarget#onSave to #onSaveEvent to avoid clash.

Change-Id: I5efb1884f9626e5da72b226cc8ca596bb6db4a40
2015-08-03 18:41:58 -07:00
jenkins-bot c89795c49e Merge "Revert "Revert "For empty / whitespace-only headings, output <p> instead of <h#>""" 2015-08-03 22:57:28 +00:00
jenkins-bot 5a5ec053b6 Merge "Follow-up fd2ef3e: Call prototype., not ve.init.mw.Target#onSerialize" 2015-08-03 22:57:06 +00:00
Jforrester dbe11c3b14 Revert "Revert "For empty / whitespace-only headings, output <p> instead of <h#>""
It's seemingly still needed.

This reverts commit 924c58a893.

Change-Id: Ib9428865fbab2669153bd23cf239717080eb8291
2015-08-03 22:49:16 +00:00
James D. Forrester d6541e1e8d Follow-up fd2ef3e: Call prototype., not ve.init.mw.Target#onSerialize
Change-Id: I9fd86b91c8b7fa3c09758b492332c56d10c39a95
2015-08-03 22:42:51 +00:00
Alex Monk 871a0a288f Unbreak meta dialog cancel button
Don't try to apply page settings changes to meta list unless we're actually
applying. "Cancel" shouldn't apply changes, we have another button for that.

Bug: T97682
Change-Id: I9eae20c3946b315413340268e44537cdbec2e455
2015-08-03 22:36:53 +00:00
Translation updater bot daa87a3651 Localisation updates from https://translatewiki.net.
Change-Id: I5e096e96395b6df698aa210fabdb91a6fd3e59c1
2015-08-03 22:06:38 +02:00
Ed Sanders a4b250c790 MWImageModel#insertImageNode: Separate out linmod generation
Change-Id: Idee01e2e59f2a68481476f3d784502d3ebdf015b
2015-08-03 01:11:50 +00:00
Ed Sanders 322d1f54c6 MWMediaDialog: Remove redundant check of this.imageModel existence
The fact it has to exist for the two previous statements to
not fatal is a bit of a clue. I assume this made sense at
some point in the past.

Change-Id: Ic9c04395408301f514ff7e9a224b8e2c30d64896
2015-08-03 01:09:03 +00:00
Ed Sanders 022fa98856 Use target-specific command registry for lookup
Only use was in MWHelpPopupTool#onKeyboardShortcutsClick.

Depends on Ie24369b9 in core.

Change-Id: I630d3e55057ddf6f87e39ab2e99e93a71bd1d8bb
2015-08-03 01:07:47 +00:00
Ed Sanders dedc107507 MWCommandRegistry: Move commands' registrations to their code
By moving the registration to the code which introduce the commands, if any
module such as 'media' is omitted from an integration, we don't register a
command which is never used.

MWCommandRegistry.js remains to be used for over-rides of core tools' exact
commands, such as insertTable.

Change-Id: I84b4351b980a764d3c72a564f605821ae1c761f9
2015-08-02 17:55:09 -07:00
Ed Sanders 4ab947d336 MWSaveDialog: Remove unnecessary <br /> from diff panel
Change-Id: I430794d781c91886abb4802c7f53ad4e0ff14c3b
2015-08-03 00:43:51 +00:00
Ed Sanders 92cc1d1b53 Use super constructors in ArticleTargets
Change-Id: I58041de7421232dabe4541d438dd7cc66e3c8d92
2015-08-03 00:35:01 +00:00
jenkins-bot e98412bbec Merge "ve.init.mw.Target#save: Bind this#onSave, not #onSave" 2015-08-03 00:33:10 +00:00
Ed Sanders adcfb56761 ve.init.mw.Target#save: Bind this#onSave, not #onSave
Change-Id: I62fbb6f31c0ddd17a1179fb4c2d8f13e44e9c9bb
2015-08-03 00:30:06 +00:00
jenkins-bot 44eeb5c8c1 Merge "Revert "Revert "Replace wgVisualEditorNamespaces with an associative array""" 2015-08-02 23:50:44 +00:00
Alex Monk ea34d938c8 Revert "Revert "Replace wgVisualEditorNamespaces with an associative array""
This reverts commit 7ca1afbbd2.

Bug: T104898
Change-Id: I061c1fd9ab8ec6b2afac92feef888ba207e1a9b1
2015-08-02 23:13:24 +01:00
Translation updater bot 132caa7c43 Localisation updates from https://translatewiki.net.
Change-Id: I95a7d246d51437effb52ca2a17edc1979ccad6d7
2015-08-02 21:54:59 +02:00
James D. Forrester d32c390523 Update VE core submodule to master (d9d4e33)
New changes:
288b060 Use frameless buttons in mobile process dialogs
b7deb26 Fix typo in TargetWidget.css
62c63d7 Localisation updates from https://translatewiki.net.
ac0c49a Remove duplicated commands for 'code' and 'strikethrough'
c4120fc Make setExcludeInsertions chainable, like all other SurfaceFragment methods
d2e86df Use super constructors in Desktop/MobileSurface
a1364f4 Have getLinearFragment call getFragment
842b322 Use overridable factory methods for creating surface model and view
8e729f7 Localisation updates from https://translatewiki.net.
479095c Make 'plainText' a paste rule, rather than a named parameter
744c633 Allow the target to specify command and sequence registries

Change-Id: Ie312412d5af350e7b1478393ad288bbe14a7a43a
2015-08-01 15:46:47 -07:00
jenkins-bot a15c54f4db Merge "MWSaveDialog: Make a FragmentDialog now that's available" 2015-08-01 22:44:18 +00:00