Commit graph

2548 commits

Author SHA1 Message Date
Roan Kattouw 0bc3edfd91 Focus the bookletLayout on ready in the template dialog
Depends on I60377cb5 in oojs-ui

Change-Id: I5d8b73f878bf136efdc97493ef1f6e7bd6f56066
2014-11-21 18:13:27 -08:00
Roan Kattouw 4cf254a31b OO.ui.WindowManager -> ve.ui.WindowManager
In keeping with Id6660a4b54 in VE core.

Change-Id: I6fa6c0cdc3e514a66889e41c2eb4c710650a3405
2014-11-21 13:58:53 -08:00
Translation updater bot bc031a78ba Localisation updates from https://translatewiki.net.
Change-Id: I2cd1e9f2abf494d61a1a2011e7a271c0dd937f97
2014-11-21 22:12:28 +01:00
jenkins-bot 7416393354 Merge "[BrowserTest] consolidate some duplicate elements" 2014-11-21 20:30:28 +00:00
Cmcmahon 2449ebde99 [BrowserTest] consolidate some duplicate elements
and remove one unused

Change-Id: Ica50cf74edd9a21423800a7d58f4832b77a7e8bc
2014-11-21 13:28:01 -07:00
jenkins-bot 1b3fe26a3a Merge "Move tearDownBeforeUnloadHandler() to cancel()" 2014-11-21 19:42:59 +00:00
jenkins-bot ad908a666d Merge "Prevent JS errors when surfaceReady fires after deactivation" 2014-11-21 19:41:00 +00:00
James D. Forrester a1d75042c0 Update VE core submodule to master (fb57e24)
New changes:
7d8ed7f Copy in some IE CSS hacks from ve-mw
a2e962e Update OOjs UI to v0.1.0-pre (20c61ec865)
d99c62f Update OOjs UI to v0.1.0-pre (d4cfcce969)
7fe02b3 Fix lots of spelling mistakes and typos

Local changes:
Remove redundant IE CSS rules since core's I013688c5

Bug: 73565
Change-Id: Ic60cd5290932ec38fab26492fffa17c3a8e91398
2014-11-21 10:28:34 -08:00
jenkins-bot d8b82d2de7 Merge "Fix lots of spelling mistakes and typos" 2014-11-21 17:54:05 +00:00
Cmcmahon f6526cb0a9 [BrowserTest] comments for classes
Change-Id: I3d5e063ee4dd36632ab9c2a433660567b70777ea
2014-11-21 09:49:50 -07:00
Cmcmahon 473877202b [BrowserTest] rubocop change to an if()
Change-Id: I5ae9ec4d94af88fa67ac8de58a38b6ea03b14acc
2014-11-21 09:40:40 -07:00
Cmcmahon 95a798867c [BrowserTest] rubocop proper format for comments
Change-Id: I2fe136f29e0bc430420a0931092695d3f4147112
2014-11-21 09:21:53 -07:00
Cmcmahon 1b69fc97c7 [BrowserTest] Fixed Style/SpaceAfterComma RuboCop offense
Change-Id: Ia11c32c74acf4c2226f84ea566f4074b193f4e20
2014-11-21 16:15:58 +00:00
Cmcmahon ede14c75fb [BrowserTest] rubocop updates to replace double quotes with single
Change-Id: I0608aea2bd634156bf800b3be47a5c2a6d9fadca
2014-11-21 09:06:09 -07:00
Ed Sanders 2997cee444 Fix lots of spelling mistakes and typos
Change-Id: Icf78d3d599326d3f12d09edcd2b8491ed35ade04
2014-11-21 13:00:50 +00:00
jenkins-bot c8028dfe06 Merge "Fix ridiculously small font size in overlays under MonoBook" 2014-11-20 20:01:22 +00:00
Roan Kattouw 9ed9c6cfe0 Move tearDownBeforeUnloadHandler() to cancel()
Make sure it always gets torn down on deactivate, not
just on save. Otherwise we end up with multiple copies of it.

Change-Id: I7b95c316641fc48ce7087a0042ec6174fe03180b
2014-11-20 19:23:17 +00:00
Roan Kattouw 5317ce8082 Prevent JS errors when surfaceReady fires after deactivation
If you clicked "Read" while the editor was loading
(but only while the "Edit" tab was already active, not before)
then you could get in a situation where surfaceReady fired
on an already-aborted target, which caused JS errors.

It seems like we should clean more things up in this
case, but I don't know what they are. In any case,
we should not try to set things up on a non-activating
target when surfaceReady fires.

Change-Id: Id57bd63ff288156725e472e7d89009022090253a
2014-11-20 19:22:49 +00:00
jenkins-bot dc6eec0bb7 Merge "[BrowserTest] more rubocop style fixes" 2014-11-20 19:13:30 +00:00
jenkins-bot d8808da403 Merge "Insert last modified text as HTML" 2014-11-20 19:12:07 +00:00
Cmcmahon 2f05d1b10a [BrowserTest] more rubocop style fixes
Change-Id: Ibc1cabbdc00f569b10fd6aae0e5bb998211745b1
2014-11-20 12:07:45 -07:00
jenkins-bot 0394e23516 Merge "[BrowserTest] Rubocop style fixes" 2014-11-20 19:00:03 +00:00
Cmcmahon 65e4d91cf0 [BrowserTest] Rubocop style fixes
Change-Id: Ieb1ba49f2a987b41f82a3b66c542fba48313eb1f
2014-11-20 11:55:40 -07:00
jenkins-bot 921f606209 Merge "Remove unused CSS: toolbar contains no PopupButtonWidgets" 2014-11-20 18:27:55 +00:00
jenkins-bot 3bad2c8ffb Merge "Use super to call parent constructors" 2014-11-20 18:27:51 +00:00
Alex Monk 8a1adef97c Fix ridiculously small font size in overlays under MonoBook
Copy in the font-size:127%; rule from MonoBook's main.css which is applied to
div#globalWrapper

Caused by Id425c56d

Bug: 73660
Change-Id: I05502295b81c62fd1180dff860dea68d76c2dfa9
2014-11-20 17:56:38 +00:00
Cmcmahon 513031c4bf [BrowserTest] locator changed
Change-Id: I3aeb1f60cf512c55f497f4ef6743b149bc0add43
2014-11-20 10:02:20 -07:00
Ed Sanders 7abbea1c19 Use super to call parent constructors
Change-Id: I5f911fc35c420cd7980bc1fbaecf3b685596c7a8
2014-11-20 13:58:27 +00:00
Ed Sanders 6ffbc72f82 Remove unused CSS: toolbar contains no PopupButtonWidgets
Change-Id: I719a4dec30d5ca52337bd3a7d2506065562d831d
2014-11-20 13:56:48 +00:00
Amir E. Aharoni a513ba9583 [BrowserTest] Fix the index of the insert menu
Change-Id: Id0e821d3cf01efff74fdb189cf09d24d9eb753e2
2014-11-20 10:52:47 +00:00
James D. Forrester 7317114187 Update VE core submodule to master (029fc7e)
New changes:
029fc7e Update OOjs UI to v0.1.0-pre (1fa4eb7a73)

Update changes:
Changes were generated by running this script:
https://gist.github.com/trevorparscal/265f1b8c854190637a1e

File changes:

Scripts (modules/ve-mw/ui/widgets)
- ve.ui.MWInternalLinkMenuItemWidget.js → ve.ui.MWInternalLinkMenuOptionWidget.js
- ve.ui.MWLinkMenuItemWidget.js → ve.ui.MWLinkMenuOptionWidget.js

File content changes:

Scripts (*.js)
- MWInternalLinkMenuItemWidget → MWInternalLinkMenuOptionWidget
- MWLinkMenuItemWidget → MWLinkMenuOptionWidget
- ContextMenuWidget → ContextSelectWidget
- ContextItemWidget → ContextOptionWidget
- TextInputMenuWidget → TextInputMenuSelectWidget
- MenuWidget → MenuSelectWidget
- MenuItemWidget → MenuOptionWidget
- MenuSectionItemWidget → MenuSectionOptionWidget
- OutlineWidget → OutlineSelectWidget
- OutlineItemWidget → OutlineOptionWidget

Styles (*.less)
- contextMenuWidget → contextSelectWidget
- contextItemWidget → contextOptionWidget
- textInputMenuWidget → textInputMenuSelectWidget
- menuWidget → menuSelectWidget
- menuItemWidget → menuOptionWidget
- menuSectionItemWidget → menuSectionOptionWidget
- outlineWidget → outlineSelectWidget
- outlineItemWidget → outlineOptionWidget

Change-Id: Ifded7f9e17923dbb56a722b7424ccd2854194c21
2014-11-19 17:04:26 -08:00
ryasmeen@wikimedia.org 6cce39ee10 [BrowserTest] Extend options test
Adding cases to test categories in options.feature

Change-Id: I6fbe8bc170306c5f2942bf3c7e87f7a3ff661bb2
2014-11-19 16:26:07 -07:00
Cmcmahon c49b2a77f2 [BrowserTest] once more
Change-Id: I34b4be6aadf991cf9d12c76fd8c8410697b2b500
2014-11-19 14:53:08 -07:00
Translation updater bot d043be3315 Localisation updates from https://translatewiki.net.
Change-Id: Iea9ba638731f58e49ac2a2c1219180cf2d465ecc
2014-11-19 22:41:42 +01:00
lokal-profil 591f3fcedb API i18n: Fix consistency in messages
Fixed consistency in two messages and added article to a third.
Affected messages:
* apihelp-visualeditor-description
* apihelp-visualeditor-param-oldid
* apihelp-visualeditoredit-param-oldid

Reported at:
https://translatewiki.net/wiki/MediaWiki:Apihelp-visualeditor-param-oldid/sv
https://translatewiki.net/wiki/MediaWiki:Apihelp-visualeditoredit-param-oldid/sv

Change-Id: I054cf021482276c3676e91d9cf9f6fcdfc12d583
2014-11-19 15:46:22 +00:00
James D. Forrester cfb20ef8a1 ve.ce.MWTransclusionNode: Replace last use of ', ' in VE-MW with <comma-seperator>
Bug: 66894
Change-Id: Idd6d02e35b9aa0db5f71c75adb0a0400cc31c83a
2014-11-19 11:19:50 +00:00
jenkins-bot 30d8bf60f1 Merge "ViewPageTarget#onSaveErrorSpamBlacklist: Use mw.language.listToText now it exists" 2014-11-19 11:06:01 +00:00
Timo Tijhof 420b336d31 mw.ViewPageTarget.init: Simplify hideLoading and pushState
Follows-up Ica33de675, If505a46f54.

* The setting of 'uri' looked like a redundant local alias before
  passing on to pushState, but is actually important on itself.

* Remove binding for hideLoading. It's a detachable method on
  a singleton, not an instance method.

Change-Id: Ic3536caf3f42ee893124312fd5981b67336bd480
2014-11-19 02:58:17 +00:00
Roan Kattouw bb6e01c488 Fix back button not exiting VE
When you clicked the Back button in the browser, the URL
in the address bar would change (removing veaction=edit),
but we would not go back to read mode. This was broken
by 5c0c11753 almost a month ago but apparently no one noticed.

This is because 5c0c11753 moved the pushState() calls to
be earlier (in init init), making the replaceState() call
in the ViewPageTarget constructor (which is there
specifically for this bug) run too late in those cases.

The simplest way to fix this is to duplicate these replaceState()
calls before the pushState() calls in init init.
I feel a bit bad about copying code, but not very bad
because the code I'm copying already has a FIXME comment
about how there should be a better way :P

Change-Id: I6627a5d1d9377ae815bc58bceeb059ce9f4f19ab
2014-11-19 02:07:41 +00:00
jenkins-bot aa44c8916b Merge "Consistently use location as global, and location.href for full url" 2014-11-19 02:00:35 +00:00
jenkins-bot c8152914eb Merge "Use history as global instead of via window" 2014-11-19 01:59:26 +00:00
Timo Tijhof dc648e6b06 test: Omit 'window' in mw-preload.js
Follows-up 92c38ea.

Change-Id: Ib8a37036a1a9dac980527bfccd506fff5ea8dce1
2014-11-19 01:46:38 +00:00
Timo Tijhof c0692af5f7 Use history as global instead of via window
Just like DOM interfaces such as document and location. And JS
constructors like Object.prototype, and libs like jQuery.
No need for the window host object.

Change-Id: Ie39aaea2ca17bdec5fb3afe32a4e6c9f751bd0c6
2014-11-19 01:12:11 +00:00
Timo Tijhof 82657727f9 Consistently use location as global, and location.href for full url
The location object is a global, just like document.

Using it via 'window' needlessly adds complexity and, for example,
makes it harder to catch typos in static analysis.

Standardise on location.href in place of the many different
variants for accessing and assinging the full url:

 location =
 location.href =
 location.assign() =

And each with 'window', 'document' and without host object.

Change-Id: If88515bd88fc5b93ebacd4ec41fce02fec540f18
2014-11-19 00:20:08 +00:00
Alex Monk 94fadaec4a Insert last modified text as HTML
mw.msg can return things with <br />, which we want to be interpreted as HTML
rather than just escaped as text.

Bug: 73571
Change-Id: I7861432d9361e01f9def0578c342e60715c3d764
2014-11-18 23:42:18 +00:00
James D. Forrester 6b61addd06 ViewPageTarget#onSaveErrorSpamBlacklist: Use mw.language.listToText now it exists
Change-Id: I1289c43ea4be1cd9dc1addb7c765d7050b311d8d
2014-11-18 14:22:30 -08:00
Translation updater bot 384232ee64 Localisation updates from https://translatewiki.net.
Change-Id: I7e799602cb9d11c2e77be38b3707ebd0b82c7d9d
2014-11-18 21:35:49 +01:00
Cmcmahon 210169c55b [BrowserTest] forgot a bit of dead code
Change-Id: I249e229d449eb74ff341f511e84290a4ca731f92
2014-11-18 13:09:17 -07:00
Cmcmahon 6489767bc7 [BrowserTest] remove sleeps from shared tests
* remove dead code

Change-Id: Id95ff81746eb440124958bcc6dd9334b7ed299a4
2014-11-18 12:59:34 -07:00
Cmcmahon 06aa53747c [BrowserTest] interim step, no functional change
Change-Id: I3a7787c4ab9206c70f0f64b6c0986ae93ddb3d84
2014-11-17 15:14:32 -07:00