Commit graph

10762 commits

Author SHA1 Message Date
Bartosz Dziewoński c684e2c682 ve.init.mw.Target: Remove jqueryMsg hacks in #saveErrorNewUser
The bug in jqueryMsg that required this is now fixed.

Bug: T87219
Change-Id: Ib7ef7e6a0451539099c12ae32d02b50c269c7529
2015-10-06 19:04:10 +02:00
Alex Monk 9d6fbc894e Educational popups and highlights for links+citations
Bug: T108620
Change-Id: I42b0e06f50aca5cb783d88f79a080461e745ceee
2015-10-06 14:33:57 +01:00
jenkins-bot cd29e0376d Merge "Add error element to MWLiveExtensionInspector" 2015-10-05 22:53:20 +00:00
jenkins-bot 4f378fda7d Merge "Update VE core submodule to master (737a235)" 2015-10-05 22:51:03 +00:00
Translation updater bot e75fb6a2da Localisation updates from https://translatewiki.net.
Change-Id: Icbf09f06f978d791208bc9ac37f56524700e7a97
2015-10-05 22:17:32 +02:00
James D. Forrester 5fa34afc2f Update VE core submodule to master (737a235)
New changes:
6e38f99 Pass generated content error to inspector

Change-Id: I362972dcdffc72b906263670d034872f0af03a01
2015-10-05 13:11:40 -07:00
Ed Sanders 3f2a885e3e Ensure full error message is shown when inspector is closed
Applying staging doesn't emit an update event on the node, so
forcefully emit one with 'staged' equal to false, so the full
error is rendered (if present).

Logically depends on I8ebb26d4bc in core.

Bug: T114480
Change-Id: I7ba54b67982fc5b10839426cdc216e14c0e33c01
2015-10-05 17:15:40 +00:00
James D. Forrester 8e8fe70d79 Update VE core submodule to master (8feaeef)
New changes:
9cb6f74 Move insertion annotation calc logic from DM Surface to ElementLinearData
04d4bfd Refactor the code that determine insertion annotations
d9efa1c DimensionsWidget: Fix alignment of labels
66ba732 Always render generated content the first time, including errors
23a957c Consistently use spaces inside brackets in CSS
f17c8ad Localisation updates from https://translatewiki.net.
f4d0643 Localisation updates from https://translatewiki.net.
ec29e77 Follow-up I553e31: Don't show error for non-rendered GCNs
5f2402b Pass staging state through Document#commit to ve.dm.Node update event
0d3e998 Fix ve.ce.Document HTML tests
7c95c6a Wrap <hr>s so their margins are clickable
164b9a3 Localisation updates from https://translatewiki.net.

Change-Id: I069082baeb45105bf2e0106879d472319a6ffe2a
2015-10-05 09:57:20 -07:00
jenkins-bot aaaded172b Merge "Toolbar config: Prevent 'Table' from moving after menu expand" 2015-10-05 15:14:47 +00:00
jenkins-bot 4878313bea Merge "Consistently use spaces inside brackets in CSS" 2015-10-05 15:02:25 +00:00
Ed Sanders 2c9b9e4d73 ReferenceContextItem: Factor out getReferenceNode and use correct node
Use the node from the parent dm document, not the internal list document.

Change-Id: Ieeb0a63bd40de7a8a2944322ba800feec7a7f4dd
2015-10-05 16:01:54 +01:00
jenkins-bot 7c0f17c2cf Merge "ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons" 2015-10-05 11:55:04 +00:00
Thalia 9307fa7095 Add error element to MWLiveExtensionInspector
As part of the plan to render extension errors in the
inspector instead of the view, append an element to
contain the error. More specifically, the element is
a div that contains a LabelWidget (in which the error
message is displayed) and a ButtonWidget (to expand
and collapse the error).

Initially the error element is hidden, but if Parsoid
returns an error, the element will be shown. If the
error is longer than 1 line, it is truncated but can
be expanded. On closing the inspector, any remaining
error is collapsed and hidden.

Depends on I6002d9870d2b to work

Bug: T113172
Change-Id: Ie84130d4ac0da9a738bf98ad0a3677d47566d585
2015-10-05 00:22:22 +01:00
Translation updater bot 4eb7a0554b Localisation updates from https://translatewiki.net.
Change-Id: I1574aa4164e8e530740112596120b44b1707d562
2015-10-04 22:20:56 +02:00
jenkins-bot 291065459c Merge "Use ve.setProp to set new pages list in MWTemplateTitleInputWidget#getLookupRequest" 2015-10-04 19:54:45 +00:00
Bartosz Dziewoński 205beb2b49 ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons
OO.ui.BookletLayout does not respect tabindices when trying to focus
the first focusable element after a page is switched. Remove the need
for manually set tabindices in ve.ui.MWTemplateDialog by using natural
DOM order and absolutely positioning things to keep current design.

Bug: T114562
Change-Id: I7a18a455f9fa80eb3d2ea17bff8139e0194c0fbf
2015-10-04 20:39:16 +02:00
Ed Sanders 1eb0ef2011 Consistently use spaces inside brackets in CSS
Change-Id: Ie63a50cb16cb89dac7060857220485d7d23f2fe3
2015-10-04 18:33:43 +01:00
Ed Sanders 6c1891c150 Find and replace: Add pref keys for find/replace text inputs
Adds support for storing find and replace text inputs added
in core in I8ae8d49.

Change-Id: I78dea87025e2bfa1b3ff977b16986e8431ddfb22
2015-10-04 13:39:58 +01:00
Ed Sanders 7337eb1d7e Toolbar config: Prevent 'Table' from moving after menu expand
Change-Id: I9f472668e0cf8f3014c681f6f2430e685bf50534
2015-10-04 13:28:55 +01:00
Translation updater bot 5124a7075b Localisation updates from https://translatewiki.net.
Change-Id: I751798608f4e54a643b4cb488d9217bfcb704266
2015-10-03 22:14:37 +02:00
Translation updater bot 815a729780 Localisation updates from https://translatewiki.net.
Change-Id: I0d72901cb61d21af1ff710c1be8d3cc9150ca75c
2015-10-02 23:51:15 +02:00
Ed Sanders d63dce138d MWExtensionNode: Fix selector to find dimension-less images
Change-Id: Idf219636f9b2b58e30b1a155c052ada4c60e6ec9
2015-10-02 14:18:13 +01:00
jenkins-bot ec2ff26563 Merge "Hack to stop logging edit events for non-desktop targets" 2015-10-02 00:09:05 +00:00
Alex Monk a46b7a819e Hack to stop logging edit events for non-desktop targets
Mobile target, for example, has events logged in the MobileFrontend extension instead
(which covers both the wikitext editor there and the VE integration)

Bug: T110272
Bug: T109525
Change-Id: I521f1825dc9c0a135db54cd005cda723908f14bc
2015-10-01 23:48:10 +00:00
James D. Forrester 6800e1bc04 Update VE core submodule to master (54ec246)
New changes:
ec74b6f [BREAKING CHANGE] PreviewElement: Remove deprecated alias to PreviewWidget
987d3b1 Follow-up c02882c: Don't break non-GCNs
df74df2 Localisation updates from https://translatewiki.net.

Change-Id: I9d2261b48593d604ff54cfea2ea5ff3e7472ab3a
2015-10-01 14:32:06 -07:00
jenkins-bot e14c8e11cf Merge "Change a bunch of parsoid references to acknowledge that RESTBase is sometimes in the middle" 2015-10-01 16:14:29 +00:00
jenkins-bot 1bbfcf23c6 Merge "MWExtenionNode: Ensure objects are deep copied when used in the hash" 2015-10-01 15:28:01 +00:00
Thalia 34f6e11a19 Call updatePreview when closing the LiveExtensionInspector
Call updatePreview in insertOrUpdate node, when closing the
inspector. If edits have only been made to attributes that
don't affect the rendering, updatePreview will not have been
called, so the model won't have changed. Therefore
updatePreview should be called every time the inspector is
closed to make sure such edits are applied.

Bug: T113078
Change-Id: I48fb291487f76fc515f122646d205366a60dca62
2015-10-01 15:58:20 +01:00
Ed Sanders c5c88482b9 MWExtenionNode: Ensure objects are deep copied when used in the hash
We don't expect users not to alter the hash (subclasses may delete items)
so make a copy of any objects we put in it.

Change-Id: I6274f47e02b9f2d53864d4a2ae80df42e6c89867
2015-10-01 15:57:49 +01:00
Ed Sanders 50de745afd MWExtensionNode: Copy mw data before modifying
Otherwise we are directly modifying model.element.attributes
which is very bad.

Change-Id: Icf066a5848b9c67c2c4b3fcafd72d0142996e48d
2015-10-01 13:34:01 +01:00
jenkins-bot 2566110456 Merge "build: Alter settings to force utf-8 and allow .php5/.inc extensions" 2015-10-01 05:22:36 +00:00
jenkins-bot cc9a2140e8 Merge "Update VE core submodule to master (a98e11c)" 2015-10-01 01:33:53 +00:00
jenkins-bot f323aa9108 Merge "Update VE core submodule to master (ca4bd8c)" 2015-10-01 01:18:50 +00:00
James D. Forrester 2668383755 Update VE core submodule to master (a98e11c)
New changes:
3eea110 Refactor PreviewElement to allow preview to be updated
c02882c Don't render errors in generated content

Change-Id: I1ecd85473846a0ce533a885e28440e443d9928ea
2015-09-30 18:18:15 -07:00
jenkins-bot 76fc2f71ad Merge "More autodisable script fixes" 2015-09-30 21:33:26 +00:00
Alex Monk 4a7bf9d894 More autodisable script fixes
* Load users from master, probably not useful until I4ffc8325 goes in
* Don't bother with extra query for 0 users at the end, stop when we get less
  users than our batch size limit.

Bug: T112352
Change-Id: Ie800a5aa3b134301ead75cc5b3ae112f29589e3c
2015-09-30 22:08:37 +01:00
jenkins-bot 1b455ac201 Merge "Call afterRender whether or not images emit 'load'" 2015-09-30 21:00:13 +00:00
Thalia 53f4aa64d9 Call afterRender whether or not images emit 'load'
MWExtensionNodes currently don't call afterRender if the image
is already loaded, which can happen if we decide not to rerender
after an update (e.g. when the response is an error).

Change-Id: Ic9c11e446a7cc789bb20680466709ff2ad5cb22e
2015-09-30 21:47:40 +01:00
Translation updater bot 90d7b4f3ce Merge "Localisation updates from https://translatewiki.net." 2015-09-30 20:13:07 +00:00
Translation updater bot d6f09eb3b0 Localisation updates from https://translatewiki.net.
Change-Id: I661c0b37dce0b8e30c960dad2bfa0600e9920d83
2015-09-30 22:12:21 +02:00
Alex Monk 5d3cd8ebbb Fix output from autodisable pref script
Report correct number of users and add linebreak.

Bug: T112352
Change-Id: I19cd23ff4c28a83408881c299fb3a3ef42ea305b
2015-09-30 20:57:48 +01:00
C. Scott Ananian 0ec26ef23b Rename RESTBase1/Parsoid3 bodyOnly parameter to body_only
The old `bodyOnly` name was deprecated on 2015-09-09.

Bug: T114185
Change-Id: Ic7b71acdbf56366cd4bd0172f06f75babf45edb7
2015-09-30 10:31:05 -04:00
James D. Forrester 01bd73c808 Update VE core submodule to master (ca4bd8c)
New changes:
8c917a7 Add focused class to surface when focused
04d7f8c Localisation updates from https://translatewiki.net.
dfc71e6 Move cursor offset calc from CE Surface to DM Document
02040d0 Localisation updates from https://translatewiki.net.
7d6d49e IME tests: Add IE11 Win8.1 Korean; name specific Windows versions
7ce9d64 Localisation updates from https://translatewiki.net.
ca4bd8c Update OOjs UI to v0.12.10

Change-Id: I7c04d72cb6bf1d21eb257e2a6cf42c61c7d34eba
2015-09-29 15:14:02 -07:00
Translation updater bot c1f26c0922 Localisation updates from https://translatewiki.net.
Change-Id: I53bf43111c86cabfb668f0bd3d05b57611e78bb1
2015-09-29 22:10:19 +02:00
Ed Sanders 074f7bcefe Follow-up If556afa10: Fix typo: nodeType -> nodeName
Change-Id: I19915647981787f7bbf2c86fc7bd02308d5da218
2015-09-29 17:35:23 +01:00
jenkins-bot d3d81ca258 Merge "MWInlineExtensionNode: Don't assume responses are always <p>-wrapper" 2015-09-29 12:43:36 +00:00
Roan Kattouw 0d4b30f927 MWInlineExtensionNode: Don't assume responses are always <p>-wrapper
For the Score extension they aren't, and this causes JS errors in production.

Change-Id: If556afa1046f460d7fdd29cb1c50ac93dad88fde
2015-09-28 19:36:48 -07:00
Roan Kattouw 28fbf2bcda Update autodisable logic
* Make betatempdisable appear checked if autodisable is true
* Set autodisable=false only if betatempdisable is also false
* On wikis where $wgVisualEditorTransitionDefault=true, set
  autodisable=true when the user disables VE

Change-Id: I3415af4a735afb10cf246f4b22b9d84ef98c882f
2015-09-28 18:19:56 -07:00
jenkins-bot ce8107ec0b Merge "Autodisable preference" 2015-09-28 23:46:59 +00:00
Alex Monk 97e70ba3cc Autodisable preference
We want to flip the default of visualeditor-enable to true, but don't
necessarily want to turn it on for users who already have contributions but who
haven't already enabled it. Therefore we're considering adding such users to
this autodisable preference which they can self-remove (by explicitly enabling
VE) or we can target later, separate from betatempdisable users.

Bug: T112352
Change-Id: I1ce5e6c92055e30fdc82bc912a767e913b190ef6
2015-09-29 00:30:27 +01:00