Commit graph

12863 commits

Author SHA1 Message Date
Bartosz Dziewoński 0462b6ed8f ve.init.mw.DesktopArticleTarget: Refactor redirect interface handling
Redirect pages have two extra things not present on normal pages:
* Redirect subtitle: the "Redirect page" shown under the page heading.
* Redirect page content header: the "↳ Foo" at the beginning of content.

Our handling was pretty messy and had some bugs (T161614).

Notable behavior changes:
* Update 'wgIsRedirect' in mw.config after saving the page.
* Use #mw-content-text rather than .mw-jump for inserting the fake .redirectMsg.
  .mw-jump is not guaranteed to exist on the page (it's a skin feature).
* Never replace the real .redirectMsg existing on the page, except by the
  new HTML after a page is saved. Our fake is separate now.

Bug: T161614
Change-Id: I96a5e45a71bf10bf6a2b501dc0cf81e6c37060ec
2017-03-28 17:40:23 +02:00
Bartosz Dziewoński d905d705ce ve.init.mw.DesktopArticleTarget: Hide redirect subtitle if we cancel editing
To reproduce: start editing a page, turn it into a redirect,
cancel editing and go back to view mode. The "Redirect page"
subtitle under the page title should disappear.

Note that #redirectsub is correctly spelled all lowercase,
unlike #contentSub.

This reverts commit 0e1bc7309b
and fixes the code instead.

Change-Id: Ibacd73122dfec63268a77794bc77c4b88876d3ee
2017-03-28 01:31:29 +00:00
Bartosz Dziewoński 0e1bc7309b ve.init.mw.DesktopArticleTarget: Remove unused code
As it happens, #redirectsub is correctly spelled all lowercase,
unlike #contentSub. This line does nothing. We remove #redirectsub
correctly elsewhere; I don't think this was ever meant to be here.

Follows-up 96421b283c.

Change-Id: I3e4c6eb2ff94f363b488477b3ddd248e571e723a
2017-03-28 00:39:38 +00:00
Bartosz Dziewoński 86f739c994 Remove "prefix": "oo-ui-icon" from ve.ui.Icons.json
This gets overridden by "selectorWithoutVariant" and "selectorWithVariant"
in the module definition anyway.

Change-Id: I51b8e76d542058c008d92ce55c7ec6bb66df70b7
2017-03-21 20:27:04 +01:00
jenkins-bot ae247352d5 Merge "Update VE core submodule to master (f294778e6)" 2017-03-21 16:11:33 +00:00
James D. Forrester 551b601548 Update VE core submodule to master (f294778e6)
New changes:
642e86498 Localisation updates from https://translatewiki.net.
98608eb3d ce.test: Use nodeType constant
8e795e433 Fire a surface change event from the toolbar so tools can rebind

Bug: T160906
Change-Id: I9c3c65b43f3209049ba0ca7e587cc39fffc413d2
2017-03-20 08:37:41 -07:00
Ed Sanders 1adedfbd8b Disable clickable categories bar in wikitext mode
Bug: T160733
Change-Id: I79b7c880e63675a322b2ada053819b36a175ccbe
2017-03-20 11:07:52 +00:00
Translation updater bot b3566dde97 Localisation updates from https://translatewiki.net.
Change-Id: Ifb2f7e4a3f14de95c4b4400330d1b3207370fdff
2017-03-18 23:03:38 +01:00
James D. Forrester 8f4802b7f1 Update VE core submodule to master (a63435906)
New changes:
dcff78aa0 Pass element to describeChanges
51bc2139f Move diff cleanup to ve.DiffMatchPatch
92f3219e2 Use diff_match_patch action constants for better readability
0ff1f053f VisualDiff: Merge remove+inserts separated by whitespace only
5255ac49c Ensure inline node changes are balanced and minimal
a63435906 i18n: Add param documentation in qqq for some recent keys

Bug: T160632
Bug: T160729
Bug: T160740
Change-Id: Iacb47e849004fe52c1edb0ba09c26ac3f03cc06d
2017-03-17 23:16:18 +00:00
jenkins-bot fb16c402aa Merge "Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory()" 2017-03-17 22:31:44 +00:00
Translation updater bot e227996539 Localisation updates from https://translatewiki.net.
Change-Id: Ie989ec6b785d9de48465481e4ef3da88f17e7998
2017-03-17 22:50:58 +01:00
WMDE-Fisch 9053906f33 Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory()
Change-Id: If7ef514b625e67268d524477ac43ad9bc3dcae5f
2017-03-17 12:20:35 +01:00
James D. Forrester ff888f3b44 Update VE core submodule to master (ac6d7031c)
New changes:
80b31eddb Update treeDiffer.js library
96619eefb DesktopContext: on destroy, tell our popup to stop positioning
8dadf74f1 ve.ui.DesktopContext: Prevent hiding of the context popup

Bug: T160190
Bug: T160197
Change-Id: I3a09d528aae15b1be008f27803211f4ecd70947a
2017-03-16 17:38:45 -07:00
James D. Forrester fc332c69e7 Follow-up 335b56728: Reality doesn't run in perma-debug mode :-)
Change-Id: I042b907263a5ec40a277803d73c6bbd5e161b0f0
2017-03-16 17:09:10 -07:00
David Lynch e035c1de08 Follow up ec559041: abort notices display early if no notices
This avoids attempting to toggle after a destroy call has been made.

Change-Id: Ia756ff6436ec0590639dbbff216c9999daf684ec
2017-03-16 18:00:22 -05:00
James D. Forrester b6b041961b Follow-up 7a8cc04f0: Re-set qqq messages that i18n bot destroyed
Change-Id: I9f26d252db8069e514dddf00f6f42194fe0a1c15
2017-03-16 15:49:15 -07:00
Translation updater bot 7a8cc04f0d Localisation updates from https://translatewiki.net.
Change-Id: I75712f53ef3d2ca69f25d5bb3908ec66e2b4d249
2017-03-16 23:35:16 +01:00
jenkins-bot 421a432b7a Merge "VisualDiff: Add custom messages for change descriptions" 2017-03-16 21:50:07 +00:00
Ed Sanders 9cd8faea8b VisualDiff: Add custom messages for change descriptions
Bug: T151403
Change-Id: I469a3c7897f2417c1850364f65da51c0deca2386
2017-03-16 14:36:09 -07:00
jenkins-bot 0ae808913c Merge "Introduce visual differ in the save dialog" 2017-03-16 21:28:41 +00:00
jenkins-bot 85736d5a7b Merge "Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display its own popup" 2017-03-16 20:14:05 +00:00
Ed Sanders 12c73bc01f Update VE core submodule to master (ef5dc965f)
New changes:
4b94f212e Add tool to change directionality of document view

Bug: T153356
Depends-On: I1e3d89e8250b75d0b6992cf4664e84de66d99bc0
Change-Id: Ic832cc661a0899b1668eb650fb09b66ada54d1ef
2017-03-16 12:42:42 -07:00
James D. Forrester ec5590418e Follow-up eb8ba26a: Make MWNoticesTool#setNotices() display its own popup
Running setNotices( [] ) makes MWNoticesTool run this.destroy() to avoid taking
up extra space in the toolbar when not needed.

Also, make setNotices() bail earlier.

Change-Id: I492fd59a1e15e8f296bf7f03d9b0035c40dafa59
2017-03-16 11:29:34 -07:00
jenkins-bot f39c6f5983 Merge "MWNoticesPopupTool: When setting notices, clear existing notices" 2017-03-16 17:46:49 +00:00
David Lynch 318c6718fd MWNoticesPopupTool: When setting notices, clear existing notices
This would keep on duplicating notices when switching modes.

Change-Id: I04720904eddd95c0d3618d284d1930e41a0ae137
2017-03-16 12:13:36 -05:00
David Lynch eb8ba26adf DesktopArticleTarget: Only try to show notices if some exist
This avoids an OOui deprecation warning for trying to toggle a popup which
isn't connected to anything.

Bug: T160161
Change-Id: I9ad97785f0de4ecf81d189985459689644e25923
2017-03-16 11:35:10 -05:00
jenkins-bot cf94956fba Merge "Update VE core submodule to master (5c4c9e8ed)" 2017-03-16 15:47:44 +00:00
jenkins-bot 7b8d0ff55b Merge "Update VE core submodule to master (8817821b6)" 2017-03-16 15:42:23 +00:00
Ed Sanders 335b56728a Introduce visual differ in the save dialog
Bug: T143350
Change-Id: I1297d0f4bb87e69be3b50220c1830a22dac1bbae
2017-03-16 15:33:54 +00:00
James D. Forrester 5ac029a153 Update VE core submodule to master (5c4c9e8ed)
New changes:
cc3e61930 ElementLinearData: when removing original dom elements, remap hashes
89ad89739 Localisation updates from https://translatewiki.net.
056366b22 Revert "Remove $returnFocusTo hack now null is supported upstream"
515a90521 Remove redundant setDisabled calls from tools extending ve.ui.Tool

Bug: T154123
Bug: T160479
Change-Id: I1726bc2ee0efb20ad03da178a51ca1f6482f0551
2017-03-16 08:24:27 -07:00
jenkins-bot a3a4ff3d20 Merge "Don't load VE or NWE on lint-targetted pages (until that works)" 2017-03-16 04:59:33 +00:00
James D. Forrester 6225a6536a Update VE core submodule to master (8817821b6)
New changes:
ae944e7fd VisualDiff: Show attribute changes in a sidebar
1a3b7ec90 VisualDiff: Add custom messages for change descriptions

Bug: T151404
Bug: T156189
Change-Id: I218bf2eee6606cedc21f1e542fba62c1b98ca43f
2017-03-15 16:31:57 -07:00
Bartosz Dziewoński 3d5cedb0ff ve.ui.MWLinkAction: Improve ISBN and RFC/PMID autolinking
These changes allow us to be more aggressive in autolinking ISBNs (no
need anymore to wait for the user to type a space or move their
selection) and more correct in autolinking RFCs and PMIDs (stray
spaces and dashes no longer mess them up).

* ISBN numbers can only be 10 or 13 digits long. We don't need to
  handle arbitrary lengths.
  * If a number does not begin with 978 or 979, it's the ISBN-10 variant
    and we can autolink it as soon as the user types 10 digits.
  * If a number begins with 978 or 979, it can be either.
    * But if we already have 13 digits typed, autolink immediately.
    * Otherwise, use a delayed sequence to see if it ends at 10 digits.
* RFC and PMID numbers can consist only of digits, no optional spaces
  or dashes are allowed. Typing a space or dash will immediately
  autolink the number.

Bug: T117165
Change-Id: I6a085cd78d910661245a351f3ceb3fabe2f093cf
2017-03-15 21:58:26 +00:00
Bartosz Dziewoński 5afd15b2cc ve.ui.MWLinkAction: Use delayed sequence
The trailing space at the end of the regexp is no longer required to
prevent matching (and executing) too soon. We also don't need to know
about trailing punctuation.

However, to prevent the match from ending in the middle of typing, we
have to allow for ' ' and '-' at the end of the match.

Tweaked tests to better match the intent now that a trailing space is
not included, but they pass without changes too, the command is quite
permissive.

Bug: T117165
Depends-On: Ie36046fa43ce49f8a25c99f2de577eb296d68a51
Depends-On: I2af0a738afa43295bf6d7d612cac4349bc6cd20d
Change-Id: I7c28d5c93b1a441387ad05a75846af83d2b21b6a
2017-03-15 21:58:13 +00:00
James D. Forrester 13eb3d9027 Update VE core submodule to master (da310202f)
New changes:
d091c2e5c Refactor rect-from-element computation in FocusableNode into static method
9184a8e8c Update OOjs UI to v0.20.0
a48bac967 ve.ce.Surface: Check delayed sequences when deactivating surface

Change-Id: I7ad4b17c6e4ea3fdf4f0fc72e244f875fddc766b
2017-03-15 14:54:15 -07:00
James D. Forrester c07a6df74c Don't load VE or NWE on lint-targetted pages (until that works)
Bug: T160102
Change-Id: Ibb364ff2d89975d5907fa887cca666eee6e78d37
2017-03-15 14:23:17 -07:00
jenkins-bot 2a9562aca5 Merge "MWAceEditorWidget: Fix position of ace tooltip" 2017-03-15 19:23:38 +00:00
Ed Sanders 6fc47dce64 MWAceEditorWidget: Fix position of ace tooltip
The floating tooltip breaks inside OOUI dialogs. In the absence
of an upstream fix, just anchor it to the bottom of the textbox.

Bug: T160245
Change-Id: I9055c4e4947f5581605bd490f076415c1edaf8ec
2017-03-15 12:02:27 -07:00
jenkins-bot 6e14a1eb8e Merge "MWExtensionWindow: Remove pointless zero argument from ve.debounce call" 2017-03-15 18:24:09 +00:00
jenkins-bot ea8606360d Merge "MWMediaInfoFieldWidget: Add extra rules for word-break: break-word" 2017-03-15 18:14:35 +00:00
Ed Sanders 5086b45f15 MWExtensionWindow: Remove pointless zero argument from ve.debounce call
Change-Id: I58a048af0e6397592e84554024aed3a17c5e5977
2017-03-15 17:57:54 +00:00
Ed Sanders 97a8041bf2 MWMediaInfoFieldWidget: Add extra rules for word-break: break-word
We use three rules elsewhere for better browser support

Change-Id: Ic2ecd12c3f78bc3a2d45a10b5305449e7de82b75
2017-03-15 17:56:53 +00:00
Ed Sanders d85e8da9e2 Remove MSIE from blacklist, already blacklisted upstream
We support all versions of IE that MW supports, so no need
for additional blacklisting.

Bug: T160494
Change-Id: I771459b4d6a0e2d5781a69a905a51323369b3b66
2017-03-15 17:42:34 +00:00
L10n-bot 85a163e629 Merge "Localisation updates from https://translatewiki.net." 2017-03-14 21:55:57 +00:00
Translation updater bot 74f67c71a8 Localisation updates from https://translatewiki.net.
Change-Id: Id47d1613684ff81148023a286264c5625f07fb51
2017-03-14 22:55:51 +01:00
Bartosz Dziewoński 49f603c703 Update <pre> support for Parsoid changes
After 79ccfb9372cb57afa569036ef39ead13abfba673, MediaWiki's `<pre>`
tags get rendered as `<pre typeof="mw:Extension/pre">` in Parsoid HTML.
MediaWiki's indent-pre syntax (block indented by a single space) is
still rendered as `<pre>` in Parsoid HTML, however.

Indent-pre is still handled by MWPreformattedNode (no changes).
Introducing MWPreNode, which will handle `<pre>` extension tags,
and MWPreDialog to change its contents (and allow converting
to MWPreformattedNode).

Pieces copied from MWGalleryNode, MWLinkNodeInspector, CommentInspector.

Possible future improvements:
* Add a specific icon for MWPreContextItem
* Avoid API roundtrips for rendering (but rendering wikitext <pre>
  is not as simple as it looks)
* Consider a way to insert these other than '<pre' sequence

Bug: T159900
Change-Id: I5bc4ea6e5d893736f65ef0dd43b08c18cb1a1e85
2017-03-14 14:08:50 -07:00
James D. Forrester 6ab24fe9f0 Update VE core submodule to master (41134af2b)
New changes:
1e12d0174 Generalize DiffElement logic (improves lists and tables)
24e0c7a94 Localisation updates from https://translatewiki.net.
32759ae86 Allow variable-length sequences without a fake space terminator, use for autolinking
82c204ba0 QUnit.assert.equalHash: Correctly compare JSON representation
2e5462610 DiffElement: Allow a node change to be an attribute change *and* a linear diff
41134af2b ve.ui.LinkAction: Allow autolinking ranges including trailing spaces again

Local changes:
Updated tests for 32759ae86: the autolinkUrl command no longer expects
trailing whitespace to be included in the range.

Bug: T117165
Bug: T149537
Bug: T158518
Change-Id: I5c2d5b97894fc93f49ce6270a198f3dfdcd09986
2017-03-14 12:47:32 -07:00
jenkins-bot 399d03df5f Merge "Update gallery actions in response to changes" 2017-03-14 19:43:22 +00:00
Thalia 586cb06821 Update gallery actions in response to changes
Bug: T62311
Change-Id: Icf51b92cb9a88471c5f11843473523787c177742
2017-03-14 19:10:34 +00:00
jenkins-bot 797aac9d88 Merge "ArticleTarget#switchToVisualEditor: Bail if the server won't let you switch" 2017-03-14 16:19:06 +00:00