wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Use promise pattern inside MWTemplateDialog in order to download TemplateData (currently just mocked) asynchronously."

Browse source
This commit is contained in:
jenkins-bot 2013-05-17 05:49:29 +00:00 committed by Gerrit Code Review
parent 28d33df097 97157a1c1c
commit dd2d6e900d
1 changed files with 56 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

108
modules/ve/ui/dialogs/ve.ui.MWTemplateDialog.js
View file

@ -49,27 +49,27 @@ ve.ui.MWTemplateDialog.prototype.initialize = function () {
* @method
*/
ve.ui.MWTemplateDialog.prototype.onOpen = function () {
var mwAttr = this.surface.view.focusedNode.model.getAttribute( 'mw' ),
templateData = this.getTemplateData( mwAttr.target.wt ),
param;
var mwAttr = this.surface.view.focusedNode.model.getAttribute( 'mw' );
this.getTemplateData( mwAttr.target.wt ).done( ve.bind( function( templateData ) {
var param;
this.paramsKeys = [];
this.paramsToInputs = {};
this.paramsKeys = [];
this.paramsToInputs = {};
// Parent method
ve.ui.PagedDialog.prototype.onOpen.call( this );
// Parent method
ve.ui.PagedDialog.prototype.onOpen.call( this );
// Add template page
this.addPage( 'template', mwAttr.target.wt, 'template' );
// Add template page
this.addPage( 'template', mwAttr.target.wt, 'template' );
// Loop through parameters
for ( param in mwAttr.params ) {
this.createPage(
param,
mwAttr.params[param],
templateData && templateData.params[param]
);
}
// Loop through parameters
for ( param in mwAttr.params ) {
this.createPage(
param,
mwAttr.params[param],
templateData && templateData.params[param]
);
}
}, this ) );
};
/**
@ -105,42 +105,46 @@ ve.ui.MWTemplateDialog.prototype.createPage = function( key, value, singleTempla
};
ve.ui.MWTemplateDialog.prototype.getTemplateData = function ( /*templateName*/ ) {
var templateData = {
'title': 'Template:Unsigned',
'params': {
'user': {
'label': {
'en': 'User'
var promise = $.Deferred(),
templateData = {
'title': 'Template:Unsigned',
'params': {
'user': {
'label': {
'en': 'User'
},
'description': {
'en': 'Name or IP of user who left the comment'
},
'required': true,
'type': 'string/wiki-user-name',
'aliases': [
'1'
],
'deprecated': false,
'default': ''
},
'description': {
'en': 'Name or IP of user who left the comment'
},
'required': true,
'type': 'string/wiki-user-name',
'aliases': [
'1'
],
'deprecated': false,
'default': ''
},
'param1': {
'label': {
'en': 'Time stamp'
},
'description': {
'en': 'datestamp from edit history (remember to label it UTC)'
},
'aliases': [
'2'
],
'required': false,
'deprecated': false,
'default': '',
'type': 'unknown'
'param1': {
'label': {
'en': 'Time stamp'
},
'description': {
'en': 'datestamp from edit history (remember to label it UTC)'
},
'aliases': [
'2'
],
'required': false,
'deprecated': false,
'default': '',
'type': 'unknown'
}
}
}
};
return templateData;
};
setTimeout( function() {
promise.resolve( templateData );
}, 500 );
return promise;
};
/**