wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-27 04:06:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Support for nodes that handles their own children in ve.dm.Converter.prototype.getDomSubtreeFromData"

Browse source
This commit is contained in:
jenkins-bot 2013-05-17 05:48:35 +00:00 committed by Gerrit Code Review
parent 6033608ba1 531c049679
commit 28d33df097
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/ve/dm/ve.dm.Converter.js
View file

@ -921,6 +921,7 @@ ve.dm.Converter.prototype.getDomSubtreeFromData = function ( data, container ) {
var dataSlice, j, depth,
handlesOwn = false;
// TODO: Shouldn't be implemented with try..catch cause it makes debugging harder and sacrifice performance.
try {
handlesOwn = ve.dm.nodeFactory.doesNodeHandleOwnChildren( data[i].type );
} catch ( e ) {}
@ -1225,6 +1226,17 @@ ve.dm.Converter.prototype.getDomSubtreeFromData = function ( data, container ) {
);
}
}
// In case of nodes that handles own children ascend to parent node.
// It looks like the solution would be to avoid descending first ( so ascending
// wouldn't be needed ) but note that then code above for handling white spaces
// wouldn't execute correctly.
// TODO: Shouldn't be implemented with try..catch cause it makes debugging harder and sacrifice performance.
try {
if ( ve.dm.nodeFactory.doesNodeHandleOwnChildren( data[i].type ) ) {
domElement = parentDomElement;
}
} catch ( e ) {}
}
if ( ve.isArray( dataElementOrSlice ) ) {