wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 00:00:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Set onDiffViewHeader argument defaults = null

Browse source 
As suggested by Bartosz in https://gerrit.wikimedia.org/r/#/c/361938/
Just set a default value but keep the type hint. This should avoid
the logspam while retaining type safety.

Bug: T169132
Change-Id: I1221357746f5d4ba1430bcf0bfe773202484eebc
This commit is contained in:
Mukunda Modell 2017-06-28 16:12:17 -05:00
parent 27467c32d4
commit c14b1c46a9
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
VisualEditor.hooks.php
View file

@ -79,8 +79,8 @@ class VisualEditorHooks {
public static function onDiffViewHeader( public static function onDiffViewHeader(
DifferenceEngine $diff, DifferenceEngine $diff,
/* Revision */ $oldRev, Revision $oldRev = null,
/* Revision */ $newRev Revision $newRev = null
) { ) {
$config = ConfigFactory::getDefaultInstance()->makeConfig( 'visualeditor' ); $config = ConfigFactory::getDefaultInstance()->makeConfig( 'visualeditor' );
$output = RequestContext::getMain()->getOutput(); $output = RequestContext::getMain()->getOutput();