From c14b1c46a9ea5b4083346d320c940b30c2cfc551 Mon Sep 17 00:00:00 2001
From: Mukunda Modell <mmodell@wikimedia.org>
Date: Wed, 28 Jun 2017 16:12:17 -0500
Subject: [PATCH] Set onDiffViewHeader argument defaults = null

As suggested by Bartosz in https://gerrit.wikimedia.org/r/#/c/361938/
Just set a default value but keep the type hint. This should avoid
the logspam while retaining type safety.

Bug: T169132
Change-Id: I1221357746f5d4ba1430bcf0bfe773202484eebc
---
 VisualEditor.hooks.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 1415e4bab2..1a27f4c3e2 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -79,8 +79,8 @@ class VisualEditorHooks {
 
 	public static function onDiffViewHeader(
 		DifferenceEngine $diff,
-		/* Revision */ $oldRev,
-		/* Revision */ $newRev
+		Revision $oldRev = null,
+		Revision $newRev = null
 	) {
 		$config = ConfigFactory::getDefaultInstance()->makeConfig( 'visualeditor' );
 		$output = RequestContext::getMain()->getOutput();