wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-01 01:16:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix beta warning appearing for some users that it shouldn't.

Browse source 
Check that the user is anonymous before looking at their cookie to decide whether
to show beta warning dialog.
With the existing code, we would see that the preference is false and then check
that they have no cookie. But being logged in should make the cookie existence
be disregarded.

Fixes Ica9e5a92

Bug: 65821
Change-Id: I84e31323930c404222388bb74e4b4ca8d303e05c
This commit is contained in:
Alex Monk 2014-05-29 17:39:49 +01:00
parent d2896e111d
commit 837eea324e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
View file

@ -1636,7 +1636,7 @@ ve.init.mw.ViewPageTarget.prototype.maybeShowDialogs = function () {
!urlSaysHide &&
(
prefSaysShow ||
$.cookie( 've-beta-welcome-dialog' ) === null
( !usePrefs && $.cookie( 've-beta-welcome-dialog' ) === null )
)
) {
this.surface.getDialogs().getWindow( 'betaWelcome' ).open();