From 837eea324e6b58f29ec7b1fa215ae66bf16dc893 Mon Sep 17 00:00:00 2001 From: Alex Monk Date: Thu, 29 May 2014 17:39:49 +0100 Subject: [PATCH] Fix beta warning appearing for some users that it shouldn't. Check that the user is anonymous before looking at their cookie to decide whether to show beta warning dialog. With the existing code, we would see that the preference is false and then check that they have no cookie. But being logged in should make the cookie existence be disregarded. Fixes Ica9e5a92 Bug: 65821 Change-Id: I84e31323930c404222388bb74e4b4ca8d303e05c --- modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js index 096a6fae7c..ec3448b9e8 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js @@ -1636,7 +1636,7 @@ ve.init.mw.ViewPageTarget.prototype.maybeShowDialogs = function () { !urlSaysHide && ( prefSaysShow || - $.cookie( 've-beta-welcome-dialog' ) === null + ( !usePrefs && $.cookie( 've-beta-welcome-dialog' ) === null ) ) ) { this.surface.getDialogs().getWindow( 'betaWelcome' ).open();