From 71e42d50fe9e2e4253ec1edfdde3b9e6b245efa7 Mon Sep 17 00:00:00 2001
From: David Lynch <dlynch@wikimedia.org>
Date: Mon, 9 Jul 2018 09:25:41 -0500
Subject: [PATCH] init.mw.ArticleTarget: sort categories correctly in
 renderCategories

I.e. don't sort them, because they're provided in source order and that's all
we need.

Bug: T197759
Change-Id: I3b9508ff49233ccfbeba1d111a6df9f29f0fc318
---
 modules/ve-mw/init/ve.init.mw.ArticleTarget.js | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index 662935d85f..2db61eadd4 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -2624,19 +2624,7 @@ ve.init.mw.ArticleTarget.prototype.renderCategories = function ( categoryItems )
 			}
 			return $list;
 		}
-		function categorySort( a, b ) {
-			var sortA = a.sortkey || a.category,
-				sortB = b.sortkey || b.category;
-			if ( sortA < sortB ) {
-				return -1;
-			}
-			if ( sortA > sortB ) {
-				return 1;
-			}
-			return 0;
-		}
 		if ( categories.normal.length ) {
-			categories.normal.sort( categorySort );
 			$normal = $( '<div class="mw-normal-catlinks" />' );
 			$normal.append(
 				renderPageLink( ve.msg( 'pagecategorieslink' ) ).text( ve.msg( 'pagecategories', categories.normal.length ) ),
@@ -2646,7 +2634,6 @@ ve.init.mw.ArticleTarget.prototype.renderCategories = function ( categoryItems )
 			$output.append( $normal );
 		}
 		if ( categories.hidden.length ) {
-			categories.hidden.sort( categorySort );
 			$hidden = $( '<div class="mw-hidden-catlinks" />' );
 			if ( mw.user.options.get( 'showhiddencats' ) ) {
 				$hidden.addClass( 'mw-hidden-cats-user-shown' );