wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 16:20:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Fix JS error in DocumentSynchronizer when adding to an empty document"

Browse source
This commit is contained in:
Trevor Parscal 2012-10-17 19:28:58 +00:00 committed by Gerrit Code Review
parent 020a04f3dc 91964a48d0
commit 64442e03d8
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve/dm/ve.dm.DocumentSynchronizer.js
View file

@ -112,10 +112,12 @@ ve.dm.DocumentSynchronizer.synchronizers.rebuild = function ( action ) {
return;
}
if ( 'indexInNode' in selection[0] ) {
// If the document is empty, selection[0].node will be the document (so no parent)
// but we won't get indexInNode either. Detect this and use index=0 in that case.
if ( 'indexInNode' in selection[0] || !selection[0].node.getParent() ) {
// Insertion
parent = selection[0].node;
index = selection[0].indexInNode;
index = selection[0].indexInNode || 0;
numNodes = 0;
} else {
// Rebuild