wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix JS error in DocumentSynchronizer when adding to an empty document

Browse source 
This was reproducible by blanking the entire document (Ctrl+A Delete),
then undoing that (Ctrl+Z). AFAIK that's the only way to trigger an
insertion on a document that is completely empty.

Change-Id: I22252d5972a413dff614880a90c4c6b22e79672d
This commit is contained in:
Catrope 2012-10-15 15:01:39 -07:00
parent dac224e110
commit 91964a48d0
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve/dm/ve.dm.DocumentSynchronizer.js
View file

@ -112,10 +112,12 @@ ve.dm.DocumentSynchronizer.synchronizers.rebuild = function ( action ) {
return;
}
if ( 'indexInNode' in selection[0] ) {
// If the document is empty, selection[0].node will be the document (so no parent)
// but we won't get indexInNode either. Detect this and use index=0 in that case.
if ( 'indexInNode' in selection[0] || !selection[0].node.getParent() ) {
// Insertion
parent = selection[0].node;
index = selection[0].indexInNode;
index = selection[0].indexInNode || 0;
numNodes = 0;
} else {
// Rebuild